René's URL Explorer Experiment


Title: fix(account-deletion): list storage keys through the S3 client so Trigger runs can sweep by waleedlatif1 · Pull Request #9193 · simstudioai/sim · GitHub

Open Graph Title: fix(account-deletion): list storage keys through the S3 client so Trigger runs can sweep by waleedlatif1 · Pull Request #9193 · simstudioai/sim

X Title: fix(account-deletion): list storage keys through the S3 client so Trigger runs can sweep by waleedlatif1 · Pull Request #9193 · simstudioai/sim

Description: Summary Since v0.9.26 reached production, every account-deletion.storage.workspace-sweep and project-file.storage.prefix-cleanup outbox event fails in Trigger.dev with ListObjectsV2Command is not a constructor and dead-letters after 10 attempts. No objects are deleted, so nothing live is at risk, but a deleted account's storage and a deleted Project's files are left behind. Cause: listStorageKeyPage loaded the command with await import('@aws-sdk/client-s3'). The Trigger bundle resolves that package to its CommonJS build, and the dynamically imported namespace does not carry ListObjectsV2Command; static named imports of the same package (the rest of providers/s3/client.ts) are unaffected. Next.js resolves the package differently, so the app and the unit tests never hit it. Fix: the listing moves into listS3ObjectKeyPage in lib/uploads/providers/s3/client.ts, beside the other S3 commands it imports statically, and listStorageKeyPage calls it the way the Blob and GCS branches call their client modules. It now also fails clearly when the bucket is unset rather than sending Bucket: undefined. Verification I bundled the real listStorageKeyPage → S3 client path with esbuild (Node platform, code splitting, default main-first resolution) and pointed it at a local ListObjectsV2 mock that returns two pages: origin/staging: {"status":"fail","error":"TypeError: ListObjectsV2Command is not a constructor"}. This is the exact production error. this branch: {"status":"pass","pages":[{"keys":["ws/u1/a.txt","ws/u1/b.txt"],"done":false,"nextPageToken":"tok-2"},{"keys":["ws/u1/c.txt"],"done":true}]} Follow-up after deploy Dead-lettered events of both types need a requeue (POST /api/v1/admin/outbox/{id}/requeue). Both handlers are idempotent and re-check every reference before deleting. 🤖 Generated with Claude Code

Open Graph Description: Summary Since v0.9.26 reached production, every account-deletion.storage.workspace-sweep and project-file.storage.prefix-cleanup outbox event fails in Trigger.dev with ListObjectsV2Command is not ...

X Description: Summary Since v0.9.26 reached production, every account-deletion.storage.workspace-sweep and project-file.storage.prefix-cleanup outbox event fails in Trigger.dev with ListObjectsV2Command is not ...

Opengraph URL: https://github.com/simstudioai/sim/pull/9193

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:66f2b16f-fac3-b9de-ad78-8b55811f32ea
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC908:2550AC:ABA444:F1D712:6AFB78EB
html-safe-nonce4d1a661ef256cadcd2d4f973f2601ef8bfef36eb19e5c9840dead5b307e3f685
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTA4OjI1NTBBQzpBQkE0NDQ6RjFENzEyOjZBRkI3OEVCIiwidmlzaXRvcl9pZCI6IjYzNzYyMTEwNTU3MzE5ODA1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0e655c6e3ae9646568bb1f7a6c126cf54a58909c7d6a577083ecee104f1b1852
hovercard-subject-tagpull_request:4912662777
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9193/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Since v0.9.26 reached production, every account-deletion.storage.workspace-sweep and project-file.storage.prefix-cleanup outbox event fails in Trigger.dev with ListObjectsV2Command is not ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9193/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9193%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9193%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9193/files
Reloadhttps://github.com/simstudioai/sim/pull/9193/files
Reloadhttps://github.com/simstudioai/sim/pull/9193/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests201 (201)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/storage-sweep-s3-list-static-importhttps://github.com/simstudioai/sim/tree/fix/storage-sweep-s3-list-static-import
Conversation 6 https://github.com/simstudioai/sim/pull/9193
Commits 2 https://github.com/simstudioai/sim/pull/9193/commits
Checks 51 https://github.com/simstudioai/sim/pull/9193/checks
Files changed https://github.com/simstudioai/sim/pull/9193/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9193/files
fix(account-deletion): list storage keys through the S3 client so Trigger runs can sweep https://github.com/simstudioai/sim/pull/9193/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/9193/files
36c8ea0 fix(account-deletion): list storage keys through the S3 client so Tri… waleedlatif1 Oct 18, 2026 https://github.com/simstudioai/sim/pull/9193/commits/36c8ea0ffaa41f39b54b92eeafc609f17ea811a8
6f41000 fix(uploads): keep deleteS3ObjectVersion reading its bucket from cust… waleedlatif1 Oct 18, 2026 https://github.com/simstudioai/sim/pull/9193/commits/6f410001c49ccce6811599dfb3da6fcef968d4c8
Clear filters https://github.com/simstudioai/sim/pull/9193/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9193/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9193/files
prefix-sweep.ts https://github.com/simstudioai/sim/pull/9193/files#diff-ff62f462de8eff013984ceb9e224f49831527dff7a865321fb5884d166e92047
client.ts https://github.com/simstudioai/sim/pull/9193/files#diff-5b5c75fd8b0e84e44544dfe3eb319a86603568755f5568c5b4ce3007b519927e
apps/sim/lib/uploads/core/prefix-sweep.tshttps://github.com/simstudioai/sim/pull/9193/files#diff-ff62f462de8eff013984ceb9e224f49831527dff7a865321fb5884d166e92047
View file https://github.com/simstudioai/sim/blob/6f410001c49ccce6811599dfb3da6fcef968d4c8/apps/sim/lib/uploads/core/prefix-sweep.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9193/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9193/files#diff-ff62f462de8eff013984ceb9e224f49831527dff7a865321fb5884d166e92047
https://github.com/simstudioai/sim/pull/9193/files#diff-ff62f462de8eff013984ceb9e224f49831527dff7a865321fb5884d166e92047
apps/sim/lib/uploads/providers/s3/client.tshttps://github.com/simstudioai/sim/pull/9193/files#diff-5b5c75fd8b0e84e44544dfe3eb319a86603568755f5568c5b4ce3007b519927e
View file https://github.com/simstudioai/sim/blob/6f410001c49ccce6811599dfb3da6fcef968d4c8/apps/sim/lib/uploads/providers/s3/client.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9193/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9193/files#diff-5b5c75fd8b0e84e44544dfe3eb319a86603568755f5568c5b4ce3007b519927e
https://github.com/simstudioai/sim/pull/9193/files#diff-5b5c75fd8b0e84e44544dfe3eb319a86603568755f5568c5b4ce3007b519927e
https://github.com/simstudioai/sim/pull/9193/files#diff-5b5c75fd8b0e84e44544dfe3eb319a86603568755f5568c5b4ce3007b519927e
https://github.com/simstudioai/sim/pull/9193/files#diff-5b5c75fd8b0e84e44544dfe3eb319a86603568755f5568c5b4ce3007b519927e
Please reload this pagehttps://github.com/simstudioai/sim/pull/9193/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.