René's URL Explorer Experiment


Title: fix(logs): remove the client log-persistence route that let a run's actor rewrite its log and cost by waleedlatif1 · Pull Request #9183 · simstudioai/sim · GitHub

Open Graph Title: fix(logs): remove the client log-persistence route that let a run's actor rewrite its log and cost by waleedlatif1 · Pull Request #9183 · simstudioai/sim

X Title: fix(logs): remove the client log-persistence route that let a run's actor rewrite its log and cost by waleedlatif1 · Pull Request #9183 · simstudioai/sim

Description: Summary Remove POST /api/workflows/[id]/log. It let whoever started a run re-complete that run with a client-supplied result: overwrite the status, output, and trace spans of an already finished log, and record client-controlled cost into the payer's usage ledger. The ledger only adds increments, so this could inflate charges and burn through the workspace's usage limit The route was gated by validateWorkflowAccess(..., false), which only checks read. Read-only members can run deployed workflows, so they could reach it too. Bumping it to write would still leave the cost and log forgery open to every write member, so the route goes Its only caller was debug mode's persistLogs, which has no UI entry point. It also sent a freshly generated execution ID, so the route answered 404 and the client swallowed the error. Nothing has been persisted through this route, so removing it changes no behaviour Drop the contract and schemas, the client persistLogs path (the debug handlers are now synchronous), and the deleted route's entries from the explicit-any, source-conventions, and unused-exports baselines No other callers in this repo (SDKs, CLI, docs, realtime, desktop) or in the copilot repo. No other route feeds request-supplied trace spans or cost into run completion. The remaining validateWorkflowAccess(..., false) callers are all read-only GETs Type of Change Bug fix Testing use-workflow-execution.test.tsx, middleware.test.ts (15 passing) bun run lint, block-registry check, generators (no drift), check:api-validation:strict, check:unused-exports, check:explicit-any, check:source-conventions, check:test-patterns, check:boundaries Full check:audits, type-check, and suite left to CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Remove POST /api/workflows/[id]/log. It let whoever started a run re-complete that run with a client-supplied result: overwrite the status, output, and trace spans of an already finished l...

X Description: Summary Remove POST /api/workflows/[id]/log. It let whoever started a run re-complete that run with a client-supplied result: overwrite the status, output, and trace spans of an already finished l...

Opengraph URL: https://github.com/simstudioai/sim/pull/9183

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:14fca50f-fe45-e1e2-591e-6e44def0da4f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC9E0:19FA2E:90A2FB:CD1023:6AFB509A
html-safe-nonce3f75dc87fcaf57b0e8990e4f723908fd36cffd92fbf8e540cd92037f2f6b30cf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOUUwOjE5RkEyRTo5MEEyRkI6Q0QxMDIzOjZBRkI1MDlBIiwidmlzaXRvcl9pZCI6IjM3OTQzMjY5MDQ1NDI4MTAyNjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac94995724d925eef5ddbcac9db1995f01e132640a17022cd5ebc9c3b7fc852816
hovercard-subject-tagpull_request:4903997088
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9183/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Remove POST /api/workflows/[id]/log. It let whoever started a run re-complete that run with a client-supplied result: overwrite the status, output, and trace spans of an already finished l...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9183/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9183%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9183%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9183/files
Reloadhttps://github.com/simstudioai/sim/pull/9183/files
Reloadhttps://github.com/simstudioai/sim/pull/9183/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/remove-workflow-log-routehttps://github.com/simstudioai/sim/tree/fix/remove-workflow-log-route
Conversation 2 https://github.com/simstudioai/sim/pull/9183
Commits 1 https://github.com/simstudioai/sim/pull/9183/commits
Checks 53 https://github.com/simstudioai/sim/pull/9183/checks
Files changed https://github.com/simstudioai/sim/pull/9183/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9183/files
fix(logs): remove the client log-persistence route that let a run's actor rewrite its log and cost https://github.com/simstudioai/sim/pull/9183/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/9183/files
70c15d4 fix(logs): remove the client log-persistence route that let a run's a… waleedlatif1 Oct 17, 2026 https://github.com/simstudioai/sim/pull/9183/commits/70c15d4f856fd616cf88e6bf24768f92b7dedf7c
Clear filters https://github.com/simstudioai/sim/pull/9183/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9183/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9183/files
route.test.ts https://github.com/simstudioai/sim/pull/9183/files#diff-fb32040a68b39efae4e74d39ce384221ad8af6ade27f7ae425871040fb0cbc17
route.ts https://github.com/simstudioai/sim/pull/9183/files#diff-21c00e8bfd05df1e4c0c1ed2ab9989019d989fd2564a96a618de1bb19dd2cef9
middleware.test.ts https://github.com/simstudioai/sim/pull/9183/files#diff-9b0a72232e68a4169ae7e0edcab4bfa18c64918620d41aa18a16b6611677a006
use-workflow-execution.test.tsx https://github.com/simstudioai/sim/pull/9183/files#diff-fb314434f8653766dedb1b4756779e59a1643d137a9d9d0d72be0270c0fbee28
use-workflow-execution.ts https://github.com/simstudioai/sim/pull/9183/files#diff-26a2ffd51d627fc3dadc9abff80196d5f5f7421369413728dbcfe6f72c46e4e6
workflows.ts https://github.com/simstudioai/sim/pull/9183/files#diff-29bb15f0acc725362f6756e12f9ffce0a49b3d2068334d2e10f18e5986e46411
check-explicit-any.baseline.json https://github.com/simstudioai/sim/pull/9183/files#diff-780d04116ec981737479435cdb0364b49047711f2dfb93b671a9be50a1b0bb27
check-source-conventions.baseline.json https://github.com/simstudioai/sim/pull/9183/files#diff-f2c7074fc5e74c3cb4f2c59eae74fce826fead48160a9ca8858cfabd077cbb93
check-unused-exports.baseline.json https://github.com/simstudioai/sim/pull/9183/files#diff-4b59a8526a4f226dffb0fbf6b8ec25d3082ab45da697f584eaaca4bd483c928f
apps/sim/app/api/workflows/[id]/log/route.test.tshttps://github.com/simstudioai/sim/pull/9183/files#diff-fb32040a68b39efae4e74d39ce384221ad8af6ade27f7ae425871040fb0cbc17
View file https://github.com/simstudioai/sim/blob/d1957107c0de03dca6b428e8bd8b471650cf7e6c/apps/sim/app/api/workflows/%5Bid%5D/log/route.test.ts
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/simstudioai/sim/pull/9183/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9183/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9183/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.