René's URL Explorer Experiment


Title: fix(auth): revoke sessions and OAuth grants on password reset by waleedlatif1 · Pull Request #9178 · simstudioai/sim · GitHub

Open Graph Title: fix(auth): revoke sessions and OAuth grants on password reset by waleedlatif1 · Pull Request #9178 · simstudioai/sim

X Title: fix(auth): revoke sessions and OAuth grants on password reset by waleedlatif1 · Pull Request #9178 · simstudioai/sim

Description: Summary Completing a password reset left every existing session signed in, so a stolen cookie or an abandoned device kept access for the rest of the 30-day session lifetime onPasswordReset now deletes the user's sessions, then their OAuth refresh families and access tokens (revokeUserOAuthGrants). Sessions go first because OAuth issuance writes its session id under a foreign key, so once the sessions are gone no new grant can be minted behind the sweep OAuth grants need their own sweep: their session_id is ON DELETE SET NULL and access-token validation never checks the session, so deleting sessions alone left app tokens (Sim CLI, MCP clients) live and rotatable. This matches Google's revoke-on-password-change and Auth0's documented post-compromise step Consents are kept, so a legitimate client signs in again without a new consent prompt. Integration credentials, API keys and workflows are untouched revokeSessionsOnPasswordReset: true re-sweeps after the hook, catching a session created while it ran. A failure fails the reset, and redoing it from a new link reruns the revocation A cookie-cached session can still authenticate until cookieCache.maxAge (5 min), the same bound as any per-device sign-out Type of Change Bug fix Testing New lib/auth/lifecycle-audit.integration.ts case drives /request-password-reset → /reset-password through the real auth handler on Postgres and asserts there are no sessions, OAuth families or access tokens afterwards Red→green: removing the session revocation, the grant sweep, or just the access-token delete each fails the test on its own lifecycle-audit.integration.ts (19/19) and oauth-provider-lifecycle.integration.ts (13/13) pass locally, as do the lib/auth + app/api/auth unit suites (658 tests); biome and check:tool-registry-boundary --check clean Reset UI already redirects to /login after success, so the flow doesn't change Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Completing a password reset left every existing session signed in, so a stolen cookie or an abandoned device kept access for the rest of the 30-day session lifetime onPasswordReset now del...

X Description: Summary Completing a password reset left every existing session signed in, so a stolen cookie or an abandoned device kept access for the rest of the 30-day session lifetime onPasswordReset now del...

Opengraph URL: https://github.com/simstudioai/sim/pull/9178

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:36de0855-c9d5-ebea-6143-423aec4a70a9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA1E:2F4711:114886:186EC8:6AFB4C7D
html-safe-noncec9b9822dd22b48af5346498d80b088e87db096b60eb4c2e799300e30159cf047
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTFFOjJGNDcxMToxMTQ4ODY6MTg2RUM4OjZBRkI0QzdEIiwidmlzaXRvcl9pZCI6Ijc1MzMzODE1ODg2NjQ1MTU4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac93119c7c27cf14b7163db405975e78d449a317ddde985927dad6625930c90f11
hovercard-subject-tagpull_request:4902716996
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9178/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Completing a password reset left every existing session signed in, so a stolen cookie or an abandoned device kept access for the rest of the 30-day session lifetime onPasswordReset now del...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9178/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9178%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9178%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9178/files
Reloadhttps://github.com/simstudioai/sim/pull/9178/files
Reloadhttps://github.com/simstudioai/sim/pull/9178/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/revoke-sessions-on-password-resethttps://github.com/simstudioai/sim/tree/fix/revoke-sessions-on-password-reset
Conversation 25 https://github.com/simstudioai/sim/pull/9178
Commits 4 https://github.com/simstudioai/sim/pull/9178/commits
Checks 53 https://github.com/simstudioai/sim/pull/9178/checks
Files changed https://github.com/simstudioai/sim/pull/9178/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9178/files
fix(auth): revoke sessions and OAuth grants on password reset https://github.com/simstudioai/sim/pull/9178/files#top
Show all changes 4 commits https://github.com/simstudioai/sim/pull/9178/files
4e554dc fix(auth): revoke sessions and OAuth grants on password reset waleedlatif1 Oct 17, 2026 https://github.com/simstudioai/sim/pull/9178/commits/4e554dcaeb6dc07e70c8d03a921352a764f21bf1
40413cb fix(auth): keep OAuth grant revocation out of the auth module graph waleedlatif1 Oct 17, 2026 https://github.com/simstudioai/sim/pull/9178/commits/40413cbf1fce8e8c157764161b4c019a386b3fa2
33e5dc4 fix(auth): delete sessions before sweeping OAuth grants on reset waleedlatif1 Oct 17, 2026 https://github.com/simstudioai/sim/pull/9178/commits/33e5dc4b410c992998d22ef2c433ca4af8be2d55
cac0534 fix(auth): colocate OAuth grant revocation with access tokens waleedlatif1 Oct 17, 2026 https://github.com/simstudioai/sim/pull/9178/commits/cac05343b77b4dbc26277da2ba59fac881c0332c
Clear filters https://github.com/simstudioai/sim/pull/9178/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9178/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9178/files
auth.ts https://github.com/simstudioai/sim/pull/9178/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
lifecycle-audit.integration.ts https://github.com/simstudioai/sim/pull/9178/files#diff-e2b3524ee9bdb68b8f4f874d85dd262c87d691f1fee79e6ea8e29370a4ae14bf
oauth-access-token.ts https://github.com/simstudioai/sim/pull/9178/files#diff-4792b2fa49a2f9230bdf71ed33e693e6a60716b97472a3c7efa5013ba9c56f08
apps/sim/lib/auth/auth.tshttps://github.com/simstudioai/sim/pull/9178/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
View file https://github.com/simstudioai/sim/blob/cac05343b77b4dbc26277da2ba59fac881c0332c/apps/sim/lib/auth/auth.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9178/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9178/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
https://github.com/simstudioai/sim/pull/9178/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
https://github.com/simstudioai/sim/pull/9178/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
Please reload this pagehttps://github.com/simstudioai/sim/pull/9178/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9178/files
https://github.com/simstudioai/sim/pull/9178/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
apps/sim/lib/auth/lifecycle-audit.integration.tshttps://github.com/simstudioai/sim/pull/9178/files#diff-e2b3524ee9bdb68b8f4f874d85dd262c87d691f1fee79e6ea8e29370a4ae14bf
View file https://github.com/simstudioai/sim/blob/cac05343b77b4dbc26277da2ba59fac881c0332c/apps/sim/lib/auth/lifecycle-audit.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9178/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9178/files#diff-e2b3524ee9bdb68b8f4f874d85dd262c87d691f1fee79e6ea8e29370a4ae14bf
https://github.com/simstudioai/sim/pull/9178/files#diff-e2b3524ee9bdb68b8f4f874d85dd262c87d691f1fee79e6ea8e29370a4ae14bf
https://github.com/simstudioai/sim/pull/9178/files#diff-e2b3524ee9bdb68b8f4f874d85dd262c87d691f1fee79e6ea8e29370a4ae14bf
Please reload this pagehttps://github.com/simstudioai/sim/pull/9178/files
https://github.com/simstudioai/sim/pull/9178/files#diff-e2b3524ee9bdb68b8f4f874d85dd262c87d691f1fee79e6ea8e29370a4ae14bf
apps/sim/lib/auth/oauth-access-token.tshttps://github.com/simstudioai/sim/pull/9178/files#diff-4792b2fa49a2f9230bdf71ed33e693e6a60716b97472a3c7efa5013ba9c56f08
View file https://github.com/simstudioai/sim/blob/cac05343b77b4dbc26277da2ba59fac881c0332c/apps/sim/lib/auth/oauth-access-token.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9178/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9178/files#diff-4792b2fa49a2f9230bdf71ed33e693e6a60716b97472a3c7efa5013ba9c56f08
https://github.com/simstudioai/sim/pull/9178/files#diff-4792b2fa49a2f9230bdf71ed33e693e6a60716b97472a3c7efa5013ba9c56f08
https://github.com/simstudioai/sim/pull/9178/files#diff-4792b2fa49a2f9230bdf71ed33e693e6a60716b97472a3c7efa5013ba9c56f08
Please reload this pagehttps://github.com/simstudioai/sim/pull/9178/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.