René's URL Explorer Experiment


Title: fix(salesforce): pin instance URL to Salesforce domains and guard update-custom-field egress by waleedlatif1 · Pull Request #9177 · simstudioai/sim · GitHub

Open Graph Title: fix(salesforce): pin instance URL to Salesforce domains and guard update-custom-field egress by waleedlatif1 · Pull Request #9177 · simstudioai/sim

X Title: fix(salesforce): pin instance URL to Salesforce domains and guard update-custom-field egress by waleedlatif1 · Pull Request #9177 · simstudioai/sim

Description: Summary getInstanceUrl returned a caller-supplied instanceUrl verbatim. salesforce_update_custom_field runs as an in-process internal operation, so it skipped the request path's validateUrlWithDNS guard and raw-fetched that URL with the Salesforce bearer token attached instanceUrl is hidden, but stored agent tool params pass through to the operation, so a workflow editor could aim the GET/PATCH at loopback, RFC1918 or link-local hosts and read the response back through the error message Added validateSalesforceInstanceUrl on the shared validateVendorHostedUrl allowlist (https only; *.salesforce.com, *.force.com, *.cloudforce.com, *.database.com, *.salesforce.mil, *.sfcrmproducts.cn; reduced to the origin) getInstanceUrl now runs both the explicit instanceUrl and the id-token claims through it, so every Salesforce tool inherits the check. Login hosts are still rejected The update-custom-field operation resolves DNS once and pins its GET and PATCH to that IP with secureFetchWithPinnedIP, with a 10 MB response cap Type of Change Bug fix (security) Testing tools/salesforce/utils.test.ts, lib/internal/salesforce/operations/update-custom-field.test.ts, lib/core/security/input-validation.test.ts pass (147 tests) Reverted the fix and confirmed every new case goes red (10 failures) Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary getInstanceUrl returned a caller-supplied instanceUrl verbatim. salesforce_update_custom_field runs as an in-process internal operation, so it skipped the request path's validateUrlWit...

X Description: Summary getInstanceUrl returned a caller-supplied instanceUrl verbatim. salesforce_update_custom_field runs as an in-process internal operation, so it skipped the request path's validateUr...

Opengraph URL: https://github.com/simstudioai/sim/pull/9177

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8799455e-ca2d-b9c2-aa63-4fe1bd5adfb9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA41C:73CE1:BAD0C5:10024A7:6AFB5359
html-safe-nonce4d543548cd1de77106649dae36076773f0a9a9a65f7eb31f3d6a7e2527085537
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDFDOjczQ0UxOkJBRDBDNToxMDAyNEE3OjZBRkI1MzU5IiwidmlzaXRvcl9pZCI6Ijc0MDg5MzUzMDc0MjYwOTE4NjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaced1073ed7ab57d77cae1c21b2bb5c04499c56344bf1ec7fcb824cb26927cd623
hovercard-subject-tagpull_request:4902689118
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9177/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary getInstanceUrl returned a caller-supplied instanceUrl verbatim. salesforce_update_custom_field runs as an in-process internal operation, so it skipped the request path's validateUrlWit...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9177/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9177%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9177%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9177/files
Reloadhttps://github.com/simstudioai/sim/pull/9177/files
Reloadhttps://github.com/simstudioai/sim/pull/9177/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/salesforce-instance-url-ssrfhttps://github.com/simstudioai/sim/tree/fix/salesforce-instance-url-ssrf
Conversation 19 https://github.com/simstudioai/sim/pull/9177
Commits 3 https://github.com/simstudioai/sim/pull/9177/commits
Checks 52 https://github.com/simstudioai/sim/pull/9177/checks
Files changed https://github.com/simstudioai/sim/pull/9177/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9177/files
fix(salesforce): pin instance URL to Salesforce domains and guard update-custom-field egress https://github.com/simstudioai/sim/pull/9177/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/9177/files
3e95daa fix(salesforce): pin instance URL to Salesforce domains and guard upd… waleedlatif1 Oct 17, 2026 https://github.com/simstudioai/sim/pull/9177/commits/3e95daa7763188d5f9996e50026f642b73b00c67
6f70ef0 fix(security): check vendor-hosted URL scheme on the parsed URL and p… waleedlatif1 Oct 17, 2026 https://github.com/simstudioai/sim/pull/9177/commits/6f70ef020433dfb1096e5e9bd42488712bc45a42
bf0d75c test(salesforce): cover private-address DNS refusal in update-custom-… waleedlatif1 Oct 17, 2026 https://github.com/simstudioai/sim/pull/9177/commits/bf0d75c72134e90a6ccb27231947ae5b517b2314
Clear filters https://github.com/simstudioai/sim/pull/9177/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9177/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9177/files
input-validation.ts https://github.com/simstudioai/sim/pull/9177/files#diff-69599ab9ede3d937e027206bfbbaef65edcfeae21ad92d8b3d69fd5d11f8adf6
update-custom-field.test.ts https://github.com/simstudioai/sim/pull/9177/files#diff-96e5b80e3f4d827df2e7beab1acb65297f0f1d9218d3ee0fd804a2c0108b09a0
update-custom-field.ts https://github.com/simstudioai/sim/pull/9177/files#diff-629bf265d50c4231e1b04e167787f274c755bbdb402da7c6579aef5a70e2d168
utils.test.ts https://github.com/simstudioai/sim/pull/9177/files#diff-05efdbc734f8b76c89d21c57b1566df0d6abcb1f3995664f935325ab226bb926
utils.ts https://github.com/simstudioai/sim/pull/9177/files#diff-0f2cdded518dd600f56375320633c1fd44af0cf1f04788c41f7e214d6c9c920d
apps/sim/lib/core/security/input-validation.tshttps://github.com/simstudioai/sim/pull/9177/files#diff-69599ab9ede3d937e027206bfbbaef65edcfeae21ad92d8b3d69fd5d11f8adf6
View file https://github.com/simstudioai/sim/blob/bf0d75c72134e90a6ccb27231947ae5b517b2314/apps/sim/lib/core/security/input-validation.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9177/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9177/files#diff-69599ab9ede3d937e027206bfbbaef65edcfeae21ad92d8b3d69fd5d11f8adf6
https://github.com/simstudioai/sim/pull/9177/files#diff-69599ab9ede3d937e027206bfbbaef65edcfeae21ad92d8b3d69fd5d11f8adf6
https://github.com/simstudioai/sim/pull/9177/files#diff-69599ab9ede3d937e027206bfbbaef65edcfeae21ad92d8b3d69fd5d11f8adf6
Please reload this pagehttps://github.com/simstudioai/sim/pull/9177/files
https://github.com/simstudioai/sim/pull/9177/files#diff-69599ab9ede3d937e027206bfbbaef65edcfeae21ad92d8b3d69fd5d11f8adf6
apps/sim/lib/internal/salesforce/operations/update-custom-field.test.tshttps://github.com/simstudioai/sim/pull/9177/files#diff-96e5b80e3f4d827df2e7beab1acb65297f0f1d9218d3ee0fd804a2c0108b09a0
View file https://github.com/simstudioai/sim/blob/bf0d75c72134e90a6ccb27231947ae5b517b2314/apps/sim/lib/internal/salesforce/operations/update-custom-field.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9177/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9177/files#diff-96e5b80e3f4d827df2e7beab1acb65297f0f1d9218d3ee0fd804a2c0108b09a0
Please reload this pagehttps://github.com/simstudioai/sim/pull/9177/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9177/files
apps/sim/lib/internal/salesforce/operations/update-custom-field.tshttps://github.com/simstudioai/sim/pull/9177/files#diff-629bf265d50c4231e1b04e167787f274c755bbdb402da7c6579aef5a70e2d168
View file https://github.com/simstudioai/sim/blob/bf0d75c72134e90a6ccb27231947ae5b517b2314/apps/sim/lib/internal/salesforce/operations/update-custom-field.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9177/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9177/files#diff-629bf265d50c4231e1b04e167787f274c755bbdb402da7c6579aef5a70e2d168
https://github.com/simstudioai/sim/pull/9177/files#diff-629bf265d50c4231e1b04e167787f274c755bbdb402da7c6579aef5a70e2d168
https://github.com/simstudioai/sim/pull/9177/files#diff-629bf265d50c4231e1b04e167787f274c755bbdb402da7c6579aef5a70e2d168
https://github.com/simstudioai/sim/pull/9177/files#diff-629bf265d50c4231e1b04e167787f274c755bbdb402da7c6579aef5a70e2d168
apps/sim/tools/salesforce/utils.test.tshttps://github.com/simstudioai/sim/pull/9177/files#diff-05efdbc734f8b76c89d21c57b1566df0d6abcb1f3995664f935325ab226bb926
View file https://github.com/simstudioai/sim/blob/bf0d75c72134e90a6ccb27231947ae5b517b2314/apps/sim/tools/salesforce/utils.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9177/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9177/files#diff-05efdbc734f8b76c89d21c57b1566df0d6abcb1f3995664f935325ab226bb926
apps/sim/tools/salesforce/utils.tshttps://github.com/simstudioai/sim/pull/9177/files#diff-0f2cdded518dd600f56375320633c1fd44af0cf1f04788c41f7e214d6c9c920d
View file https://github.com/simstudioai/sim/blob/bf0d75c72134e90a6ccb27231947ae5b517b2314/apps/sim/tools/salesforce/utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9177/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9177/files#diff-0f2cdded518dd600f56375320633c1fd44af0cf1f04788c41f7e214d6c9c920d
https://github.com/simstudioai/sim/pull/9177/files#diff-0f2cdded518dd600f56375320633c1fd44af0cf1f04788c41f7e214d6c9c920d
Please reload this pagehttps://github.com/simstudioai/sim/pull/9177/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.