René's URL Explorer Experiment


Title: fix(chat): treat browser tab metadata as untrusted and bound attachment resolution by waleedlatif1 · Pull Request #9161 · simstudioai/sim · GitHub

Open Graph Title: fix(chat): treat browser tab metadata as untrusted and bound attachment resolution by waleedlatif1 · Pull Request #9161 · simstudioai/sim

X Title: fix(chat): treat browser tab metadata as untrusted and bound attachment resolution by waleedlatif1 · Pull Request #9161 · simstudioai/sim

Description: Summary Browser tab attachments now go through safeBrowserSelectionUrl, which drops credentialed and non-http(s) URLs. The title (capped) and URL are quoted in an UNTRUSTED BROWSER TAB JSON block, the same way browser and terminal selections already are; the URL used to be inlined as plain instruction text One shared formatUntrustedJsonBlock in selection-context.ts replaces the copies in the browser and terminal selection formatters, with byte-identical output for both Open-tab attachments resolve through mapWithConcurrency at the existing CONTEXT_RESOLUTION_CONCURRENCY (now in context-limits.ts) instead of an unbounded Promise.allSettled; each resolution stays settled-style, so logging and persistence order are unchanged. No schema limit was added, so no request that is valid today gets rejected project-file-read.integration.ts teardown deletes the fixture files' search chunks and builds, mirroring owners.integration.ts Type of Change Bug fix Testing New post.test.ts cases: a credentialed URL never reaches context, and the title and URL sit inside the untrusted block. Both fail on the previous browser branch post.test.ts, process-contents.test.ts, selection-context.test.ts pass (169 tests) check:comment-hygiene, check:source-conventions, check:explicit-any, check:test-patterns; full suite and integration in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Browser tab attachments now go through safeBrowserSelectionUrl, which drops credentialed and non-http(s) URLs. The title (capped) and URL are quoted in an UNTRUSTED BROWSER TAB JSON block,...

X Description: Summary Browser tab attachments now go through safeBrowserSelectionUrl, which drops credentialed and non-http(s) URLs. The title (capped) and URL are quoted in an UNTRUSTED BROWSER TAB JSON block,...

Opengraph URL: https://github.com/simstudioai/sim/pull/9161

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5cf50254-ba93-8477-34ae-aea6c323d263
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8B18:C0BA8:ABC58D:EBD17C:6AFB4F65
html-safe-nonce8d88e058eecd4d5b0c38ac893234541cc50aeed9ea48c747ab5cd1a10b282abf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QjE4OkMwQkE4OkFCQzU4RDpFQkQxN0M6NkFGQjRGNjUiLCJ2aXNpdG9yX2lkIjoiNDQ3NDE3MzcwNzY4MjY1MDYxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6b7c38864e582b58150227e4c174a1f6fbff04468fa37e4a6801c2866f751a33
hovercard-subject-tagpull_request:4896501192
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9161/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Browser tab attachments now go through safeBrowserSelectionUrl, which drops credentialed and non-http(s) URLs. The title (capped) and URL are quoted in an UNTRUSTED BROWSER TAB JSON block,...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9161/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9161%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9161%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9161/files
Reloadhttps://github.com/simstudioai/sim/pull/9161/files
Reloadhttps://github.com/simstudioai/sim/pull/9161/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/chat-attachment-context-hardeninghttps://github.com/simstudioai/sim/tree/fix/chat-attachment-context-hardening
Conversation 12 https://github.com/simstudioai/sim/pull/9161
Commits 3 https://github.com/simstudioai/sim/pull/9161/commits
Checks 52 https://github.com/simstudioai/sim/pull/9161/checks
Files changed https://github.com/simstudioai/sim/pull/9161/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9161/files
fix(chat): treat browser tab metadata as untrusted and bound attachment resolution https://github.com/simstudioai/sim/pull/9161/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/9161/files
c99c745 fix(chat): treat browser tab metadata as untrusted and bound attachme… waleedlatif1 Oct 17, 2026 https://github.com/simstudioai/sim/pull/9161/commits/c99c745a3a9d496f41a49e07e1b2268eb10617ea
126dc10 improvement(chat): settle attachment resolution through a shared boun… waleedlatif1 Oct 17, 2026 https://github.com/simstudioai/sim/pull/9161/commits/126dc1031caaf6b1a4627b118f588bab43c1ef95
8ba721a fix(chat): keep truncated browser tab titles within the title bound waleedlatif1 Oct 17, 2026 https://github.com/simstudioai/sim/pull/9161/commits/8ba721a1095ec5a4687ebc86413a1e4aee15059d
Clear filters https://github.com/simstudioai/sim/pull/9161/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9161/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9161/files
concurrency.ts https://github.com/simstudioai/sim/pull/9161/files#diff-9ef9caa5998fdce7f925ec30d279f6f395f0dbe4864639c6e01ac90ced007e7c
project-file-read.integration.ts https://github.com/simstudioai/sim/pull/9161/files#diff-ce37481bbf0995d3a9d4597d9487419199758ceaf7d45291d6f29732506e8f00
context-limits.ts https://github.com/simstudioai/sim/pull/9161/files#diff-147c99305bb3f3cd8f34512059960d238509edece9dc3969dfc0051cd3cda532
post.test.ts https://github.com/simstudioai/sim/pull/9161/files#diff-6d0b4ca3c83105bc58cee0c55acba06bb1f231570a250386296939e365c11531
post.ts https://github.com/simstudioai/sim/pull/9161/files#diff-3706d2f19175754e3005560cd5a01658d443edbd6724899e9e7ef0238e6fdffa
process-contents.ts https://github.com/simstudioai/sim/pull/9161/files#diff-c3819859701a12aabbc776fa382884f9484a852c61462173e39de94fd69329f3
resource-attachments.ts https://github.com/simstudioai/sim/pull/9161/files#diff-011b92013cb3152f88907d93df1f6de3c45099b45e04259f6c643e79919d0c2d
selection-context.ts https://github.com/simstudioai/sim/pull/9161/files#diff-864e20af73420c6e32ecee7180278a2a7428a595c30c91911064fb311864e056
apps/sim/lib/core/utils/concurrency.tshttps://github.com/simstudioai/sim/pull/9161/files#diff-9ef9caa5998fdce7f925ec30d279f6f395f0dbe4864639c6e01ac90ced007e7c
View file https://github.com/simstudioai/sim/blob/8ba721a1095ec5a4687ebc86413a1e4aee15059d/apps/sim/lib/core/utils/concurrency.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9161/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9161/files#diff-9ef9caa5998fdce7f925ec30d279f6f395f0dbe4864639c6e01ac90ced007e7c
https://github.com/simstudioai/sim/pull/9161/files#diff-9ef9caa5998fdce7f925ec30d279f6f395f0dbe4864639c6e01ac90ced007e7c
https://github.com/simstudioai/sim/pull/9161/files#diff-9ef9caa5998fdce7f925ec30d279f6f395f0dbe4864639c6e01ac90ced007e7c
apps/sim/lib/mothership/agent-cli/project-file-read.integration.tshttps://github.com/simstudioai/sim/pull/9161/files#diff-ce37481bbf0995d3a9d4597d9487419199758ceaf7d45291d6f29732506e8f00
View file https://github.com/simstudioai/sim/blob/8ba721a1095ec5a4687ebc86413a1e4aee15059d/apps/sim/lib/mothership/agent-cli/project-file-read.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9161/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9161/files#diff-ce37481bbf0995d3a9d4597d9487419199758ceaf7d45291d6f29732506e8f00
https://github.com/simstudioai/sim/pull/9161/files#diff-ce37481bbf0995d3a9d4597d9487419199758ceaf7d45291d6f29732506e8f00
https://github.com/simstudioai/sim/pull/9161/files#diff-ce37481bbf0995d3a9d4597d9487419199758ceaf7d45291d6f29732506e8f00
https://github.com/simstudioai/sim/pull/9161/files#diff-ce37481bbf0995d3a9d4597d9487419199758ceaf7d45291d6f29732506e8f00
https://github.com/simstudioai/sim/pull/9161/files#diff-ce37481bbf0995d3a9d4597d9487419199758ceaf7d45291d6f29732506e8f00
apps/sim/lib/mothership/chat/context-limits.tshttps://github.com/simstudioai/sim/pull/9161/files#diff-147c99305bb3f3cd8f34512059960d238509edece9dc3969dfc0051cd3cda532
View file https://github.com/simstudioai/sim/blob/8ba721a1095ec5a4687ebc86413a1e4aee15059d/apps/sim/lib/mothership/chat/context-limits.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9161/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9161/files#diff-147c99305bb3f3cd8f34512059960d238509edece9dc3969dfc0051cd3cda532
apps/sim/lib/mothership/chat/post.test.tshttps://github.com/simstudioai/sim/pull/9161/files#diff-6d0b4ca3c83105bc58cee0c55acba06bb1f231570a250386296939e365c11531
View file https://github.com/simstudioai/sim/blob/8ba721a1095ec5a4687ebc86413a1e4aee15059d/apps/sim/lib/mothership/chat/post.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9161/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9161/files#diff-6d0b4ca3c83105bc58cee0c55acba06bb1f231570a250386296939e365c11531
https://github.com/simstudioai/sim/pull/9161/files#diff-6d0b4ca3c83105bc58cee0c55acba06bb1f231570a250386296939e365c11531
apps/sim/lib/mothership/chat/post.tshttps://github.com/simstudioai/sim/pull/9161/files#diff-3706d2f19175754e3005560cd5a01658d443edbd6724899e9e7ef0238e6fdffa
View file https://github.com/simstudioai/sim/blob/8ba721a1095ec5a4687ebc86413a1e4aee15059d/apps/sim/lib/mothership/chat/post.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9161/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9161/files#diff-3706d2f19175754e3005560cd5a01658d443edbd6724899e9e7ef0238e6fdffa
https://github.com/simstudioai/sim/pull/9161/files#diff-3706d2f19175754e3005560cd5a01658d443edbd6724899e9e7ef0238e6fdffa
https://github.com/simstudioai/sim/pull/9161/files#diff-3706d2f19175754e3005560cd5a01658d443edbd6724899e9e7ef0238e6fdffa
https://github.com/simstudioai/sim/pull/9161/files#diff-3706d2f19175754e3005560cd5a01658d443edbd6724899e9e7ef0238e6fdffa
apps/sim/lib/mothership/chat/process-contents.tshttps://github.com/simstudioai/sim/pull/9161/files#diff-c3819859701a12aabbc776fa382884f9484a852c61462173e39de94fd69329f3
View file https://github.com/simstudioai/sim/blob/8ba721a1095ec5a4687ebc86413a1e4aee15059d/apps/sim/lib/mothership/chat/process-contents.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9161/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9161/files#diff-c3819859701a12aabbc776fa382884f9484a852c61462173e39de94fd69329f3
https://github.com/simstudioai/sim/pull/9161/files#diff-c3819859701a12aabbc776fa382884f9484a852c61462173e39de94fd69329f3
https://github.com/simstudioai/sim/pull/9161/files#diff-c3819859701a12aabbc776fa382884f9484a852c61462173e39de94fd69329f3
https://github.com/simstudioai/sim/pull/9161/files#diff-c3819859701a12aabbc776fa382884f9484a852c61462173e39de94fd69329f3
https://github.com/simstudioai/sim/pull/9161/files#diff-c3819859701a12aabbc776fa382884f9484a852c61462173e39de94fd69329f3
Please reload this pagehttps://github.com/simstudioai/sim/pull/9161/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9161/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.