René's URL Explorer Experiment


Title: fix(account-deletion): resume the workspace storage sweep from its saved listing position by waleedlatif1 · Pull Request #9159 · simstudioai/sim · GitHub

Open Graph Title: fix(account-deletion): resume the workspace storage sweep from its saved listing position by waleedlatif1 · Pull Request #9159 · simstudioai/sim

X Title: fix(account-deletion): resume the workspace storage sweep from its saved listing position by waleedlatif1 · Pull Request #9159 · simstudioai/sim

Description: Summary Follow-up to #9146, from the v0.9.26 release review (#9155). The durable workspace storage sweep kept its listing position only in memory and checkpointed just the storage family. When a run stopped at its deadline, the next run listed that family again from page one. The failure: if the first pages hold only objects a surviving reference still names, every run re-walks them and deletes nothing, so each run spends an outbox attempt. The event then dead-letters and leaves later unreferenced objects behind. That is an erasure-completeness gap, never live-data loss. Saving the position The sweep checkpoints { family, pageToken } and resumes that family from the saved token. Finishing a family writes pageToken: null, because the checkpoint merges with jsonb ||. A run whose only progress is a moved position continues without spending an attempt, up to MAX_POSITION_RESUMES (1000, counted in the payload). Past that, attempts bound it, so the sweep always terminates even if a provider cursor misbehaved. If listing from a saved token fails, the family lists again once from the start in the same run. That restart never counts as progress; aborts and deadlines are rethrown. A local page token outside the prefix (e.g. a cloud token left by a provider switch) is rejected instead of skipping keys. Unchanged Every guard still runs on resumed pages: the prefix boundary, the sidecar owner, the reference guard, and the workspace re-check before each delete. Deletion semantics and Project cleanup. Payloads queued by the previous version (no pageToken, no resumes) parse as starting the family. Older code ignores the new fields and restarts the family, which is its existing behavior. Type of Change Bug fix Testing Unit tests on real local storage cover: 1000 kept objects before unkept ones: reached and deleted over several runs without spending attempts; resume from a saved token; invalid saved token → restart; a restart that walks only kept objects spends an attempt; the resume cap; a foreign local token; parser rejections. Each guard was reverted and its test went red. lib/users/storage-sweep.integration.ts (real Postgres) passes locally. An independent adversarial review found and fixed a termination gap (the resume cap) before this PR opened. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced

Open Graph Description: Summary Follow-up to #9146, from the v0.9.26 release review (#9155). The durable workspace storage sweep kept its listing position only in memory and checkpointed just the storage family. When a ru...

X Description: Summary Follow-up to #9146, from the v0.9.26 release review (#9155). The durable workspace storage sweep kept its listing position only in memory and checkpointed just the storage family. When a ru...

Opengraph URL: https://github.com/simstudioai/sim/pull/9159

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:dc07a663-98cc-e7d1-2dc8-04289e35e6a4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE496:7C051:9F45C7:DBE918:6AFB501A
html-safe-nonce8d073d51d395a82a405e1820a09620d9d6ade537757376fce5e625f077655947
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDk2OjdDMDUxOjlGNDVDNzpEQkU5MTg6NkFGQjUwMUEiLCJ2aXNpdG9yX2lkIjoiMzc2NjE1NzIwMTg5MDgyNDIxOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc548dba79b69cd1a4dcad4c0ee8ce5e8bd39fa8582fb95efd808968f4ed38d8c
hovercard-subject-tagpull_request:4896220531
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9159/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-up to #9146, from the v0.9.26 release review (#9155). The durable workspace storage sweep kept its listing position only in memory and checkpointed just the storage family. When a ru...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9159/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9159%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9159%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9159/files
Reloadhttps://github.com/simstudioai/sim/pull/9159/files
Reloadhttps://github.com/simstudioai/sim/pull/9159/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/storage-sweep-durable-page-positionhttps://github.com/simstudioai/sim/tree/fix/storage-sweep-durable-page-position
Conversation 8 https://github.com/simstudioai/sim/pull/9159
Commits 3 https://github.com/simstudioai/sim/pull/9159/commits
Checks 52 https://github.com/simstudioai/sim/pull/9159/checks
Files changed https://github.com/simstudioai/sim/pull/9159/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9159/files
fix(account-deletion): resume the workspace storage sweep from its saved listing position https://github.com/simstudioai/sim/pull/9159/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/9159/files
dc0430b fix(account-deletion): resume a workspace storage sweep from its save… waleedlatif1 Oct 17, 2026 https://github.com/simstudioai/sim/pull/9159/commits/dc0430b833092bb17fe9904cd4125ea49eea28d3
75a029f fix(account-deletion): bound position-only sweep resumes and reject f… waleedlatif1 Oct 17, 2026 https://github.com/simstudioai/sim/pull/9159/commits/75a029f8eba9e4cbfd0a5586d8a001a5c9563f3a
b552339 fix(account-deletion): retry a saved sweep position once before resta… waleedlatif1 Oct 17, 2026 https://github.com/simstudioai/sim/pull/9159/commits/b552339b3944c41c042a87bbb2ca48959c1ac996
Clear filters https://github.com/simstudioai/sim/pull/9159/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9159/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9159/files
prefix-sweep.ts https://github.com/simstudioai/sim/pull/9159/files#diff-ff62f462de8eff013984ceb9e224f49831527dff7a865321fb5884d166e92047
storage-sweep.test.ts https://github.com/simstudioai/sim/pull/9159/files#diff-dc76eb4b9c1ef6a5f9837d93ca1723c9e06bce6ca244171dd97b5d554465b911
storage-sweep.ts https://github.com/simstudioai/sim/pull/9159/files#diff-687a729ff842b594d9937a2510c232a1cf3cce3d3f53493ce1c9170efb7b53a4
apps/sim/lib/uploads/core/prefix-sweep.tshttps://github.com/simstudioai/sim/pull/9159/files#diff-ff62f462de8eff013984ceb9e224f49831527dff7a865321fb5884d166e92047
View file https://github.com/simstudioai/sim/blob/b552339b3944c41c042a87bbb2ca48959c1ac996/apps/sim/lib/uploads/core/prefix-sweep.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9159/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9159/files#diff-ff62f462de8eff013984ceb9e224f49831527dff7a865321fb5884d166e92047
https://github.com/simstudioai/sim/pull/9159/files#diff-ff62f462de8eff013984ceb9e224f49831527dff7a865321fb5884d166e92047
https://github.com/simstudioai/sim/pull/9159/files#diff-ff62f462de8eff013984ceb9e224f49831527dff7a865321fb5884d166e92047
https://github.com/simstudioai/sim/pull/9159/files#diff-ff62f462de8eff013984ceb9e224f49831527dff7a865321fb5884d166e92047
apps/sim/lib/users/storage-sweep.test.tshttps://github.com/simstudioai/sim/pull/9159/files#diff-dc76eb4b9c1ef6a5f9837d93ca1723c9e06bce6ca244171dd97b5d554465b911
View file https://github.com/simstudioai/sim/blob/b552339b3944c41c042a87bbb2ca48959c1ac996/apps/sim/lib/users/storage-sweep.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9159/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9159/files#diff-dc76eb4b9c1ef6a5f9837d93ca1723c9e06bce6ca244171dd97b5d554465b911
https://github.com/simstudioai/sim/pull/9159/files#diff-dc76eb4b9c1ef6a5f9837d93ca1723c9e06bce6ca244171dd97b5d554465b911
https://github.com/simstudioai/sim/pull/9159/files#diff-dc76eb4b9c1ef6a5f9837d93ca1723c9e06bce6ca244171dd97b5d554465b911
https://github.com/simstudioai/sim/pull/9159/files#diff-dc76eb4b9c1ef6a5f9837d93ca1723c9e06bce6ca244171dd97b5d554465b911
https://github.com/simstudioai/sim/pull/9159/files#diff-dc76eb4b9c1ef6a5f9837d93ca1723c9e06bce6ca244171dd97b5d554465b911
https://github.com/simstudioai/sim/pull/9159/files#diff-dc76eb4b9c1ef6a5f9837d93ca1723c9e06bce6ca244171dd97b5d554465b911
Please reload this pagehttps://github.com/simstudioai/sim/pull/9159/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9159/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.