René's URL Explorer Experiment


Title: fix(files): answer 499 instead of 500 when a client disconnects mid-serve by waleedlatif1 · Pull Request #9143 · simstudioai/sim · GitHub

Open Graph Title: fix(files): answer 499 instead of 500 when a client disconnects mid-serve by waleedlatif1 · Pull Request #9143 · simstudioai/sim

X Title: fix(files): answer 499 instead of 500 when a client disconnects mid-serve by waleedlatif1 · Pull Request #9143 · simstudioai/sim

Description: Summary File serve route caught every error itself, so a client disconnect mid-read (navigating away, closing a preview) was logged at error and answered 500 — inflating 5xx counts with failures nobody saw Rethrow when request.signal has aborted so withRouteHandler classifies it as a 499 at info, same as every other route (and the existing pattern in the Shopify OAuth callback) Same guard in the cloud and local read helpers, which logged at error before rethrowing Type of Change Bug fix Testing New route test: a read that throws after the client aborts answers 499 with no error log. Verified red on the old code (500) and red with only the outer guard (helper still logs at error) app/api/files/serve/[...path]/route.test.ts (13/13), biome, check:test-patterns, check:comment-hygiene; full suite/type-check/audits in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) 🤖 Generated with Claude Code

Open Graph Description: Summary File serve route caught every error itself, so a client disconnect mid-read (navigating away, closing a preview) was logged at error and answered 500 — inflating 5xx counts with failures n...

X Description: Summary File serve route caught every error itself, so a client disconnect mid-read (navigating away, closing a preview) was logged at error and answered 500 — inflating 5xx counts with failures n...

Opengraph URL: https://github.com/simstudioai/sim/pull/9143

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:76e81693-3800-4851-792c-c41b68f0cab1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC0E0:9464C:B56A5C:F846B2:6AFB5263
html-safe-noncef2996cd2ba5463c9d35f937fe5c1ae78365f4b7acca669e90e78d74c0bc51438
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMEUwOjk0NjRDOkI1NkE1QzpGODQ2QjI6NkFGQjUyNjMiLCJ2aXNpdG9yX2lkIjoiOTA0Mzc3Mzg5MjM1ODUyNTU0MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd4ee05b74644971b620c31b3c07320f6e92b66ef44306bf0510260f7a0afb9c8
hovercard-subject-tagpull_request:4894810220
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9143/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary File serve route caught every error itself, so a client disconnect mid-read (navigating away, closing a preview) was logged at error and answered 500 — inflating 5xx counts with failures n...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9143/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9143%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9143%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9143/files
Reloadhttps://github.com/simstudioai/sim/pull/9143/files
Reloadhttps://github.com/simstudioai/sim/pull/9143/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/files-serve-client-aborthttps://github.com/simstudioai/sim/tree/fix/files-serve-client-abort
Conversation 5 https://github.com/simstudioai/sim/pull/9143
Commits 1 https://github.com/simstudioai/sim/pull/9143/commits
Checks 52 https://github.com/simstudioai/sim/pull/9143/checks
Files changed https://github.com/simstudioai/sim/pull/9143/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9143/files
fix(files): answer 499 instead of 500 when a client disconnects mid-serve https://github.com/simstudioai/sim/pull/9143/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/9143/files
6975ce2 fix(files): answer 499 instead of 500 when a client disconnects mid-s… waleedlatif1 Oct 16, 2026 https://github.com/simstudioai/sim/pull/9143/commits/6975ce23e4cb70612535fe77227d78af064d55cb
Clear filters https://github.com/simstudioai/sim/pull/9143/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9143/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9143/files
route.test.ts https://github.com/simstudioai/sim/pull/9143/files#diff-aaa040f5cf2c4f4a89280a9560728fcb6c688e410ee0f6945faee6a913a8634f
route.ts https://github.com/simstudioai/sim/pull/9143/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
apps/sim/app/api/files/serve/[...path]/route.test.tshttps://github.com/simstudioai/sim/pull/9143/files#diff-aaa040f5cf2c4f4a89280a9560728fcb6c688e410ee0f6945faee6a913a8634f
View file https://github.com/simstudioai/sim/blob/6975ce23e4cb70612535fe77227d78af064d55cb/apps/sim/app/api/files/serve/%5B...path%5D/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9143/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9143/files#diff-aaa040f5cf2c4f4a89280a9560728fcb6c688e410ee0f6945faee6a913a8634f
https://github.com/simstudioai/sim/pull/9143/files#diff-aaa040f5cf2c4f4a89280a9560728fcb6c688e410ee0f6945faee6a913a8634f
https://github.com/simstudioai/sim/pull/9143/files#diff-aaa040f5cf2c4f4a89280a9560728fcb6c688e410ee0f6945faee6a913a8634f
https://github.com/simstudioai/sim/pull/9143/files#diff-aaa040f5cf2c4f4a89280a9560728fcb6c688e410ee0f6945faee6a913a8634f
apps/sim/app/api/files/serve/[...path]/route.tshttps://github.com/simstudioai/sim/pull/9143/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
View file https://github.com/simstudioai/sim/blob/6975ce23e4cb70612535fe77227d78af064d55cb/apps/sim/app/api/files/serve/%5B...path%5D/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9143/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9143/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
https://github.com/simstudioai/sim/pull/9143/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
https://github.com/simstudioai/sim/pull/9143/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
Please reload this pagehttps://github.com/simstudioai/sim/pull/9143/files
https://github.com/simstudioai/sim/pull/9143/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
https://github.com/simstudioai/sim/pull/9143/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
https://github.com/simstudioai/sim/pull/9143/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.