René's URL Explorer Experiment


Title: fix(trigger): complete async workflow runs whose failure is already recorded instead of failing them by waleedlatif1 · Pull Request #9139 · simstudioai/sim · GitHub

Open Graph Title: fix(trigger): complete async workflow runs whose failure is already recorded instead of failing them by waleedlatif1 · Pull Request #9139 · simstudioai/sim

X Title: fix(trigger): complete async workflow runs whose failure is already recorded instead of failing them by waleedlatif1 · Pull Request #9139 · simstudioai/sim

Description: Summary Async workflow-execution runs failed their Trigger.dev run on every ordinary workflow error, so each one posted ":rotating_light: Error in workflow-execution" to Slack. In the last 7 days all 38 Failed runs were user/workflow errors (missing start block, user Python errors, provider 429/500s), none were infrastructure faults. #4860 fixed the same problem for webhook runs but skipped this task, and its "already recorded" check could never pass: core sets that flag inside a post-execution promise the worker never awaited. A shared isRecordedWorkflowFailure awaits post-execution before checking whether core recorded the failure. It is used by workflow, webhook (no behavior change) and schedule runs. A recorded failure now records the exception on the span and completes the run with { success: false, error }. Timeouts still throw (and alert), as do failures core did not record (infrastructure faults, parse errors), preprocessing 5xx, and retryable 402/429/503 rejections. Non-retryable preprocessing rejections (404 deleted/archived workflow, 403 not deployed or suspended, 402 usage exceeded, 429 rate limit) are already written to the execution log, so they also complete instead of failing. Legacy contract preserved: both queue backends' getJob report a completed workflow-execution job whose output is { success: false, error } as status: 'failed' with the same error. GET /api/jobs/[jobId] (v1 async statusUrl, the TS and Python SDKs, legacy resume) and the v2 status fallback therefore return the same JSON as before. Error text in the result is capped at 16 KiB of UTF-8 so it stays inline under Trigger's 128 KiB output offload limit. Resume runs are unchanged: their inline callers rely on the throw. Type of Change Bug fix Testing Worker tests cover the post-execution race, timeout (still throws), deadline-aborted recorded errors (still throw), the 4 non-retryable rejections, and the retryable 429/402 cases. Backend tests compare the new projection with toStrictEqual against the Job an old FAILED run/row produced, on both Trigger and database backends. Each guard was reverted on its own; its test went red each time and green when restored. An independent adversarial review checked every consumer of the run status and output, plus deploy order (Trigger promotes after the app). No regression found. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced

Open Graph Description: Summary Async workflow-execution runs failed their Trigger.dev run on every ordinary workflow error, so each one posted ":rotating_light: Error in workflow-execution" to Slack. In the las...

X Description: Summary Async workflow-execution runs failed their Trigger.dev run on every ordinary workflow error, so each one posted ":rotating_light: Error in workflow-execution" to Slack. In...

Opengraph URL: https://github.com/simstudioai/sim/pull/9139

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e80f965c-bc0a-21fb-e22c-86aed5ed6d32
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8A5C:1BB96C:CB4337:1163319:6AFB5755
html-safe-nonce65d25cf69dd337186ec2bce3afaa899cacc673d1e825b9fedbd7dbcd08775ab6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTVDOjFCQjk2QzpDQjQzMzc6MTE2MzMxOTo2QUZCNTc1NSIsInZpc2l0b3JfaWQiOiIzNTg1MzQ3OTk1MDgxMzMyNTY1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb58dc27715b53b64697c19d9505aef1e10932cf0c3ba063f7acdbeb4528e99d2
hovercard-subject-tagpull_request:4894705806
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9139/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Async workflow-execution runs failed their Trigger.dev run on every ordinary workflow error, so each one posted ":rotating_light: Error in workflow-execution" to Slack. In the las...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9139/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9139%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9139%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9139/files
Reloadhttps://github.com/simstudioai/sim/pull/9139/files
Reloadhttps://github.com/simstudioai/sim/pull/9139/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/workflow-task-failure-outcomehttps://github.com/simstudioai/sim/tree/fix/workflow-task-failure-outcome
Conversation 12 https://github.com/simstudioai/sim/pull/9139
Commits 5 https://github.com/simstudioai/sim/pull/9139/commits
Checks 52 https://github.com/simstudioai/sim/pull/9139/checks
Files changed https://github.com/simstudioai/sim/pull/9139/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9139/files
fix(trigger): complete async workflow runs whose failure is already recorded instead of failing them https://github.com/simstudioai/sim/pull/9139/files#top
Show all changes 5 commits https://github.com/simstudioai/sim/pull/9139/files
e3cbbad fix(trigger): complete async workflow runs whose failure is already r… waleedlatif1 Oct 16, 2026 https://github.com/simstudioai/sim/pull/9139/commits/e3cbbadb4b4f389b5a147ed193a3f9f259188925
d4d9485 fix(trigger): bound recorded workflow failure errors in UTF-8 bytes waleedlatif1 Oct 16, 2026 https://github.com/simstudioai/sim/pull/9139/commits/d4d94856f6e28fa00a1fe6de726978b7c9931a13
d913d6a chore(audits): shrink the unused-exports baseline for PreprocessExecu… waleedlatif1 Oct 16, 2026 https://github.com/simstudioai/sim/pull/9139/commits/d913d6a8ac6d7564ac27d2f012942495924bf7ce
6431fc6 fix(trigger): keep alerting on deadline-passed and unlogged async wor… waleedlatif1 Oct 16, 2026 https://github.com/simstudioai/sim/pull/9139/commits/6431fc60c80ec14c17a5547a364b8a2edf6d6d12
d5e6319 refactor(trigger): share the recorded-failure completion and skip the… waleedlatif1 Oct 16, 2026 https://github.com/simstudioai/sim/pull/9139/commits/d5e6319c5f5b16d714727ef76cd145d46ed1fc1b
Clear filters https://github.com/simstudioai/sim/pull/9139/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9139/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9139/files
async-preprocessing-correlation.test.ts https://github.com/simstudioai/sim/pull/9139/files#diff-ca34e4edc8b5e34181ac65445f6a7db848ace1390f962db97bf19a3e36cd13bc
schedule-execution.ts https://github.com/simstudioai/sim/pull/9139/files#diff-c9c5a894650376fd9b109f150455a416252960499a892b1371b297af299db347
webhook-execution.ts https://github.com/simstudioai/sim/pull/9139/files#diff-d3c199a17069fce702da388ec4cd1b4efc793e0a5968072a181280db5aafdbb1
workflow-execution.ts https://github.com/simstudioai/sim/pull/9139/files#diff-f8d70a9414b6740f6d7f47310a28af20aa45bcbfe00c399166f3f785dfc3903d
database.test.ts https://github.com/simstudioai/sim/pull/9139/files#diff-9087a5b4b6a502eecdf7db9b25eb9073a11baff1a98261a5a4cecfe5402018ef
database.ts https://github.com/simstudioai/sim/pull/9139/files#diff-fefc9fd260f80579ec85711ad364032eba5dc97e39be0933bd84841d8d83e4c6
trigger-dev.test.ts https://github.com/simstudioai/sim/pull/9139/files#diff-b5bf5f0ed76ee983bd85f4bb53a0f92b294c79cff64e593184a39672b320464e
trigger-dev.ts https://github.com/simstudioai/sim/pull/9139/files#diff-b958b57cdd2a5f9c4810a9ab7f23f04197dc6bf85c187708611c43de2293676a
recorded-failure.ts https://github.com/simstudioai/sim/pull/9139/files#diff-54472e056adff39b34f4f6bb5b561fdbf77eb6b872a997e2793f24e6737f0071
recorded-failure.ts https://github.com/simstudioai/sim/pull/9139/files#diff-f338b73fdcf2cb2dd897cc099f1d677e8cf98bd8056c6fab7e116d35cbcdd43f
check-unused-exports.baseline.json https://github.com/simstudioai/sim/pull/9139/files#diff-4b59a8526a4f226dffb0fbf6b8ec25d3082ab45da697f584eaaca4bd483c928f
apps/sim/background/async-preprocessing-correlation.test.tshttps://github.com/simstudioai/sim/pull/9139/files#diff-ca34e4edc8b5e34181ac65445f6a7db848ace1390f962db97bf19a3e36cd13bc
View file https://github.com/simstudioai/sim/blob/d5e6319c5f5b16d714727ef76cd145d46ed1fc1b/apps/sim/background/async-preprocessing-correlation.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9139/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9139/files#diff-ca34e4edc8b5e34181ac65445f6a7db848ace1390f962db97bf19a3e36cd13bc
https://github.com/simstudioai/sim/pull/9139/files#diff-ca34e4edc8b5e34181ac65445f6a7db848ace1390f962db97bf19a3e36cd13bc
https://github.com/simstudioai/sim/pull/9139/files#diff-ca34e4edc8b5e34181ac65445f6a7db848ace1390f962db97bf19a3e36cd13bc
https://github.com/simstudioai/sim/pull/9139/files#diff-ca34e4edc8b5e34181ac65445f6a7db848ace1390f962db97bf19a3e36cd13bc
apps/sim/background/schedule-execution.tshttps://github.com/simstudioai/sim/pull/9139/files#diff-c9c5a894650376fd9b109f150455a416252960499a892b1371b297af299db347
View file https://github.com/simstudioai/sim/blob/d5e6319c5f5b16d714727ef76cd145d46ed1fc1b/apps/sim/background/schedule-execution.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9139/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9139/files#diff-c9c5a894650376fd9b109f150455a416252960499a892b1371b297af299db347
https://github.com/simstudioai/sim/pull/9139/files#diff-c9c5a894650376fd9b109f150455a416252960499a892b1371b297af299db347
https://github.com/simstudioai/sim/pull/9139/files#diff-c9c5a894650376fd9b109f150455a416252960499a892b1371b297af299db347
https://github.com/simstudioai/sim/pull/9139/files#diff-c9c5a894650376fd9b109f150455a416252960499a892b1371b297af299db347
apps/sim/background/webhook-execution.tshttps://github.com/simstudioai/sim/pull/9139/files#diff-d3c199a17069fce702da388ec4cd1b4efc793e0a5968072a181280db5aafdbb1
View file https://github.com/simstudioai/sim/blob/d5e6319c5f5b16d714727ef76cd145d46ed1fc1b/apps/sim/background/webhook-execution.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9139/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9139/files#diff-d3c199a17069fce702da388ec4cd1b4efc793e0a5968072a181280db5aafdbb1
https://github.com/simstudioai/sim/pull/9139/files#diff-d3c199a17069fce702da388ec4cd1b4efc793e0a5968072a181280db5aafdbb1
https://github.com/simstudioai/sim/pull/9139/files#diff-d3c199a17069fce702da388ec4cd1b4efc793e0a5968072a181280db5aafdbb1
https://github.com/simstudioai/sim/pull/9139/files#diff-d3c199a17069fce702da388ec4cd1b4efc793e0a5968072a181280db5aafdbb1
apps/sim/background/workflow-execution.tshttps://github.com/simstudioai/sim/pull/9139/files#diff-f8d70a9414b6740f6d7f47310a28af20aa45bcbfe00c399166f3f785dfc3903d
View file https://github.com/simstudioai/sim/blob/d5e6319c5f5b16d714727ef76cd145d46ed1fc1b/apps/sim/background/workflow-execution.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9139/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9139/files#diff-f8d70a9414b6740f6d7f47310a28af20aa45bcbfe00c399166f3f785dfc3903d
https://github.com/simstudioai/sim/pull/9139/files#diff-f8d70a9414b6740f6d7f47310a28af20aa45bcbfe00c399166f3f785dfc3903d
https://github.com/simstudioai/sim/pull/9139/files#diff-f8d70a9414b6740f6d7f47310a28af20aa45bcbfe00c399166f3f785dfc3903d
https://github.com/simstudioai/sim/pull/9139/files#diff-f8d70a9414b6740f6d7f47310a28af20aa45bcbfe00c399166f3f785dfc3903d
https://github.com/simstudioai/sim/pull/9139/files#diff-f8d70a9414b6740f6d7f47310a28af20aa45bcbfe00c399166f3f785dfc3903d
https://github.com/simstudioai/sim/pull/9139/files#diff-f8d70a9414b6740f6d7f47310a28af20aa45bcbfe00c399166f3f785dfc3903d
https://github.com/simstudioai/sim/pull/9139/files#diff-f8d70a9414b6740f6d7f47310a28af20aa45bcbfe00c399166f3f785dfc3903d
https://github.com/simstudioai/sim/pull/9139/files#diff-f8d70a9414b6740f6d7f47310a28af20aa45bcbfe00c399166f3f785dfc3903d
https://github.com/simstudioai/sim/pull/9139/files#diff-f8d70a9414b6740f6d7f47310a28af20aa45bcbfe00c399166f3f785dfc3903d
https://github.com/simstudioai/sim/pull/9139/files#diff-f8d70a9414b6740f6d7f47310a28af20aa45bcbfe00c399166f3f785dfc3903d
https://github.com/simstudioai/sim/pull/9139/files#diff-f8d70a9414b6740f6d7f47310a28af20aa45bcbfe00c399166f3f785dfc3903d
apps/sim/lib/core/async-jobs/backends/database.test.tshttps://github.com/simstudioai/sim/pull/9139/files#diff-9087a5b4b6a502eecdf7db9b25eb9073a11baff1a98261a5a4cecfe5402018ef
View file https://github.com/simstudioai/sim/blob/d5e6319c5f5b16d714727ef76cd145d46ed1fc1b/apps/sim/lib/core/async-jobs/backends/database.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9139/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9139/files#diff-9087a5b4b6a502eecdf7db9b25eb9073a11baff1a98261a5a4cecfe5402018ef
https://github.com/simstudioai/sim/pull/9139/files#diff-9087a5b4b6a502eecdf7db9b25eb9073a11baff1a98261a5a4cecfe5402018ef
https://github.com/simstudioai/sim/pull/9139/files#diff-9087a5b4b6a502eecdf7db9b25eb9073a11baff1a98261a5a4cecfe5402018ef
Please reload this pagehttps://github.com/simstudioai/sim/pull/9139/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9139/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.