René's URL Explorer Experiment


Title: fix(mothership): keep a started call's result after Stop, and let a blocked owner stop their run by waleedlatif1 · Pull Request #9114 · simstudioai/sim · GitHub

Open Graph Title: fix(mothership): keep a started call's result after Stop, and let a blocked owner stop their run by waleedlatif1 · Pull Request #9114 · simstudioai/sim

X Title: fix(mothership): keep a started call's result after Stop, and let a blocked owner stop their run by waleedlatif1 · Pull Request #9114 · simstudioai/sim

Description: Summary Two independent run-stopping fixes, one commit each. Stopped run's tool call (executor) When a second controller reached a call after Stop closed tool admission, it settled the row as "Run stopped before tool admission" with an unguarded write that also overwrote a running row. If another process's handler was still executing that call under a live lease, the call actually ran, its real result was lost (the owner's fenced write then failed), and the call read as both not-run and executed The closed branch now cancels only a still-pending row (completePendingAsyncToolCall); a call something already started falls through to the existing observer path and reports the owner's durable result (or lets an expired lease be revoked as lost). The common case publishes exactly the same cancellation Stop for a blocked owner (run controls) Stop resolved the run's chat through the same owned-chat check as every other chat operation, which refuses a blocked account, so an owner on the access-control blocklist got 403 "User account is suspended" from Stop while their run kept going resolveOwnedChatContext takes an explicit allowBlockedOwner option, passed only by Stop when resolving an already-admitted run. Ownership, chat, run and scope checks are unchanged; steer, send and every other caller keep the ban check, and a Stop recorded ahead of admission still requires an unblocked account Type of Change Bug fix Testing executor.test.ts: a closed claim on a pending row is cancelled exactly as before; on a row another controller started, the row is not overwritten and the call returns that controller's real result (fails before) removal-stops-runs.integration.ts (real Postgres + Redis): a blocked owner can Stop their run and the worker receives it (fails before); the same owner is refused steer and send; another workspace member cannot Stop the run Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Two independent run-stopping fixes, one commit each. Stopped run's tool call (executor) When a second controller reached a call after Stop closed tool admission, it settled the row as ...

X Description: Summary Two independent run-stopping fixes, one commit each. Stopped run's tool call (executor) When a second controller reached a call after Stop closed tool admission, it settled the row...

Opengraph URL: https://github.com/simstudioai/sim/pull/9114

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7ac2d175-d717-64ed-5356-56247ab0ad43
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDCDC:18E6DD:A33F54:E09D48:6AFB4F76
html-safe-nonce748e0d87cdaffa06d9b65397ed8cd533a38630ad74ddc8f5b67abc358c565cd7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0RDOjE4RTZERDpBMzNGNTQ6RTA5RDQ4OjZBRkI0Rjc2IiwidmlzaXRvcl9pZCI6IjgwNDE5NzQ2NjQ2NDcxMDIzMjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace3f7848059fbbd0d8689dd4bc71f2e496a16c3964445e864c7faf0e8027193ab
hovercard-subject-tagpull_request:4883914218
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9114/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Two independent run-stopping fixes, one commit each. Stopped run's tool call (executor) When a second controller reached a call after Stop closed tool admission, it settled the row as ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9114/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9114%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9114%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9114/files
Reloadhttps://github.com/simstudioai/sim/pull/9114/files
Reloadhttps://github.com/simstudioai/sim/pull/9114/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/closed-settle-and-blocked-owner-stophttps://github.com/simstudioai/sim/tree/fix/closed-settle-and-blocked-owner-stop
Conversation 2 https://github.com/simstudioai/sim/pull/9114
Commits 2 https://github.com/simstudioai/sim/pull/9114/commits
Checks 52 https://github.com/simstudioai/sim/pull/9114/checks
Files changed https://github.com/simstudioai/sim/pull/9114/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9114/files
fix(mothership): keep a started call's result after Stop, and let a blocked owner stop their run https://github.com/simstudioai/sim/pull/9114/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/9114/files
72bf2f8 fix(mothership): settle a stopped run's call as never run only while … waleedlatif1 Oct 16, 2026 https://github.com/simstudioai/sim/pull/9114/commits/72bf2f8a8bf00afc8afcac81c7bb4651ee6b57b2
f99a843 fix(mothership): let a blocked owner stop their admitted run waleedlatif1 Oct 16, 2026 https://github.com/simstudioai/sim/pull/9114/commits/f99a843b238a1e0a963e6b6eb75e3a106d3f00c5
Clear filters https://github.com/simstudioai/sim/pull/9114/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9114/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9114/files
context.ts https://github.com/simstudioai/sim/pull/9114/files#diff-53ba708ba4ce73b692c29881bcce54f3849d93c97886844a7c8a1d6bce501a2b
controls.ts https://github.com/simstudioai/sim/pull/9114/files#diff-99343ce422b25af55834e446458d5d048b56514d2bf23fe923f4609015fe51bf
removal-stops-runs.integration.ts https://github.com/simstudioai/sim/pull/9114/files#diff-57d195cefaa4cde88de82ea602cc9114d119faab15d8a7b7d9ad8fb58f3a3e4d
executor.test.ts https://github.com/simstudioai/sim/pull/9114/files#diff-5c0149489977e70711d949724f46e8bcd43162b7fbd3928da59a33aa935af5e7
executor.ts https://github.com/simstudioai/sim/pull/9114/files#diff-42b57bff4502cb04d3c049cc5137e7208b20a861400af267c0f15f773633f6ab
apps/sim/lib/mothership/chat/application/context.tshttps://github.com/simstudioai/sim/pull/9114/files#diff-53ba708ba4ce73b692c29881bcce54f3849d93c97886844a7c8a1d6bce501a2b
View file https://github.com/simstudioai/sim/blob/f99a843b238a1e0a963e6b6eb75e3a106d3f00c5/apps/sim/lib/mothership/chat/application/context.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9114/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9114/files#diff-53ba708ba4ce73b692c29881bcce54f3849d93c97886844a7c8a1d6bce501a2b
https://github.com/simstudioai/sim/pull/9114/files#diff-53ba708ba4ce73b692c29881bcce54f3849d93c97886844a7c8a1d6bce501a2b
https://github.com/simstudioai/sim/pull/9114/files#diff-53ba708ba4ce73b692c29881bcce54f3849d93c97886844a7c8a1d6bce501a2b
apps/sim/lib/mothership/request/application/controls.tshttps://github.com/simstudioai/sim/pull/9114/files#diff-99343ce422b25af55834e446458d5d048b56514d2bf23fe923f4609015fe51bf
View file https://github.com/simstudioai/sim/blob/f99a843b238a1e0a963e6b6eb75e3a106d3f00c5/apps/sim/lib/mothership/request/application/controls.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9114/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9114/files#diff-99343ce422b25af55834e446458d5d048b56514d2bf23fe923f4609015fe51bf
https://github.com/simstudioai/sim/pull/9114/files#diff-99343ce422b25af55834e446458d5d048b56514d2bf23fe923f4609015fe51bf
https://github.com/simstudioai/sim/pull/9114/files#diff-99343ce422b25af55834e446458d5d048b56514d2bf23fe923f4609015fe51bf
https://github.com/simstudioai/sim/pull/9114/files#diff-99343ce422b25af55834e446458d5d048b56514d2bf23fe923f4609015fe51bf
https://github.com/simstudioai/sim/pull/9114/files#diff-99343ce422b25af55834e446458d5d048b56514d2bf23fe923f4609015fe51bf
https://github.com/simstudioai/sim/pull/9114/files#diff-99343ce422b25af55834e446458d5d048b56514d2bf23fe923f4609015fe51bf
https://github.com/simstudioai/sim/pull/9114/files#diff-99343ce422b25af55834e446458d5d048b56514d2bf23fe923f4609015fe51bf
apps/sim/lib/mothership/request/application/removal-stops-runs.integration.tshttps://github.com/simstudioai/sim/pull/9114/files#diff-57d195cefaa4cde88de82ea602cc9114d119faab15d8a7b7d9ad8fb58f3a3e4d
View file https://github.com/simstudioai/sim/blob/f99a843b238a1e0a963e6b6eb75e3a106d3f00c5/apps/sim/lib/mothership/request/application/removal-stops-runs.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9114/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9114/files#diff-57d195cefaa4cde88de82ea602cc9114d119faab15d8a7b7d9ad8fb58f3a3e4d
https://github.com/simstudioai/sim/pull/9114/files#diff-57d195cefaa4cde88de82ea602cc9114d119faab15d8a7b7d9ad8fb58f3a3e4d
https://github.com/simstudioai/sim/pull/9114/files#diff-57d195cefaa4cde88de82ea602cc9114d119faab15d8a7b7d9ad8fb58f3a3e4d
https://github.com/simstudioai/sim/pull/9114/files#diff-57d195cefaa4cde88de82ea602cc9114d119faab15d8a7b7d9ad8fb58f3a3e4d
apps/sim/lib/mothership/request/tools/executor.test.tshttps://github.com/simstudioai/sim/pull/9114/files#diff-5c0149489977e70711d949724f46e8bcd43162b7fbd3928da59a33aa935af5e7
View file https://github.com/simstudioai/sim/blob/f99a843b238a1e0a963e6b6eb75e3a106d3f00c5/apps/sim/lib/mothership/request/tools/executor.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9114/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9114/files#diff-5c0149489977e70711d949724f46e8bcd43162b7fbd3928da59a33aa935af5e7
https://github.com/simstudioai/sim/pull/9114/files#diff-5c0149489977e70711d949724f46e8bcd43162b7fbd3928da59a33aa935af5e7
https://github.com/simstudioai/sim/pull/9114/files#diff-5c0149489977e70711d949724f46e8bcd43162b7fbd3928da59a33aa935af5e7
https://github.com/simstudioai/sim/pull/9114/files#diff-5c0149489977e70711d949724f46e8bcd43162b7fbd3928da59a33aa935af5e7
apps/sim/lib/mothership/request/tools/executor.tshttps://github.com/simstudioai/sim/pull/9114/files#diff-42b57bff4502cb04d3c049cc5137e7208b20a861400af267c0f15f773633f6ab
View file https://github.com/simstudioai/sim/blob/f99a843b238a1e0a963e6b6eb75e3a106d3f00c5/apps/sim/lib/mothership/request/tools/executor.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9114/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9114/files#diff-42b57bff4502cb04d3c049cc5137e7208b20a861400af267c0f15f773633f6ab
https://github.com/simstudioai/sim/pull/9114/files#diff-42b57bff4502cb04d3c049cc5137e7208b20a861400af267c0f15f773633f6ab
https://github.com/simstudioai/sim/pull/9114/files#diff-42b57bff4502cb04d3c049cc5137e7208b20a861400af267c0f15f773633f6ab
https://github.com/simstudioai/sim/pull/9114/files#diff-42b57bff4502cb04d3c049cc5137e7208b20a861400af267c0f15f773633f6ab
https://github.com/simstudioai/sim/pull/9114/files#diff-42b57bff4502cb04d3c049cc5137e7208b20a861400af267c0f15f773633f6ab
https://github.com/simstudioai/sim/pull/9114/files#diff-42b57bff4502cb04d3c049cc5137e7208b20a861400af267c0f15f773633f6ab
https://github.com/simstudioai/sim/pull/9114/files#diff-42b57bff4502cb04d3c049cc5137e7208b20a861400af267c0f15f773633f6ab
https://github.com/simstudioai/sim/pull/9114/files#diff-42b57bff4502cb04d3c049cc5137e7208b20a861400af267c0f15f773633f6ab
Please reload this pagehttps://github.com/simstudioai/sim/pull/9114/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.