René's URL Explorer Experiment


Title: fix(desktop): tighten computer use input guards for text, tabs, menus and AX failures by waleedlatif1 · Pull Request #9112 · simstudioai/sim · GitHub

Open Graph Title: fix(desktop): tighten computer use input guards for text, tabs, menus and AX failures by waleedlatif1 · Pull Request #9112 · simstudioai/sim

X Title: fix(desktop): tighten computer use input guards for text, tabs, menus and AX failures by waleedlatif1 · Pull Request #9112 · simstudioai/sim

Description: Summary Follow-ups to #9084, #9093 and #9100. A review of those changes found input guards that were looser than they needed to be. Each finding below was confirmed on a macOS 26 VM, against both the previous helper and this one. Text input type_text and input_sequence accepted any element whose focus can be set. That let them type into sliders, and, in web and Electron content, into buttons and lists, where a space or a letter is a command. Typed text now needs a text control: a text field or area (terminals included), a combo box, a date or time field, or anything with an editable text selection. A container target is accepted only while its focused editor holds focus, and keys are sent only while focus is in a text input. Targeting a container whose inner editor already had focus moved focus to the container. That editor now keeps focus. Windows A hidden native tab (Finder, Terminal) is a separate off-screen window with the same bounds as the visible tab. Accessibility exposes only the visible tab, so a click aimed at a hidden tab's id was accepted and landed in the visible tab. The selected window could also be a hidden tab. Off-screen windows no longer get a window identity, and the focused window is now matched by its Accessibility identity rather than by bounds. A click on a window's own background or title bar was refused as occluded, because a window does not report an AXWindow of itself. One containingWindow helper now handles this for the hit-test, element windows and the editor's window. An element click that falls back to a coordinate click now targets the element's own window. Before, it used whichever observed window contained the point, in arbitrary order. Menus The menu bar is now read with the priority entries. On a large window the old helper never reached the menu bar: with a 2,000-node Safari page it observed no menu nodes, so no menu could be opened. Now an open menu's items come first. A closed menu's items are read last, still capped at 80. The Return that completes a highlighted menu item is sent only while the item's own menu is still open and the app itself reports the item as highlighted. Before, any pop-up-level window of the app counted as an open menu, and the helper set the highlight itself. Calendar keeps reporting an item as highlighted after its menu closes, so the open-menu check is what stops a stray Return. Accessibility failures An Accessibility failure now counts as dispatched unless Accessibility rejected the request before the app saw it (unsupported attribute or action, illegal argument, not implemented, API disabled). A generic failure can follow an effect. It used to report "Nothing was sent; this snapshot is still valid", which could lead to a duplicate retry. "This snapshot is still valid" is now added only to request errors. It used to follow "observe again" on stale-window, occlusion and focus errors, and it repeated activation_required's own wording. Other The desktop service rejects arguments its bundled schema predates with a structured invalid_arguments error marked not_started, instead of a raw ZodError. The web treated a raw ZodError as "outcome unknown, do not retry", although nothing had been queued. The computer-use contract copies are synced from simstudioai/mothership#725: one description per shared field, and scroll deltas no longer described as "Defaults to 0" while one is required. This is a description-only change. Type of Change Bug fix Testing Run on a macOS 26.6 VM, previous helper vs this one: Check Previous helper This change tests/live.py pass pass New live.py checks: slider refuses text; window target types into its focused field; title-bar click fail pass Finder window with three tabs: right-click aimed at each window id all 4 accepted, a hidden tab selected only the visible tab accepted and selected TextEdit title-bar click window_occluded accepted Safari with a 2,000-node page: History or Bookmarks open no menu bar observed 15 and 16 open items observed Finder New Tab, Calendar New Event via the menus ran once ran once The paired benchmark against the previous helper is posted below. vitest for service.test.ts (32 passed) and ipc.test.ts (45 passed); biome. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Follow-ups to #9084, #9093 and #9100. A review of those changes found input guards that were looser than they needed to be. Each finding below was confirmed on a macOS 26 VM, against both t...

X Description: Summary Follow-ups to #9084, #9093 and #9100. A review of those changes found input guards that were looser than they needed to be. Each finding below was confirmed on a macOS 26 VM, against both t...

Opengraph URL: https://github.com/simstudioai/sim/pull/9112

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3fbcb317-afd9-7362-5954-492e4c339ec9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB560:FD97C:26F5FF:368494:6AFB5274
html-safe-noncea803b1cbf2cedd0c68f0ce8816eadd9188d0c6c3371e81f78fc59e3e8152fad9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTYwOkZEOTdDOjI2RjVGRjozNjg0OTQ6NkFGQjUyNzQiLCJ2aXNpdG9yX2lkIjoiNTg5MzQ0MzA1MzIxNjgxMzY4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac320029301532a653f9199b345f2fad1662db4b6a2cbc40ad4443f6e067c0f1e0
hovercard-subject-tagpull_request:4883720073
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9112/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-ups to #9084, #9093 and #9100. A review of those changes found input guards that were looser than they needed to be. Each finding below was confirmed on a macOS 26 VM, against both t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9112/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9112%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9112%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9112/files
Reloadhttps://github.com/simstudioai/sim/pull/9112/files
Reloadhttps://github.com/simstudioai/sim/pull/9112/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/computer-use-guardshttps://github.com/simstudioai/sim/tree/fix/computer-use-guards
Conversation 15 https://github.com/simstudioai/sim/pull/9112
Commits 2 https://github.com/simstudioai/sim/pull/9112/commits
Checks 55 https://github.com/simstudioai/sim/pull/9112/checks
Files changed https://github.com/simstudioai/sim/pull/9112/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9112/files
fix(desktop): tighten computer use input guards for text, tabs, menus and AX failures https://github.com/simstudioai/sim/pull/9112/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/9112/files
9f29b11 fix(desktop): tighten computer use input guards for text, tabs, menus… waleedlatif1 Oct 16, 2026 https://github.com/simstudioai/sim/pull/9112/commits/9f29b112ac609386f75849c1da494b65ef782e51
b22eecd fix(desktop): keep hidden tabs out of the window list and pin typed t… waleedlatif1 Oct 16, 2026 https://github.com/simstudioai/sim/pull/9112/commits/b22eecd182cc564450f4c7d069f579bb22228d3b
Clear filters https://github.com/simstudioai/sim/pull/9112/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9112/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9112/files
ComputerUse.swift https://github.com/simstudioai/sim/pull/9112/files#diff-8e77406c8b4bdb699d65031fc9054f5d47a9422c1cdaf440deb111c29853b303
README.md https://github.com/simstudioai/sim/pull/9112/files#diff-03fc5e0250cdf6ef5d5dd01b4f430847bd8745da6b657dd1afe6cda2f3d7fc64
live.py https://github.com/simstudioai/sim/pull/9112/files#diff-c4c5d4127e98667220262780db3add8a3cffa103580548accb07f89c95232d06
service.ts https://github.com/simstudioai/sim/pull/9112/files#diff-ce1c51357a80d69159986c3f4353cbf608bb98703cf84fc65841abe26e32e194
computer-use.ts https://github.com/simstudioai/sim/pull/9112/files#diff-21c457ba233c9c33fa093b5e2b400fc8d4f582c203424cfa1f629e100263ff61
computer-use.generated.ts https://github.com/simstudioai/sim/pull/9112/files#diff-527b771cb8411b5397ed272d9b3a8eca55a0253bd07f73e9766d10a42475f9b8
apps/desktop/native/computer-use/ComputerUse.swifthttps://github.com/simstudioai/sim/pull/9112/files#diff-8e77406c8b4bdb699d65031fc9054f5d47a9422c1cdaf440deb111c29853b303
View file https://github.com/simstudioai/sim/blob/b22eecd182cc564450f4c7d069f579bb22228d3b/apps/desktop/native/computer-use/ComputerUse.swift
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/simstudioai/sim/pull/9112/files
apps/desktop/native/computer-use/README.mdhttps://github.com/simstudioai/sim/pull/9112/files#diff-03fc5e0250cdf6ef5d5dd01b4f430847bd8745da6b657dd1afe6cda2f3d7fc64
View file https://github.com/simstudioai/sim/blob/b22eecd182cc564450f4c7d069f579bb22228d3b/apps/desktop/native/computer-use/README.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9112/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9112/files#diff-03fc5e0250cdf6ef5d5dd01b4f430847bd8745da6b657dd1afe6cda2f3d7fc64
https://github.com/simstudioai/sim/pull/9112/files#diff-03fc5e0250cdf6ef5d5dd01b4f430847bd8745da6b657dd1afe6cda2f3d7fc64
apps/desktop/native/computer-use/tests/live.pyhttps://github.com/simstudioai/sim/pull/9112/files#diff-c4c5d4127e98667220262780db3add8a3cffa103580548accb07f89c95232d06
View file https://github.com/simstudioai/sim/blob/b22eecd182cc564450f4c7d069f579bb22228d3b/apps/desktop/native/computer-use/tests/live.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9112/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9112/files#diff-c4c5d4127e98667220262780db3add8a3cffa103580548accb07f89c95232d06
https://github.com/simstudioai/sim/pull/9112/files#diff-c4c5d4127e98667220262780db3add8a3cffa103580548accb07f89c95232d06
https://github.com/simstudioai/sim/pull/9112/files#diff-c4c5d4127e98667220262780db3add8a3cffa103580548accb07f89c95232d06
https://github.com/simstudioai/sim/pull/9112/files#diff-c4c5d4127e98667220262780db3add8a3cffa103580548accb07f89c95232d06
apps/desktop/src/main/computer-use/service.tshttps://github.com/simstudioai/sim/pull/9112/files#diff-ce1c51357a80d69159986c3f4353cbf608bb98703cf84fc65841abe26e32e194
View file https://github.com/simstudioai/sim/blob/b22eecd182cc564450f4c7d069f579bb22228d3b/apps/desktop/src/main/computer-use/service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9112/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9112/files#diff-ce1c51357a80d69159986c3f4353cbf608bb98703cf84fc65841abe26e32e194
https://github.com/simstudioai/sim/pull/9112/files#diff-ce1c51357a80d69159986c3f4353cbf608bb98703cf84fc65841abe26e32e194
apps/sim/lib/mothership/generated/computer-use.tshttps://github.com/simstudioai/sim/pull/9112/files#diff-21c457ba233c9c33fa093b5e2b400fc8d4f582c203424cfa1f629e100263ff61
View file https://github.com/simstudioai/sim/blob/b22eecd182cc564450f4c7d069f579bb22228d3b/apps/sim/lib/mothership/generated/computer-use.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9112/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9112/files#diff-21c457ba233c9c33fa093b5e2b400fc8d4f582c203424cfa1f629e100263ff61
https://github.com/simstudioai/sim/pull/9112/files#diff-21c457ba233c9c33fa093b5e2b400fc8d4f582c203424cfa1f629e100263ff61
https://github.com/simstudioai/sim/pull/9112/files#diff-21c457ba233c9c33fa093b5e2b400fc8d4f582c203424cfa1f629e100263ff61
https://github.com/simstudioai/sim/pull/9112/files#diff-21c457ba233c9c33fa093b5e2b400fc8d4f582c203424cfa1f629e100263ff61
https://github.com/simstudioai/sim/pull/9112/files#diff-21c457ba233c9c33fa093b5e2b400fc8d4f582c203424cfa1f629e100263ff61
https://github.com/simstudioai/sim/pull/9112/files#diff-21c457ba233c9c33fa093b5e2b400fc8d4f582c203424cfa1f629e100263ff61
https://github.com/simstudioai/sim/pull/9112/files#diff-21c457ba233c9c33fa093b5e2b400fc8d4f582c203424cfa1f629e100263ff61
Please reload this pagehttps://github.com/simstudioai/sim/pull/9112/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9112/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.