René's URL Explorer Experiment


Title: fix(slack): refuse binding a Search bot to a different app or workspace than members by waleedlatif1 · Pull Request #9109 · simstudioai/sim · GitHub

Open Graph Title: fix(slack): refuse binding a Search bot to a different app or workspace than members by waleedlatif1 · Pull Request #9109 · simstudioai/sim

X Title: fix(slack): refuse binding a Search bot to a different app or workspace than members by waleedlatif1 · Pull Request #9109 · simstudioai/sim

Description: Summary Binding Sim Search to an existing bot credential (configureSlackSearchInstallation) created a new installation without checking the organization's member Slack app, so a bot left over from an earlier install could be bound to a different app or workspace than the members' accounts — a state the install flow already refuses, and one that leaves member setup stuck The new-installation path now runs the same check as setup, inside its transaction under the organization Slack app lock; enabling, disabling and re-validating an existing installation are unchanged (an update is already pinned to its app and workspace) The member-app resolution and the bot-vs-members rule move from setup.ts into organization-slack-app.ts, so both paths share one implementation and one message requireSlackSearchAppAvailable takes the caller's transaction: enabling a custom bot and completing member setup looked up the Slack app kind on a second pooled connection while holding the transaction's, which can deadlock the pool at saturation (the new integration test is the first to reach that path) Type of Change Bug fix Testing Integration (slack-shared-member-accounts.integration.ts, real Postgres): members on the shared app, then binding a leftover custom bot in another workspace is refused with no installation written (inserts one on the current code); binding a leftover shared-app bot in the members' workspace still succeeds setup.test.ts updated for the moved helper; it still exercises the real rule Ran biome on changed files; lint, check:audits, type-check, unit and integration suites run in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Binding Sim Search to an existing bot credential (configureSlackSearchInstallation) created a new installation without checking the organization's member Slack app, so a bot left over ...

X Description: Summary Binding Sim Search to an existing bot credential (configureSlackSearchInstallation) created a new installation without checking the organization's member Slack app, so a bot left o...

Opengraph URL: https://github.com/simstudioai/sim/pull/9109

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:644e6e72-5628-8b1d-6a83-da7b0c38f764
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id84E0:5A71D:AF6E08:F03E77:6AFB4FF0
html-safe-nonce8964fddbe25633c75eed67650eb2702bd9266c77c16065d0f8b62d9c3fd1d009
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NEUwOjVBNzFEOkFGNkUwODpGMDNFNzc6NkFGQjRGRjAiLCJ2aXNpdG9yX2lkIjoiMjU2NTYzMzg4MzI1MjY3NDU0NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9347c04e0489f4473613363c78a1d0c292d2dea068cda2b14128f377799ada84
hovercard-subject-tagpull_request:4883623156
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9109/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Binding Sim Search to an existing bot credential (configureSlackSearchInstallation) created a new installation without checking the organization's member Slack app, so a bot left over ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9109/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9109%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9109%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9109/files
Reloadhttps://github.com/simstudioai/sim/pull/9109/files
Reloadhttps://github.com/simstudioai/sim/pull/9109/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/slack-search-bot-member-apphttps://github.com/simstudioai/sim/tree/fix/slack-search-bot-member-app
Conversation 2 https://github.com/simstudioai/sim/pull/9109
Commits 2 https://github.com/simstudioai/sim/pull/9109/commits
Checks 51 https://github.com/simstudioai/sim/pull/9109/checks
Files changed https://github.com/simstudioai/sim/pull/9109/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9109/files
fix(slack): refuse binding a Search bot to a different app or workspace than members https://github.com/simstudioai/sim/pull/9109/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/9109/files
adf0bb6 fix(slack): refuse binding a Search bot to a different app or workspa… waleedlatif1 Oct 16, 2026 https://github.com/simstudioai/sim/pull/9109/commits/adf0bb6cabd3db7e27d74759229dd0c8ef75e956
5d5f4a0 fix(slack): check Search app availability on the caller's transaction waleedlatif1 Oct 16, 2026 https://github.com/simstudioai/sim/pull/9109/commits/5d5f4a0efb97447d0db5e27c8143013f1539b3a7
Clear filters https://github.com/simstudioai/sim/pull/9109/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9109/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9109/files
slack-shared-member-accounts.integration.ts https://github.com/simstudioai/sim/pull/9109/files#diff-92c2f89c9970ca894df1ef5fb70b484b81e1d1af90726134f9e117d29940e364
organization-slack-app.ts https://github.com/simstudioai/sim/pull/9109/files#diff-0917f381fba2d60f62490c7b6ac55179a33bb78bb38fe5e89fce2eebfca99ed2
provider-configuration.ts https://github.com/simstudioai/sim/pull/9109/files#diff-2ce08d2afe4cadf0d868faac5b9e5e232b741a6e48e41826458eea25754b0bfb
slack-managed-users.ts https://github.com/simstudioai/sim/pull/9109/files#diff-220df4c221b1a1e3a42f13c2c088342c19411d0bc11d1fdac52285f4aca87bdc
installations.ts https://github.com/simstudioai/sim/pull/9109/files#diff-ba1cf3350011fe297d4c9faeb46d268af15a9f8da2a1d341adc90bf158a6006f
setup.test.ts https://github.com/simstudioai/sim/pull/9109/files#diff-4e4fdbbbf6001354e8ea78d39db754c8e96ca17bc6f39a26c47eb3050e07c3d3
setup.ts https://github.com/simstudioai/sim/pull/9109/files#diff-30e93de6d789ea1679b1db7ad8da22b29adec2a20b36bac532da764bfb4e4cb7
shared-app.ts https://github.com/simstudioai/sim/pull/9109/files#diff-a9f26059d2b634cbc308e87c34f47fb4a424bc3f9411269214b533c97d74b9d8
apps/sim/lib/credential-groups/__integration__/slack-shared-member-accounts.integration.tshttps://github.com/simstudioai/sim/pull/9109/files#diff-92c2f89c9970ca894df1ef5fb70b484b81e1d1af90726134f9e117d29940e364
View file https://github.com/simstudioai/sim/blob/5d5f4a0efb97447d0db5e27c8143013f1539b3a7/apps/sim/lib/credential-groups/__integration__/slack-shared-member-accounts.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9109/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9109/files#diff-92c2f89c9970ca894df1ef5fb70b484b81e1d1af90726134f9e117d29940e364
https://github.com/simstudioai/sim/pull/9109/files#diff-92c2f89c9970ca894df1ef5fb70b484b81e1d1af90726134f9e117d29940e364
https://github.com/simstudioai/sim/pull/9109/files#diff-92c2f89c9970ca894df1ef5fb70b484b81e1d1af90726134f9e117d29940e364
https://github.com/simstudioai/sim/pull/9109/files#diff-92c2f89c9970ca894df1ef5fb70b484b81e1d1af90726134f9e117d29940e364
https://github.com/simstudioai/sim/pull/9109/files#diff-92c2f89c9970ca894df1ef5fb70b484b81e1d1af90726134f9e117d29940e364
https://github.com/simstudioai/sim/pull/9109/files#diff-92c2f89c9970ca894df1ef5fb70b484b81e1d1af90726134f9e117d29940e364
https://github.com/simstudioai/sim/pull/9109/files#diff-92c2f89c9970ca894df1ef5fb70b484b81e1d1af90726134f9e117d29940e364
apps/sim/lib/credential-groups/organization-slack-app.tshttps://github.com/simstudioai/sim/pull/9109/files#diff-0917f381fba2d60f62490c7b6ac55179a33bb78bb38fe5e89fce2eebfca99ed2
View file https://github.com/simstudioai/sim/blob/5d5f4a0efb97447d0db5e27c8143013f1539b3a7/apps/sim/lib/credential-groups/organization-slack-app.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9109/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9109/files#diff-0917f381fba2d60f62490c7b6ac55179a33bb78bb38fe5e89fce2eebfca99ed2
https://github.com/simstudioai/sim/pull/9109/files#diff-0917f381fba2d60f62490c7b6ac55179a33bb78bb38fe5e89fce2eebfca99ed2
https://github.com/simstudioai/sim/pull/9109/files#diff-0917f381fba2d60f62490c7b6ac55179a33bb78bb38fe5e89fce2eebfca99ed2
https://github.com/simstudioai/sim/pull/9109/files#diff-0917f381fba2d60f62490c7b6ac55179a33bb78bb38fe5e89fce2eebfca99ed2
apps/sim/lib/credential-groups/provider-configuration.tshttps://github.com/simstudioai/sim/pull/9109/files#diff-2ce08d2afe4cadf0d868faac5b9e5e232b741a6e48e41826458eea25754b0bfb
View file https://github.com/simstudioai/sim/blob/5d5f4a0efb97447d0db5e27c8143013f1539b3a7/apps/sim/lib/credential-groups/provider-configuration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9109/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9109/files#diff-2ce08d2afe4cadf0d868faac5b9e5e232b741a6e48e41826458eea25754b0bfb
https://github.com/simstudioai/sim/pull/9109/files#diff-2ce08d2afe4cadf0d868faac5b9e5e232b741a6e48e41826458eea25754b0bfb
apps/sim/lib/credential-groups/slack-managed-users.tshttps://github.com/simstudioai/sim/pull/9109/files#diff-220df4c221b1a1e3a42f13c2c088342c19411d0bc11d1fdac52285f4aca87bdc
View file https://github.com/simstudioai/sim/blob/5d5f4a0efb97447d0db5e27c8143013f1539b3a7/apps/sim/lib/credential-groups/slack-managed-users.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9109/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9109/files#diff-220df4c221b1a1e3a42f13c2c088342c19411d0bc11d1fdac52285f4aca87bdc
https://github.com/simstudioai/sim/pull/9109/files#diff-220df4c221b1a1e3a42f13c2c088342c19411d0bc11d1fdac52285f4aca87bdc
apps/sim/lib/knowledge/application/slack-search/installations.tshttps://github.com/simstudioai/sim/pull/9109/files#diff-ba1cf3350011fe297d4c9faeb46d268af15a9f8da2a1d341adc90bf158a6006f
View file https://github.com/simstudioai/sim/blob/5d5f4a0efb97447d0db5e27c8143013f1539b3a7/apps/sim/lib/knowledge/application/slack-search/installations.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9109/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9109/files#diff-ba1cf3350011fe297d4c9faeb46d268af15a9f8da2a1d341adc90bf158a6006f
https://github.com/simstudioai/sim/pull/9109/files#diff-ba1cf3350011fe297d4c9faeb46d268af15a9f8da2a1d341adc90bf158a6006f
https://github.com/simstudioai/sim/pull/9109/files#diff-ba1cf3350011fe297d4c9faeb46d268af15a9f8da2a1d341adc90bf158a6006f
https://github.com/simstudioai/sim/pull/9109/files#diff-ba1cf3350011fe297d4c9faeb46d268af15a9f8da2a1d341adc90bf158a6006f
https://github.com/simstudioai/sim/pull/9109/files#diff-ba1cf3350011fe297d4c9faeb46d268af15a9f8da2a1d341adc90bf158a6006f
https://github.com/simstudioai/sim/pull/9109/files#diff-ba1cf3350011fe297d4c9faeb46d268af15a9f8da2a1d341adc90bf158a6006f
apps/sim/lib/knowledge/application/slack-search/setup.test.tshttps://github.com/simstudioai/sim/pull/9109/files#diff-4e4fdbbbf6001354e8ea78d39db754c8e96ca17bc6f39a26c47eb3050e07c3d3
View file https://github.com/simstudioai/sim/blob/5d5f4a0efb97447d0db5e27c8143013f1539b3a7/apps/sim/lib/knowledge/application/slack-search/setup.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9109/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9109/files#diff-4e4fdbbbf6001354e8ea78d39db754c8e96ca17bc6f39a26c47eb3050e07c3d3
https://github.com/simstudioai/sim/pull/9109/files#diff-4e4fdbbbf6001354e8ea78d39db754c8e96ca17bc6f39a26c47eb3050e07c3d3
https://github.com/simstudioai/sim/pull/9109/files#diff-4e4fdbbbf6001354e8ea78d39db754c8e96ca17bc6f39a26c47eb3050e07c3d3
https://github.com/simstudioai/sim/pull/9109/files#diff-4e4fdbbbf6001354e8ea78d39db754c8e96ca17bc6f39a26c47eb3050e07c3d3
https://github.com/simstudioai/sim/pull/9109/files#diff-4e4fdbbbf6001354e8ea78d39db754c8e96ca17bc6f39a26c47eb3050e07c3d3
https://github.com/simstudioai/sim/pull/9109/files#diff-4e4fdbbbf6001354e8ea78d39db754c8e96ca17bc6f39a26c47eb3050e07c3d3
https://github.com/simstudioai/sim/pull/9109/files#diff-4e4fdbbbf6001354e8ea78d39db754c8e96ca17bc6f39a26c47eb3050e07c3d3
https://github.com/simstudioai/sim/pull/9109/files#diff-4e4fdbbbf6001354e8ea78d39db754c8e96ca17bc6f39a26c47eb3050e07c3d3
https://github.com/simstudioai/sim/pull/9109/files#diff-4e4fdbbbf6001354e8ea78d39db754c8e96ca17bc6f39a26c47eb3050e07c3d3
apps/sim/lib/knowledge/application/slack-search/setup.tshttps://github.com/simstudioai/sim/pull/9109/files#diff-30e93de6d789ea1679b1db7ad8da22b29adec2a20b36bac532da764bfb4e4cb7
View file https://github.com/simstudioai/sim/blob/5d5f4a0efb97447d0db5e27c8143013f1539b3a7/apps/sim/lib/knowledge/application/slack-search/setup.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9109/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9109/files#diff-30e93de6d789ea1679b1db7ad8da22b29adec2a20b36bac532da764bfb4e4cb7
https://github.com/simstudioai/sim/pull/9109/files#diff-30e93de6d789ea1679b1db7ad8da22b29adec2a20b36bac532da764bfb4e4cb7
https://github.com/simstudioai/sim/pull/9109/files#diff-30e93de6d789ea1679b1db7ad8da22b29adec2a20b36bac532da764bfb4e4cb7
https://github.com/simstudioai/sim/pull/9109/files#diff-30e93de6d789ea1679b1db7ad8da22b29adec2a20b36bac532da764bfb4e4cb7
https://github.com/simstudioai/sim/pull/9109/files#diff-30e93de6d789ea1679b1db7ad8da22b29adec2a20b36bac532da764bfb4e4cb7
https://github.com/simstudioai/sim/pull/9109/files#diff-30e93de6d789ea1679b1db7ad8da22b29adec2a20b36bac532da764bfb4e4cb7
https://github.com/simstudioai/sim/pull/9109/files#diff-30e93de6d789ea1679b1db7ad8da22b29adec2a20b36bac532da764bfb4e4cb7
https://github.com/simstudioai/sim/pull/9109/files#diff-30e93de6d789ea1679b1db7ad8da22b29adec2a20b36bac532da764bfb4e4cb7
https://github.com/simstudioai/sim/pull/9109/files#diff-30e93de6d789ea1679b1db7ad8da22b29adec2a20b36bac532da764bfb4e4cb7
Please reload this pagehttps://github.com/simstudioai/sim/pull/9109/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9109/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.