René's URL Explorer Experiment


Title: fix(mothership): hold desktop leases, the resume wait and first claims to the call deadline by waleedlatif1 · Pull Request #9103 · simstudioai/sim · GitHub

Open Graph Title: fix(mothership): hold desktop leases, the resume wait and first claims to the call deadline by waleedlatif1 · Pull Request #9103 · simstudioai/sim

X Title: fix(mothership): hold desktop leases, the resume wait and first claims to the call deadline by waleedlatif1 · Pull Request #9103 · simstudioai/sim

Description: Summary Resume wait: a pending call's first watchdog deadline is capped at its ceiling, so a call whose worker deadline already passed is failed at deadline + grace instead of a full grace from now Executor: once the recorded deadline is adopted, a call whose start window has closed and that nothing has claimed is settled as "did not run" without taking a claim. A crash between claim and the handler's own refusal can no longer recover it as an unknown outcome. A call that is already claimed (takeover) keeps its existing claim path. The claim predicate itself is unchanged: making the claim refuse would return existing and wait on an owner that does not exist Desktop lease renewal (bound device and chat view) is refused once a call is past its deadline plus the resume grace, the point where the resume wait has already given up on it. The lease then lapses and the existing lapse cleanup settles the call as outcome unknown Rows without a deadline (older workers) behave exactly as before Type of Change Bug fix Testing run.test.ts: an already-passed deadline fails at deadline + grace (fails before); a call without a deadline keeps its full budget executor.test.ts: an unclaimed call past its start window is never claimed and records the not-started message (fails before); a claimed one keeps its claim; a call without a deadline is claimed without a settle attempt executor.integration.ts (real Postgres/Redis): renewal inside the grace succeeds; past it, renewal is refused (fails before), and after the lease lapses the cleanup settles the call as outcome unknown; a row without a deadline renews as before bound-turn.integration.ts, handlers and permission suites pass unchanged Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Resume wait: a pending call's first watchdog deadline is capped at its ceiling, so a call whose worker deadline already passed is failed at deadline + grace instead of a full grace fro...

X Description: Summary Resume wait: a pending call's first watchdog deadline is capped at its ceiling, so a call whose worker deadline already passed is failed at deadline + grace instead of a full grace...

Opengraph URL: https://github.com/simstudioai/sim/pull/9103

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:666ca4c1-9f5c-6129-67b5-752ec5247a80
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBE12:15DF38:92B3A4:C8667C:6AFB49BB
html-safe-nonce4b96af4e3c969dae2da723a504682292694a7b1625f44aa98f247ef9e14837d8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTEyOjE1REYzODo5MkIzQTQ6Qzg2NjdDOjZBRkI0OUJCIiwidmlzaXRvcl9pZCI6IjE1NjYzNjU5NDE3NjE3ODgzNDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0259c200d89a6292d126e4632efe59156aa6280bcb669af598cd33b315296353
hovercard-subject-tagpull_request:4882682336
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9103/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Resume wait: a pending call's first watchdog deadline is capped at its ceiling, so a call whose worker deadline already passed is failed at deadline + grace instead of a full grace fro...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9103/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9103%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9103%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9103/files
Reloadhttps://github.com/simstudioai/sim/pull/9103/files
Reloadhttps://github.com/simstudioai/sim/pull/9103/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/tool-deadline-ceilingshttps://github.com/simstudioai/sim/tree/fix/tool-deadline-ceilings
Conversation 11 https://github.com/simstudioai/sim/pull/9103
Commits 3 https://github.com/simstudioai/sim/pull/9103/commits
Checks 55 https://github.com/simstudioai/sim/pull/9103/checks
Files changed https://github.com/simstudioai/sim/pull/9103/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9103/files
fix(mothership): hold desktop leases, the resume wait and first claims to the call deadline https://github.com/simstudioai/sim/pull/9103/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/9103/files
98fb34c fix(mothership): hold desktop leases, the resume wait and first claim… waleedlatif1 Oct 16, 2026 https://github.com/simstudioai/sim/pull/9103/commits/98fb34c387c245d5903d27b1968b6111f753db2c
5457cfa fix(mothership): type the integration test's row update waleedlatif1 Oct 16, 2026 https://github.com/simstudioai/sim/pull/9103/commits/5457cfa328f1a4942b1026d39d14faf918e01820
50e66ae fix(mothership): settle a too-late call as never run only under open … waleedlatif1 Oct 16, 2026 https://github.com/simstudioai/sim/pull/9103/commits/50e66ae78d0c60e0db7ff8bbb2ec52a9936cca79
Clear filters https://github.com/simstudioai/sim/pull/9103/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9103/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9103/files
executor.integration.ts https://github.com/simstudioai/sim/pull/9103/files#diff-69db906678846abeabee1614a546e7480b3371c924212e19951d981ecbd30dc3
orphaned-runs.integration.ts https://github.com/simstudioai/sim/pull/9103/files#diff-ec44c1c6e5915437ecd7e01af1911844cdd02ebc730abd5c8c8fb34498fdbb07
repository.ts https://github.com/simstudioai/sim/pull/9103/files#diff-bdd330821217c2b7b7e64b969c999f2d2d57e7cb2f0cd376efcdc1bea63f95fa
run.test.ts https://github.com/simstudioai/sim/pull/9103/files#diff-0391696e45945f80cdf49dc490d5bed440504197fb63965c30be6871e2eed616
run.ts https://github.com/simstudioai/sim/pull/9103/files#diff-42286b1c13539c62ff83806b87ad5eb1669e4ce1e893862f952cf81cdc440573
execution-lifetime.ts https://github.com/simstudioai/sim/pull/9103/files#diff-ed90dcf84d93706d132cb16610fd33cc54f8e8b775cfca5e58bb67c69c1bf64e
executor.test.ts https://github.com/simstudioai/sim/pull/9103/files#diff-5c0149489977e70711d949724f46e8bcd43162b7fbd3928da59a33aa935af5e7
executor.ts https://github.com/simstudioai/sim/pull/9103/files#diff-42b57bff4502cb04d3c049cc5137e7208b20a861400af267c0f15f773633f6ab
apps/sim/lib/desktop/application/executor.integration.tshttps://github.com/simstudioai/sim/pull/9103/files#diff-69db906678846abeabee1614a546e7480b3371c924212e19951d981ecbd30dc3
View file https://github.com/simstudioai/sim/blob/50e66ae78d0c60e0db7ff8bbb2ec52a9936cca79/apps/sim/lib/desktop/application/executor.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9103/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9103/files#diff-69db906678846abeabee1614a546e7480b3371c924212e19951d981ecbd30dc3
https://github.com/simstudioai/sim/pull/9103/files#diff-69db906678846abeabee1614a546e7480b3371c924212e19951d981ecbd30dc3
https://github.com/simstudioai/sim/pull/9103/files#diff-69db906678846abeabee1614a546e7480b3371c924212e19951d981ecbd30dc3
https://github.com/simstudioai/sim/pull/9103/files#diff-69db906678846abeabee1614a546e7480b3371c924212e19951d981ecbd30dc3
https://github.com/simstudioai/sim/pull/9103/files#diff-69db906678846abeabee1614a546e7480b3371c924212e19951d981ecbd30dc3
https://github.com/simstudioai/sim/pull/9103/files#diff-69db906678846abeabee1614a546e7480b3371c924212e19951d981ecbd30dc3
https://github.com/simstudioai/sim/pull/9103/files#diff-69db906678846abeabee1614a546e7480b3371c924212e19951d981ecbd30dc3
apps/sim/lib/mothership/async-runs/orphaned-runs.integration.tshttps://github.com/simstudioai/sim/pull/9103/files#diff-ec44c1c6e5915437ecd7e01af1911844cdd02ebc730abd5c8c8fb34498fdbb07
View file https://github.com/simstudioai/sim/blob/50e66ae78d0c60e0db7ff8bbb2ec52a9936cca79/apps/sim/lib/mothership/async-runs/orphaned-runs.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9103/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9103/files#diff-ec44c1c6e5915437ecd7e01af1911844cdd02ebc730abd5c8c8fb34498fdbb07
https://github.com/simstudioai/sim/pull/9103/files#diff-ec44c1c6e5915437ecd7e01af1911844cdd02ebc730abd5c8c8fb34498fdbb07
apps/sim/lib/mothership/async-runs/repository.tshttps://github.com/simstudioai/sim/pull/9103/files#diff-bdd330821217c2b7b7e64b969c999f2d2d57e7cb2f0cd376efcdc1bea63f95fa
View file https://github.com/simstudioai/sim/blob/50e66ae78d0c60e0db7ff8bbb2ec52a9936cca79/apps/sim/lib/mothership/async-runs/repository.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9103/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9103/files#diff-bdd330821217c2b7b7e64b969c999f2d2d57e7cb2f0cd376efcdc1bea63f95fa
https://github.com/simstudioai/sim/pull/9103/files#diff-bdd330821217c2b7b7e64b969c999f2d2d57e7cb2f0cd376efcdc1bea63f95fa
https://github.com/simstudioai/sim/pull/9103/files#diff-bdd330821217c2b7b7e64b969c999f2d2d57e7cb2f0cd376efcdc1bea63f95fa
https://github.com/simstudioai/sim/pull/9103/files#diff-bdd330821217c2b7b7e64b969c999f2d2d57e7cb2f0cd376efcdc1bea63f95fa
https://github.com/simstudioai/sim/pull/9103/files#diff-bdd330821217c2b7b7e64b969c999f2d2d57e7cb2f0cd376efcdc1bea63f95fa
https://github.com/simstudioai/sim/pull/9103/files#diff-bdd330821217c2b7b7e64b969c999f2d2d57e7cb2f0cd376efcdc1bea63f95fa
https://github.com/simstudioai/sim/pull/9103/files#diff-bdd330821217c2b7b7e64b969c999f2d2d57e7cb2f0cd376efcdc1bea63f95fa
https://github.com/simstudioai/sim/pull/9103/files#diff-bdd330821217c2b7b7e64b969c999f2d2d57e7cb2f0cd376efcdc1bea63f95fa
https://github.com/simstudioai/sim/pull/9103/files#diff-bdd330821217c2b7b7e64b969c999f2d2d57e7cb2f0cd376efcdc1bea63f95fa
https://github.com/simstudioai/sim/pull/9103/files#diff-bdd330821217c2b7b7e64b969c999f2d2d57e7cb2f0cd376efcdc1bea63f95fa
https://github.com/simstudioai/sim/pull/9103/files#diff-bdd330821217c2b7b7e64b969c999f2d2d57e7cb2f0cd376efcdc1bea63f95fa
https://github.com/simstudioai/sim/pull/9103/files#diff-bdd330821217c2b7b7e64b969c999f2d2d57e7cb2f0cd376efcdc1bea63f95fa
https://github.com/simstudioai/sim/pull/9103/files#diff-bdd330821217c2b7b7e64b969c999f2d2d57e7cb2f0cd376efcdc1bea63f95fa
apps/sim/lib/mothership/request/lifecycle/run.test.tshttps://github.com/simstudioai/sim/pull/9103/files#diff-0391696e45945f80cdf49dc490d5bed440504197fb63965c30be6871e2eed616
View file https://github.com/simstudioai/sim/blob/50e66ae78d0c60e0db7ff8bbb2ec52a9936cca79/apps/sim/lib/mothership/request/lifecycle/run.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9103/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9103/files#diff-0391696e45945f80cdf49dc490d5bed440504197fb63965c30be6871e2eed616
https://github.com/simstudioai/sim/pull/9103/files#diff-0391696e45945f80cdf49dc490d5bed440504197fb63965c30be6871e2eed616
apps/sim/lib/mothership/request/lifecycle/run.tshttps://github.com/simstudioai/sim/pull/9103/files#diff-42286b1c13539c62ff83806b87ad5eb1669e4ce1e893862f952cf81cdc440573
View file https://github.com/simstudioai/sim/blob/50e66ae78d0c60e0db7ff8bbb2ec52a9936cca79/apps/sim/lib/mothership/request/lifecycle/run.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9103/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9103/files#diff-42286b1c13539c62ff83806b87ad5eb1669e4ce1e893862f952cf81cdc440573
https://github.com/simstudioai/sim/pull/9103/files#diff-42286b1c13539c62ff83806b87ad5eb1669e4ce1e893862f952cf81cdc440573
apps/sim/lib/mothership/request/tools/execution-lifetime.tshttps://github.com/simstudioai/sim/pull/9103/files#diff-ed90dcf84d93706d132cb16610fd33cc54f8e8b775cfca5e58bb67c69c1bf64e
View file https://github.com/simstudioai/sim/blob/50e66ae78d0c60e0db7ff8bbb2ec52a9936cca79/apps/sim/lib/mothership/request/tools/execution-lifetime.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9103/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9103/files#diff-ed90dcf84d93706d132cb16610fd33cc54f8e8b775cfca5e58bb67c69c1bf64e
https://github.com/simstudioai/sim/pull/9103/files#diff-ed90dcf84d93706d132cb16610fd33cc54f8e8b775cfca5e58bb67c69c1bf64e
https://github.com/simstudioai/sim/pull/9103/files#diff-ed90dcf84d93706d132cb16610fd33cc54f8e8b775cfca5e58bb67c69c1bf64e
apps/sim/lib/mothership/request/tools/executor.test.tshttps://github.com/simstudioai/sim/pull/9103/files#diff-5c0149489977e70711d949724f46e8bcd43162b7fbd3928da59a33aa935af5e7
View file https://github.com/simstudioai/sim/blob/50e66ae78d0c60e0db7ff8bbb2ec52a9936cca79/apps/sim/lib/mothership/request/tools/executor.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9103/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9103/files#diff-5c0149489977e70711d949724f46e8bcd43162b7fbd3928da59a33aa935af5e7
https://github.com/simstudioai/sim/pull/9103/files#diff-5c0149489977e70711d949724f46e8bcd43162b7fbd3928da59a33aa935af5e7
https://github.com/simstudioai/sim/pull/9103/files#diff-5c0149489977e70711d949724f46e8bcd43162b7fbd3928da59a33aa935af5e7
https://github.com/simstudioai/sim/pull/9103/files#diff-5c0149489977e70711d949724f46e8bcd43162b7fbd3928da59a33aa935af5e7
Please reload this pagehttps://github.com/simstudioai/sim/pull/9103/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9103/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.