René's URL Explorer Experiment


Title: fix(file-doc): stop the permission resend loop and restore the 10 MB proxy body limit by waleedlatif1 · Pull Request #9057 · simstudioai/sim · GitHub

Open Graph Title: fix(file-doc): stop the permission resend loop and restore the 10 MB proxy body limit by waleedlatif1 · Pull Request #9057 · simstudioai/sim

X Title: fix(file-doc): stop the permission resend loop and restore the 10 MB proxy body limit by waleedlatif1 · Pull Request #9057 · simstudioai/sim

Description: Summary Changes only flag-gated Project file paths (behind the projects flag). Project file reads and writes that do not charge storage hold the Project lock shared; storage-charging operations (create, update_content, upload_complete, versions.revert, extract_archive) declare chargesStorage and take it exclusively up front, so a shared hold is never upgraded. Lifecycle, payer transfer, retention, and account deletion stay exclusive and still exclude every file operation. The Project file authorizer holds the organization's permission-group lock shared (acquirePermissionGroupOrgReadLock): group writes, workspace creation, and OAuth refresh still wait for it and the capability decision stays current through commit, but file operations no longer serialize on it. The 5s lock_timeout now bounds only the acquisition and the caller's setting is restored. Project storage accounting locks the payer row last and only for a non-zero delta (the global order: Project → owner row → directory → files → payer); the Project row lock taken at prepare keeps the payer identity fixed. Zero-delta writes read usage unlocked. readProjectFileContent and version content reads drop an unused preflight transaction (prepareFromSnapshot); their snapshot use case authorizes, and the final transaction still revalidates after the storage read. Collaborative-document seed/persist retry only on moved revisions (ProjectFileRevisionConflictError) or cached-history conflicts; Project lock timeouts and lifecycle conflicts surface immediately instead of being retried and reported as a document conflict. Persist reads at most the largest editable file size. Archive/restore find files with cached document state in one query instead of locking and decoding every file, and post-commit retirements run at most 8 at a time. Project file id/root-name reference lookups no longer load the whole folder tree. Removes the blanket knip ignores over the Project file contracts: unused aliases are deleted or un-exported; the four files still holding exports consumed only by stacked PRs keep a per-file ignore naming them. Expected conflicts for the stacked Project file PRs: knip.jsonc (#9018 adds entries; its new project-file*.ts contract files lose the glob ignore), projects/files/application/authorization.ts (#9018 exports helpers), billing/storage/tracking.ts and projects/membership.ts (#9034). Type of Change Bug fix Testing New integration checks in projects/files/__integration__/authorization.integration.ts: concurrent reads and a folder create proceed while a read holds the Project, lock_timeout is restored, and exclusive Project and permission-group holders still wait; a storage-charging write still excludes shared holders New projects/files/application/documents.test.ts: lock conflicts are surfaced, revision conflicts still retry (verified red on the old predicate) biome on changed files; type-check, audits, and integration suites run in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Changes only flag-gated Project file paths (behind the projects flag). Project file reads and writes that do not charge storage hold the Project lock shared; storage-charging operations (c...

X Description: Summary Changes only flag-gated Project file paths (behind the projects flag). Project file reads and writes that do not charge storage hold the Project lock shared; storage-charging operations (c...

Opengraph URL: https://github.com/simstudioai/sim/pull/9057

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:190b08a6-8aa0-8d07-b416-65057a76e57c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE9DA:3C556:B19DB2:F45DCD:6AFB5211
html-safe-nonce4539cb3bd326186b6779782d26875e1530f80d5da1a2f4c04df398938352ff08
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOURBOjNDNTU2OkIxOURCMjpGNDVEQ0Q6NkFGQjUyMTEiLCJ2aXNpdG9yX2lkIjoiMzEyMDc0NjExNDA2NDI3MzkzNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaceb4c2b062dde576a48307f2eede28fca5e5e6975c836e55730a9dba64c10e134
hovercard-subject-tagpull_request:4866135651
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9057/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Changes only flag-gated Project file paths (behind the projects flag). Project file reads and writes that do not charge storage hold the Project lock shared; storage-charging operations (c...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9057/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9057%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9057%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9057/files
Reloadhttps://github.com/simstudioai/sim/pull/9057/files
Reloadhttps://github.com/simstudioai/sim/pull/9057/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/live-doc-permission-loop-and-proxy-limithttps://github.com/simstudioai/sim/tree/fix/live-doc-permission-loop-and-proxy-limit
Conversation 12 https://github.com/simstudioai/sim/pull/9057
Commits 3 https://github.com/simstudioai/sim/pull/9057/commits
Checks 52 https://github.com/simstudioai/sim/pull/9057/checks
Files changed https://github.com/simstudioai/sim/pull/9057/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9057/files
fix(file-doc): stop the permission resend loop and restore the 10 MB proxy body limit https://github.com/simstudioai/sim/pull/9057/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/9057/files
0df7b5c fix(file-doc): stop the permission resend loop and restore the 10 MB … waleedlatif1 Oct 14, 2026 https://github.com/simstudioai/sim/pull/9057/commits/0df7b5cfa489ca5e41038fa407cc570bc468bdf5
72dee6c fix(file-doc): admit joins on their validated permission and route sw… waleedlatif1 Oct 15, 2026 https://github.com/simstudioai/sim/pull/9057/commits/72dee6cf24d369a34aa0ec07ad4acbe6a7cb793e
1eb5758 fix(file-doc): reschedule an unattributed persist and pin admission a… waleedlatif1 Oct 15, 2026 https://github.com/simstudioai/sim/pull/9057/commits/1eb5758ecccc82f60692e3311496676f1dfe49f1
Clear filters https://github.com/simstudioai/sim/pull/9057/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9057/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9057/files
access-revalidation.test.ts https://github.com/simstudioai/sim/pull/9057/files#diff-d68660f5845944c67a91771806fe917d9c0c183cd7833e1ea4b5e00fc82c0c28
access-revalidation.ts https://github.com/simstudioai/sim/pull/9057/files#diff-09c3a2d548ed8aaa678551a5ed8b14ecc1ac86a06b3e3da5bb001d8d43de1cba
file-doc.redis-store.test.ts https://github.com/simstudioai/sim/pull/9057/files#diff-ba134050477e72d1cf40f0f7c5d79aa48495f449bb1d4bb6bef75096ecbe1632
file-doc.test.ts https://github.com/simstudioai/sim/pull/9057/files#diff-e5340b7461b8def251df0b8bcc90796d84ac1296310a7be1230cd374551aae77
file-doc.ts https://github.com/simstudioai/sim/pull/9057/files#diff-d3588b9954ee6e449255c053a6b579f4f687e6afa4ed18f60ab53077ad8411c8
room-permission.ts https://github.com/simstudioai/sim/pull/9057/files#diff-6349e69eb01d1975783a988d6dc12309c3c507ada0bdff8a89fca081c8b28a21
route.ts https://github.com/simstudioai/sim/pull/9057/files#diff-1c6ccbadb935b36e3bf252453c76a31b0aca4f00cc41f5a1b1a812d55c064a16
route.test.ts https://github.com/simstudioai/sim/pull/9057/files#diff-b4052196c356f11a02557754378b84a52b53866d0de6b8ac4491c39c5abbb353
route.ts https://github.com/simstudioai/sim/pull/9057/files#diff-d7a59921045705b9e3c2edeaddfbf7324da89998685abf7064df2c9ed9d57cc7
route.ts https://github.com/simstudioai/sim/pull/9057/files#diff-1f23be4d193fc5a868184204ccd1fbfc78e2742838d07168305af133559af646
route.ts https://github.com/simstudioai/sim/pull/9057/files#diff-fc697233449509ce13882aab3d809b3a58e1a6b83c097b1152143084ec1ca2eb
utils.test.ts https://github.com/simstudioai/sim/pull/9057/files#diff-2a5b06a4045f2c3ce64b84cfa09326ee2c1832b1a52f873fb2337639697c5d29
utils.ts https://github.com/simstudioai/sim/pull/9057/files#diff-d7177d55c049dceced2d942257670d1591863a9bb7e031b5096cd086deb96388
route.test.ts https://github.com/simstudioai/sim/pull/9057/files#diff-d34e0c324bef86c75fca5c182bbdf596fc2cd8ffdd5bad7b92f67b99f57c4d54
file-doc-provider.test.ts https://github.com/simstudioai/sim/pull/9057/files#diff-86ca687225a7128b114120aeef6e5609bd452da7c03292cf199518373ace515d
file-doc-provider.ts https://github.com/simstudioai/sim/pull/9057/files#diff-598531064700e61a529706f022aa7de5653fea72bca2dfd7a0ca6ab621a666b2
editor-lifecycle.test.tsx https://github.com/simstudioai/sim/pull/9057/files#diff-a9ba25870233b28700778055ce71565387b31603b1b48067c65789edeee77c0b
rich-markdown-editor.tsx https://github.com/simstudioai/sim/pull/9057/files#diff-6ddf250be25a5febc97c8c4a2e0f9e93b869e674efbb9bd43358137571ddc05a
v2-operations.ts https://github.com/simstudioai/sim/pull/9057/files#diff-a32a173b553c777ebd3d9ecabb9cbc5fe7705ac6fa3761dbceaeb5458fc449b7
internal-json-route.ts https://github.com/simstudioai/sim/pull/9057/files#diff-97b2f3cc3f5b8e62f536c627f6b57d8e215978dd86069d159dfe2f1e98c88da8
validation.test.ts https://github.com/simstudioai/sim/pull/9057/files#diff-f9f139883d4ceba3549bb164975e6bfb9c1ebd01785c96895ecb2860df36c2d1
validation.ts https://github.com/simstudioai/sim/pull/9057/files#diff-e9a15c0809d7eaa72c234d21e34c25352aa33ead99590c1f3ea04c62d0438d26
request-limits.ts https://github.com/simstudioai/sim/pull/9057/files#diff-14ce4acd87aa4cb1b124b6a602496703c0f61c7c5caa85a1d7e97e1125693d12
delivery.ts https://github.com/simstudioai/sim/pull/9057/files#diff-1a70f50558db85a00d2709cdfa887369fd7fa6100efd797eb77b93395e72a65b
next.config.ts https://github.com/simstudioai/sim/pull/9057/files#diff-a2e0d564b8bf660a492f7abe431643db390b0f5696809465afc46475f552f15f
proxy.test.ts https://github.com/simstudioai/sim/pull/9057/files#diff-85921dbeaec3aa778a756f3c9366a482c82f303630a95dd650ab91c5f446b8e3
proxy.ts https://github.com/simstudioai/sim/pull/9057/files#diff-15ec1afb2cdc5fde188dc70ae860a2f0ec3970fab290ca04263b685b5dd2cff3
program.ts https://github.com/simstudioai/sim/pull/9057/files#diff-735d8e38e3c32275671a16f3e199dcc5bff06e2d2e117c13564a5efcc14ffd25
generate-cli-docs.ts https://github.com/simstudioai/sim/pull/9057/files#diff-0aa378f7eeb9307d7d984a3774e4e932e57f7d7e0d685c03012706e7654b9515
generate-v2-mcp-operations.ts https://github.com/simstudioai/sim/pull/9057/files#diff-1890c930ef1fb9dd8bd14dcc3a1ce18ed212bcb7d4ef0e7af98de13b67a5a9cd
apps/realtime/src/access-revalidation.test.tshttps://github.com/simstudioai/sim/pull/9057/files#diff-d68660f5845944c67a91771806fe917d9c0c183cd7833e1ea4b5e00fc82c0c28
View file https://github.com/simstudioai/sim/blob/1eb5758ecccc82f60692e3311496676f1dfe49f1/apps/realtime/src/access-revalidation.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9057/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9057/files#diff-d68660f5845944c67a91771806fe917d9c0c183cd7833e1ea4b5e00fc82c0c28
https://github.com/simstudioai/sim/pull/9057/files#diff-d68660f5845944c67a91771806fe917d9c0c183cd7833e1ea4b5e00fc82c0c28
https://github.com/simstudioai/sim/pull/9057/files#diff-d68660f5845944c67a91771806fe917d9c0c183cd7833e1ea4b5e00fc82c0c28
https://github.com/simstudioai/sim/pull/9057/files#diff-d68660f5845944c67a91771806fe917d9c0c183cd7833e1ea4b5e00fc82c0c28
https://github.com/simstudioai/sim/pull/9057/files#diff-d68660f5845944c67a91771806fe917d9c0c183cd7833e1ea4b5e00fc82c0c28
apps/realtime/src/access-revalidation.tshttps://github.com/simstudioai/sim/pull/9057/files#diff-09c3a2d548ed8aaa678551a5ed8b14ecc1ac86a06b3e3da5bb001d8d43de1cba
View file https://github.com/simstudioai/sim/blob/1eb5758ecccc82f60692e3311496676f1dfe49f1/apps/realtime/src/access-revalidation.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9057/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9057/files#diff-09c3a2d548ed8aaa678551a5ed8b14ecc1ac86a06b3e3da5bb001d8d43de1cba
https://github.com/simstudioai/sim/pull/9057/files#diff-09c3a2d548ed8aaa678551a5ed8b14ecc1ac86a06b3e3da5bb001d8d43de1cba
https://github.com/simstudioai/sim/pull/9057/files#diff-09c3a2d548ed8aaa678551a5ed8b14ecc1ac86a06b3e3da5bb001d8d43de1cba
https://github.com/simstudioai/sim/pull/9057/files#diff-09c3a2d548ed8aaa678551a5ed8b14ecc1ac86a06b3e3da5bb001d8d43de1cba
apps/realtime/src/handlers/file-doc.redis-store.test.tshttps://github.com/simstudioai/sim/pull/9057/files#diff-ba134050477e72d1cf40f0f7c5d79aa48495f449bb1d4bb6bef75096ecbe1632
View file https://github.com/simstudioai/sim/blob/1eb5758ecccc82f60692e3311496676f1dfe49f1/apps/realtime/src/handlers/file-doc.redis-store.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9057/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9057/files#diff-ba134050477e72d1cf40f0f7c5d79aa48495f449bb1d4bb6bef75096ecbe1632
https://github.com/simstudioai/sim/pull/9057/files#diff-ba134050477e72d1cf40f0f7c5d79aa48495f449bb1d4bb6bef75096ecbe1632
https://github.com/simstudioai/sim/pull/9057/files#diff-ba134050477e72d1cf40f0f7c5d79aa48495f449bb1d4bb6bef75096ecbe1632
https://github.com/simstudioai/sim/pull/9057/files#diff-ba134050477e72d1cf40f0f7c5d79aa48495f449bb1d4bb6bef75096ecbe1632
https://github.com/simstudioai/sim/pull/9057/files#diff-ba134050477e72d1cf40f0f7c5d79aa48495f449bb1d4bb6bef75096ecbe1632
apps/realtime/src/handlers/file-doc.test.tshttps://github.com/simstudioai/sim/pull/9057/files#diff-e5340b7461b8def251df0b8bcc90796d84ac1296310a7be1230cd374551aae77
View file https://github.com/simstudioai/sim/blob/1eb5758ecccc82f60692e3311496676f1dfe49f1/apps/realtime/src/handlers/file-doc.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9057/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9057/files#diff-e5340b7461b8def251df0b8bcc90796d84ac1296310a7be1230cd374551aae77
https://github.com/simstudioai/sim/pull/9057/files#diff-e5340b7461b8def251df0b8bcc90796d84ac1296310a7be1230cd374551aae77
https://github.com/simstudioai/sim/pull/9057/files#diff-e5340b7461b8def251df0b8bcc90796d84ac1296310a7be1230cd374551aae77
https://github.com/simstudioai/sim/pull/9057/files#diff-e5340b7461b8def251df0b8bcc90796d84ac1296310a7be1230cd374551aae77
Please reload this pagehttps://github.com/simstudioai/sim/pull/9057/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9057/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.