René's URL Explorer Experiment


Title: fix(folders): run reorder lock checks on the reorder transaction by waleedlatif1 · Pull Request #9055 · simstudioai/sim · GitHub

Open Graph Title: fix(folders): run reorder lock checks on the reorder transaction by waleedlatif1 · Pull Request #9055 · simstudioai/sim

X Title: fix(folders): run reorder lock checks on the reorder transaction by waleedlatif1 · Pull Request #9055 · simstudioai/sim

Description: Summary PUT /api/folders/reorder ran assertFolderMutable inside its withTransactionRetry callback, but the lock walk queried the global pool. Each check took a second connection while the transaction held one, which can deadlock the pool at saturation (the @sim/db transaction tripwire flags exactly this) assertFolderMutable now accepts an optional executor (the same Pick = db shape resolveEffectiveWorkspacePermission uses). The reorder route passes its tx, so the ancestry walk reads on the held connection The checks stay inside the transaction instead of being hoisted out, so they still run under the per-workspace folder-tree advisory lock that updateFolder (lock toggles) also takes No other caller of assertFolderMutable / assertWorkflowMutable runs inside a transaction. They all check before opening one, and the default executor leaves them unchanged Why tests missed it: the route's unit test mocks @sim/db globally, so the real pool instrumentation never ran. The new integration test runs the route against real Postgres with the tripwire in throw mode. All 3 cases fail with 500 before the fix and pass after Type of Change Bug fix Testing New app/api/folders/reorder/route.integration.ts covers three cases against real Postgres (tripwire throw): reparent + reorder of unlocked folders, a folder that inherits its ancestor's lock (423), and a locked destination (423). I confirmed it fails on the pre-fix code and passes with the fix. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary PUT /api/folders/reorder ran assertFolderMutable inside its withTransactionRetry callback, but the lock walk queried the global pool. Each check took a second connection while the transact...

X Description: Summary PUT /api/folders/reorder ran assertFolderMutable inside its withTransactionRetry callback, but the lock walk queried the global pool. Each check took a second connection while the transact...

Opengraph URL: https://github.com/simstudioai/sim/pull/9055

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:604678f0-b934-c81e-aa4b-c5843c1cb531
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id96CE:C876F:B045D9:F34A3A:6AFB5349
html-safe-nonce9454eb4c1ae9cc7b25b57c776c9e9a3bf3eee5d9dfc11c30d051cf5f57f7381b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkNFOkM4NzZGOkIwNDVEOTpGMzRBM0E6NkFGQjUzNDkiLCJ2aXNpdG9yX2lkIjoiNDQ5MDM1OTkxNTczNDA2MTg5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbd1063ebe5fae281b31963b5159839fbb551b0fccd229f74d45298fc5d555976
hovercard-subject-tagpull_request:4865954442
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9055/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary PUT /api/folders/reorder ran assertFolderMutable inside its withTransactionRetry callback, but the lock walk queried the global pool. Each check took a second connection while the transact...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9055/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9055%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9055%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9055/files
Reloadhttps://github.com/simstudioai/sim/pull/9055/files
Reloadhttps://github.com/simstudioai/sim/pull/9055/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/folders-reorder-txhttps://github.com/simstudioai/sim/tree/fix/folders-reorder-tx
Conversation 2 https://github.com/simstudioai/sim/pull/9055
Commits 1 https://github.com/simstudioai/sim/pull/9055/commits
Checks 52 https://github.com/simstudioai/sim/pull/9055/checks
Files changed https://github.com/simstudioai/sim/pull/9055/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9055/files
fix(folders): run reorder lock checks on the reorder transaction https://github.com/simstudioai/sim/pull/9055/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/9055/files
c918c96 fix(folders): run reorder lock checks on the reorder transaction waleedlatif1 Oct 14, 2026 https://github.com/simstudioai/sim/pull/9055/commits/c918c96319485f4eb2a5f1eff2a0858ec5183ff3
Clear filters https://github.com/simstudioai/sim/pull/9055/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9055/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9055/files
route.integration.ts https://github.com/simstudioai/sim/pull/9055/files#diff-34687fb64f4ec2f3e79e9e99f3108bfe06ee12253beec7f17dbbdbd1f0307366
route.ts https://github.com/simstudioai/sim/pull/9055/files#diff-b21260328f16a6c01500a23b148a64b601fc9c8150991ba38b154e637a3310e6
workflow.ts https://github.com/simstudioai/sim/pull/9055/files#diff-13cad0c12e182f574a9f6cf227b5810fe3c4b58d506a77d6bf186edfe810e31a
apps/sim/app/api/folders/reorder/route.integration.tshttps://github.com/simstudioai/sim/pull/9055/files#diff-34687fb64f4ec2f3e79e9e99f3108bfe06ee12253beec7f17dbbdbd1f0307366
View file https://github.com/simstudioai/sim/blob/c918c96319485f4eb2a5f1eff2a0858ec5183ff3/apps/sim/app/api/folders/reorder/route.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9055/{{ revealButtonHref }}
apps/sim/app/api/folders/reorder/route.tshttps://github.com/simstudioai/sim/pull/9055/files#diff-b21260328f16a6c01500a23b148a64b601fc9c8150991ba38b154e637a3310e6
View file https://github.com/simstudioai/sim/blob/c918c96319485f4eb2a5f1eff2a0858ec5183ff3/apps/sim/app/api/folders/reorder/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9055/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9055/files#diff-b21260328f16a6c01500a23b148a64b601fc9c8150991ba38b154e637a3310e6
https://github.com/simstudioai/sim/pull/9055/files#diff-b21260328f16a6c01500a23b148a64b601fc9c8150991ba38b154e637a3310e6
packages/platform-authz/src/workflow.tshttps://github.com/simstudioai/sim/pull/9055/files#diff-13cad0c12e182f574a9f6cf227b5810fe3c4b58d506a77d6bf186edfe810e31a
View file https://github.com/simstudioai/sim/blob/c918c96319485f4eb2a5f1eff2a0858ec5183ff3/packages/platform-authz/src/workflow.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9055/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9055/files#diff-13cad0c12e182f574a9f6cf227b5810fe3c4b58d506a77d6bf186edfe810e31a
https://github.com/simstudioai/sim/pull/9055/files#diff-13cad0c12e182f574a9f6cf227b5810fe3c4b58d506a77d6bf186edfe810e31a
https://github.com/simstudioai/sim/pull/9055/files#diff-13cad0c12e182f574a9f6cf227b5810fe3c4b58d506a77d6bf186edfe810e31a
https://github.com/simstudioai/sim/pull/9055/files#diff-13cad0c12e182f574a9f6cf227b5810fe3c4b58d506a77d6bf186edfe810e31a
https://github.com/simstudioai/sim/pull/9055/files#diff-13cad0c12e182f574a9f6cf227b5810fe3c4b58d506a77d6bf186edfe810e31a
Please reload this pagehttps://github.com/simstudioai/sim/pull/9055/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.