René's URL Explorer Experiment


Title: fix(byok): preserve credential ownership on lookup failures by icecrasher321 · Pull Request #9054 · simstudioai/sim · GitHub

Open Graph Title: fix(byok): preserve credential ownership on lookup failures by icecrasher321 · Pull Request #9054 · simstudioai/sim

X Title: fix(byok): preserve credential ownership on lookup failures by icecrasher321 · Pull Request #9054 · simstudioai/sim

Description: Summary A failed BYOK database lookup could be treated as an absent key, allowing a request to run and be billed with a platform credential. The shared resolver now returns null only after successfully confirming that no eligible customer key applies. Lookup failures and unusable configured key pools stop execution. Transient database reads use the existing error classifier, jittered backoff, and deadline helpers: at most three attempts within five seconds, with caller cancellation propagated. Tool execution no longer swallows credential failures. Copilot's enterprise gate uses the billing layer's existing strict-read policy so an unavailable subscription lookup cannot bypass BYOK. Type of Change Bug fix Testing Seven real-Postgres regressions cover a terminated connection and recovery, exhausted retries, permanent query errors, corrupt ciphertext, confirmed absence, and organization/personal entitlement read failures. Reverting each safeguard makes its regression fail. Focused tests cover cancellation, late database results, and stopping tool dispatch and metering after credential failure. Workspace type checks, test-type ratchet, lint, all 60 audits, and the staging-sensitive block registry check pass. Full repository gate passes: 606 script tests, 37,711 app tests (7 skipped), and all 20 workspace tasks. Ran with bun run test --concurrency=2 -- --maxWorkers=4. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced

Open Graph Description: Summary A failed BYOK database lookup could be treated as an absent key, allowing a request to run and be billed with a platform credential. The shared resolver now returns null only after successf...

X Description: Summary A failed BYOK database lookup could be treated as an absent key, allowing a request to run and be billed with a platform credential. The shared resolver now returns null only after successf...

Opengraph URL: https://github.com/simstudioai/sim/pull/9054

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:aaec72ba-565d-7a45-f771-2e87f563ec7b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE9D2:B85F4:B7884E:FBA1ED:6AFB520F
html-safe-nonce68d22fcea3fc39d914c6a68b579c7ab96477db2805d182e0af3680023e0956b4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOUQyOkI4NUY0OkI3ODg0RTpGQkExRUQ6NkFGQjUyMEYiLCJ2aXNpdG9yX2lkIjoiNzkwNjgwMTk3OTcwNzQzODIzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9204add7ab7ca68d84068d7bf358f76341d66521b36a436d96faa7392a1e04b2
hovercard-subject-tagpull_request:4865934257
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9054/files
twitter:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
og:image:altSummary A failed BYOK database lookup could be treated as an absent key, allowing a request to run and be billed with a platform credential. The shared resolver now returns null only after successf...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9054/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9054%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9054%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9054/files
Reloadhttps://github.com/simstudioai/sim/pull/9054/files
Reloadhttps://github.com/simstudioai/sim/pull/9054/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
codex/byok-fail-closedhttps://github.com/simstudioai/sim/tree/codex/byok-fail-closed
Conversation 8 https://github.com/simstudioai/sim/pull/9054
Commits 2 https://github.com/simstudioai/sim/pull/9054/commits
Checks 53 https://github.com/simstudioai/sim/pull/9054/checks
Files changed https://github.com/simstudioai/sim/pull/9054/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9054/files
fix(byok): preserve credential ownership on lookup failures https://github.com/simstudioai/sim/pull/9054/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/9054/files
6e54013 fix(byok): preserve credential ownership on lookup failures Oct 14, 2026 https://github.com/simstudioai/sim/pull/9054/commits/6e54013e748dea71347173abf25d5e4290648c88
8dd6810 fix(byok): isolate enterprise entitlement test fixtures Oct 14, 2026 https://github.com/simstudioai/sim/pull/9054/commits/8dd68105af82befa23d77fa38ad236cbb7fe15bf
Clear filters https://github.com/simstudioai/sim/pull/9054/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9054/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9054/files
byok.integration.ts https://github.com/simstudioai/sim/pull/9054/files#diff-4ee4312a369485a2f217bcc467e5c4d8731bb5651368b62ae3016d5b57eb57ef
byok.test.ts https://github.com/simstudioai/sim/pull/9054/files#diff-f841c517cb545c304bef290f4a0f46843d8d6f9379ef43d69a8bb04605e4bb3e
byok.ts https://github.com/simstudioai/sim/pull/9054/files#diff-c005b3d5176372adb521b659913d6ef6fed32b3380cfb8b20b33f7e7c7490c69
inbox-entitlement.test.ts https://github.com/simstudioai/sim/pull/9054/files#diff-4590ebf0f4e0f6bffe89e83db3080fa683d8c516cf5cd941e1c15e8bdc4ae27c
subscription.integration.ts https://github.com/simstudioai/sim/pull/9054/files#diff-369623d8325f5ab65683309d4ae104651ea56dffaaf2d72e2ac039caa123829a
subscription.test.ts https://github.com/simstudioai/sim/pull/9054/files#diff-d9e761d0d22661eb78c13ad23e9c65e37046fc36adbe1aa7d84101bb5c7ce15e
subscription.ts https://github.com/simstudioai/sim/pull/9054/files#diff-ba28a867a18d2fec4e36fc5dea465c7dcfd8b755794a2e6ea72b0eec32fd99be
enterprise-byok.ts https://github.com/simstudioai/sim/pull/9054/files#diff-7b62ab402589d3c61d38801fb1d7a7874796cd016bb8872ba69ed64c236f0546
index.test.ts https://github.com/simstudioai/sim/pull/9054/files#diff-457f24777e278f328941b561bacfb240afbf5d793309275f6074dbcfd3772dc5
index.ts https://github.com/simstudioai/sim/pull/9054/files#diff-92244480a807def297332120dcdc4194e4456e8afedcd04786ddff18f495d51a
index.test.ts https://github.com/simstudioai/sim/pull/9054/files#diff-9ba0f7033f9247e496b4f9e0f46183a13c79b1bb48d721ba4bf042bdd08e4dd0
index.ts https://github.com/simstudioai/sim/pull/9054/files#diff-47ae0066fea628681d98d136239929a240a55aaf3d99ef293c83b3eca7e197c1
api-key-byok.mock.ts https://github.com/simstudioai/sim/pull/9054/files#diff-ce90b1c27796c70e24c5ffbbcf2404eb2589867eb353bf98184db56ac14e4d22
apps/sim/lib/api-key/byok.integration.tshttps://github.com/simstudioai/sim/pull/9054/files#diff-4ee4312a369485a2f217bcc467e5c4d8731bb5651368b62ae3016d5b57eb57ef
View file https://github.com/simstudioai/sim/blob/8dd68105af82befa23d77fa38ad236cbb7fe15bf/apps/sim/lib/api-key/byok.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9054/{{ revealButtonHref }}
apps/sim/lib/api-key/byok.test.tshttps://github.com/simstudioai/sim/pull/9054/files#diff-f841c517cb545c304bef290f4a0f46843d8d6f9379ef43d69a8bb04605e4bb3e
View file https://github.com/simstudioai/sim/blob/8dd68105af82befa23d77fa38ad236cbb7fe15bf/apps/sim/lib/api-key/byok.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9054/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9054/files#diff-f841c517cb545c304bef290f4a0f46843d8d6f9379ef43d69a8bb04605e4bb3e
https://github.com/simstudioai/sim/pull/9054/files#diff-f841c517cb545c304bef290f4a0f46843d8d6f9379ef43d69a8bb04605e4bb3e
https://github.com/simstudioai/sim/pull/9054/files#diff-f841c517cb545c304bef290f4a0f46843d8d6f9379ef43d69a8bb04605e4bb3e
https://github.com/simstudioai/sim/pull/9054/files#diff-f841c517cb545c304bef290f4a0f46843d8d6f9379ef43d69a8bb04605e4bb3e
https://github.com/simstudioai/sim/pull/9054/files#diff-f841c517cb545c304bef290f4a0f46843d8d6f9379ef43d69a8bb04605e4bb3e
https://github.com/simstudioai/sim/pull/9054/files#diff-f841c517cb545c304bef290f4a0f46843d8d6f9379ef43d69a8bb04605e4bb3e
https://github.com/simstudioai/sim/pull/9054/files#diff-f841c517cb545c304bef290f4a0f46843d8d6f9379ef43d69a8bb04605e4bb3e
Please reload this pagehttps://github.com/simstudioai/sim/pull/9054/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9054/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.