René's URL Explorer Experiment


Title: fix(mothership): drop queued tab adds the server already removed by waleedlatif1 · Pull Request #9050 · simstudioai/sim · GitHub

Open Graph Title: fix(mothership): drop queued tab adds the server already removed by waleedlatif1 · Pull Request #9050 · simstudioai/sim

X Title: fix(mothership): drop queued tab adds the server already removed by waleedlatif1 · Pull Request #9050 · simstudioai/sim

Description: Summary A server-applied remove effect (e.g. the agent deleting a file) cleared the tab locally but left the client's queued or failed add for that resource in the persistence queue. The next flush re-posted it and hydration re-projected the tab, so the deleted resource went out as an open tab on every later message A server remove effect now discards that queued or failed add, both live and when it arrives through a reconnect replay. The server already removed the resource, so no client delete is sent Active-tab resolution logs a missing resource at info and a revoked one at warn instead of error. Other failures still log at error, and the model receives the same context as before Known residual: an add whose POST is already in flight when the remove effect arrives keeps today's behavior (narrow, pre-existing window). Closing it client-side would add new client/server ordering hazards, so it's left out of this change Type of Change Bug fix Testing use-chat DOM regression tests: a failed add followed by a server remove effect, delivered live and via a reconnect replay. Before the fix the add is re-posted, the tab comes back and the deleted id is sent as an attachment; after the fix none of that happens process-contents test covering info/warn/error per failure class Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary A server-applied remove effect (e.g. the agent deleting a file) cleared the tab locally but left the client's queued or failed add for that resource in the persistence queue. The next ...

X Description: Summary A server-applied remove effect (e.g. the agent deleting a file) cleared the tab locally but left the client's queued or failed add for that resource in the persistence queue. The n...

Opengraph URL: https://github.com/simstudioai/sim/pull/9050

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a6735042-5412-154a-c07f-d9b7df687d57
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC740:14C9D4:1E3084:2A7209:6AFB501F
html-safe-nonce45ae5e301ca2bfeb2e7bb54a59f6939ca78f926312ed7b5e164050fb689a9f6c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNzQwOjE0QzlENDoxRTMwODQ6MkE3MjA5OjZBRkI1MDFGIiwidmlzaXRvcl9pZCI6IjQwNDk2ODIwMTE4NzMwMzgzNjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace03cb9a71af155bfd0cb394f4564194e9ad9c3f0d6e5b5e93da2ee41797b141e
hovercard-subject-tagpull_request:4865771389
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9050/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary A server-applied remove effect (e.g. the agent deleting a file) cleared the tab locally but left the client's queued or failed add for that resource in the persistence queue. The next ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9050/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9050%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9050%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9050/files
Reloadhttps://github.com/simstudioai/sim/pull/9050/files
Reloadhttps://github.com/simstudioai/sim/pull/9050/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/stale-resource-tabshttps://github.com/simstudioai/sim/tree/fix/stale-resource-tabs
Conversation 36 https://github.com/simstudioai/sim/pull/9050
Commits 7 https://github.com/simstudioai/sim/pull/9050/commits
Checks 53 https://github.com/simstudioai/sim/pull/9050/checks
Files changed https://github.com/simstudioai/sim/pull/9050/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9050/files
fix(mothership): drop queued tab adds the server already removed https://github.com/simstudioai/sim/pull/9050/files#top
Show all changes 7 commits https://github.com/simstudioai/sim/pull/9050/files
1cf8284 fix(mothership): drop queued tab adds the server already removed waleedlatif1 Oct 14, 2026 https://github.com/simstudioai/sim/pull/9050/commits/1cf828497873424c010fd2e5067e03bb23305e9d
7e3ce08 fix(mothership): type the stale-tab regression test's stream events waleedlatif1 Oct 14, 2026 https://github.com/simstudioai/sim/pull/9050/commits/7e3ce08b83972d730a22350d7d6feb4328ef282a
b99ed44 fix(mothership): close in-flight and recovery gaps for server-removed… waleedlatif1 Oct 14, 2026 https://github.com/simstudioai/sim/pull/9050/commits/b99ed4468fb131614ff67838e5d463f9d2b89844
e7f4fdd fix(mothership): gate the stale-tab test stream on the client's add, … waleedlatif1 Oct 14, 2026 https://github.com/simstudioai/sim/pull/9050/commits/e7f4fdd4766e2bd7755859583cc6a2987225db1f
be11be5 fix(mothership): use the shared deferred helper in stale-tab tests waleedlatif1 Oct 14, 2026 https://github.com/simstudioai/sim/pull/9050/commits/be11be5dc349f10a3a7f5e0229088c0306670ec5
65b42f0 fix(mothership): a server restore cancels a pending compensating delete waleedlatif1 Oct 14, 2026 https://github.com/simstudioai/sim/pull/9050/commits/65b42f029c506a105c63f4c41eb2c2fefe42d3cf
8bd8c38 fix(mothership): scope stale-tab fix to queued and failed adds waleedlatif1 Oct 15, 2026 https://github.com/simstudioai/sim/pull/9050/commits/8bd8c38c1c9a5f0d87d8547f38c499dcd219188a
Clear filters https://github.com/simstudioai/sim/pull/9050/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9050/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9050/files
handle-resource-event.ts https://github.com/simstudioai/sim/pull/9050/files#diff-74ec4a503172dd09cc57b9bc78e15b7fc22a6e265078924b5f29e48a48c21435
stream-context.ts https://github.com/simstudioai/sim/pull/9050/files#diff-a9020c8fc69ad002e000d09f88839129b90f08e554ccd81174ec226803adba13
stream-test-helpers.ts https://github.com/simstudioai/sim/pull/9050/files#diff-738f76e8bd5f9630745c429f669f8ed454105534c958618c2f9d9f1f03e9730a
use-chat.dom.test.tsx https://github.com/simstudioai/sim/pull/9050/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
use-chat.ts https://github.com/simstudioai/sim/pull/9050/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
process-contents.test.ts https://github.com/simstudioai/sim/pull/9050/files#diff-76858d265d8294c8908403aff91c4e6a2d2117c7a93107813fe5823dcaf44988
process-contents.ts https://github.com/simstudioai/sim/pull/9050/files#diff-c3819859701a12aabbc776fa382884f9484a852c61462173e39de94fd69329f3
client-persistence-queue.ts https://github.com/simstudioai/sim/pull/9050/files#diff-198f0c9bc6a474e617c4f467957d77ed4a43601cf010b66c63fdadeaf49d9f36
apps/sim/app/workspace/[workspaceId]/home/hooks/stream/handle-resource-event.tshttps://github.com/simstudioai/sim/pull/9050/files#diff-74ec4a503172dd09cc57b9bc78e15b7fc22a6e265078924b5f29e48a48c21435
View file https://github.com/simstudioai/sim/blob/8bd8c38c1c9a5f0d87d8547f38c499dcd219188a/apps/sim/app/workspace/%5BworkspaceId%5D/home/hooks/stream/handle-resource-event.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9050/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9050/files#diff-74ec4a503172dd09cc57b9bc78e15b7fc22a6e265078924b5f29e48a48c21435
https://github.com/simstudioai/sim/pull/9050/files#diff-74ec4a503172dd09cc57b9bc78e15b7fc22a6e265078924b5f29e48a48c21435
apps/sim/app/workspace/[workspaceId]/home/hooks/stream/stream-context.tshttps://github.com/simstudioai/sim/pull/9050/files#diff-a9020c8fc69ad002e000d09f88839129b90f08e554ccd81174ec226803adba13
View file https://github.com/simstudioai/sim/blob/8bd8c38c1c9a5f0d87d8547f38c499dcd219188a/apps/sim/app/workspace/%5BworkspaceId%5D/home/hooks/stream/stream-context.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9050/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9050/files#diff-a9020c8fc69ad002e000d09f88839129b90f08e554ccd81174ec226803adba13
https://github.com/simstudioai/sim/pull/9050/files#diff-a9020c8fc69ad002e000d09f88839129b90f08e554ccd81174ec226803adba13
apps/sim/app/workspace/[workspaceId]/home/hooks/stream/stream-test-helpers.tshttps://github.com/simstudioai/sim/pull/9050/files#diff-738f76e8bd5f9630745c429f669f8ed454105534c958618c2f9d9f1f03e9730a
View file https://github.com/simstudioai/sim/blob/8bd8c38c1c9a5f0d87d8547f38c499dcd219188a/apps/sim/app/workspace/%5BworkspaceId%5D/home/hooks/stream/stream-test-helpers.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9050/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9050/files#diff-738f76e8bd5f9630745c429f669f8ed454105534c958618c2f9d9f1f03e9730a
https://github.com/simstudioai/sim/pull/9050/files#diff-738f76e8bd5f9630745c429f669f8ed454105534c958618c2f9d9f1f03e9730a
apps/sim/app/workspace/[workspaceId]/home/hooks/use-chat.dom.test.tsxhttps://github.com/simstudioai/sim/pull/9050/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
View file https://github.com/simstudioai/sim/blob/8bd8c38c1c9a5f0d87d8547f38c499dcd219188a/apps/sim/app/workspace/%5BworkspaceId%5D/home/hooks/use-chat.dom.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9050/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9050/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
https://github.com/simstudioai/sim/pull/9050/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
https://github.com/simstudioai/sim/pull/9050/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
https://github.com/simstudioai/sim/pull/9050/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
https://github.com/simstudioai/sim/pull/9050/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
https://github.com/simstudioai/sim/pull/9050/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
apps/sim/app/workspace/[workspaceId]/home/hooks/use-chat.tshttps://github.com/simstudioai/sim/pull/9050/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
View file https://github.com/simstudioai/sim/blob/8bd8c38c1c9a5f0d87d8547f38c499dcd219188a/apps/sim/app/workspace/%5BworkspaceId%5D/home/hooks/use-chat.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9050/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9050/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/9050/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/9050/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/9050/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/9050/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/9050/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
apps/sim/lib/mothership/chat/process-contents.test.tshttps://github.com/simstudioai/sim/pull/9050/files#diff-76858d265d8294c8908403aff91c4e6a2d2117c7a93107813fe5823dcaf44988
View file https://github.com/simstudioai/sim/blob/8bd8c38c1c9a5f0d87d8547f38c499dcd219188a/apps/sim/lib/mothership/chat/process-contents.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9050/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9050/files#diff-76858d265d8294c8908403aff91c4e6a2d2117c7a93107813fe5823dcaf44988
https://github.com/simstudioai/sim/pull/9050/files#diff-76858d265d8294c8908403aff91c4e6a2d2117c7a93107813fe5823dcaf44988
https://github.com/simstudioai/sim/pull/9050/files#diff-76858d265d8294c8908403aff91c4e6a2d2117c7a93107813fe5823dcaf44988
https://github.com/simstudioai/sim/pull/9050/files#diff-76858d265d8294c8908403aff91c4e6a2d2117c7a93107813fe5823dcaf44988
apps/sim/lib/mothership/chat/process-contents.tshttps://github.com/simstudioai/sim/pull/9050/files#diff-c3819859701a12aabbc776fa382884f9484a852c61462173e39de94fd69329f3
View file https://github.com/simstudioai/sim/blob/8bd8c38c1c9a5f0d87d8547f38c499dcd219188a/apps/sim/lib/mothership/chat/process-contents.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9050/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9050/files#diff-c3819859701a12aabbc776fa382884f9484a852c61462173e39de94fd69329f3
https://github.com/simstudioai/sim/pull/9050/files#diff-c3819859701a12aabbc776fa382884f9484a852c61462173e39de94fd69329f3
https://github.com/simstudioai/sim/pull/9050/files#diff-c3819859701a12aabbc776fa382884f9484a852c61462173e39de94fd69329f3
https://github.com/simstudioai/sim/pull/9050/files#diff-c3819859701a12aabbc776fa382884f9484a852c61462173e39de94fd69329f3
apps/sim/lib/mothership/resources/client-persistence-queue.tshttps://github.com/simstudioai/sim/pull/9050/files#diff-198f0c9bc6a474e617c4f467957d77ed4a43601cf010b66c63fdadeaf49d9f36
View file https://github.com/simstudioai/sim/blob/8bd8c38c1c9a5f0d87d8547f38c499dcd219188a/apps/sim/lib/mothership/resources/client-persistence-queue.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9050/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9050/files#diff-198f0c9bc6a474e617c4f467957d77ed4a43601cf010b66c63fdadeaf49d9f36
Please reload this pagehttps://github.com/simstudioai/sim/pull/9050/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9050/files
https://github.com/simstudioai/sim/pull/9050/files#diff-198f0c9bc6a474e617c4f467957d77ed4a43601cf010b66c63fdadeaf49d9f36
Please reload this pagehttps://github.com/simstudioai/sim/pull/9050/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.