René's URL Explorer Experiment


Title: fix(uploads): sign transfers for in-process v2 callers that carry no network origin by waleedlatif1 · Pull Request #9049 · simstudioai/sim · GitHub

Open Graph Title: fix(uploads): sign transfers for in-process v2 callers that carry no network origin by waleedlatif1 · Pull Request #9049 · simstudioai/sim

X Title: fix(uploads): sign transfers for in-process v2 callers that carry no network origin by waleedlatif1 · Pull Request #9049 · simstudioai/sim

Description: Summary requestOrigin() threw "Upload signing requires a request origin" for in-process v2 callers. Chat's CLI (scoped in-process transport) and MCP tool dispatch build NextRequests with no Origin/Host headers. The nextUrl instanceof URL branch never matched, because NextRequest.nextUrl is a NextURL, not a URL. Because of that, knowledge document upload create/parts, table import create/parts, and workspace file upload parts failed for those callers on every storage provider. The origin is only read by the local provider. A network request still resolves its origin from the Origin header first, then x-forwarded-host/host, so browser and proxied self-hosted behavior is unchanged. A request with neither now uses the URL it was addressed to: the CLI's configured endpoint, or the app URL for MCP. A context without a URL falls back to the configured app URL instead of throwing. Removed the dead nextUrl branch. Added an optional url to OrchestrationRequestContext, which NextRequest already satisfies. Type of Change Bug fix Testing New requestOrigin unit tests. The in-process case reproduced the thrown error before the fix and passes after it. New integration test that drives knowledge upload, table import, and workspace file create + parts through createScopedCliTransport and dispatchMcpOperation on local storage, with no host headers. It asserts the PUT and part URLs point at the CLI endpoint and at the app URL respectively. The existing use-case tests mocked requestOrigin, so none of them exercised a header-less request. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary requestOrigin() threw "Upload signing requires a request origin" for in-process v2 callers. Chat's CLI (scoped in-process transport) and MCP tool dispatch build NextRequests ...

X Description: Summary requestOrigin() threw "Upload signing requires a request origin" for in-process v2 callers. Chat's CLI (scoped in-process transport) and MCP tool dispatch build N...

Opengraph URL: https://github.com/simstudioai/sim/pull/9049

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3987685c-fb35-ccab-d4ba-efc38452656b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB6C2:15DF38:B5B559:F7E07D:6AFB51A7
html-safe-nonce12cb74a3246fda8be7f2f839a8cc3d90c1d662d4bf72dd663f2ea07e51b7126c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNkMyOjE1REYzODpCNUI1NTk6RjdFMDdEOjZBRkI1MUE3IiwidmlzaXRvcl9pZCI6IjMwMzQ2NDIwOTU3NzI3NTAyNDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace670aea9d3b7c92fc1f8f9f77847aaabb333f4c04a4aa8b3089b2508d12e94de
hovercard-subject-tagpull_request:4865755359
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9049/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary requestOrigin() threw "Upload signing requires a request origin" for in-process v2 callers. Chat's CLI (scoped in-process transport) and MCP tool dispatch build NextRequests ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9049/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9049%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9049%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9049/files
Reloadhttps://github.com/simstudioai/sim/pull/9049/files
Reloadhttps://github.com/simstudioai/sim/pull/9049/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/upload-signing-originhttps://github.com/simstudioai/sim/tree/fix/upload-signing-origin
Conversation 5 https://github.com/simstudioai/sim/pull/9049
Commits 2 https://github.com/simstudioai/sim/pull/9049/commits
Checks 52 https://github.com/simstudioai/sim/pull/9049/checks
Files changed https://github.com/simstudioai/sim/pull/9049/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9049/files
fix(uploads): sign transfers for in-process v2 callers that carry no network origin https://github.com/simstudioai/sim/pull/9049/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/9049/files
544ca08 fix(uploads): sign transfers for in-process v2 callers that carry no … waleedlatif1 Oct 14, 2026 https://github.com/simstudioai/sim/pull/9049/commits/544ca083dcb460595a727f5fe14266aa7c0a5cb1
f062fcc test(uploads): give the MCP fixture request a client address waleedlatif1 Oct 14, 2026 https://github.com/simstudioai/sim/pull/9049/commits/f062fcceed924b6c7513d96b8583d33e94f4285d
Clear filters https://github.com/simstudioai/sim/pull/9049/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9049/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9049/files
types.ts https://github.com/simstudioai/sim/pull/9049/files#diff-c5ae99c1474ab4f0af0cd6826e971dbabfbdb0279187c645c50f4b595dd89bc3
application.test.ts https://github.com/simstudioai/sim/pull/9049/files#diff-595f7b4eb28ae1cd6456ae579567ce3ba96a90024e40abc54fea0396334d8229
application.ts https://github.com/simstudioai/sim/pull/9049/files#diff-65634bb55c928323a309ccf15421583554843cad0dc1cb8be1023538cbaefb91
in-process-origin.integration.ts https://github.com/simstudioai/sim/pull/9049/files#diff-3565e666e90c523f96bcc3a49801e0c6794b6c0629ac9f75ab107eeda50736b6
apps/sim/lib/core/orchestration/types.tshttps://github.com/simstudioai/sim/pull/9049/files#diff-c5ae99c1474ab4f0af0cd6826e971dbabfbdb0279187c645c50f4b595dd89bc3
View file https://github.com/simstudioai/sim/blob/f062fcceed924b6c7513d96b8583d33e94f4285d/apps/sim/lib/core/orchestration/types.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9049/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9049/files#diff-c5ae99c1474ab4f0af0cd6826e971dbabfbdb0279187c645c50f4b595dd89bc3
apps/sim/lib/uploads/upload-session/application.test.tshttps://github.com/simstudioai/sim/pull/9049/files#diff-595f7b4eb28ae1cd6456ae579567ce3ba96a90024e40abc54fea0396334d8229
View file https://github.com/simstudioai/sim/blob/f062fcceed924b6c7513d96b8583d33e94f4285d/apps/sim/lib/uploads/upload-session/application.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9049/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9049/files#diff-595f7b4eb28ae1cd6456ae579567ce3ba96a90024e40abc54fea0396334d8229
https://github.com/simstudioai/sim/pull/9049/files#diff-595f7b4eb28ae1cd6456ae579567ce3ba96a90024e40abc54fea0396334d8229
https://github.com/simstudioai/sim/pull/9049/files#diff-595f7b4eb28ae1cd6456ae579567ce3ba96a90024e40abc54fea0396334d8229
apps/sim/lib/uploads/upload-session/application.tshttps://github.com/simstudioai/sim/pull/9049/files#diff-65634bb55c928323a309ccf15421583554843cad0dc1cb8be1023538cbaefb91
View file https://github.com/simstudioai/sim/blob/f062fcceed924b6c7513d96b8583d33e94f4285d/apps/sim/lib/uploads/upload-session/application.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9049/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9049/files#diff-65634bb55c928323a309ccf15421583554843cad0dc1cb8be1023538cbaefb91
https://github.com/simstudioai/sim/pull/9049/files#diff-65634bb55c928323a309ccf15421583554843cad0dc1cb8be1023538cbaefb91
https://github.com/simstudioai/sim/pull/9049/files#diff-65634bb55c928323a309ccf15421583554843cad0dc1cb8be1023538cbaefb91
apps/sim/lib/uploads/upload-session/in-process-origin.integration.tshttps://github.com/simstudioai/sim/pull/9049/files#diff-3565e666e90c523f96bcc3a49801e0c6794b6c0629ac9f75ab107eeda50736b6
View file https://github.com/simstudioai/sim/blob/f062fcceed924b6c7513d96b8583d33e94f4285d/apps/sim/lib/uploads/upload-session/in-process-origin.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9049/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/9049/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.