René's URL Explorer Experiment


Title: fix(mothership): surface actionable workbench file read failures by waleedlatif1 · Pull Request #9048 · simstudioai/sim · GitHub

Open Graph Title: fix(mothership): surface actionable workbench file read failures by waleedlatif1 · Pull Request #9048 · simstudioai/sim

X Title: fix(mothership): surface actionable workbench file read failures by waleedlatif1 · Pull Request #9048 · simstudioai/sim

Description: Summary The workbench copy script exited non-zero on any exception, and the server only recognized three stderr phrases. Everything else (missing file, directory, permission, disk full) became a plain Error, so files read gave the model "The file could not be read. Retry..." and logged an error. Even the recognized cases were plain Errors, so fileReadFailure hid them too. A directory never reached the regular-file check, because os.fdopen raised IsADirectoryError first. The copy script now reports one failure from a closed set (not_found, not_regular, permission, outside_roots, too_large, no_space) as a fixed marker line on stdout. fstat now runs before fdopen, and raw stderr and paths are never parsed. openSessionFileSnapshot maps each reason to an OrchestrationError with a message the model can act on. A missing file tells the model to check the path or wait for the step that writes it. A chat without a workbench is now not_found. An unclassified failure stays internal and reports only the exit code and exception class. A workspace reference that is not a valid VFS path (e.g. a URL) was an unclassified VfsPathError. Reference resolution now turns it into a validation error. Why tests missed it: the snapshot tests asserted thrown message text, never whether the error type survives fileReadFailure. The only failure cases covered were the three phrases that the stderr matcher recognized. Type of Change Bug fix Testing Snapshot tests run the real copy script against a temp dir for missing, directory, permission, too-large and symlink-escape paths. They also cover disk-full, no-workbench, unclassified and killed failures, and each case checks the exact message the model receives through fileReadFailure. They fail before this change and pass after. A URL reference test goes through the real VFS decoder. A pass-through test covers readChatSandboxFile. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The workbench copy script exited non-zero on any exception, and the server only recognized three stderr phrases. Everything else (missing file, directory, permission, disk full) became a p...

X Description: Summary The workbench copy script exited non-zero on any exception, and the server only recognized three stderr phrases. Everything else (missing file, directory, permission, disk full) became a p...

Opengraph URL: https://github.com/simstudioai/sim/pull/9048

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6523c74f-421c-ffaf-2745-bd9743fa4998
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDC3C:29D5DB:C1D54D:109DAAD:6AFB5682
html-safe-nonceb7b437d89f69f83083d2b3e23e20da4a78bc001ea289dd79676ae44e9e5774cb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzNDOjI5RDVEQjpDMUQ1NEQ6MTA5REFBRDo2QUZCNTY4MiIsInZpc2l0b3JfaWQiOiIxNDQ1MjQ3NzU2NjQwNDA5MjE4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac174372105a6a93be77892c2f904156c3adbaa915a9afaa17ef46685de2ea5a71
hovercard-subject-tagpull_request:4865743098
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9048/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The workbench copy script exited non-zero on any exception, and the server only recognized three stderr phrases. Everything else (missing file, directory, permission, disk full) became a p...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9048/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9048%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9048%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9048/files
Reloadhttps://github.com/simstudioai/sim/pull/9048/files
Reloadhttps://github.com/simstudioai/sim/pull/9048/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/workbench-read-errorshttps://github.com/simstudioai/sim/tree/fix/workbench-read-errors
Conversation 18 https://github.com/simstudioai/sim/pull/9048
Commits 4 https://github.com/simstudioai/sim/pull/9048/commits
Checks 52 https://github.com/simstudioai/sim/pull/9048/checks
Files changed https://github.com/simstudioai/sim/pull/9048/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9048/files
fix(mothership): surface actionable workbench file read failures https://github.com/simstudioai/sim/pull/9048/files#top
Show all changes 4 commits https://github.com/simstudioai/sim/pull/9048/files
d98f193 fix(mothership): surface actionable workbench file read failures waleedlatif1 Oct 14, 2026 https://github.com/simstudioai/sim/pull/9048/commits/d98f193cda022a6e076d4ba061f730fd1373e112
56b86a7 chore(lint): drop VfsPathError from unused-exports baseline waleedlatif1 Oct 14, 2026 https://github.com/simstudioai/sim/pull/9048/commits/56b86a71101ec5b50465b66c7fb7147cad854b51
ed5f389 fix(mothership): classify workbench staging failures apart from sourc… waleedlatif1 Oct 14, 2026 https://github.com/simstudioai/sim/pull/9048/commits/ed5f38994232e7d8b3317552e6ebffc67dc4b5d0
c372287 fix(mothership): report a workbench socket path as not a regular file waleedlatif1 Oct 14, 2026 https://github.com/simstudioai/sim/pull/9048/commits/c372287c8cfdf5fa598a6f6611c99cf74ef2bd5c
Clear filters https://github.com/simstudioai/sim/pull/9048/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9048/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9048/files
session-file-snapshot.test.ts https://github.com/simstudioai/sim/pull/9048/files#diff-5860fbd9b8dc6d4d48669bc9e726ef2d12283357134d9b3070e2343287e76b26
session-file-snapshot.ts https://github.com/simstudioai/sim/pull/9048/files#diff-1d8505e72603d78bef483580bfdd932396718fa19e8c39e88c8d9c45af6c944d
read-sandbox-file.test.ts https://github.com/simstudioai/sim/pull/9048/files#diff-ceb1bef26cdbca83fc9f0cfc5bf43b4ded927535799da5961ae34b869a72af65
resolve-workspace-file-reference.test.ts https://github.com/simstudioai/sim/pull/9048/files#diff-8f167718466a3084861b8d05feaf3411e05a283ac323b86db24974bf743aeaae
resolve-workspace-file-reference.ts https://github.com/simstudioai/sim/pull/9048/files#diff-2bd3b3035a38ca30588d12469ada46bc010039c4d83719a4103ffe55db68b4df
check-unused-exports.baseline.json https://github.com/simstudioai/sim/pull/9048/files#diff-4b59a8526a4f226dffb0fbf6b8ec25d3082ab45da697f584eaaca4bd483c928f
apps/sim/lib/execution/remote-sandbox/session-file-snapshot.test.tshttps://github.com/simstudioai/sim/pull/9048/files#diff-5860fbd9b8dc6d4d48669bc9e726ef2d12283357134d9b3070e2343287e76b26
View file https://github.com/simstudioai/sim/blob/c372287c8cfdf5fa598a6f6611c99cf74ef2bd5c/apps/sim/lib/execution/remote-sandbox/session-file-snapshot.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9048/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9048/files#diff-5860fbd9b8dc6d4d48669bc9e726ef2d12283357134d9b3070e2343287e76b26
https://github.com/simstudioai/sim/pull/9048/files#diff-5860fbd9b8dc6d4d48669bc9e726ef2d12283357134d9b3070e2343287e76b26
https://github.com/simstudioai/sim/pull/9048/files#diff-5860fbd9b8dc6d4d48669bc9e726ef2d12283357134d9b3070e2343287e76b26
https://github.com/simstudioai/sim/pull/9048/files#diff-5860fbd9b8dc6d4d48669bc9e726ef2d12283357134d9b3070e2343287e76b26
https://github.com/simstudioai/sim/pull/9048/files#diff-5860fbd9b8dc6d4d48669bc9e726ef2d12283357134d9b3070e2343287e76b26
https://github.com/simstudioai/sim/pull/9048/files#diff-5860fbd9b8dc6d4d48669bc9e726ef2d12283357134d9b3070e2343287e76b26
apps/sim/lib/execution/remote-sandbox/session-file-snapshot.tshttps://github.com/simstudioai/sim/pull/9048/files#diff-1d8505e72603d78bef483580bfdd932396718fa19e8c39e88c8d9c45af6c944d
View file https://github.com/simstudioai/sim/blob/c372287c8cfdf5fa598a6f6611c99cf74ef2bd5c/apps/sim/lib/execution/remote-sandbox/session-file-snapshot.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9048/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9048/files#diff-1d8505e72603d78bef483580bfdd932396718fa19e8c39e88c8d9c45af6c944d
https://github.com/simstudioai/sim/pull/9048/files#diff-1d8505e72603d78bef483580bfdd932396718fa19e8c39e88c8d9c45af6c944d
https://github.com/simstudioai/sim/pull/9048/files#diff-1d8505e72603d78bef483580bfdd932396718fa19e8c39e88c8d9c45af6c944d
https://github.com/simstudioai/sim/pull/9048/files#diff-1d8505e72603d78bef483580bfdd932396718fa19e8c39e88c8d9c45af6c944d
https://github.com/simstudioai/sim/pull/9048/files#diff-1d8505e72603d78bef483580bfdd932396718fa19e8c39e88c8d9c45af6c944d
apps/sim/lib/mothership/chat/application/read-sandbox-file.test.tshttps://github.com/simstudioai/sim/pull/9048/files#diff-ceb1bef26cdbca83fc9f0cfc5bf43b4ded927535799da5961ae34b869a72af65
View file https://github.com/simstudioai/sim/blob/c372287c8cfdf5fa598a6f6611c99cf74ef2bd5c/apps/sim/lib/mothership/chat/application/read-sandbox-file.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9048/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9048/files#diff-ceb1bef26cdbca83fc9f0cfc5bf43b4ded927535799da5961ae34b869a72af65
https://github.com/simstudioai/sim/pull/9048/files#diff-ceb1bef26cdbca83fc9f0cfc5bf43b4ded927535799da5961ae34b869a72af65
https://github.com/simstudioai/sim/pull/9048/files#diff-ceb1bef26cdbca83fc9f0cfc5bf43b4ded927535799da5961ae34b869a72af65
https://github.com/simstudioai/sim/pull/9048/files#diff-ceb1bef26cdbca83fc9f0cfc5bf43b4ded927535799da5961ae34b869a72af65
apps/sim/lib/workspace-files/application/resolve-workspace-file-reference.test.tshttps://github.com/simstudioai/sim/pull/9048/files#diff-8f167718466a3084861b8d05feaf3411e05a283ac323b86db24974bf743aeaae
View file https://github.com/simstudioai/sim/blob/c372287c8cfdf5fa598a6f6611c99cf74ef2bd5c/apps/sim/lib/workspace-files/application/resolve-workspace-file-reference.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9048/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9048/files#diff-8f167718466a3084861b8d05feaf3411e05a283ac323b86db24974bf743aeaae
https://github.com/simstudioai/sim/pull/9048/files#diff-8f167718466a3084861b8d05feaf3411e05a283ac323b86db24974bf743aeaae
https://github.com/simstudioai/sim/pull/9048/files#diff-8f167718466a3084861b8d05feaf3411e05a283ac323b86db24974bf743aeaae
https://github.com/simstudioai/sim/pull/9048/files#diff-8f167718466a3084861b8d05feaf3411e05a283ac323b86db24974bf743aeaae
Please reload this pagehttps://github.com/simstudioai/sim/pull/9048/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9048/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.