René's URL Explorer Experiment


Title: fix(resume): answer a sync v2 resume whose run fails with the failed run, not a 500 by waleedlatif1 · Pull Request #9047 · simstudioai/sim · GitHub

Open Graph Title: fix(resume): answer a sync v2 resume whose run fails with the failed run, not a 500 by waleedlatif1 · Pull Request #9047 · simstudioai/sim

X Title: fix(resume): answer a sync v2 resume whose run fails with the failed run, not a 500 by waleedlatif1 · Pull Request #9047 · simstudioai/sim

Description: Summary A sync POST /api/v2/workflows/:id/runs/:runId/resume whose resumed run failed in-band (e.g. a block error) returned 500 INTERNAL_ERROR: the engine throws the failure with the partial executionResult attached, startResumeExecution rethrows it, and executeResumeWorkflow passed it through to the route's unhandled-error path executeResumeWorkflow's sync branch now settles an error carrying an executionResult as a kind: 'sync', status: 'failed' result, with the error classified via classifyExecutionError(error, result), same as sync execute (block id/name/type and code included). Errors with no run behind them (run buffer unavailable, pause persistence, admission) still throw and stay 5xx/mapped as before v2 resume route presents the domain's structuredError instead of re-classifying the bare message, so a failed resume returns the same run resource shape as a failed v2 execute (200, status: 'failed') Legacy /api/resume/... keeps its existing answer for a failed sync run (400 { error }); async, streaming and UI-started resumes are untouched Type of Change Bug fix Testing New tests through the real executeResumeWorkflow: in-band failure resolves as a failed run with a classified error (fails before the fix), a failure with no run still throws, legacy route still answers 400 v2 route: failed sync result renders the failed run resource and parses against the contract (fails before the fix) Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary A sync POST /api/v2/workflows/:id/runs/:runId/resume whose resumed run failed in-band (e.g. a block error) returned 500 INTERNAL_ERROR: the engine throws the failure with the partial execu...

X Description: Summary A sync POST /api/v2/workflows/:id/runs/:runId/resume whose resumed run failed in-band (e.g. a block error) returned 500 INTERNAL_ERROR: the engine throws the failure with the partial execu...

Opengraph URL: https://github.com/simstudioai/sim/pull/9047

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3b6b69f2-f393-e471-0ef5-63366bd3d665
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA938:9D91A:24B0C8:33F174:6AFB5284
html-safe-nonce36a7d4bf3460a848057808b75d10f5049c28a967a7da1ebdc7a6c252ec1db07f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTM4OjlEOTFBOjI0QjBDODozM0YxNzQ6NkFGQjUyODQiLCJ2aXNpdG9yX2lkIjoiMTE1NDIwMjkxNDE4OTQzMTQyOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca9ae0fe7bb5f15951ba9d6b8026a6f09c23007d2dcae5bbb9c8b44910af63b7c
hovercard-subject-tagpull_request:4865741528
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9047/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary A sync POST /api/v2/workflows/:id/runs/:runId/resume whose resumed run failed in-band (e.g. a block error) returned 500 INTERNAL_ERROR: the engine throws the failure with the partial execu...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9047/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9047%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9047%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9047/files
Reloadhttps://github.com/simstudioai/sim/pull/9047/files
Reloadhttps://github.com/simstudioai/sim/pull/9047/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/v2-sync-resume-run-failurehttps://github.com/simstudioai/sim/tree/fix/v2-sync-resume-run-failure
Conversation 2 https://github.com/simstudioai/sim/pull/9047
Commits 1 https://github.com/simstudioai/sim/pull/9047/commits
Checks 51 https://github.com/simstudioai/sim/pull/9047/checks
Files changed https://github.com/simstudioai/sim/pull/9047/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9047/files
fix(resume): answer a sync v2 resume whose run fails with the failed run, not a 500 https://github.com/simstudioai/sim/pull/9047/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/9047/files
a7c3970 fix(resume): answer a sync v2 resume whose run fails with the failed … waleedlatif1 Oct 14, 2026 https://github.com/simstudioai/sim/pull/9047/commits/a7c397074b04c3b496f1316ab7cef86b13e499a1
Clear filters https://github.com/simstudioai/sim/pull/9047/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9047/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9047/files
route.test.ts https://github.com/simstudioai/sim/pull/9047/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
resume-handler.ts https://github.com/simstudioai/sim/pull/9047/files#diff-2747afa46cc2b328243ac3608c407f2d915facd5400ecd3a1b2f7af8875906a0
route.test.ts https://github.com/simstudioai/sim/pull/9047/files#diff-b281a2d5d86a631525fac0dd758d37c1457b2a2907de0c488241d30164271a6f
route.ts https://github.com/simstudioai/sim/pull/9047/files#diff-7e6d50fd88ff452c4637e5419f46aecc8fc451f858d0e7748d0029cf88bce2b2
resume-execution.ts https://github.com/simstudioai/sim/pull/9047/files#diff-304d5a83871c2e18b2f6994cb1cf3f6832238938ebf88dcfa4273e9d43e38082
apps/sim/app/api/resume/[workflowId]/[executionId]/[contextId]/route.test.tshttps://github.com/simstudioai/sim/pull/9047/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
View file https://github.com/simstudioai/sim/blob/a7c397074b04c3b496f1316ab7cef86b13e499a1/apps/sim/app/api/resume/%5BworkflowId%5D/%5BexecutionId%5D/%5BcontextId%5D/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9047/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9047/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
https://github.com/simstudioai/sim/pull/9047/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
https://github.com/simstudioai/sim/pull/9047/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
https://github.com/simstudioai/sim/pull/9047/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
apps/sim/app/api/resume/resume-handler.tshttps://github.com/simstudioai/sim/pull/9047/files#diff-2747afa46cc2b328243ac3608c407f2d915facd5400ecd3a1b2f7af8875906a0
View file https://github.com/simstudioai/sim/blob/a7c397074b04c3b496f1316ab7cef86b13e499a1/apps/sim/app/api/resume/resume-handler.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9047/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9047/files#diff-2747afa46cc2b328243ac3608c407f2d915facd5400ecd3a1b2f7af8875906a0
https://github.com/simstudioai/sim/pull/9047/files#diff-2747afa46cc2b328243ac3608c407f2d915facd5400ecd3a1b2f7af8875906a0
apps/sim/app/api/v2/workflows/[workflowId]/runs/[runId]/resume/route.test.tshttps://github.com/simstudioai/sim/pull/9047/files#diff-b281a2d5d86a631525fac0dd758d37c1457b2a2907de0c488241d30164271a6f
View file https://github.com/simstudioai/sim/blob/a7c397074b04c3b496f1316ab7cef86b13e499a1/apps/sim/app/api/v2/workflows/%5BworkflowId%5D/runs/%5BrunId%5D/resume/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9047/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9047/files#diff-b281a2d5d86a631525fac0dd758d37c1457b2a2907de0c488241d30164271a6f
https://github.com/simstudioai/sim/pull/9047/files#diff-b281a2d5d86a631525fac0dd758d37c1457b2a2907de0c488241d30164271a6f
https://github.com/simstudioai/sim/pull/9047/files#diff-b281a2d5d86a631525fac0dd758d37c1457b2a2907de0c488241d30164271a6f
https://github.com/simstudioai/sim/pull/9047/files#diff-b281a2d5d86a631525fac0dd758d37c1457b2a2907de0c488241d30164271a6f
apps/sim/app/api/v2/workflows/[workflowId]/runs/[runId]/resume/route.tshttps://github.com/simstudioai/sim/pull/9047/files#diff-7e6d50fd88ff452c4637e5419f46aecc8fc451f858d0e7748d0029cf88bce2b2
View file https://github.com/simstudioai/sim/blob/a7c397074b04c3b496f1316ab7cef86b13e499a1/apps/sim/app/api/v2/workflows/%5BworkflowId%5D/runs/%5BrunId%5D/resume/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9047/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9047/files#diff-7e6d50fd88ff452c4637e5419f46aecc8fc451f858d0e7748d0029cf88bce2b2
https://github.com/simstudioai/sim/pull/9047/files#diff-7e6d50fd88ff452c4637e5419f46aecc8fc451f858d0e7748d0029cf88bce2b2
https://github.com/simstudioai/sim/pull/9047/files#diff-7e6d50fd88ff452c4637e5419f46aecc8fc451f858d0e7748d0029cf88bce2b2
https://github.com/simstudioai/sim/pull/9047/files#diff-7e6d50fd88ff452c4637e5419f46aecc8fc451f858d0e7748d0029cf88bce2b2
apps/sim/lib/workflows/executor/resume-execution.tshttps://github.com/simstudioai/sim/pull/9047/files#diff-304d5a83871c2e18b2f6994cb1cf3f6832238938ebf88dcfa4273e9d43e38082
View file https://github.com/simstudioai/sim/blob/a7c397074b04c3b496f1316ab7cef86b13e499a1/apps/sim/lib/workflows/executor/resume-execution.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9047/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9047/files#diff-304d5a83871c2e18b2f6994cb1cf3f6832238938ebf88dcfa4273e9d43e38082
https://github.com/simstudioai/sim/pull/9047/files#diff-304d5a83871c2e18b2f6994cb1cf3f6832238938ebf88dcfa4273e9d43e38082
https://github.com/simstudioai/sim/pull/9047/files#diff-304d5a83871c2e18b2f6994cb1cf3f6832238938ebf88dcfa4273e9d43e38082
https://github.com/simstudioai/sim/pull/9047/files#diff-304d5a83871c2e18b2f6994cb1cf3f6832238938ebf88dcfa4273e9d43e38082
https://github.com/simstudioai/sim/pull/9047/files#diff-304d5a83871c2e18b2f6994cb1cf3f6832238938ebf88dcfa4273e9d43e38082
https://github.com/simstudioai/sim/pull/9047/files#diff-304d5a83871c2e18b2f6994cb1cf3f6832238938ebf88dcfa4273e9d43e38082
Please reload this pagehttps://github.com/simstudioai/sim/pull/9047/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.