René's URL Explorer Experiment


Title: fix(files): keep file search and compiled-doc reads off write locks by waleedlatif1 · Pull Request #9023 · simstudioai/sim · GitHub

Open Graph Title: fix(files): keep file search and compiled-doc reads off write locks by waleedlatif1 · Pull Request #9023 · simstudioai/sim

X Title: fix(files): keep file search and compiled-doc reads off write locks by waleedlatif1 · Pull Request #9023 · simstudioai/sim

Description: Summary Follow-up to #8609. Keeps file search and compiled-document reads off write locks, and restores pre-#8609 search behavior where it regressed. Copilot content search took no locks before #8609; now it does again. The delivery transaction held the exclusive Project mutex, the exclusive org-wide permission-group lock (also taken by OAuth refresh and workspace creation), FOR UPDATE on permission rows, and FOR SHARE on the workspace and matched file rows. Admission runs after commit, so these fenced nothing. They serialized Copilot greps across an org and against uploads. The transaction is now a plain snapshot validation. A changed file no longer fails the whole search. Before #8609 a file that changed mid-search lost only its preview. delivery.ts now gives it unknown provenance (preview withheld), drops hits that left the folder scope, and checks owned inputs only for sources that still validate. No preview from a stale revision is released. Compiled-document reads no longer always open a locking transaction. Every authorized serve with an artifact key ran SELECT … FOR UPDATE on the file and dependency rows before its "already ready" return, with no lock timeout, and a failure there failed a read whose bytes were already fetched. A lock-free pre-check now returns early in exactly the cases where the locked path was a no-op. Otherwise the locked path runs with a 1s lock_timeout, and any error logs a warning and still returns the bytes. Coverage counts: pending is now total − ready − failed − skipped, which is identical because the statuses partition the rows. This halves the dependency probes per search. Reference scanning: sources without any reference marker skip the full TypeScript parse. TypeScript loads on first use instead of statically into the serve and index paths. A source the parser rejects is indexed as raw text again instead of being excluded. Type of Change Bug fix Testing search-workspace-file-content.test.ts passes locally (5/5). Integration suites (owners, chunks, dispatcher) run in CI. Reviewers: the S1 pre-check equivalence and the pending-count partition are argued in the commit. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Follow-up to #8609. Keeps file search and compiled-document reads off write locks, and restores pre-#8609 search behavior where it regressed. Copilot content search took no locks before #8...

X Description: Summary Follow-up to #8609. Keeps file search and compiled-document reads off write locks, and restores pre-#8609 search behavior where it regressed. Copilot content search took no locks before #8...

Opengraph URL: https://github.com/simstudioai/sim/pull/9023

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:337f532a-6334-bb6b-f3cb-534180e319ca
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD0A6:394173:832014:B47B65:6AFB467D
html-safe-nonceb223aa9aa16e5bdbd7958c51ead3f579c97c8589815a065bb320e226bca2fc40
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMEE2OjM5NDE3Mzo4MzIwMTQ6QjQ3QjY1OjZBRkI0NjdEIiwidmlzaXRvcl9pZCI6IjE0MDgwMzI0MjMzNjYzMTM1OTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6979a8ce857e92e5f33fd9914711337d672218938359ab12258d6bf9a6f2eaf4
hovercard-subject-tagpull_request:4860225247
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9023/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-up to #8609. Keeps file search and compiled-document reads off write locks, and restores pre-#8609 search behavior where it regressed. Copilot content search took no locks before #8...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9023/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9023%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9023%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9023/files
Reloadhttps://github.com/simstudioai/sim/pull/9023/files
Reloadhttps://github.com/simstudioai/sim/pull/9023/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/file-search-read-pathhttps://github.com/simstudioai/sim/tree/fix/file-search-read-path
Conversation 20 https://github.com/simstudioai/sim/pull/9023
Commits 3 https://github.com/simstudioai/sim/pull/9023/commits
Checks 51 https://github.com/simstudioai/sim/pull/9023/checks
Files changed https://github.com/simstudioai/sim/pull/9023/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9023/files
fix(files): keep file search and compiled-doc reads off write locks https://github.com/simstudioai/sim/pull/9023/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/9023/files
1c1e520 fix(files): keep file search and compiled-doc reads off write locks waleedlatif1 Oct 14, 2026 https://github.com/simstudioai/sim/pull/9023/commits/1c1e520e838469f9d571e00292dabe13b91b7044
94a45ea fix(files): validate search delivery against one snapshot and count r… waleedlatif1 Oct 14, 2026 https://github.com/simstudioai/sim/pull/9023/commits/94a45eae1255b4af70ba3b9cbf7d9e4e6aa972e9
8e6b763 refactor(files): move rendered-artifact search requeue into artifact-… waleedlatif1 Oct 14, 2026 https://github.com/simstudioai/sim/pull/9023/commits/8e6b763f7a1465f4ea4fed2286fcc31f1c622c5f
Clear filters https://github.com/simstudioai/sim/pull/9023/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9023/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9023/files
references.ts https://github.com/simstudioai/sim/pull/9023/files#diff-1b40514c1e221fb3ce6b63520d5c1c7246704e2233916251d61df9fd96924b36
fetch-servable-workspace-file-buffer.ts https://github.com/simstudioai/sim/pull/9023/files#diff-8537ecd85bff6bad9fb8be7bfd3e7b5c68f39d8f522b812914156e11bf7884e4
search-workspace-file-content.test.ts https://github.com/simstudioai/sim/pull/9023/files#diff-ce2e108d023d41c53260bdf4c0ea74371875464222a9f1d10eace5ff5c37c2a4
search-workspace-file-content.ts https://github.com/simstudioai/sim/pull/9023/files#diff-14912de00a65e52eb46d81b39b5db4953774151f7d419cea798f619612cd7e6e
artifact-ready.ts https://github.com/simstudioai/sim/pull/9023/files#diff-733f0be20894a7e9403d000d38a09d0a433dbc058b7d751620742f836db48c5d
constants.ts https://github.com/simstudioai/sim/pull/9023/files#diff-25abdafbc319ad195e37055eeebf63e23f0a8d6294ed87fbb6726afb3496a9eb
delivery.ts https://github.com/simstudioai/sim/pull/9023/files#diff-197899a8234fefdea4d171551061f520899f7f58ffab57a601ecd97e2b0490be
repository.ts https://github.com/simstudioai/sim/pull/9023/files#diff-67a00ddf8c2f51a97a8b944dbb15fd00a59a9590135a0b9fd3deffb5498dbb5c
source.ts https://github.com/simstudioai/sim/pull/9023/files#diff-29b600be6c0d44fbb5b2dd13c01fd5ca9dc04a44fdc557e78adedcc1976161ec
apps/sim/lib/uploads/documents/references.tshttps://github.com/simstudioai/sim/pull/9023/files#diff-1b40514c1e221fb3ce6b63520d5c1c7246704e2233916251d61df9fd96924b36
View file https://github.com/simstudioai/sim/blob/8e6b763f7a1465f4ea4fed2286fcc31f1c622c5f/apps/sim/lib/uploads/documents/references.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9023/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9023/files#diff-1b40514c1e221fb3ce6b63520d5c1c7246704e2233916251d61df9fd96924b36
https://github.com/simstudioai/sim/pull/9023/files#diff-1b40514c1e221fb3ce6b63520d5c1c7246704e2233916251d61df9fd96924b36
https://github.com/simstudioai/sim/pull/9023/files#diff-1b40514c1e221fb3ce6b63520d5c1c7246704e2233916251d61df9fd96924b36
https://github.com/simstudioai/sim/pull/9023/files#diff-1b40514c1e221fb3ce6b63520d5c1c7246704e2233916251d61df9fd96924b36
https://github.com/simstudioai/sim/pull/9023/files#diff-1b40514c1e221fb3ce6b63520d5c1c7246704e2233916251d61df9fd96924b36
https://github.com/simstudioai/sim/pull/9023/files#diff-1b40514c1e221fb3ce6b63520d5c1c7246704e2233916251d61df9fd96924b36
https://github.com/simstudioai/sim/pull/9023/files#diff-1b40514c1e221fb3ce6b63520d5c1c7246704e2233916251d61df9fd96924b36
apps/sim/lib/workspace-files/application/fetch-servable-workspace-file-buffer.tshttps://github.com/simstudioai/sim/pull/9023/files#diff-8537ecd85bff6bad9fb8be7bfd3e7b5c68f39d8f522b812914156e11bf7884e4
View file https://github.com/simstudioai/sim/blob/8e6b763f7a1465f4ea4fed2286fcc31f1c622c5f/apps/sim/lib/workspace-files/application/fetch-servable-workspace-file-buffer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9023/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9023/files#diff-8537ecd85bff6bad9fb8be7bfd3e7b5c68f39d8f522b812914156e11bf7884e4
https://github.com/simstudioai/sim/pull/9023/files#diff-8537ecd85bff6bad9fb8be7bfd3e7b5c68f39d8f522b812914156e11bf7884e4
https://github.com/simstudioai/sim/pull/9023/files#diff-8537ecd85bff6bad9fb8be7bfd3e7b5c68f39d8f522b812914156e11bf7884e4
Please reload this pagehttps://github.com/simstudioai/sim/pull/9023/files
apps/sim/lib/workspace-files/application/search-workspace-file-content.test.tshttps://github.com/simstudioai/sim/pull/9023/files#diff-ce2e108d023d41c53260bdf4c0ea74371875464222a9f1d10eace5ff5c37c2a4
View file https://github.com/simstudioai/sim/blob/8e6b763f7a1465f4ea4fed2286fcc31f1c622c5f/apps/sim/lib/workspace-files/application/search-workspace-file-content.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9023/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9023/files#diff-ce2e108d023d41c53260bdf4c0ea74371875464222a9f1d10eace5ff5c37c2a4
https://github.com/simstudioai/sim/pull/9023/files#diff-ce2e108d023d41c53260bdf4c0ea74371875464222a9f1d10eace5ff5c37c2a4
apps/sim/lib/workspace-files/application/search-workspace-file-content.tshttps://github.com/simstudioai/sim/pull/9023/files#diff-14912de00a65e52eb46d81b39b5db4953774151f7d419cea798f619612cd7e6e
View file https://github.com/simstudioai/sim/blob/8e6b763f7a1465f4ea4fed2286fcc31f1c622c5f/apps/sim/lib/workspace-files/application/search-workspace-file-content.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9023/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9023/files#diff-14912de00a65e52eb46d81b39b5db4953774151f7d419cea798f619612cd7e6e
https://github.com/simstudioai/sim/pull/9023/files#diff-14912de00a65e52eb46d81b39b5db4953774151f7d419cea798f619612cd7e6e
https://github.com/simstudioai/sim/pull/9023/files#diff-14912de00a65e52eb46d81b39b5db4953774151f7d419cea798f619612cd7e6e
https://github.com/simstudioai/sim/pull/9023/files#diff-14912de00a65e52eb46d81b39b5db4953774151f7d419cea798f619612cd7e6e
apps/sim/lib/workspace-files/search/artifact-ready.tshttps://github.com/simstudioai/sim/pull/9023/files#diff-733f0be20894a7e9403d000d38a09d0a433dbc058b7d751620742f836db48c5d
View file https://github.com/simstudioai/sim/blob/8e6b763f7a1465f4ea4fed2286fcc31f1c622c5f/apps/sim/lib/workspace-files/search/artifact-ready.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9023/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9023/files#diff-733f0be20894a7e9403d000d38a09d0a433dbc058b7d751620742f836db48c5d
https://github.com/simstudioai/sim/pull/9023/files#diff-733f0be20894a7e9403d000d38a09d0a433dbc058b7d751620742f836db48c5d
https://github.com/simstudioai/sim/pull/9023/files#diff-733f0be20894a7e9403d000d38a09d0a433dbc058b7d751620742f836db48c5d
apps/sim/lib/workspace-files/search/constants.tshttps://github.com/simstudioai/sim/pull/9023/files#diff-25abdafbc319ad195e37055eeebf63e23f0a8d6294ed87fbb6726afb3496a9eb
View file https://github.com/simstudioai/sim/blob/8e6b763f7a1465f4ea4fed2286fcc31f1c622c5f/apps/sim/lib/workspace-files/search/constants.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9023/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9023/files#diff-25abdafbc319ad195e37055eeebf63e23f0a8d6294ed87fbb6726afb3496a9eb
https://github.com/simstudioai/sim/pull/9023/files#diff-25abdafbc319ad195e37055eeebf63e23f0a8d6294ed87fbb6726afb3496a9eb
Please reload this pagehttps://github.com/simstudioai/sim/pull/9023/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.