René's URL Explorer Experiment


Title: fix(slack): serialize Search bot removal with member setup, refuse a custom row on the shared app ID by waleedlatif1 · Pull Request #8993 · simstudioai/sim · GitHub

Open Graph Title: fix(slack): serialize Search bot removal with member setup, refuse a custom row on the shared app ID by waleedlatif1 · Pull Request #8993 · simstudioai/sim

X Title: fix(slack): serialize Search bot removal with member setup, refuse a custom row on the shared app ID by waleedlatif1 · Pull Request #8993 · simstudioai/sim

Description: Summary Addresses review findings on the v0.9.21 release PR (#8989) for the Slack member-accounts work (#8979, #8986). removeSlackSearchInstallation now runs in a transaction that takes lockOrganizationSlackApp, so an admin removing a Search bot serializes with in-flight member Slack setup like every other Slack Search installation write A custom slack_app row holding the shared app's ID is refused at member setup start (before OAuth, so the admin sees "This Slack app belongs to another installation owner."), and completion's existing FOR UPDATE read throws a conflict for one created mid-authorization. Previously member setup also refused, but late and as an unclassified error / generic popup failure; bot setup already had its own pre-check. ensureSharedSlackAppRow stays ON CONFLICT DO NOTHING Lock TSDoc states the contract precisely: Slack revocations (must never wait on setup, and would invert lock order) and the bot-credential delete cascade skip it — they only withdraw a bot, which member setup tolerates Changelog empty state: drop the last earlier release, whose notes sat below the 148px viewBox and whose heading only grazed the bottom edge inside the fade's fully transparent end; render is unchanged and the graphic keeps its siblings' 148px height Type of Change Bug fix Testing slack-shared-member-accounts.integration.ts (real Postgres/Redis): removal waits on the Slack organization lock; member setup refuses a custom row holding the shared app ID at start and (asserting code: 'conflict') at completion, writing nothing; both lock-contention cases share one whileOrganizationSlackAppLocked helper whose barrier is scoped to backends waiting on that lock Targeted suites: slack-search, credential-groups, slack-search lib, knowledge Slack and credential-group routes, resource empty states, credentials (813 tests) biome on changed files; check:api-validation:strict, check:comment-hygiene, check:test-patterns, check:boundaries, check:utils Full type-check, check:audits, and integration run in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) 🤖 Generated with Claude Code

Open Graph Description: Summary Addresses review findings on the v0.9.21 release PR (#8989) for the Slack member-accounts work (#8979, #8986). removeSlackSearchInstallation now runs in a transaction that takes lockOrgani...

X Description: Summary Addresses review findings on the v0.9.21 release PR (#8989) for the Slack member-accounts work (#8979, #8986). removeSlackSearchInstallation now runs in a transaction that takes lockOrgani...

Opengraph URL: https://github.com/simstudioai/sim/pull/8993

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:40457e58-4623-0518-eb96-be97a6138795
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD758:1CB508:7CA441:B1611B:6AFB4C81
html-safe-noncee32ef68d32a675ce657fbb2c646bc2c8c4dc71bac53b51c949f03c785a8df440
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzU4OjFDQjUwODo3Q0E0NDE6QjE2MTFCOjZBRkI0QzgxIiwidmlzaXRvcl9pZCI6IjQ5NjcyOTMwNDcyODk4OTE5NjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6df2ce653989564cd41765d684a56ed9d7342ee5fb2a5f1e9330b371beb402a7
hovercard-subject-tagpull_request:4849809852
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8993/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Addresses review findings on the v0.9.21 release PR (#8989) for the Slack member-accounts work (#8979, #8986). removeSlackSearchInstallation now runs in a transaction that takes lockOrgani...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8993/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8993%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8993%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8993/files
Reloadhttps://github.com/simstudioai/sim/pull/8993/files
Reloadhttps://github.com/simstudioai/sim/pull/8993/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/slack-installation-lock-coveragehttps://github.com/simstudioai/sim/tree/fix/slack-installation-lock-coverage
Conversation 18 https://github.com/simstudioai/sim/pull/8993
Commits 2 https://github.com/simstudioai/sim/pull/8993/commits
Checks 52 https://github.com/simstudioai/sim/pull/8993/checks
Files changed https://github.com/simstudioai/sim/pull/8993/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8993/files
fix(slack): serialize Search bot removal with member setup, refuse a custom row on the shared app ID https://github.com/simstudioai/sim/pull/8993/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/8993/files
52a3386 fix(slack): serialize Search bot removal with member setup, refuse a … waleedlatif1 Oct 13, 2026 https://github.com/simstudioai/sim/pull/8993/commits/52a3386f29efdf2326e42dccf25ed1e6d974e9c5
4f3afe7 fix(slack): refuse a custom shared-app row at setup start, scope lock… waleedlatif1 Oct 13, 2026 https://github.com/simstudioai/sim/pull/8993/commits/4f3afe701caeb250e3e3161c0bf0ff1de3f87c6c
Clear filters https://github.com/simstudioai/sim/pull/8993/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8993/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8993/files
changelog-empty-state.tsx https://github.com/simstudioai/sim/pull/8993/files#diff-5a60ada02adffaed1e223d78a8c0187cb06727b424e996ef2d287bb1f2372ae9
slack-shared-member-accounts.integration.ts https://github.com/simstudioai/sim/pull/8993/files#diff-92c2f89c9970ca894df1ef5fb70b484b81e1d1af90726134f9e117d29940e364
organization-slack-app.ts https://github.com/simstudioai/sim/pull/8993/files#diff-0917f381fba2d60f62490c7b6ac55179a33bb78bb38fe5e89fce2eebfca99ed2
slack-managed-users.ts https://github.com/simstudioai/sim/pull/8993/files#diff-220df4c221b1a1e3a42f13c2c088342c19411d0bc11d1fdac52285f4aca87bdc
installations.ts https://github.com/simstudioai/sim/pull/8993/files#diff-ba1cf3350011fe297d4c9faeb46d268af15a9f8da2a1d341adc90bf158a6006f
...orkspaceId]/components/resource/components/resource-empty-state/changelog-empty-state.tsxhttps://github.com/simstudioai/sim/pull/8993/files#diff-5a60ada02adffaed1e223d78a8c0187cb06727b424e996ef2d287bb1f2372ae9
View file https://github.com/simstudioai/sim/blob/4f3afe701caeb250e3e3161c0bf0ff1de3f87c6c/apps/sim/app/workspace/%5BworkspaceId%5D/components/resource/components/resource-empty-state/changelog-empty-state.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8993/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8993/files#diff-5a60ada02adffaed1e223d78a8c0187cb06727b424e996ef2d287bb1f2372ae9
Please reload this pagehttps://github.com/simstudioai/sim/pull/8993/files
https://github.com/simstudioai/sim/pull/8993/files#diff-5a60ada02adffaed1e223d78a8c0187cb06727b424e996ef2d287bb1f2372ae9
https://github.com/simstudioai/sim/pull/8993/files#diff-5a60ada02adffaed1e223d78a8c0187cb06727b424e996ef2d287bb1f2372ae9
https://github.com/simstudioai/sim/pull/8993/files#diff-5a60ada02adffaed1e223d78a8c0187cb06727b424e996ef2d287bb1f2372ae9
apps/sim/lib/credential-groups/__integration__/slack-shared-member-accounts.integration.tshttps://github.com/simstudioai/sim/pull/8993/files#diff-92c2f89c9970ca894df1ef5fb70b484b81e1d1af90726134f9e117d29940e364
View file https://github.com/simstudioai/sim/blob/4f3afe701caeb250e3e3161c0bf0ff1de3f87c6c/apps/sim/lib/credential-groups/__integration__/slack-shared-member-accounts.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8993/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8993/files#diff-92c2f89c9970ca894df1ef5fb70b484b81e1d1af90726134f9e117d29940e364
https://github.com/simstudioai/sim/pull/8993/files#diff-92c2f89c9970ca894df1ef5fb70b484b81e1d1af90726134f9e117d29940e364
https://github.com/simstudioai/sim/pull/8993/files#diff-92c2f89c9970ca894df1ef5fb70b484b81e1d1af90726134f9e117d29940e364
https://github.com/simstudioai/sim/pull/8993/files#diff-92c2f89c9970ca894df1ef5fb70b484b81e1d1af90726134f9e117d29940e364
https://github.com/simstudioai/sim/pull/8993/files#diff-92c2f89c9970ca894df1ef5fb70b484b81e1d1af90726134f9e117d29940e364
https://github.com/simstudioai/sim/pull/8993/files#diff-92c2f89c9970ca894df1ef5fb70b484b81e1d1af90726134f9e117d29940e364
https://github.com/simstudioai/sim/pull/8993/files#diff-92c2f89c9970ca894df1ef5fb70b484b81e1d1af90726134f9e117d29940e364
https://github.com/simstudioai/sim/pull/8993/files#diff-92c2f89c9970ca894df1ef5fb70b484b81e1d1af90726134f9e117d29940e364
apps/sim/lib/credential-groups/organization-slack-app.tshttps://github.com/simstudioai/sim/pull/8993/files#diff-0917f381fba2d60f62490c7b6ac55179a33bb78bb38fe5e89fce2eebfca99ed2
View file https://github.com/simstudioai/sim/blob/4f3afe701caeb250e3e3161c0bf0ff1de3f87c6c/apps/sim/lib/credential-groups/organization-slack-app.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8993/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8993/files#diff-0917f381fba2d60f62490c7b6ac55179a33bb78bb38fe5e89fce2eebfca99ed2
https://github.com/simstudioai/sim/pull/8993/files#diff-0917f381fba2d60f62490c7b6ac55179a33bb78bb38fe5e89fce2eebfca99ed2
apps/sim/lib/credential-groups/slack-managed-users.tshttps://github.com/simstudioai/sim/pull/8993/files#diff-220df4c221b1a1e3a42f13c2c088342c19411d0bc11d1fdac52285f4aca87bdc
View file https://github.com/simstudioai/sim/blob/4f3afe701caeb250e3e3161c0bf0ff1de3f87c6c/apps/sim/lib/credential-groups/slack-managed-users.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8993/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8993/files#diff-220df4c221b1a1e3a42f13c2c088342c19411d0bc11d1fdac52285f4aca87bdc
https://github.com/simstudioai/sim/pull/8993/files#diff-220df4c221b1a1e3a42f13c2c088342c19411d0bc11d1fdac52285f4aca87bdc
https://github.com/simstudioai/sim/pull/8993/files#diff-220df4c221b1a1e3a42f13c2c088342c19411d0bc11d1fdac52285f4aca87bdc
https://github.com/simstudioai/sim/pull/8993/files#diff-220df4c221b1a1e3a42f13c2c088342c19411d0bc11d1fdac52285f4aca87bdc
https://github.com/simstudioai/sim/pull/8993/files#diff-220df4c221b1a1e3a42f13c2c088342c19411d0bc11d1fdac52285f4aca87bdc
https://github.com/simstudioai/sim/pull/8993/files#diff-220df4c221b1a1e3a42f13c2c088342c19411d0bc11d1fdac52285f4aca87bdc
https://github.com/simstudioai/sim/pull/8993/files#diff-220df4c221b1a1e3a42f13c2c088342c19411d0bc11d1fdac52285f4aca87bdc
https://github.com/simstudioai/sim/pull/8993/files#diff-220df4c221b1a1e3a42f13c2c088342c19411d0bc11d1fdac52285f4aca87bdc
apps/sim/lib/knowledge/application/slack-search/installations.tshttps://github.com/simstudioai/sim/pull/8993/files#diff-ba1cf3350011fe297d4c9faeb46d268af15a9f8da2a1d341adc90bf158a6006f
View file https://github.com/simstudioai/sim/blob/4f3afe701caeb250e3e3161c0bf0ff1de3f87c6c/apps/sim/lib/knowledge/application/slack-search/installations.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8993/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8993/files#diff-ba1cf3350011fe297d4c9faeb46d268af15a9f8da2a1d341adc90bf158a6006f
https://github.com/simstudioai/sim/pull/8993/files#diff-ba1cf3350011fe297d4c9faeb46d268af15a9f8da2a1d341adc90bf158a6006f
Please reload this pagehttps://github.com/simstudioai/sim/pull/8993/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.