Title: improvement(logs): group dashboard stats by workflow id and join names once per group by waleedlatif1 · Pull Request #8973 · simstudioai/sim · GitHub
Open Graph Title: improvement(logs): group dashboard stats by workflow id and join names once per group by waleedlatif1 · Pull Request #8973 · simstudioai/sim
X Title: improvement(logs): group dashboard stats by workflow id and join names once per group by waleedlatif1 · Pull Request #8973 · simstudioai/sim
Description: Summary Dashboard stats segments now aggregate by the log's own workflow_id (plus the bucket) in a subquery instead of grouping by (COALESCE(workflow_id), COALESCE(workflow.name)), then LEFT JOIN workflow once per grouped row for COALESCE(workflow.name, 'Deleted Workflow') in the outer select. One statement, one snapshot, no batching, and the group key no longer carries name text The aggregate keeps its existing LEFT JOIN to workflow so folder/workflow/name filters keep working. Postgres 17 removes that join when no filter references workflow (it is on the PK and nothing else reads it), so no per-row workflow probe remains in the aggregate in the common case Output stays byte-identical: null workflow_id rows still collapse into deleted / Deleted Workflow, a workflow id with no row gets the same label, and the MAX_STATS_WORKFLOWS cut and its name tie-break are unchanged The main p99 gain comes together with the covering index in #8971 (which lets the aggregate stay index-only); on its own, this PR removes the name from the group key and does the name join once per group rather than once per log row readLogStatsBounds and the "All time" default are unchanged Type of Change Improvement (performance) Testing New lib/logs/stats-queries.integration.ts runs the old query verbatim as an oracle against the new read on seeded data, and compares both the raw rows and the buildDashboardStats output (capped and uncapped): 14 dashboard-route filter combinations: level, workflow ids, folder ids, workflow name, folder name, triggers, the all sentinel, date range, cost, duration, execution search, and a combined folder+trigger+level+date case 9 v2 cases: workflow ids, name, level, statuses, cost range, root scope, folder subtree, empty scope the handled-error count a hard-deleted workflow plus runs whose workflow id was never recorded MAX_STATS_WORKFLOWS + 5 workflows, most tied on error rate, so the cut falls inside a name-ordered tie Biome on changed files. Plain EXPLAIN (synthetic params): unfiltered, the aggregate scans only the log index and workflow appears once, as a workflow_pkey probe per grouped row; with a folder filter the join stays inside the aggregate as expected Type-check, audits, and the integration suite run in CI (not run locally) Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Dashboard stats segments now aggregate by the log's own workflow_id (plus the bucket) in a subquery instead of grouping by (COALESCE(workflow_id), COALESCE(workflow.name)), then LEFT J...
X Description: Summary Dashboard stats segments now aggregate by the log's own workflow_id (plus the bucket) in a subquery instead of grouping by (COALESCE(workflow_id), COALESCE(workflow.name)), then LE...
Opengraph URL: https://github.com/simstudioai/sim/pull/8973
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:961756c9-5bcd-9e8d-8cac-e644b35cfd5f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CBE2:3BD2EB:21AA3E:2F38D2:6AFB511F |
| html-safe-nonce | 3ba3d686cd4e472665d89e0492ec7f238b8c5445e1134843530a1687e6331e38 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQkUyOjNCRDJFQjoyMUFBM0U6MkYzOEQyOjZBRkI1MTFGIiwidmlzaXRvcl9pZCI6IjM4NjEyNjkyNTY5NTU3MTE3NzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d333fdfa991663d8819ec080f7167a386f8c95028af0321866a2fe435e09bf87 |
| hovercard-subject-tag | pull_request:4847625666 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8973/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Dashboard stats segments now aggregate by the log's own workflow_id (plus the bucket) in a subquery instead of grouping by (COALESCE(workflow_id), COALESCE(workflow.name)), then LEFT J... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width