René's URL Explorer Experiment


Title: improvement(db): disable fastupdate on the table-rows GIN and cover level in the logs activity index by waleedlatif1 · Pull Request #8971 · simstudioai/sim · GitHub

Open Graph Title: improvement(db): disable fastupdate on the table-rows GIN and cover level in the logs activity index by waleedlatif1 · Pull Request #8971 · simstudioai/sim

X Title: improvement(db): disable fastupdate on the table-rows GIN and cover level in the logs activity index by waleedlatif1 · Pull Request #8971 · simstudioai/sim

Description: Summary user_table_rows_tenant_data_gin_idx: SET (fastupdate = off), then COMMIT and a one-time gin_clean_pending_list under a 5min statement_timeout. Row writers were queuing on the GIN metapage ExclusiveLock (up to 4.3 s) while another writer merged the pending list in the foreground. Same pattern and lock handling as 0410 (emb_content_fts_idx). Replaces workflow_execution_logs_workspace_activity_idx with workflow_execution_logs_workspace_activity_level_idx: identical key columns in identical order plus a trailing level. Built CONCURRENTLY first, old one dropped CONCURRENTLY after, so the index count is unchanged (no added write amplification). Why: the logs stats read (lib/logs/stats-queries.ts) filters and counts on level, which the activity index lacks, so today it plans a plain index scan on workspace_started_at_idx and heap-fetches every run in the window (plain EXPLAIN on prod for a large workspace, 30-day window). The heap is fully all-visible, so with level covered every column the stats read touches (workspace_id, started_at, level, total_duration_ms, workflow_id, plus trigger filters) is in one index and it can go index-only. That holds for the current query and for a version that groups by workflow_id without joining workflow. level is a trailing key column rather than INCLUDE: drizzle 0.45 cannot express INCLUDE, and as a trailing key it is still a strict key-prefix superset (suffix truncation keeps it out of internal pages). schema.ts mirrors both; drizzle-kit generate reports no changes afterwards. No app code changes. Who else uses the old index lib/billing/core/organization-activity-queries.ts (org activity series and breakdowns, the reason for 0355) reads only workspace_id, started_at, status, total_duration_ms, workflow_id, trigger. Those are the same leading keys in the new index, so every index-only scan it gets today it still gets. No code references the index by name. Failure modes Replay: a failed run replays unjournaled files from the top. ALTER INDEX ... SET and gin_clean_pending_list are idempotent. The new index is DROP ... IF EXISTS then CREATE ... IF NOT EXISTS; the old drop is IF EXISTS. If a crash lands after the old drop but before the journal row, replay rebuilds the new index and activity reads fall back to workspace_started_at_idx (slower, still correct) for the build duration. Interrupted concurrent build: it leaves an INVALID ..._activity_level_idx that IF NOT EXISTS would skip forever; the preceding DROP INDEX CONCURRENTLY IF EXISTS clears it. The old index is only dropped after the new build succeeds, so a failed build never leaves the table without one. lock_timeout: ALTER INDEX runs inside the migration transaction under the runner's 5s lock_timeout with its retry budget. The concurrent build/drop run under lock_timeout = 0 (they wait for older transactions, not block writers), then reset to 5s. statement_timeout is 0 for the build per migrate.ts. Blue/green with old app code: nothing depends on index names, and no query shape changes. Old and new app versions plan against the same key columns. Build cost: the build reads the whole table twice and writes a full index's worth of WAL under sync-rep, like 0355 did for the index it replaces. Disk peaks at both indexes for the build duration. fastupdate off: each GIN insert now updates the index directly instead of appending to the pending list, so per-row write cost is steadier but slightly higher on bulk imports. That is the trade 0410 already made for emb_content_fts_idx. Type of Change Performance improvement Testing check:migrations against origin/staging: passes drizzle-kit generate after the migration: "No schema changes" Prod catalog: confirmed current definitions of both indexes, and that the existing stats plan does not use the activity index (plain EXPLAIN only) Biome on changed files Not verified: the post-swap plan (read-only access cannot create a hypothetical index), and the migration against a local DB Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary user_table_rows_tenant_data_gin_idx: SET (fastupdate = off), then COMMIT and a one-time gin_clean_pending_list under a 5min statement_timeout. Row writers were queuing on the GIN metapage ...

X Description: Summary user_table_rows_tenant_data_gin_idx: SET (fastupdate = off), then COMMIT and a one-time gin_clean_pending_list under a 5min statement_timeout. Row writers were queuing on the GIN metapage ...

Opengraph URL: https://github.com/simstudioai/sim/pull/8971

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b8b0b377-1352-2e7b-c806-4b834bb2538c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCBD6:38C411:220B61:2FC758:6AFB511E
html-safe-nonce793cd4bbeaf169ce50924379cdb4b50f3167f2d8f19312ce5285fd0425232747
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQkQ2OjM4QzQxMToyMjBCNjE6MkZDNzU4OjZBRkI1MTFFIiwidmlzaXRvcl9pZCI6IjE4MzYzODkyMjE0MDEzMTc2NjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac55b637e3b82f20e85b04dbc770a736588fcb322437e7975298da9e2af7b157dd
hovercard-subject-tagpull_request:4847603955
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8971/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary user_table_rows_tenant_data_gin_idx: SET (fastupdate = off), then COMMIT and a one-time gin_clean_pending_list under a 5min statement_timeout. Row writers were queuing on the GIN metapage ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8971/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8971%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8971%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8971/files
Reloadhttps://github.com/simstudioai/sim/pull/8971/files
Reloadhttps://github.com/simstudioai/sim/pull/8971/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
perf/db-index-0411https://github.com/simstudioai/sim/tree/perf/db-index-0411
Conversation 8 https://github.com/simstudioai/sim/pull/8971
Commits 2 https://github.com/simstudioai/sim/pull/8971/commits
Checks 50 https://github.com/simstudioai/sim/pull/8971/checks
Files changed https://github.com/simstudioai/sim/pull/8971/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8971/files
improvement(db): disable fastupdate on the table-rows GIN and cover level in the logs activity index https://github.com/simstudioai/sim/pull/8971/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/8971/files
ee0cced improvement(db): disable fastupdate on the table-rows GIN and cover l… waleedlatif1 Oct 13, 2026 https://github.com/simstudioai/sim/pull/8971/commits/ee0ccedd4dd520830bef451baa9c423afaa29858
6f7e8f2 fix(db): keep a valid replacement index when replaying migration 0413 waleedlatif1 Oct 13, 2026 https://github.com/simstudioai/sim/pull/8971/commits/6f7e8f24ef32b30f44f1fb41f67dcf4c2e96f6bf
Clear filters https://github.com/simstudioai/sim/pull/8971/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8971/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8971/files
0413_workspace_activity_level_gin_fastupdate.sql https://github.com/simstudioai/sim/pull/8971/files#diff-7d4edbba4178f077522aff6504cceb16652b3047e2c5374ac002b776090b7e4f
0413_snapshot.json https://github.com/simstudioai/sim/pull/8971/files#diff-b8182e1a2d0c89953a82dfe095288fda11181e5915343d8db0bb448bc28e05dc
_journal.json https://github.com/simstudioai/sim/pull/8971/files#diff-37150cc65ad16ee6fbc5fa318fc096be7730e16d63eaf863e3df5521b7030649
schema.ts https://github.com/simstudioai/sim/pull/8971/files#diff-9a959e2ce3cb4c86957bbae021d06eae364f7b0cb18964f5873bab53220af928
packages/db/migrations/0413_workspace_activity_level_gin_fastupdate.sqlhttps://github.com/simstudioai/sim/pull/8971/files#diff-7d4edbba4178f077522aff6504cceb16652b3047e2c5374ac002b776090b7e4f
View file https://github.com/simstudioai/sim/blob/6f7e8f24ef32b30f44f1fb41f67dcf4c2e96f6bf/packages/db/migrations/0413_workspace_activity_level_gin_fastupdate.sql
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8971/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/8971/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8971/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.