René's URL Explorer Experiment


Title: fix(knowledge): bill Gemini spend for image reads that fail the pass by waleedlatif1 · Pull Request #8967 · simstudioai/sim · GitHub

Open Graph Title: fix(knowledge): bill Gemini spend for image reads that fail the pass by waleedlatif1 · Pull Request #8967 · simstudioai/sim

X Title: fix(knowledge): bill Gemini spend for image reads that fail the pass by waleedlatif1 · Pull Request #8967 · simstudioai/sim

Description: Summary Gemini bills every image-extraction reply, but vision spend was recorded only after a pass committed. A reply cut off at the token limit, a non-STOP or schema-invalid reply, repeated malformed JSON, a deferral after a billed reply, and a pass that failed later (chunk limit, embeddings) or was superseded after extraction all went unbilled extractImageText now reports spend through onUsage from a finally, so failure paths report too. processDocumentAsync records each charge as it is reported and awaits it before the pass settles Each extraction run that calls Gemini mints a chargeId, stored in the vision checkpoint. The usage key is knowledge-document-vision::. A resumed pass replays the checkpointed charge and dedupes on the unique event key, while a run that really called Gemini again bills its own spend. The old per-pass key would have dropped every charge after the first in a pass BYOK calls still cost 0 and record nothing. The embedding charge and its key are unchanged The restore guard originally in this PR was superseded by #8965 Type of Change Bug fix Testing image-extraction.test.ts: spend is reported when retries are exhausted, none for throttling, and checkpoint replay keeps the same chargeId document-indexing-usage.test.ts: a pass whose embeddings fail after extraction still writes exactly one vision usage row confluence-images.integration.ts: the real extractor gets a reply cut off at the token limit, and the document fails with exactly one billed usage_log row /simplify, /cleanup (comment and test-audit passes), and an independent review; biome check. Type-check, audits, and the suites run in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Gemini bills every image-extraction reply, but vision spend was recorded only after a pass committed. A reply cut off at the token limit, a non-STOP or schema-invalid reply, repeated malfo...

X Description: Summary Gemini bills every image-extraction reply, but vision spend was recorded only after a pass committed. A reply cut off at the token limit, a non-STOP or schema-invalid reply, repeated malfo...

Opengraph URL: https://github.com/simstudioai/sim/pull/8967

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:bfcc789c-8c9b-795e-5d60-b797601cc0f4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB610:1FFEE4:8E0A65:C9B4FC:6AFB5072
html-safe-noncead5c41fd02bce2df0faa506ebe04064c65672b6bc17b127dd3940695d2df8e7b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjEwOjFGRkVFNDo4RTBBNjU6QzlCNEZDOjZBRkI1MDcyIiwidmlzaXRvcl9pZCI6Ijg4MjA0MDU1NDUzNzUzMjIyMjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5fbb40f98eed7ed0b956cee3e1c5278971644a33de5072c7f37403d40b5b2a21
hovercard-subject-tagpull_request:4839175397
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8967/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Gemini bills every image-extraction reply, but vision spend was recorded only after a pass committed. A reply cut off at the token limit, a non-STOP or schema-invalid reply, repeated malfo...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8967/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8967%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8967%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8967/files
Reloadhttps://github.com/simstudioai/sim/pull/8967/files
Reloadhttps://github.com/simstudioai/sim/pull/8967/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/kb-image-billing-restorehttps://github.com/simstudioai/sim/tree/fix/kb-image-billing-restore
Conversation 22 https://github.com/simstudioai/sim/pull/8967
Commits 1 https://github.com/simstudioai/sim/pull/8967/commits
Checks 51 https://github.com/simstudioai/sim/pull/8967/checks
Files changed https://github.com/simstudioai/sim/pull/8967/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8967/files
fix(knowledge): bill Gemini spend for image reads that fail the pass https://github.com/simstudioai/sim/pull/8967/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/8967/files
0edee67 fix(knowledge): bill Gemini spend for image reads that fail the pass waleedlatif1 Oct 13, 2026 https://github.com/simstudioai/sim/pull/8967/commits/0edee67a1b4cc87d01097f5bb86a3053b8cf5be4
Clear filters https://github.com/simstudioai/sim/pull/8967/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8967/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8967/files
confluence-images.integration.ts https://github.com/simstudioai/sim/pull/8967/files#diff-535e9beb0216aa2769f62608da90bf9368e450a18ad16958010a10ab0f0dc76d
document-indexing-usage.test.ts https://github.com/simstudioai/sim/pull/8967/files#diff-ff4ae625d37edbdfb8ea953b69b76e91faa6761157ff50400a5242c5ef120577
document-processing-source.test.ts https://github.com/simstudioai/sim/pull/8967/files#diff-5b6e93417c23c69dd607283ad630cf19fce90751f3480053378e133760b97633
document-processor.ts https://github.com/simstudioai/sim/pull/8967/files#diff-caef18c7f5680f8ad0ec1e40b90e7635fe8f182b55d4fd20ef78fbe881f11205
image-document-routing.test.ts https://github.com/simstudioai/sim/pull/8967/files#diff-75adda4b407135ec6b5ac3825a8a9b40979908210a9b996f04be0659528df442
image-extraction.test.ts https://github.com/simstudioai/sim/pull/8967/files#diff-a4f2218ec7440e32ba8b16b8bcc2d74ff697da4a3eb3e4080d6142d26cabc12d
image-extraction.ts https://github.com/simstudioai/sim/pull/8967/files#diff-2a9925881510c65e31961483782c7ca11941af6e41ba95d99f41b3c3e7ea6396
service.ts https://github.com/simstudioai/sim/pull/8967/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
vision-checkpoints.test.ts https://github.com/simstudioai/sim/pull/8967/files#diff-0afd606e4236feef9562f76b8f50f793bbfbca7eb503251bcddbf97620d2592b
vision-checkpoints.ts https://github.com/simstudioai/sim/pull/8967/files#diff-ad9c6ac44eb47033d4b433e8ebd00580772dd89a634f976f70f9ccb5af56faf1
apps/sim/lib/knowledge/__integration__/confluence-images.integration.tshttps://github.com/simstudioai/sim/pull/8967/files#diff-535e9beb0216aa2769f62608da90bf9368e450a18ad16958010a10ab0f0dc76d
View file https://github.com/simstudioai/sim/blob/0edee67a1b4cc87d01097f5bb86a3053b8cf5be4/apps/sim/lib/knowledge/__integration__/confluence-images.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8967/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8967/files#diff-535e9beb0216aa2769f62608da90bf9368e450a18ad16958010a10ab0f0dc76d
https://github.com/simstudioai/sim/pull/8967/files#diff-535e9beb0216aa2769f62608da90bf9368e450a18ad16958010a10ab0f0dc76d
https://github.com/simstudioai/sim/pull/8967/files#diff-535e9beb0216aa2769f62608da90bf9368e450a18ad16958010a10ab0f0dc76d
https://github.com/simstudioai/sim/pull/8967/files#diff-535e9beb0216aa2769f62608da90bf9368e450a18ad16958010a10ab0f0dc76d
https://github.com/simstudioai/sim/pull/8967/files#diff-535e9beb0216aa2769f62608da90bf9368e450a18ad16958010a10ab0f0dc76d
https://github.com/simstudioai/sim/pull/8967/files#diff-535e9beb0216aa2769f62608da90bf9368e450a18ad16958010a10ab0f0dc76d
https://github.com/simstudioai/sim/pull/8967/files#diff-535e9beb0216aa2769f62608da90bf9368e450a18ad16958010a10ab0f0dc76d
https://github.com/simstudioai/sim/pull/8967/files#diff-535e9beb0216aa2769f62608da90bf9368e450a18ad16958010a10ab0f0dc76d
https://github.com/simstudioai/sim/pull/8967/files#diff-535e9beb0216aa2769f62608da90bf9368e450a18ad16958010a10ab0f0dc76d
https://github.com/simstudioai/sim/pull/8967/files#diff-535e9beb0216aa2769f62608da90bf9368e450a18ad16958010a10ab0f0dc76d
https://github.com/simstudioai/sim/pull/8967/files#diff-535e9beb0216aa2769f62608da90bf9368e450a18ad16958010a10ab0f0dc76d
https://github.com/simstudioai/sim/pull/8967/files#diff-535e9beb0216aa2769f62608da90bf9368e450a18ad16958010a10ab0f0dc76d
https://github.com/simstudioai/sim/pull/8967/files#diff-535e9beb0216aa2769f62608da90bf9368e450a18ad16958010a10ab0f0dc76d
https://github.com/simstudioai/sim/pull/8967/files#diff-535e9beb0216aa2769f62608da90bf9368e450a18ad16958010a10ab0f0dc76d
https://github.com/simstudioai/sim/pull/8967/files#diff-535e9beb0216aa2769f62608da90bf9368e450a18ad16958010a10ab0f0dc76d
apps/sim/lib/knowledge/documents/document-indexing-usage.test.tshttps://github.com/simstudioai/sim/pull/8967/files#diff-ff4ae625d37edbdfb8ea953b69b76e91faa6761157ff50400a5242c5ef120577
View file https://github.com/simstudioai/sim/blob/0edee67a1b4cc87d01097f5bb86a3053b8cf5be4/apps/sim/lib/knowledge/documents/document-indexing-usage.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8967/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8967/files#diff-ff4ae625d37edbdfb8ea953b69b76e91faa6761157ff50400a5242c5ef120577
https://github.com/simstudioai/sim/pull/8967/files#diff-ff4ae625d37edbdfb8ea953b69b76e91faa6761157ff50400a5242c5ef120577
https://github.com/simstudioai/sim/pull/8967/files#diff-ff4ae625d37edbdfb8ea953b69b76e91faa6761157ff50400a5242c5ef120577
https://github.com/simstudioai/sim/pull/8967/files#diff-ff4ae625d37edbdfb8ea953b69b76e91faa6761157ff50400a5242c5ef120577
https://github.com/simstudioai/sim/pull/8967/files#diff-ff4ae625d37edbdfb8ea953b69b76e91faa6761157ff50400a5242c5ef120577
apps/sim/lib/knowledge/documents/document-processing-source.test.tshttps://github.com/simstudioai/sim/pull/8967/files#diff-5b6e93417c23c69dd607283ad630cf19fce90751f3480053378e133760b97633
View file https://github.com/simstudioai/sim/blob/0edee67a1b4cc87d01097f5bb86a3053b8cf5be4/apps/sim/lib/knowledge/documents/document-processing-source.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8967/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8967/files#diff-5b6e93417c23c69dd607283ad630cf19fce90751f3480053378e133760b97633
https://github.com/simstudioai/sim/pull/8967/files#diff-5b6e93417c23c69dd607283ad630cf19fce90751f3480053378e133760b97633
https://github.com/simstudioai/sim/pull/8967/files#diff-5b6e93417c23c69dd607283ad630cf19fce90751f3480053378e133760b97633
https://github.com/simstudioai/sim/pull/8967/files#diff-5b6e93417c23c69dd607283ad630cf19fce90751f3480053378e133760b97633
apps/sim/lib/knowledge/documents/document-processor.tshttps://github.com/simstudioai/sim/pull/8967/files#diff-caef18c7f5680f8ad0ec1e40b90e7635fe8f182b55d4fd20ef78fbe881f11205
View file https://github.com/simstudioai/sim/blob/0edee67a1b4cc87d01097f5bb86a3053b8cf5be4/apps/sim/lib/knowledge/documents/document-processor.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8967/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8967/files#diff-caef18c7f5680f8ad0ec1e40b90e7635fe8f182b55d4fd20ef78fbe881f11205
https://github.com/simstudioai/sim/pull/8967/files#diff-caef18c7f5680f8ad0ec1e40b90e7635fe8f182b55d4fd20ef78fbe881f11205
https://github.com/simstudioai/sim/pull/8967/files#diff-caef18c7f5680f8ad0ec1e40b90e7635fe8f182b55d4fd20ef78fbe881f11205
https://github.com/simstudioai/sim/pull/8967/files#diff-caef18c7f5680f8ad0ec1e40b90e7635fe8f182b55d4fd20ef78fbe881f11205
https://github.com/simstudioai/sim/pull/8967/files#diff-caef18c7f5680f8ad0ec1e40b90e7635fe8f182b55d4fd20ef78fbe881f11205
https://github.com/simstudioai/sim/pull/8967/files#diff-caef18c7f5680f8ad0ec1e40b90e7635fe8f182b55d4fd20ef78fbe881f11205
https://github.com/simstudioai/sim/pull/8967/files#diff-caef18c7f5680f8ad0ec1e40b90e7635fe8f182b55d4fd20ef78fbe881f11205
apps/sim/lib/knowledge/documents/image-document-routing.test.tshttps://github.com/simstudioai/sim/pull/8967/files#diff-75adda4b407135ec6b5ac3825a8a9b40979908210a9b996f04be0659528df442
View file https://github.com/simstudioai/sim/blob/0edee67a1b4cc87d01097f5bb86a3053b8cf5be4/apps/sim/lib/knowledge/documents/image-document-routing.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8967/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8967/files#diff-75adda4b407135ec6b5ac3825a8a9b40979908210a9b996f04be0659528df442
https://github.com/simstudioai/sim/pull/8967/files#diff-75adda4b407135ec6b5ac3825a8a9b40979908210a9b996f04be0659528df442
https://github.com/simstudioai/sim/pull/8967/files#diff-75adda4b407135ec6b5ac3825a8a9b40979908210a9b996f04be0659528df442
https://github.com/simstudioai/sim/pull/8967/files#diff-75adda4b407135ec6b5ac3825a8a9b40979908210a9b996f04be0659528df442
https://github.com/simstudioai/sim/pull/8967/files#diff-75adda4b407135ec6b5ac3825a8a9b40979908210a9b996f04be0659528df442
Please reload this pagehttps://github.com/simstudioai/sim/pull/8967/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8967/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.