René's URL Explorer Experiment


Title: fix(knowledge): key vision checkpoints by title and keep excluded images off while disabled by waleedlatif1 · Pull Request #8965 · simstudioai/sim · GitHub

Open Graph Title: fix(knowledge): key vision checkpoints by title and keep excluded images off while disabled by waleedlatif1 · Pull Request #8965 · simstudioai/sim

X Title: fix(knowledge): key vision checkpoints by title and keep excluded images off while disabled by waleedlatif1 · Pull Request #8965 · simstudioai/sim

Description: Summary Vision checkpoints now include the filename in their cache key, since the extraction prompt names it as the title, so a rename never reuses text extracted under the old title Restoring an excluded image is rejected while the connector's image attachments are off. Turning images off keeps excluded rows so the exclusion survives turning them back on, but those rows still hold their indexed text, and restoring one re-enabled text the source no longer lists Follow-up to #8949, from the release PR review Type of Change Bug fix Testing vision-checkpoints.test.ts: added a renamed-title case, which fails without the fix confluence-images.integration.ts: an excluded image stays excluded with images off, restore is rejected, and restore succeeds after images come back on (runs in CI) Targeted vitest on application/connectors, vision-checkpoints and image-extraction (67 passed); biome on touched files Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Vision checkpoints now include the filename in their cache key, since the extraction prompt names it as the title, so a rename never reuses text extracted under the old title Restoring an ...

X Description: Summary Vision checkpoints now include the filename in their cache key, since the extraction prompt names it as the title, so a rename never reuses text extracted under the old title Restoring an ...

Opengraph URL: https://github.com/simstudioai/sim/pull/8965

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ec7706a9-5fcc-6483-57c7-d6203f4fa581
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB5D6:295278:85E890:BDC17B:6AFB4D83
html-safe-nonce3feca2b4786f45d42d47faa4b135a0d5fe97b2646508c4836421a2f81102ec48
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNUQ2OjI5NTI3ODo4NUU4OTA6QkRDMTdCOjZBRkI0RDgzIiwidmlzaXRvcl9pZCI6IjY0MjkzNDA5MzE3ODU5NjkwMjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2465dd7682aaf717f47448c17ca4b5db912f6a641f462171bde18e24e1b5470d
hovercard-subject-tagpull_request:4839041957
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8965/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Vision checkpoints now include the filename in their cache key, since the extraction prompt names it as the title, so a rename never reuses text extracted under the old title Restoring an ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8965/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8965%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8965%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8965/files
Reloadhttps://github.com/simstudioai/sim/pull/8965/files
Reloadhttps://github.com/simstudioai/sim/pull/8965/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/kb-image-release-reviewhttps://github.com/simstudioai/sim/tree/fix/kb-image-release-review
Conversation 22 https://github.com/simstudioai/sim/pull/8965
Commits 4 https://github.com/simstudioai/sim/pull/8965/commits
Checks 50 https://github.com/simstudioai/sim/pull/8965/checks
Files changed https://github.com/simstudioai/sim/pull/8965/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8965/files
fix(knowledge): key vision checkpoints by title and keep excluded images off while disabled https://github.com/simstudioai/sim/pull/8965/files#top
Show all changes 4 commits https://github.com/simstudioai/sim/pull/8965/files
f273106 fix(knowledge): key vision checkpoints by title and keep excluded ima… waleedlatif1 Oct 13, 2026 https://github.com/simstudioai/sim/pull/8965/commits/f2731062102fc8c62a2ee3826c367365ce65ee1b
55d2840 fix(knowledge): check the image setting and restore in one locked tra… waleedlatif1 Oct 13, 2026 https://github.com/simstudioai/sim/pull/8965/commits/55d284070627a837504244dd1374145b29b9539e
851d265 fix(knowledge): take the image restore locks in sync's order waleedlatif1 Oct 13, 2026 https://github.com/simstudioai/sim/pull/8965/commits/851d2651a76040938f8dced5ca2148d17276d0fc
2201de6 improvement(knowledge): read the connector image setting with toRecord waleedlatif1 Oct 13, 2026 https://github.com/simstudioai/sim/pull/8965/commits/2201de64ced07a577711195e11ab1072739e6121
Clear filters https://github.com/simstudioai/sim/pull/8965/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8965/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8965/files
confluence-images.integration.ts https://github.com/simstudioai/sim/pull/8965/files#diff-535e9beb0216aa2769f62608da90bf9368e450a18ad16958010a10ab0f0dc76d
connectors.ts https://github.com/simstudioai/sim/pull/8965/files#diff-b3ba104a3c4cebfd8de58a8d44da0a68b5cf63d2637517c9f6283f08cb2397d9
image-extraction.ts https://github.com/simstudioai/sim/pull/8965/files#diff-2a9925881510c65e31961483782c7ca11941af6e41ba95d99f41b3c3e7ea6396
vision-checkpoints.test.ts https://github.com/simstudioai/sim/pull/8965/files#diff-0afd606e4236feef9562f76b8f50f793bbfbca7eb503251bcddbf97620d2592b
vision-checkpoints.ts https://github.com/simstudioai/sim/pull/8965/files#diff-ad9c6ac44eb47033d4b433e8ebd00580772dd89a634f976f70f9ccb5af56faf1
apps/sim/lib/knowledge/__integration__/confluence-images.integration.tshttps://github.com/simstudioai/sim/pull/8965/files#diff-535e9beb0216aa2769f62608da90bf9368e450a18ad16958010a10ab0f0dc76d
View file https://github.com/simstudioai/sim/blob/2201de64ced07a577711195e11ab1072739e6121/apps/sim/lib/knowledge/__integration__/confluence-images.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8965/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8965/files#diff-535e9beb0216aa2769f62608da90bf9368e450a18ad16958010a10ab0f0dc76d
https://github.com/simstudioai/sim/pull/8965/files#diff-535e9beb0216aa2769f62608da90bf9368e450a18ad16958010a10ab0f0dc76d
https://github.com/simstudioai/sim/pull/8965/files#diff-535e9beb0216aa2769f62608da90bf9368e450a18ad16958010a10ab0f0dc76d
https://github.com/simstudioai/sim/pull/8965/files#diff-535e9beb0216aa2769f62608da90bf9368e450a18ad16958010a10ab0f0dc76d
https://github.com/simstudioai/sim/pull/8965/files#diff-535e9beb0216aa2769f62608da90bf9368e450a18ad16958010a10ab0f0dc76d
https://github.com/simstudioai/sim/pull/8965/files#diff-535e9beb0216aa2769f62608da90bf9368e450a18ad16958010a10ab0f0dc76d
apps/sim/lib/knowledge/application/connectors.tshttps://github.com/simstudioai/sim/pull/8965/files#diff-b3ba104a3c4cebfd8de58a8d44da0a68b5cf63d2637517c9f6283f08cb2397d9
View file https://github.com/simstudioai/sim/blob/2201de64ced07a577711195e11ab1072739e6121/apps/sim/lib/knowledge/application/connectors.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8965/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8965/files#diff-b3ba104a3c4cebfd8de58a8d44da0a68b5cf63d2637517c9f6283f08cb2397d9
https://github.com/simstudioai/sim/pull/8965/files#diff-b3ba104a3c4cebfd8de58a8d44da0a68b5cf63d2637517c9f6283f08cb2397d9
https://github.com/simstudioai/sim/pull/8965/files#diff-b3ba104a3c4cebfd8de58a8d44da0a68b5cf63d2637517c9f6283f08cb2397d9
https://github.com/simstudioai/sim/pull/8965/files#diff-b3ba104a3c4cebfd8de58a8d44da0a68b5cf63d2637517c9f6283f08cb2397d9
https://github.com/simstudioai/sim/pull/8965/files#diff-b3ba104a3c4cebfd8de58a8d44da0a68b5cf63d2637517c9f6283f08cb2397d9
https://github.com/simstudioai/sim/pull/8965/files#diff-b3ba104a3c4cebfd8de58a8d44da0a68b5cf63d2637517c9f6283f08cb2397d9
https://github.com/simstudioai/sim/pull/8965/files#diff-b3ba104a3c4cebfd8de58a8d44da0a68b5cf63d2637517c9f6283f08cb2397d9
Please reload this pagehttps://github.com/simstudioai/sim/pull/8965/files
https://github.com/simstudioai/sim/pull/8965/files#diff-b3ba104a3c4cebfd8de58a8d44da0a68b5cf63d2637517c9f6283f08cb2397d9
apps/sim/lib/knowledge/documents/image-extraction.tshttps://github.com/simstudioai/sim/pull/8965/files#diff-2a9925881510c65e31961483782c7ca11941af6e41ba95d99f41b3c3e7ea6396
View file https://github.com/simstudioai/sim/blob/2201de64ced07a577711195e11ab1072739e6121/apps/sim/lib/knowledge/documents/image-extraction.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8965/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8965/files#diff-2a9925881510c65e31961483782c7ca11941af6e41ba95d99f41b3c3e7ea6396
https://github.com/simstudioai/sim/pull/8965/files#diff-2a9925881510c65e31961483782c7ca11941af6e41ba95d99f41b3c3e7ea6396
apps/sim/lib/knowledge/documents/vision-checkpoints.test.tshttps://github.com/simstudioai/sim/pull/8965/files#diff-0afd606e4236feef9562f76b8f50f793bbfbca7eb503251bcddbf97620d2592b
View file https://github.com/simstudioai/sim/blob/2201de64ced07a577711195e11ab1072739e6121/apps/sim/lib/knowledge/documents/vision-checkpoints.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8965/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8965/files#diff-0afd606e4236feef9562f76b8f50f793bbfbca7eb503251bcddbf97620d2592b
https://github.com/simstudioai/sim/pull/8965/files#diff-0afd606e4236feef9562f76b8f50f793bbfbca7eb503251bcddbf97620d2592b
https://github.com/simstudioai/sim/pull/8965/files#diff-0afd606e4236feef9562f76b8f50f793bbfbca7eb503251bcddbf97620d2592b
https://github.com/simstudioai/sim/pull/8965/files#diff-0afd606e4236feef9562f76b8f50f793bbfbca7eb503251bcddbf97620d2592b
apps/sim/lib/knowledge/documents/vision-checkpoints.tshttps://github.com/simstudioai/sim/pull/8965/files#diff-ad9c6ac44eb47033d4b433e8ebd00580772dd89a634f976f70f9ccb5af56faf1
View file https://github.com/simstudioai/sim/blob/2201de64ced07a577711195e11ab1072739e6121/apps/sim/lib/knowledge/documents/vision-checkpoints.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8965/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8965/files#diff-ad9c6ac44eb47033d4b433e8ebd00580772dd89a634f976f70f9ccb5af56faf1
https://github.com/simstudioai/sim/pull/8965/files#diff-ad9c6ac44eb47033d4b433e8ebd00580772dd89a634f976f70f9ccb5af56faf1
https://github.com/simstudioai/sim/pull/8965/files#diff-ad9c6ac44eb47033d4b433e8ebd00580772dd89a634f976f70f9ccb5af56faf1
Please reload this pagehttps://github.com/simstudioai/sim/pull/8965/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.