René's URL Explorer Experiment


Title: ci: ratchet type errors in apps/sim test files by waleedlatif1 · Pull Request #8959 · simstudioai/sim · GitHub

Open Graph Title: ci: ratchet type errors in apps/sim test files by waleedlatif1 · Pull Request #8959 · simstudioai/sim

X Title: ci: ratchet type errors in apps/sim test files by waleedlatif1 · Pull Request #8959 · simstudioai/sim

Description: Summary apps/sim's tsconfig excludes *.test.ts(x), so about 3,363 test files are never type-checked. This adds a shrink-only ratchet so new type errors can't enter test files, without forcing anyone to fix the existing ones now. apps/sim/tsconfig.tests.json extends the app config and includes the test files. Only the ratchet uses it. check:test-types (scripts/check-test-types.ts) Runs the native TS7 tsc (the repo's @typescript/native) on that config and counts errors per file. Fails if any file's count rises or a new file has errors. A drop also fails until --update shrinks the baseline, the same as check:explicit-any. --update never raises a count. Unparseable compiler output fails outright: a config error, a crash, an error total that doesn't match the parsed count, or an exit code that disagrees with it. It never reads as "fewer errors". Its own test-types job (4 vCPU) runs alongside lint, test and build, so it stays off the critical path, at about 1.5 min. It's gated on the test flag and included in ci-gate.sh. On failure it uploads diagnostics.txt and counts.json, so a shrink never needs a local compile: gh run download -n test-types -D

, then bun run scripts/check-test-types.ts --counts /counts.json --update. It isn't in check:audits, because that also runs on laptops. Baseline comes from this PR's first CI run (run 38342772080): 3,209 errors across 874 files. The one-time bootstrap path was removed before merge, so the shipped script cannot create or raise a baseline. Known gap: an @ts-expect-error or @ts-ignore added to a test still hides an error. Counting those could be a follow-up. Test plan test-types job passes against the committed baseline scripts/check-test-types.test.ts (parsing and comparison; each guard verified by revert), ci-gate.test.ts

Open Graph Description: Summary apps/sim's tsconfig excludes *.test.ts(x), so about 3,363 test files are never type-checked. This adds a shrink-only ratchet so new type errors can't enter test files, without forci...

X Description: Summary apps/sim's tsconfig excludes *.test.ts(x), so about 3,363 test files are never type-checked. This adds a shrink-only ratchet so new type errors can't enter test files, witho...

Opengraph URL: https://github.com/simstudioai/sim/pull/8959

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0ccb66e5-2b8e-f0ef-2d04-52c60822aaa4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDD86:3ED756:FADE3:15DBAF:6AFB4BFD
html-safe-nonce6a6cf686027020d873f5c24ebdc6b4d8f71f975446a7ab29733e650e883f4000
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDg2OjNFRDc1NjpGQURFMzoxNURCQUY6NkFGQjRCRkQiLCJ2aXNpdG9yX2lkIjoiMTUyNjMxMTYxMzYzMDIwNDkyNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb820ce2a3c05276f0c8a79ef9a19b2fe45e79e4afbd763d7035c52494f8a7f5c
hovercard-subject-tagpull_request:4838009062
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8959/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary apps/sim's tsconfig excludes *.test.ts(x), so about 3,363 test files are never type-checked. This adds a shrink-only ratchet so new type errors can't enter test files, without forci...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8959/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8959%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8959%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8959/files
Reloadhttps://github.com/simstudioai/sim/pull/8959/files
Reloadhttps://github.com/simstudioai/sim/pull/8959/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
ci/test-typecheck-ratchethttps://github.com/simstudioai/sim/tree/ci/test-typecheck-ratchet
Conversation 27 https://github.com/simstudioai/sim/pull/8959
Commits 6 https://github.com/simstudioai/sim/pull/8959/commits
Checks 58 https://github.com/simstudioai/sim/pull/8959/checks
Files changed https://github.com/simstudioai/sim/pull/8959/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8959/files
ci: ratchet type errors in apps/sim test files https://github.com/simstudioai/sim/pull/8959/files#top
Show all changes 6 commits https://github.com/simstudioai/sim/pull/8959/files
1d14d9c ci: ratchet type errors in apps/sim unit tests per file waleedlatif1 Oct 13, 2026 https://github.com/simstudioai/sim/pull/8959/commits/1d14d9ce387156aa8ca0d892c698ecb694b14bfd
8fe3658 ci: commit the test type-error baseline from CI and drop the one-time… waleedlatif1 Oct 13, 2026 https://github.com/simstudioai/sim/pull/8959/commits/8fe365813839da35da5d1f1169521808f3245c2a
bb4dcbd ci: ratchet test type errors per file and TS code, with command-level… waleedlatif1 Oct 13, 2026 https://github.com/simstudioai/sim/pull/8959/commits/bb4dcbd51d67ecbc8868878199aee6585a626b97
4feabc8 Merge remote-tracking branch 'origin/staging' into ci/test-typecheck-… waleedlatif1 Oct 13, 2026 https://github.com/simstudioai/sim/pull/8959/commits/4feabc8e7a9cddcdf13a48ccb3f9657ad96b2879
7db4fb2 ci: verify saved test-type diagnostics against the compile's exit status waleedlatif1 Oct 13, 2026 https://github.com/simstudioai/sim/pull/8959/commits/7db4fb2db99e1b8a0aa5bdea9cf672ac3dba5eb9
c1d25fc ci: read the saved compiler status through toRecord waleedlatif1 Oct 13, 2026 https://github.com/simstudioai/sim/pull/8959/commits/c1d25fc0ce53a6b7db8fb50feca546721ca71495
Clear filters https://github.com/simstudioai/sim/pull/8959/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8959/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8959/files
ci-changes.sh https://github.com/simstudioai/sim/pull/8959/files#diff-2c72c4a055f6fcad4b43f241c82c5190e2d73de07d6663f51ac4cb3ae7a0b2ed
ci-gate.sh https://github.com/simstudioai/sim/pull/8959/files#diff-17aee813aeef6064f714986dbcd52f8b71d12c30b8df6091f59b65aa81c94770
checks.yml https://github.com/simstudioai/sim/pull/8959/files#diff-3ea54af4839eb75404d71b28252bead7e7ec8f676b1f815e1cde02629a75c165
CLAUDE.md https://github.com/simstudioai/sim/pull/8959/files#diff-6ebdb617a8104a7756d0cf36578ab01103dc9f07e4dc6feb751296b9c402faf7
route.test.ts https://github.com/simstudioai/sim/pull/8959/files#diff-468bd7b01192a6dc93bd1b5f9e3044699a7a6dccf69e18a2b914b842c75be72f
tsconfig.tests.json https://github.com/simstudioai/sim/pull/8959/files#diff-e82ad95fb6ceb2ac949cd069f20a755e831deb51965678aeac837c0d6be2574c
package.json https://github.com/simstudioai/sim/pull/8959/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
check-test-types.baseline.json https://github.com/simstudioai/sim/pull/8959/files#diff-3f0e52298332b82e821be5c9210ddb89bb43ab248c2db79c27e6a783dbfe9e36
check-test-types.test.ts https://github.com/simstudioai/sim/pull/8959/files#diff-85254c761e540bc93bd92d6e57bd6641006db42098666948c6fb4f66015b407c
check-test-types.ts https://github.com/simstudioai/sim/pull/8959/files#diff-63a299de65d67b9f24626d85b6b59f016a42618cce8334f9cacca41ead1c2974
ci-gate.test.ts https://github.com/simstudioai/sim/pull/8959/files#diff-a1146c3591a112009409560576bfe6a59856660280b670e9f468e4a05b423697
run-audits.ts https://github.com/simstudioai/sim/pull/8959/files#diff-d2ffe3c1afd98cda5ef387b7d156d553cd50d8503588c4e1a89415ef09b774e8
.github/scripts/ci-changes.shhttps://github.com/simstudioai/sim/pull/8959/files#diff-2c72c4a055f6fcad4b43f241c82c5190e2d73de07d6663f51ac4cb3ae7a0b2ed
View file https://github.com/simstudioai/sim/blob/c1d25fc0ce53a6b7db8fb50feca546721ca71495/.github/scripts/ci-changes.sh
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8959/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8959/files#diff-2c72c4a055f6fcad4b43f241c82c5190e2d73de07d6663f51ac4cb3ae7a0b2ed
https://github.com/simstudioai/sim/pull/8959/files#diff-2c72c4a055f6fcad4b43f241c82c5190e2d73de07d6663f51ac4cb3ae7a0b2ed
.github/scripts/ci-gate.shhttps://github.com/simstudioai/sim/pull/8959/files#diff-17aee813aeef6064f714986dbcd52f8b71d12c30b8df6091f59b65aa81c94770
View file https://github.com/simstudioai/sim/blob/c1d25fc0ce53a6b7db8fb50feca546721ca71495/.github/scripts/ci-gate.sh
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8959/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8959/files#diff-17aee813aeef6064f714986dbcd52f8b71d12c30b8df6091f59b65aa81c94770
https://github.com/simstudioai/sim/pull/8959/files#diff-17aee813aeef6064f714986dbcd52f8b71d12c30b8df6091f59b65aa81c94770
https://github.com/simstudioai/sim/pull/8959/files#diff-17aee813aeef6064f714986dbcd52f8b71d12c30b8df6091f59b65aa81c94770
.github/workflows/checks.ymlhttps://github.com/simstudioai/sim/pull/8959/files#diff-3ea54af4839eb75404d71b28252bead7e7ec8f676b1f815e1cde02629a75c165
View file https://github.com/simstudioai/sim/blob/c1d25fc0ce53a6b7db8fb50feca546721ca71495/.github/workflows/checks.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8959/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8959/files#diff-3ea54af4839eb75404d71b28252bead7e7ec8f676b1f815e1cde02629a75c165
https://github.com/simstudioai/sim/pull/8959/files#diff-3ea54af4839eb75404d71b28252bead7e7ec8f676b1f815e1cde02629a75c165
https://github.com/simstudioai/sim/pull/8959/files#diff-3ea54af4839eb75404d71b28252bead7e7ec8f676b1f815e1cde02629a75c165
https://github.com/simstudioai/sim/pull/8959/files#diff-3ea54af4839eb75404d71b28252bead7e7ec8f676b1f815e1cde02629a75c165
https://github.com/simstudioai/sim/pull/8959/files#diff-3ea54af4839eb75404d71b28252bead7e7ec8f676b1f815e1cde02629a75c165
CLAUDE.mdhttps://github.com/simstudioai/sim/pull/8959/files#diff-6ebdb617a8104a7756d0cf36578ab01103dc9f07e4dc6feb751296b9c402faf7
View file https://github.com/simstudioai/sim/blob/c1d25fc0ce53a6b7db8fb50feca546721ca71495/CLAUDE.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8959/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8959/files#diff-6ebdb617a8104a7756d0cf36578ab01103dc9f07e4dc6feb751296b9c402faf7
https://github.com/simstudioai/sim/pull/8959/files#diff-6ebdb617a8104a7756d0cf36578ab01103dc9f07e4dc6feb751296b9c402faf7
apps/sim/app/api/auth/socket-token/route.test.tshttps://github.com/simstudioai/sim/pull/8959/files#diff-468bd7b01192a6dc93bd1b5f9e3044699a7a6dccf69e18a2b914b842c75be72f
View file https://github.com/simstudioai/sim/blob/c1d25fc0ce53a6b7db8fb50feca546721ca71495/apps/sim/app/api/auth/socket-token/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8959/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8959/files#diff-468bd7b01192a6dc93bd1b5f9e3044699a7a6dccf69e18a2b914b842c75be72f
https://github.com/simstudioai/sim/pull/8959/files#diff-468bd7b01192a6dc93bd1b5f9e3044699a7a6dccf69e18a2b914b842c75be72f
apps/sim/tsconfig.tests.jsonhttps://github.com/simstudioai/sim/pull/8959/files#diff-e82ad95fb6ceb2ac949cd069f20a755e831deb51965678aeac837c0d6be2574c
View file https://github.com/simstudioai/sim/blob/c1d25fc0ce53a6b7db8fb50feca546721ca71495/apps/sim/tsconfig.tests.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8959/{{ revealButtonHref }}
https://github.com/simstudioai/sim/blob/staging/.github/CODEOWNERS#L36
package.jsonhttps://github.com/simstudioai/sim/pull/8959/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
View file https://github.com/simstudioai/sim/blob/c1d25fc0ce53a6b7db8fb50feca546721ca71495/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8959/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8959/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
https://github.com/simstudioai/sim/pull/8959/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
Please reload this pagehttps://github.com/simstudioai/sim/pull/8959/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8959/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.