René's URL Explorer Experiment


Title: fix(desktop-e2e): remove root causes of four retry-masked desktop flakes by waleedlatif1 · Pull Request #8940 · simstudioai/sim · GitHub

Open Graph Title: fix(desktop-e2e): remove root causes of four retry-masked desktop flakes by waleedlatif1 · Pull Request #8940 · simstudioai/sim

X Title: fix(desktop-e2e): remove root causes of four retry-masked desktop flakes by waleedlatif1 · Pull Request #8940 · simstudioai/sim

Description: Summary Desktop Playwright retries once in CI, so flakes never show up as failures. In 143 recent runs, 8 green runs in gating jobs passed only on the retry. This PR fixes four of those flakes at their root and adds diagnostics for the other three. Fixed packaged-smoke:91 (also gates releases) and the same race at :46. Cleanup deleted the profile (userData) folder while the app's leftover helper processes, such as Crashpad's handler, could still write to it, which caused ENOTEMPTY. The app now launches in its own process group. Cleanup waits, with a bounded poll, until no process in that group or naming the unique temp profile path is left, then deletes the folder. background-executor:253. The consent dialog closes its own window before Playwright gets the click acknowledgement, so the click fails even though the answer landed. A new answerShellDialog helper waits for the window to close instead. Each caller still asserts the recorded outcome. background-executor:83. This checked a 1.5s wall-clock limit on a shared runner, while the product's real pickup deadline is 15s (repository.ts:58, constants.ts:79). The test now asserts that every call is claimed within 15s of being issued, holds the first command so lease renewal is checked, and releases that hold in a finally. Fast pickup is still asserted in test F. browser-tools:609, a real product bug. When a click makes a page close its own tab (for example a popup's Allow button), Electron can reject the final mouseReleased after the tab is gone. The driver then reported "Native click dispatch failed" for a click that had landed. cdp.clickAt now raises a typed TabClosedOnReleaseError only when the final release went to a live tab and that tab is destroyed by the time the release is rejected. The driver treats only that error as a delivered click, returning tabChanged and doNotRetry. Any failure before input, or on the move, press or hold, keeps its existing error. Diagnostics only (browser-page-dialogs:46, browser-focus:32): failures now print the tool error and the dialog id, so the next flake names its cause. smoke:85, a hang in app.close(), needs a DEBUG=pw:browser run. Playwright still retries once. failOnFlakyTests gets enabled once the remaining three are fixed. Test plan desktop-live / desktop-e2e green, with no "flaky" lines for the four fixed specs

Open Graph Description: Summary Desktop Playwright retries once in CI, so flakes never show up as failures. In 143 recent runs, 8 green runs in gating jobs passed only on the retry. This PR fixes four of those flakes at t...

X Description: Summary Desktop Playwright retries once in CI, so flakes never show up as failures. In 143 recent runs, 8 green runs in gating jobs passed only on the retry. This PR fixes four of those flakes at t...

Opengraph URL: https://github.com/simstudioai/sim/pull/8940

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7fafe9ec-5e10-1a37-957a-b282d9f96473
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC174:18732E:9D132F:D7D783:6AFB4DA9
html-safe-noncec70ebee4e3741999c0b2ef2d9e0fc16a81216e8203006c0a8a989554643b5d6a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTc0OjE4NzMyRTo5RDEzMkY6RDdENzgzOjZBRkI0REE5IiwidmlzaXRvcl9pZCI6IjczODY5NDIzMzg5NzY0MDI4NTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac373ee4be41ad80100c2c6b62c77142e55f1e1f2054b67c60686d47163322f39f
hovercard-subject-tagpull_request:4834535935
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8940/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Desktop Playwright retries once in CI, so flakes never show up as failures. In 143 recent runs, 8 green runs in gating jobs passed only on the retry. This PR fixes four of those flakes at t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8940/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8940%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8940%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8940/files
Reloadhttps://github.com/simstudioai/sim/pull/8940/files
Reloadhttps://github.com/simstudioai/sim/pull/8940/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/desktop-e2e-flakeshttps://github.com/simstudioai/sim/tree/fix/desktop-e2e-flakes
Conversation 10 https://github.com/simstudioai/sim/pull/8940
Commits 3 https://github.com/simstudioai/sim/pull/8940/commits
Checks 50 https://github.com/simstudioai/sim/pull/8940/checks
Files changed https://github.com/simstudioai/sim/pull/8940/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8940/files
fix(desktop-e2e): remove root causes of four retry-masked desktop flakes https://github.com/simstudioai/sim/pull/8940/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/8940/files
ba9238d fix(desktop-e2e): remove root causes of four retry-masked desktop flakes waleedlatif1 Oct 12, 2026 https://github.com/simstudioai/sim/pull/8940/commits/ba9238d9eeb6ff662180db80df37f5689e0ffa8a
23f493e fix(desktop-e2e): rescue only a click whose final release hit a tab t… waleedlatif1 Oct 12, 2026 https://github.com/simstudioai/sim/pull/8940/commits/23f493e30c3806056d0da7775f178f93bd6e4147
4a7ede1 fix(desktop): report a click whose tab closed mid-release as unconfirmed waleedlatif1 Oct 12, 2026 https://github.com/simstudioai/sim/pull/8940/commits/4a7ede1017b774cf0ec466da5e6bc58afbb1a65b
Clear filters https://github.com/simstudioai/sim/pull/8940/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8940/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8940/files
background-executor.spec.ts https://github.com/simstudioai/sim/pull/8940/files#diff-4332bb9fbb86c853395301498b2e8eb627bbc7c6b68c498ae343555109ea5d3b
browser-focus.spec.ts https://github.com/simstudioai/sim/pull/8940/files#diff-c8be8618266d7d2c002056094aa37a9538d878b06030eb4e0daa4f14d785b62a
browser-page-dialogs.spec.ts https://github.com/simstudioai/sim/pull/8940/files#diff-b09f848f811413e82d620ee40d653ba2b1b9046ecc55812ac087ade8bd992589
browser-tools.spec.ts https://github.com/simstudioai/sim/pull/8940/files#diff-ab82f7da68615cfd89438edd35715f85fd15d035dc6ec6ac34ce22fae3474fc2
executor-sim.ts https://github.com/simstudioai/sim/pull/8940/files#diff-f7287895c9710d50863469cc1e21109b849709c77267141ec2e89e12be1b5504
packaged-smoke.spec.ts https://github.com/simstudioai/sim/pull/8940/files#diff-d9c9c017b2b031b0e6d64809566d4050a3378fafc1c35c43fa52d4f46982bdfa
cdp.test.ts https://github.com/simstudioai/sim/pull/8940/files#diff-5c99463d5fbb5f5a8d4c7d7b2b621e8fd2ef38db866cff2a75a92fd65859a5c6
cdp.ts https://github.com/simstudioai/sim/pull/8940/files#diff-20197f234b92c7c1c2b522668174347c28d21a740fb487409f3b3637a423473c
driver.test.ts https://github.com/simstudioai/sim/pull/8940/files#diff-e3f3e254574c9ace38cf400e9ef8600989b25e602629bb7e6c7e4927a27830c5
driver.ts https://github.com/simstudioai/sim/pull/8940/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
apps/desktop/e2e/background-executor.spec.tshttps://github.com/simstudioai/sim/pull/8940/files#diff-4332bb9fbb86c853395301498b2e8eb627bbc7c6b68c498ae343555109ea5d3b
View file https://github.com/simstudioai/sim/blob/4a7ede1017b774cf0ec466da5e6bc58afbb1a65b/apps/desktop/e2e/background-executor.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8940/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8940/files#diff-4332bb9fbb86c853395301498b2e8eb627bbc7c6b68c498ae343555109ea5d3b
https://github.com/simstudioai/sim/pull/8940/files#diff-4332bb9fbb86c853395301498b2e8eb627bbc7c6b68c498ae343555109ea5d3b
https://github.com/simstudioai/sim/pull/8940/files#diff-4332bb9fbb86c853395301498b2e8eb627bbc7c6b68c498ae343555109ea5d3b
https://github.com/simstudioai/sim/pull/8940/files#diff-4332bb9fbb86c853395301498b2e8eb627bbc7c6b68c498ae343555109ea5d3b
https://github.com/simstudioai/sim/pull/8940/files#diff-4332bb9fbb86c853395301498b2e8eb627bbc7c6b68c498ae343555109ea5d3b
https://github.com/simstudioai/sim/pull/8940/files#diff-4332bb9fbb86c853395301498b2e8eb627bbc7c6b68c498ae343555109ea5d3b
https://github.com/simstudioai/sim/pull/8940/files#diff-4332bb9fbb86c853395301498b2e8eb627bbc7c6b68c498ae343555109ea5d3b
https://github.com/simstudioai/sim/pull/8940/files#diff-4332bb9fbb86c853395301498b2e8eb627bbc7c6b68c498ae343555109ea5d3b
https://github.com/simstudioai/sim/pull/8940/files#diff-4332bb9fbb86c853395301498b2e8eb627bbc7c6b68c498ae343555109ea5d3b
https://github.com/simstudioai/sim/pull/8940/files#diff-4332bb9fbb86c853395301498b2e8eb627bbc7c6b68c498ae343555109ea5d3b
https://github.com/simstudioai/sim/pull/8940/files#diff-4332bb9fbb86c853395301498b2e8eb627bbc7c6b68c498ae343555109ea5d3b
https://github.com/simstudioai/sim/pull/8940/files#diff-4332bb9fbb86c853395301498b2e8eb627bbc7c6b68c498ae343555109ea5d3b
https://github.com/simstudioai/sim/pull/8940/files#diff-4332bb9fbb86c853395301498b2e8eb627bbc7c6b68c498ae343555109ea5d3b
https://github.com/simstudioai/sim/pull/8940/files#diff-4332bb9fbb86c853395301498b2e8eb627bbc7c6b68c498ae343555109ea5d3b
https://github.com/simstudioai/sim/pull/8940/files#diff-4332bb9fbb86c853395301498b2e8eb627bbc7c6b68c498ae343555109ea5d3b
https://github.com/simstudioai/sim/pull/8940/files#diff-4332bb9fbb86c853395301498b2e8eb627bbc7c6b68c498ae343555109ea5d3b
https://github.com/simstudioai/sim/pull/8940/files#diff-4332bb9fbb86c853395301498b2e8eb627bbc7c6b68c498ae343555109ea5d3b
https://github.com/simstudioai/sim/pull/8940/files#diff-4332bb9fbb86c853395301498b2e8eb627bbc7c6b68c498ae343555109ea5d3b
apps/desktop/e2e/browser-focus.spec.tshttps://github.com/simstudioai/sim/pull/8940/files#diff-c8be8618266d7d2c002056094aa37a9538d878b06030eb4e0daa4f14d785b62a
View file https://github.com/simstudioai/sim/blob/4a7ede1017b774cf0ec466da5e6bc58afbb1a65b/apps/desktop/e2e/browser-focus.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8940/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8940/files#diff-c8be8618266d7d2c002056094aa37a9538d878b06030eb4e0daa4f14d785b62a
https://github.com/simstudioai/sim/pull/8940/files#diff-c8be8618266d7d2c002056094aa37a9538d878b06030eb4e0daa4f14d785b62a
apps/desktop/e2e/browser-page-dialogs.spec.tshttps://github.com/simstudioai/sim/pull/8940/files#diff-b09f848f811413e82d620ee40d653ba2b1b9046ecc55812ac087ade8bd992589
View file https://github.com/simstudioai/sim/blob/4a7ede1017b774cf0ec466da5e6bc58afbb1a65b/apps/desktop/e2e/browser-page-dialogs.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8940/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8940/files#diff-b09f848f811413e82d620ee40d653ba2b1b9046ecc55812ac087ade8bd992589
https://github.com/simstudioai/sim/pull/8940/files#diff-b09f848f811413e82d620ee40d653ba2b1b9046ecc55812ac087ade8bd992589
https://github.com/simstudioai/sim/pull/8940/files#diff-b09f848f811413e82d620ee40d653ba2b1b9046ecc55812ac087ade8bd992589
https://github.com/simstudioai/sim/pull/8940/files#diff-b09f848f811413e82d620ee40d653ba2b1b9046ecc55812ac087ade8bd992589
apps/desktop/e2e/browser-tools.spec.tshttps://github.com/simstudioai/sim/pull/8940/files#diff-ab82f7da68615cfd89438edd35715f85fd15d035dc6ec6ac34ce22fae3474fc2
View file https://github.com/simstudioai/sim/blob/4a7ede1017b774cf0ec466da5e6bc58afbb1a65b/apps/desktop/e2e/browser-tools.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8940/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8940/files#diff-ab82f7da68615cfd89438edd35715f85fd15d035dc6ec6ac34ce22fae3474fc2
https://github.com/simstudioai/sim/pull/8940/files#diff-ab82f7da68615cfd89438edd35715f85fd15d035dc6ec6ac34ce22fae3474fc2
apps/desktop/e2e/executor-sim.tshttps://github.com/simstudioai/sim/pull/8940/files#diff-f7287895c9710d50863469cc1e21109b849709c77267141ec2e89e12be1b5504
View file https://github.com/simstudioai/sim/blob/4a7ede1017b774cf0ec466da5e6bc58afbb1a65b/apps/desktop/e2e/executor-sim.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8940/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8940/files#diff-f7287895c9710d50863469cc1e21109b849709c77267141ec2e89e12be1b5504
https://github.com/simstudioai/sim/pull/8940/files#diff-f7287895c9710d50863469cc1e21109b849709c77267141ec2e89e12be1b5504
https://github.com/simstudioai/sim/pull/8940/files#diff-f7287895c9710d50863469cc1e21109b849709c77267141ec2e89e12be1b5504
https://github.com/simstudioai/sim/pull/8940/files#diff-f7287895c9710d50863469cc1e21109b849709c77267141ec2e89e12be1b5504
apps/desktop/e2e/packaged-smoke.spec.tshttps://github.com/simstudioai/sim/pull/8940/files#diff-d9c9c017b2b031b0e6d64809566d4050a3378fafc1c35c43fa52d4f46982bdfa
View file https://github.com/simstudioai/sim/blob/4a7ede1017b774cf0ec466da5e6bc58afbb1a65b/apps/desktop/e2e/packaged-smoke.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8940/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8940/files#diff-d9c9c017b2b031b0e6d64809566d4050a3378fafc1c35c43fa52d4f46982bdfa
https://github.com/simstudioai/sim/pull/8940/files#diff-d9c9c017b2b031b0e6d64809566d4050a3378fafc1c35c43fa52d4f46982bdfa
https://github.com/simstudioai/sim/pull/8940/files#diff-d9c9c017b2b031b0e6d64809566d4050a3378fafc1c35c43fa52d4f46982bdfa
https://github.com/simstudioai/sim/pull/8940/files#diff-d9c9c017b2b031b0e6d64809566d4050a3378fafc1c35c43fa52d4f46982bdfa
https://github.com/simstudioai/sim/pull/8940/files#diff-d9c9c017b2b031b0e6d64809566d4050a3378fafc1c35c43fa52d4f46982bdfa
https://github.com/simstudioai/sim/pull/8940/files#diff-d9c9c017b2b031b0e6d64809566d4050a3378fafc1c35c43fa52d4f46982bdfa
Please reload this pagehttps://github.com/simstudioai/sim/pull/8940/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8940/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.