René's URL Explorer Experiment


Title: fix(workflows): hold the v2 sync run result until its execution log is finalized by waleedlatif1 · Pull Request #8935 · simstudioai/sim · GitHub

Open Graph Title: fix(workflows): hold the v2 sync run result until its execution log is finalized by waleedlatif1 · Pull Request #8935 · simstudioai/sim

X Title: fix(workflows): hold the v2 sync run result until its execution log is finalized by waleedlatif1 · Pull Request #8935 · simstudioai/sim

Description: Summary A run-from-block call that names a just-finished v2 sync run as its source can fail with NOT_FOUND: No execution state found for source run. CI hit this in e2e (stop-after) (run 38262284889, attempt 1; it passed on rerun), and any v2 API, CLI or MCP caller can hit it the same way. Cause. After a run finishes, the core writes its log and saved execution state in a background step (execution-core.ts). runSynchronousWorkflow in execute-service.ts returned the completed result without waiting for that step. Run-from-block reads the state from the primary DB, found the log row with no state yet, and returned 404. In the CI log the source run passed at 14:24:52.750 and the CLI failed at 14:24:53.773, while the write was still in flight. Fix. Await loggingSession.waitForPostExecution() in runSynchronousWorkflow's finally, as the legacy execute route already does ("the sync response is the run's receipt"). It covers completed, failed, cancelled, timed-out and thrown runs, and does nothing after a pause. The wait swallows errors and the background step always settles, so it can't hang the response. This is not a retry. Trade-off. v2 sync responses now include the time to save the log, the same as the legacy route. Test plan CI e2e (stop-after) and the v2 execute suites

Open Graph Description: Summary A run-from-block call that names a just-finished v2 sync run as its source can fail with NOT_FOUND: No execution state found for source run. CI hit this in e2e (stop-after) (run 38262284889...

X Description: Summary A run-from-block call that names a just-finished v2 sync run as its source can fail with NOT_FOUND: No execution state found for source run. CI hit this in e2e (stop-after) (run 38262284889...

Opengraph URL: https://github.com/simstudioai/sim/pull/8935

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:659d6a18-0785-fed9-c48e-d2724ecb0f57
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF6C:2F3575:7FBA7C:B67F97:6AFB4DAE
html-safe-nonced799f4792fd7ba436ec6087d8b89c4bf61cea6a3599ec4614daa97338e5a4a47
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjZDOjJGMzU3NTo3RkJBN0M6QjY3Rjk3OjZBRkI0REFFIiwidmlzaXRvcl9pZCI6IjcxNTY5MzkzNDEyNjI3MDQwNDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4c99d62f8046ef9523e4c396b9085ef357d613643951dc839a5f208646eac3f6
hovercard-subject-tagpull_request:4834173068
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8935/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary A run-from-block call that names a just-finished v2 sync run as its source can fail with NOT_FOUND: No execution state found for source run. CI hit this in e2e (stop-after) (run 38262284889...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8935/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8935%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8935%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8935/files
Reloadhttps://github.com/simstudioai/sim/pull/8935/files
Reloadhttps://github.com/simstudioai/sim/pull/8935/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/stop-after-e2e-racehttps://github.com/simstudioai/sim/tree/fix/stop-after-e2e-race
Conversation 2 https://github.com/simstudioai/sim/pull/8935
Commits 1 https://github.com/simstudioai/sim/pull/8935/commits
Checks 47 https://github.com/simstudioai/sim/pull/8935/checks
Files changed https://github.com/simstudioai/sim/pull/8935/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8935/files
fix(workflows): hold the v2 sync run result until its execution log is finalized https://github.com/simstudioai/sim/pull/8935/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/8935/files
f132892 fix(workflows): hold the v2 sync run result until its execution log i… waleedlatif1 Oct 12, 2026 https://github.com/simstudioai/sim/pull/8935/commits/f132892c22e40dca6cc45cb3ebad487a5187cca2
Clear filters https://github.com/simstudioai/sim/pull/8935/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8935/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8935/files
apps/sim/lib/workflows/executor/execute-service.tshttps://github.com/simstudioai/sim/pull/8935/files#diff-4de69b061702e24d04497c8bf4f774ea9975dffe6337166857921903fba8a629
View file https://github.com/simstudioai/sim/blob/f132892c22e40dca6cc45cb3ebad487a5187cca2/apps/sim/lib/workflows/executor/execute-service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8935/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8935/files#diff-4de69b061702e24d04497c8bf4f774ea9975dffe6337166857921903fba8a629
https://github.com/simstudioai/sim/pull/8935/files#diff-4de69b061702e24d04497c8bf4f774ea9975dffe6337166857921903fba8a629
Please reload this pagehttps://github.com/simstudioai/sim/pull/8935/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.