René's URL Explorer Experiment


Title: fix(chat): name stackless error subclasses and compact stored unfinished tool params by waleedlatif1 · Pull Request #8928 · simstudioai/sim · GitHub

Open Graph Title: fix(chat): name stackless error subclasses and compact stored unfinished tool params by waleedlatif1 · Pull Request #8928 · simstudioai/sim

X Title: fix(chat): name stackless error subclasses and compact stored unfinished tool params by waleedlatif1 · Pull Request #8928 · simstudioai/sim

Description: Summary Function errors: recognize Node's stackless [Class [name]: message] headline (an error subclass that keeps its parent's name), so it reports the thrown error instead of falling back to Execution failed. Names match the stacked form (QuotaExceeded [Error]) Chat transcript: stored assistant turns now compact params of unfinished tool calls too — they render as interrupted and are never re-run or approved. Only the live assistant message keeps unfinished params whole One shared isStoredAssistantMessage predicate for display and compaction so the two can't drift Type of Change Bug fix Testing code-failure.test.ts and lib/mothership/chat/** tests pass (559); new cases fail on the pre-fix code Real Node 22 / Python stderr harness: 5 of 61 cases improve (all previously Execution failed), the rest unchanged; non-error bracket forms ([Object: …], [Function: …], [class A [T]]) still don't match biome on changed files; type-check and audits in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Function errors: recognize Node's stackless [Class [name]: message] headline (an error subclass that keeps its parent's name), so it reports the thrown error instead of falling bac...

X Description: Summary Function errors: recognize Node's stackless [Class [name]: message] headline (an error subclass that keeps its parent's name), so it reports the thrown error instead of fal...

Opengraph URL: https://github.com/simstudioai/sim/pull/8928

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:252e2375-20b0-ac93-1a41-b79879034268
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9AEA:2B673:276047:377EC7:6AFB713E
html-safe-nonce6a18890cfb8d8773cbbf782f204fdf3eb33744e31975a99860f187716c5a18dd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QUVBOjJCNjczOjI3NjA0NzozNzdFQzc6NkFGQjcxM0UiLCJ2aXNpdG9yX2lkIjoiNzU3NTExNzExNzMxOTcwMzY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7a3378c78775fd3ec166acead83a9849f702dd1b83be63960516fda5f6018952
hovercard-subject-tagpull_request:4833084296
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8928/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Function errors: recognize Node's stackless [Class [name]: message] headline (an error subclass that keeps its parent's name), so it reports the thrown error instead of falling bac...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8928/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8928%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8928%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8928/files
Reloadhttps://github.com/simstudioai/sim/pull/8928/files
Reloadhttps://github.com/simstudioai/sim/pull/8928/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/v0919-review-followupshttps://github.com/simstudioai/sim/tree/fix/v0919-review-followups
Conversation 2 https://github.com/simstudioai/sim/pull/8928
Commits 1 https://github.com/simstudioai/sim/pull/8928/commits
Checks 47 https://github.com/simstudioai/sim/pull/8928/checks
Files changed https://github.com/simstudioai/sim/pull/8928/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8928/files
fix(chat): name stackless error subclasses and compact stored unfinished tool params https://github.com/simstudioai/sim/pull/8928/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/8928/files
9efd683 fix(chat): name stackless error subclasses and compact stored unfinis… waleedlatif1 Oct 12, 2026 https://github.com/simstudioai/sim/pull/8928/commits/9efd683ce54c65fe39d7f6221784b01dd3bdcc92
Clear filters https://github.com/simstudioai/sim/pull/8928/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8928/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8928/files
code-failure.test.ts https://github.com/simstudioai/sim/pull/8928/files#diff-edd20857e3994c24b360e1d76e4f50a5ad508779426e63fed98d46e3ac726469
code-failure.ts https://github.com/simstudioai/sim/pull/8928/files#diff-0911480c6ac5d49a3343623ec14cd5dac8bd33125a0977a5a60a0dadf9d9751a
display-message.ts https://github.com/simstudioai/sim/pull/8928/files#diff-5b9b546632b2a5744a658adb5a753c357a72b3c7b05e97eee994b987a34eea37
live-message-id.ts https://github.com/simstudioai/sim/pull/8928/files#diff-e2af086435edced813a06d7713a676acf57df9a0a92b80f38b38ec7e2cbd56a5
persisted-message.test.ts https://github.com/simstudioai/sim/pull/8928/files#diff-239f9d0985dfc739b3e9e7ec56af1f316a2048eade672168c0c69eb518a7b9e9
persisted-message.ts https://github.com/simstudioai/sim/pull/8928/files#diff-1faeecc19a448ec1a06d94e9f15173be80eef721479b80608fa0b961eff2b280
apps/sim/lib/execution/remote-sandbox/code-failure.test.tshttps://github.com/simstudioai/sim/pull/8928/files#diff-edd20857e3994c24b360e1d76e4f50a5ad508779426e63fed98d46e3ac726469
View file https://github.com/simstudioai/sim/blob/9efd683ce54c65fe39d7f6221784b01dd3bdcc92/apps/sim/lib/execution/remote-sandbox/code-failure.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8928/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8928/files#diff-edd20857e3994c24b360e1d76e4f50a5ad508779426e63fed98d46e3ac726469
https://github.com/simstudioai/sim/pull/8928/files#diff-edd20857e3994c24b360e1d76e4f50a5ad508779426e63fed98d46e3ac726469
https://github.com/simstudioai/sim/pull/8928/files#diff-edd20857e3994c24b360e1d76e4f50a5ad508779426e63fed98d46e3ac726469
https://github.com/simstudioai/sim/pull/8928/files#diff-edd20857e3994c24b360e1d76e4f50a5ad508779426e63fed98d46e3ac726469
apps/sim/lib/execution/remote-sandbox/code-failure.tshttps://github.com/simstudioai/sim/pull/8928/files#diff-0911480c6ac5d49a3343623ec14cd5dac8bd33125a0977a5a60a0dadf9d9751a
View file https://github.com/simstudioai/sim/blob/9efd683ce54c65fe39d7f6221784b01dd3bdcc92/apps/sim/lib/execution/remote-sandbox/code-failure.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8928/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8928/files#diff-0911480c6ac5d49a3343623ec14cd5dac8bd33125a0977a5a60a0dadf9d9751a
https://github.com/simstudioai/sim/pull/8928/files#diff-0911480c6ac5d49a3343623ec14cd5dac8bd33125a0977a5a60a0dadf9d9751a
apps/sim/lib/mothership/chat/display-message.tshttps://github.com/simstudioai/sim/pull/8928/files#diff-5b9b546632b2a5744a658adb5a753c357a72b3c7b05e97eee994b987a34eea37
View file https://github.com/simstudioai/sim/blob/9efd683ce54c65fe39d7f6221784b01dd3bdcc92/apps/sim/lib/mothership/chat/display-message.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8928/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8928/files#diff-5b9b546632b2a5744a658adb5a753c357a72b3c7b05e97eee994b987a34eea37
https://github.com/simstudioai/sim/pull/8928/files#diff-5b9b546632b2a5744a658adb5a753c357a72b3c7b05e97eee994b987a34eea37
https://github.com/simstudioai/sim/pull/8928/files#diff-5b9b546632b2a5744a658adb5a753c357a72b3c7b05e97eee994b987a34eea37
apps/sim/lib/mothership/chat/live-message-id.tshttps://github.com/simstudioai/sim/pull/8928/files#diff-e2af086435edced813a06d7713a676acf57df9a0a92b80f38b38ec7e2cbd56a5
View file https://github.com/simstudioai/sim/blob/9efd683ce54c65fe39d7f6221784b01dd3bdcc92/apps/sim/lib/mothership/chat/live-message-id.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8928/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8928/files#diff-e2af086435edced813a06d7713a676acf57df9a0a92b80f38b38ec7e2cbd56a5
apps/sim/lib/mothership/chat/persisted-message.test.tshttps://github.com/simstudioai/sim/pull/8928/files#diff-239f9d0985dfc739b3e9e7ec56af1f316a2048eade672168c0c69eb518a7b9e9
View file https://github.com/simstudioai/sim/blob/9efd683ce54c65fe39d7f6221784b01dd3bdcc92/apps/sim/lib/mothership/chat/persisted-message.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8928/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8928/files#diff-239f9d0985dfc739b3e9e7ec56af1f316a2048eade672168c0c69eb518a7b9e9
https://github.com/simstudioai/sim/pull/8928/files#diff-239f9d0985dfc739b3e9e7ec56af1f316a2048eade672168c0c69eb518a7b9e9
https://github.com/simstudioai/sim/pull/8928/files#diff-239f9d0985dfc739b3e9e7ec56af1f316a2048eade672168c0c69eb518a7b9e9
https://github.com/simstudioai/sim/pull/8928/files#diff-239f9d0985dfc739b3e9e7ec56af1f316a2048eade672168c0c69eb518a7b9e9
apps/sim/lib/mothership/chat/persisted-message.tshttps://github.com/simstudioai/sim/pull/8928/files#diff-1faeecc19a448ec1a06d94e9f15173be80eef721479b80608fa0b961eff2b280
View file https://github.com/simstudioai/sim/blob/9efd683ce54c65fe39d7f6221784b01dd3bdcc92/apps/sim/lib/mothership/chat/persisted-message.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8928/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8928/files#diff-1faeecc19a448ec1a06d94e9f15173be80eef721479b80608fa0b961eff2b280
https://github.com/simstudioai/sim/pull/8928/files#diff-1faeecc19a448ec1a06d94e9f15173be80eef721479b80608fa0b961eff2b280
https://github.com/simstudioai/sim/pull/8928/files#diff-1faeecc19a448ec1a06d94e9f15173be80eef721479b80608fa0b961eff2b280
https://github.com/simstudioai/sim/pull/8928/files#diff-1faeecc19a448ec1a06d94e9f15173be80eef721479b80608fa0b961eff2b280
https://github.com/simstudioai/sim/pull/8928/files#diff-1faeecc19a448ec1a06d94e9f15173be80eef721479b80608fa0b961eff2b280
Please reload this pagehttps://github.com/simstudioai/sim/pull/8928/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.