René's URL Explorer Experiment


Title: fix(files): refuse an unknown file per read instead of blanking the Chat tool result by waleedlatif1 · Pull Request #8922 · simstudioai/sim · GitHub

Open Graph Title: fix(files): refuse an unknown file per read instead of blanking the Chat tool result by waleedlatif1 · Pull Request #8922 · simstudioai/sim

X Title: fix(files): refuse an unknown file per read instead of blanking the Chat tool result by waleedlatif1 · Pull Request #8922 · simstudioai/sim

Description: Summary Bug: a Chat CLI text read (grep --scope files, files read) of a file whose secret provenance is unknown returned the text anyway and marked the per-tool-call registry permanently incomplete. Egress then withheld the entire tool result, so one tainted file blanked every match of a workspace-wide grep. Forwarded version and bulk reads refused the bytes and also poisoned the registry, which added no protection. Fix: Text reads now refuse just that file, from the delivery observer, before its bytes load. The refusal is a 403 with File cannot be sent to a model because its secret provenance is unavailable, through the standard v2 file error policy. Forwarded responses return the same 403 instead of poisoning and a misleading "Retry the read" 503. grep reports the refused file as unreadable and returns the clean matches. Direct downloads (files get, including -o workbench sinks) are unchanged, on purpose. They still deliver the bytes and mark the invocation incomplete. A byte copy in the workbench has to carry its unknown classification onto anything derived from it (file-round-trip-provenance.test.ts), and a download serves one file per call, so there are no other files' results to blank. Attribution: reportWorkspaceFileDelivery now takes the canonical file id, and the transport passes it to the refusal telemetry. "Refusing unavailable durable secret provenance" now names the refused file. Security property: a refused text or forwarded read never loads or returns its bytes. Every other unknown path still withholds, including a registry that's incomplete for any other reason (covered by a test). Alternatives considered: Per-source withholding in the egress projection: unknown lists no values to redact, and grep output interleaves lines from many files. Doing it soundly would mean tracking which file each output span came from through the CLI. Skipping tainted files inside universal-grep: grep only sees the public wire shape, not provenance, and that would leave other multi-file reads with the same bug. Moving the policy into readWorkspaceFileText: that use case is shared with the public v2 API. The delivery observer exists to keep Chat policy out of it, and it already supports "the observer throws, so no bytes are read". Type of Change Bug fix Testing New and updated tests in file-provenance.test.ts: a grep over a clean file and an unknown file returns the clean match, refuses only the unknown one, and logs exactly one refusal with the right file id; a forwarded unknown response gets a 403 without the bytes; an unknown files read is refused before its bytes load; a registry that's incomplete for another reason still withholds. All 6 new or changed transport tests fail on the previous transport. Full apps/sim unit suite, plus the PostgreSQL/Redis provenance integration suites (file-versions, upload-read-provenance, execution-archive-provenance, external-file-provenance, workbench-file-provenance). bun run lint, type-check, and all 59 audits. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Bug: a Chat CLI text read (grep --scope files, files read) of a file whose secret provenance is unknown returned the text anyway and marked the per-tool-call registry permanently incomplet...

X Description: Summary Bug: a Chat CLI text read (grep --scope files, files read) of a file whose secret provenance is unknown returned the text anyway and marked the per-tool-call registry permanently incomplet...

Opengraph URL: https://github.com/simstudioai/sim/pull/8922

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e43cf78a-8c74-63da-005c-72cd608a8e05
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE3B0:2C50EC:27D939:37C7DC:6AFB713F
html-safe-noncea717806753b859e034cefc0041496d555e0a3d2ace7eb4015890c8da7d1e8f1b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0IwOjJDNTBFQzoyN0Q5Mzk6MzdDN0RDOjZBRkI3MTNGIiwidmlzaXRvcl9pZCI6IjgyMDU5MDA5MDQ3NzE4NDIzNjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc560d084b1291bd98834a3a9cd36d2a27b03772c5bbddd93296aa71a0f245cbf
hovercard-subject-tagpull_request:4830476011
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8922/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Bug: a Chat CLI text read (grep --scope files, files read) of a file whose secret provenance is unknown returned the text anyway and marked the per-tool-call registry permanently incomplet...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8922/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8922%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8922%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8922/files
Reloadhttps://github.com/simstudioai/sim/pull/8922/files
Reloadhttps://github.com/simstudioai/sim/pull/8922/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/file-read-per-file-provenance-refusalhttps://github.com/simstudioai/sim/tree/fix/file-read-per-file-provenance-refusal
Conversation 8 https://github.com/simstudioai/sim/pull/8922
Commits 3 https://github.com/simstudioai/sim/pull/8922/commits
Checks 46 https://github.com/simstudioai/sim/pull/8922/checks
Files changed https://github.com/simstudioai/sim/pull/8922/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8922/files
fix(files): refuse an unknown file per read instead of blanking the Chat tool result https://github.com/simstudioai/sim/pull/8922/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/8922/files
df06784 fix(files): refuse an unknown file per read instead of blanking the C… waleedlatif1 Oct 12, 2026 https://github.com/simstudioai/sim/pull/8922/commits/df067841462325023a57fb8705415f4094f565fe
f1e3c5b test(files): expect a per-file refusal for an unknown historical vers… waleedlatif1 Oct 12, 2026 https://github.com/simstudioai/sim/pull/8922/commits/f1e3c5bcacdcdd61538c00c2eafab71734f91c6f
fbe7511 fix(files): attribute each forwarded delivery's refusal to its own file waleedlatif1 Oct 12, 2026 https://github.com/simstudioai/sim/pull/8922/commits/fbe75114d2c15504792978123185a6a531ad922d
Clear filters https://github.com/simstudioai/sim/pull/8922/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8922/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8922/files
file-provenance.test.ts https://github.com/simstudioai/sim/pull/8922/files#diff-ec0462e4f4db7f888a44af585279a10e932c3f31049cd5d63cc687564cc3762b
file-read-transport.ts https://github.com/simstudioai/sim/pull/8922/files#diff-3a8b694e941783d9e0c3c39bd7e088cb4ad1f846b2e427966229ba70ee4b960a
workbench-confidentiality.live.test.ts https://github.com/simstudioai/sim/pull/8922/files#diff-967ee2c12a0371e8cc44c872f1d27206ae3ac046d1c70283483db0cb5155b35e
sandbox-resource-transport.test.ts https://github.com/simstudioai/sim/pull/8922/files#diff-7c532b52f412620a32c9b0d16a7d3381da2f952f866072ea2d42d81421e70f8a
copilot-file-versions.integration.ts https://github.com/simstudioai/sim/pull/8922/files#diff-192f54b5313876ab03243b3d80fab15281c3484e712e11c2e770e3ee0d4656f5
download-workspace-file.test.ts https://github.com/simstudioai/sim/pull/8922/files#diff-4149a498e154898f2048f9393f3dd7f50c6f9c6381edda4df18430e9e8b56074
download-workspace-file.ts https://github.com/simstudioai/sim/pull/8922/files#diff-6f2441601aac3bdfc13ceb847faa4f9d558f33b56b8390a6a130f6b8650a12a1
file-delivery-observer.ts https://github.com/simstudioai/sim/pull/8922/files#diff-a96ceb38e11d68f943ccf1cbbabde87767a7fbcd0f6a1b72059cbc704234c20a
file-versions.ts https://github.com/simstudioai/sim/pull/8922/files#diff-860d5d55abd8503974107012d58b44862cdd0527212f52dee4a59a49b83941be
read-workspace-file-text.test.ts https://github.com/simstudioai/sim/pull/8922/files#diff-8d5b5817e53445fb4adc78d20a04fb4b3727fcafde7497b76836dd8db9edfc4d
read-workspace-file-text.ts https://github.com/simstudioai/sim/pull/8922/files#diff-a5b5e4419228e72a99445bf57332a6aae0f19026cf3563a227e5fe4f922a51c3
apps/sim/lib/mothership/agent-cli/file-provenance.test.tshttps://github.com/simstudioai/sim/pull/8922/files#diff-ec0462e4f4db7f888a44af585279a10e932c3f31049cd5d63cc687564cc3762b
View file https://github.com/simstudioai/sim/blob/fbe75114d2c15504792978123185a6a531ad922d/apps/sim/lib/mothership/agent-cli/file-provenance.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8922/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8922/files#diff-ec0462e4f4db7f888a44af585279a10e932c3f31049cd5d63cc687564cc3762b
https://github.com/simstudioai/sim/pull/8922/files#diff-ec0462e4f4db7f888a44af585279a10e932c3f31049cd5d63cc687564cc3762b
https://github.com/simstudioai/sim/pull/8922/files#diff-ec0462e4f4db7f888a44af585279a10e932c3f31049cd5d63cc687564cc3762b
https://github.com/simstudioai/sim/pull/8922/files#diff-ec0462e4f4db7f888a44af585279a10e932c3f31049cd5d63cc687564cc3762b
https://github.com/simstudioai/sim/pull/8922/files#diff-ec0462e4f4db7f888a44af585279a10e932c3f31049cd5d63cc687564cc3762b
https://github.com/simstudioai/sim/pull/8922/files#diff-ec0462e4f4db7f888a44af585279a10e932c3f31049cd5d63cc687564cc3762b
https://github.com/simstudioai/sim/pull/8922/files#diff-ec0462e4f4db7f888a44af585279a10e932c3f31049cd5d63cc687564cc3762b
https://github.com/simstudioai/sim/pull/8922/files#diff-ec0462e4f4db7f888a44af585279a10e932c3f31049cd5d63cc687564cc3762b
https://github.com/simstudioai/sim/pull/8922/files#diff-ec0462e4f4db7f888a44af585279a10e932c3f31049cd5d63cc687564cc3762b
https://github.com/simstudioai/sim/pull/8922/files#diff-ec0462e4f4db7f888a44af585279a10e932c3f31049cd5d63cc687564cc3762b
apps/sim/lib/mothership/agent-cli/file-read-transport.tshttps://github.com/simstudioai/sim/pull/8922/files#diff-3a8b694e941783d9e0c3c39bd7e088cb4ad1f846b2e427966229ba70ee4b960a
View file https://github.com/simstudioai/sim/blob/fbe75114d2c15504792978123185a6a531ad922d/apps/sim/lib/mothership/agent-cli/file-read-transport.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8922/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8922/files#diff-3a8b694e941783d9e0c3c39bd7e088cb4ad1f846b2e427966229ba70ee4b960a
https://github.com/simstudioai/sim/pull/8922/files#diff-3a8b694e941783d9e0c3c39bd7e088cb4ad1f846b2e427966229ba70ee4b960a
https://github.com/simstudioai/sim/pull/8922/files#diff-3a8b694e941783d9e0c3c39bd7e088cb4ad1f846b2e427966229ba70ee4b960a
https://github.com/simstudioai/sim/pull/8922/files#diff-3a8b694e941783d9e0c3c39bd7e088cb4ad1f846b2e427966229ba70ee4b960a
https://github.com/simstudioai/sim/pull/8922/files#diff-3a8b694e941783d9e0c3c39bd7e088cb4ad1f846b2e427966229ba70ee4b960a
https://github.com/simstudioai/sim/pull/8922/files#diff-3a8b694e941783d9e0c3c39bd7e088cb4ad1f846b2e427966229ba70ee4b960a
https://github.com/simstudioai/sim/pull/8922/files#diff-3a8b694e941783d9e0c3c39bd7e088cb4ad1f846b2e427966229ba70ee4b960a
https://github.com/simstudioai/sim/pull/8922/files#diff-3a8b694e941783d9e0c3c39bd7e088cb4ad1f846b2e427966229ba70ee4b960a
https://github.com/simstudioai/sim/pull/8922/files#diff-3a8b694e941783d9e0c3c39bd7e088cb4ad1f846b2e427966229ba70ee4b960a
https://github.com/simstudioai/sim/pull/8922/files#diff-3a8b694e941783d9e0c3c39bd7e088cb4ad1f846b2e427966229ba70ee4b960a
Please reload this pagehttps://github.com/simstudioai/sim/pull/8922/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.