Title: fix(sandbox): name a failed Function's error from its headline, not an inspected property by waleedlatif1 · Pull Request #8921 · simstudioai/sim · GitHub
Open Graph Title: fix(sandbox): name a failed Function's error from its headline, not an inspected property by waleedlatif1 · Pull Request #8921 · simstudioai/sim
X Title: fix(sandbox): name a failed Function's error from its headline, not an inspected property by waleedlatif1 · Pull Request #8921 · simstudioai/sim
Description: Summary A failed sandboxed Function (E2B / Daytona, JavaScript and Python) named its error from the last trimmed identifier: value line of stderr. Node prints an error's own properties indented beneath it, so the error took the name of a property: a fetch that lost its socket surfaced as bytesRead: 0 (a reset as syscall: 'read'), an ENOENT as its path, a custom error as one of its fields, a missing module as code: 'ERR_MODULE_NOT_FOUND'. Match only top-level error headlines: unindented, with a space after the colon (so source-location headers like node:internal/x:12 / file:///x.mjs:3 don't match), plus Node's Name [CODE]: message and bracketed [Name: message] { forms. The traceback itself is unchanged and still returned in full. Type of Change Bug fix Testing Ran 33 real failure shapes through node 22 and python3 (socket closed / reset / refused fetches, custom errors with properties, ENOENT, coded Node errors, AggregateError, cause chains, thrown strings/objects, syntax errors, Python tracebacks incl. chained, custom-module and SyntaxError) and compared old vs new parser: 13 now name the real error, 20 unchanged (every Python case), none worse New code-failure.test.ts built from real stderr fixtures; 5 of its cases fail on the previous parser (incl. the bytesRead: 0 fetch case), Python cases pass on both biome on changed files Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary A failed sandboxed Function (E2B / Daytona, JavaScript and Python) named its error from the last trimmed identifier: value line of stderr. Node prints an error's own properties indente...
X Description: Summary A failed sandboxed Function (E2B / Daytona, JavaScript and Python) named its error from the last trimmed identifier: value line of stderr. Node prints an error's own properties ind...
Opengraph URL: https://github.com/simstudioai/sim/pull/8921
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:91da98b4-745a-6122-f4a7-b0c8e9e98c7f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9116:1D33A1:1375B6F:1A9F4F3:6AFB714E |
| html-safe-nonce | 9c606318441430573d847dcb9f0479b68d2a43a93145765e35ac399d0b307a38 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTE2OjFEMzNBMToxMzc1QjZGOjFBOUY0RjM6NkFGQjcxNEUiLCJ2aXNpdG9yX2lkIjoiMTExNDE5MjI2NTg3NTI1NTYzMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 90353c12663f89c078a91ddfd0256805f0968b5cfaf042255241154dadc517aa |
| hovercard-subject-tag | pull_request:4829988288 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8921/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary A failed sandboxed Function (E2B / Daytona, JavaScript and Python) named its error from the last trimmed identifier: value line of stderr. Node prints an error's own properties indente... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2e8872b770cc4d5d0cc1f2026afab747a268e2ce |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width