René's URL Explorer Experiment


Title: perf(auth): stop blocking requests on best-effort last-used timestamp writes by waleedlatif1 · Pull Request #8910 · simstudioai/sim · GitHub

Open Graph Title: perf(auth): stop blocking requests on best-effort last-used timestamp writes by waleedlatif1 · Pull Request #8910 · simstudioai/sim

X Title: perf(auth): stop blocking requests on best-effort last-used timestamp writes by waleedlatif1 · Pull Request #8910 · simstudioai/sim

Description: Summary Every authenticated request awaited the API key lastUsed write, and the desktop inbox poll awaited the device lastSeenAt write. When commits wait on synchronous replication, those single-row writes stalled for the whole episode and held the request with them; concurrent requests on the same key queued behind the stalled writer's row lock, each holding a pool connection. Both writes now go through createDetachedTouch (built on runDetached): the caller never waits, and a key never has two writes pending, so a stalled commit can't stack writes on the same row lock. The API key write is also debounced per process over its existing staleness window; the desktop write is not, because the offline check reads lastSeenAt and its SQL guard already bounds the write rate. Type of Change Performance improvement Testing lib/core/utils/background.test.ts: caller doesn't wait, repeats inside the interval are skipped, no overlapping write while one is pending (fails without the in-flight guard), a failed write releases its key lib/api-key/service.test.ts passes biome on changed files; CI runs type-check, audits and the full suite Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Every authenticated request awaited the API key lastUsed write, and the desktop inbox poll awaited the device lastSeenAt write. When commits wait on synchronous replication, those single-r...

X Description: Summary Every authenticated request awaited the API key lastUsed write, and the desktop inbox poll awaited the device lastSeenAt write. When commits wait on synchronous replication, those single-r...

Opengraph URL: https://github.com/simstudioai/sim/pull/8910

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f8617bf4-1936-f7f3-3804-c137ff83089e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAFD4:21EB6D:91221E:CE1EFD:6AFB5151
html-safe-nonceeaeb5342c034f8c3a415719afacb2712797ffb4c9cb2f99528309aed62df6daa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRkQ0OjIxRUI2RDo5MTIyMUU6Q0UxRUZEOjZBRkI1MTUxIiwidmlzaXRvcl9pZCI6Ijc0OTA3NDQzOTcwNzYzMjA1OTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf5c2e752603850753403becc3fb44f43b266e4c3c3089191e70591f17bfa6968
hovercard-subject-tagpull_request:4815024216
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8910/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Every authenticated request awaited the API key lastUsed write, and the desktop inbox poll awaited the device lastSeenAt write. When commits wait on synchronous replication, those single-r...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8910/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8910%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8910%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8910/files
Reloadhttps://github.com/simstudioai/sim/pull/8910/files
Reloadhttps://github.com/simstudioai/sim/pull/8910/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
perf/last-used-writeshttps://github.com/simstudioai/sim/tree/perf/last-used-writes
Conversation 14 https://github.com/simstudioai/sim/pull/8910
Commits 3 https://github.com/simstudioai/sim/pull/8910/commits
Checks 48 https://github.com/simstudioai/sim/pull/8910/checks
Files changed https://github.com/simstudioai/sim/pull/8910/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8910/files
perf(auth): stop blocking requests on best-effort last-used timestamp writes https://github.com/simstudioai/sim/pull/8910/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/8910/files
2f84984 perf(auth): stop blocking requests on best-effort last-used timestamp… waleedlatif1 Oct 10, 2026 https://github.com/simstudioai/sim/pull/8910/commits/2f84984e549d992abb6549b88ec1aecc782f03af
9780d77 fix(auth): never overlap last-used and last-seen writes for the same key waleedlatif1 Oct 10, 2026 https://github.com/simstudioai/sim/pull/8910/commits/9780d7757485b5de4249f9b9bdf8b5b74a6fcf64
10d66d9 fix(core): release a detached touch key even if its write throws sync… waleedlatif1 Oct 11, 2026 https://github.com/simstudioai/sim/pull/8910/commits/10d66d93fa66b1a53dc3fffe9799a72c30127645
Clear filters https://github.com/simstudioai/sim/pull/8910/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8910/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8910/files
auth.ts https://github.com/simstudioai/sim/pull/8910/files#diff-9da18269fd8b12862531cbe9c284ac19ace7838be677cda04fa7b4fe4523906a
middleware.ts https://github.com/simstudioai/sim/pull/8910/files#diff-49d789f6b5f17292fae5f7b6d34e2c4a08ca6dad83c6142aaad11b995bff30de
service.test.ts https://github.com/simstudioai/sim/pull/8910/files#diff-54be86c327a9dd03b739ce0a26dc0b8419e52ae20d4a5941ddd4282c6c8b2ed9
service.ts https://github.com/simstudioai/sim/pull/8910/files#diff-a321edf7bd8b74f2d6b18b7f2ffa9ad0e9f794e3ee042a0ac8387e15020f85b2
v2-api-key-auth.ts https://github.com/simstudioai/sim/pull/8910/files#diff-e8eec0542ccb0669db3bbf09dd3a622aba5c03a02ea2414f98e9b60c1d3ba91e
hybrid.ts https://github.com/simstudioai/sim/pull/8910/files#diff-7ffcb73ac93024d9bf0116fd7275bfb537b8ecd4f51c030014b7a1590b1afc16
background.test.ts https://github.com/simstudioai/sim/pull/8910/files#diff-42856ab793f8f2d79160f1f6249d104fa45f1888da3b51e57780c57275e23251
background.ts https://github.com/simstudioai/sim/pull/8910/files#diff-ce2ca80deb3f0695746ad1110852830ae5e73609b27dbcd1e91e52b042bb5d35
executor.ts https://github.com/simstudioai/sim/pull/8910/files#diff-4fbf53cb759a7d5ef3e2b0831ac9392d6e2ae214282817aed443f6bfcff894c2
route-policies.ts https://github.com/simstudioai/sim/pull/8910/files#diff-6747c051da408a50ebee8a0707d2f889c3f82a3e0de1149e6cbbb7b27744a59e
apps/sim/app/api/v1/auth.tshttps://github.com/simstudioai/sim/pull/8910/files#diff-9da18269fd8b12862531cbe9c284ac19ace7838be677cda04fa7b4fe4523906a
View file https://github.com/simstudioai/sim/blob/10d66d93fa66b1a53dc3fffe9799a72c30127645/apps/sim/app/api/v1/auth.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8910/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8910/files#diff-9da18269fd8b12862531cbe9c284ac19ace7838be677cda04fa7b4fe4523906a
https://github.com/simstudioai/sim/pull/8910/files#diff-9da18269fd8b12862531cbe9c284ac19ace7838be677cda04fa7b4fe4523906a
apps/sim/app/api/workflows/middleware.tshttps://github.com/simstudioai/sim/pull/8910/files#diff-49d789f6b5f17292fae5f7b6d34e2c4a08ca6dad83c6142aaad11b995bff30de
View file https://github.com/simstudioai/sim/blob/10d66d93fa66b1a53dc3fffe9799a72c30127645/apps/sim/app/api/workflows/middleware.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8910/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8910/files#diff-49d789f6b5f17292fae5f7b6d34e2c4a08ca6dad83c6142aaad11b995bff30de
https://github.com/simstudioai/sim/pull/8910/files#diff-49d789f6b5f17292fae5f7b6d34e2c4a08ca6dad83c6142aaad11b995bff30de
apps/sim/lib/api-key/service.test.tshttps://github.com/simstudioai/sim/pull/8910/files#diff-54be86c327a9dd03b739ce0a26dc0b8419e52ae20d4a5941ddd4282c6c8b2ed9
View file https://github.com/simstudioai/sim/blob/10d66d93fa66b1a53dc3fffe9799a72c30127645/apps/sim/lib/api-key/service.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8910/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8910/files#diff-54be86c327a9dd03b739ce0a26dc0b8419e52ae20d4a5941ddd4282c6c8b2ed9
https://github.com/simstudioai/sim/pull/8910/files#diff-54be86c327a9dd03b739ce0a26dc0b8419e52ae20d4a5941ddd4282c6c8b2ed9
https://github.com/simstudioai/sim/pull/8910/files#diff-54be86c327a9dd03b739ce0a26dc0b8419e52ae20d4a5941ddd4282c6c8b2ed9
https://github.com/simstudioai/sim/pull/8910/files#diff-54be86c327a9dd03b739ce0a26dc0b8419e52ae20d4a5941ddd4282c6c8b2ed9
apps/sim/lib/api-key/service.tshttps://github.com/simstudioai/sim/pull/8910/files#diff-a321edf7bd8b74f2d6b18b7f2ffa9ad0e9f794e3ee042a0ac8387e15020f85b2
View file https://github.com/simstudioai/sim/blob/10d66d93fa66b1a53dc3fffe9799a72c30127645/apps/sim/lib/api-key/service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8910/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8910/files#diff-a321edf7bd8b74f2d6b18b7f2ffa9ad0e9f794e3ee042a0ac8387e15020f85b2
https://github.com/simstudioai/sim/pull/8910/files#diff-a321edf7bd8b74f2d6b18b7f2ffa9ad0e9f794e3ee042a0ac8387e15020f85b2
https://github.com/simstudioai/sim/pull/8910/files#diff-a321edf7bd8b74f2d6b18b7f2ffa9ad0e9f794e3ee042a0ac8387e15020f85b2
https://github.com/simstudioai/sim/pull/8910/files#diff-a321edf7bd8b74f2d6b18b7f2ffa9ad0e9f794e3ee042a0ac8387e15020f85b2
apps/sim/lib/api/server/routes/v2-api-key-auth.tshttps://github.com/simstudioai/sim/pull/8910/files#diff-e8eec0542ccb0669db3bbf09dd3a622aba5c03a02ea2414f98e9b60c1d3ba91e
View file https://github.com/simstudioai/sim/blob/10d66d93fa66b1a53dc3fffe9799a72c30127645/apps/sim/lib/api/server/routes/v2-api-key-auth.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8910/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8910/files#diff-e8eec0542ccb0669db3bbf09dd3a622aba5c03a02ea2414f98e9b60c1d3ba91e
https://github.com/simstudioai/sim/pull/8910/files#diff-e8eec0542ccb0669db3bbf09dd3a622aba5c03a02ea2414f98e9b60c1d3ba91e
apps/sim/lib/auth/hybrid.tshttps://github.com/simstudioai/sim/pull/8910/files#diff-7ffcb73ac93024d9bf0116fd7275bfb537b8ecd4f51c030014b7a1590b1afc16
View file https://github.com/simstudioai/sim/blob/10d66d93fa66b1a53dc3fffe9799a72c30127645/apps/sim/lib/auth/hybrid.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8910/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8910/files#diff-7ffcb73ac93024d9bf0116fd7275bfb537b8ecd4f51c030014b7a1590b1afc16
https://github.com/simstudioai/sim/pull/8910/files#diff-7ffcb73ac93024d9bf0116fd7275bfb537b8ecd4f51c030014b7a1590b1afc16
apps/sim/lib/core/utils/background.test.tshttps://github.com/simstudioai/sim/pull/8910/files#diff-42856ab793f8f2d79160f1f6249d104fa45f1888da3b51e57780c57275e23251
View file https://github.com/simstudioai/sim/blob/10d66d93fa66b1a53dc3fffe9799a72c30127645/apps/sim/lib/core/utils/background.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8910/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8910/files#diff-42856ab793f8f2d79160f1f6249d104fa45f1888da3b51e57780c57275e23251
apps/sim/lib/core/utils/background.tshttps://github.com/simstudioai/sim/pull/8910/files#diff-ce2ca80deb3f0695746ad1110852830ae5e73609b27dbcd1e91e52b042bb5d35
View file https://github.com/simstudioai/sim/blob/10d66d93fa66b1a53dc3fffe9799a72c30127645/apps/sim/lib/core/utils/background.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8910/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8910/files#diff-ce2ca80deb3f0695746ad1110852830ae5e73609b27dbcd1e91e52b042bb5d35
apps/sim/lib/desktop/application/executor.tshttps://github.com/simstudioai/sim/pull/8910/files#diff-4fbf53cb759a7d5ef3e2b0831ac9392d6e2ae214282817aed443f6bfcff894c2
View file https://github.com/simstudioai/sim/blob/10d66d93fa66b1a53dc3fffe9799a72c30127645/apps/sim/lib/desktop/application/executor.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8910/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8910/files#diff-4fbf53cb759a7d5ef3e2b0831ac9392d6e2ae214282817aed443f6bfcff894c2
https://github.com/simstudioai/sim/pull/8910/files#diff-4fbf53cb759a7d5ef3e2b0831ac9392d6e2ae214282817aed443f6bfcff894c2
https://github.com/simstudioai/sim/pull/8910/files#diff-4fbf53cb759a7d5ef3e2b0831ac9392d6e2ae214282817aed443f6bfcff894c2
https://github.com/simstudioai/sim/pull/8910/files#diff-4fbf53cb759a7d5ef3e2b0831ac9392d6e2ae214282817aed443f6bfcff894c2
https://github.com/simstudioai/sim/pull/8910/files#diff-4fbf53cb759a7d5ef3e2b0831ac9392d6e2ae214282817aed443f6bfcff894c2
https://github.com/simstudioai/sim/pull/8910/files#diff-4fbf53cb759a7d5ef3e2b0831ac9392d6e2ae214282817aed443f6bfcff894c2
apps/sim/lib/workflows/api/route-policies.tshttps://github.com/simstudioai/sim/pull/8910/files#diff-6747c051da408a50ebee8a0707d2f889c3f82a3e0de1149e6cbbb7b27744a59e
View file https://github.com/simstudioai/sim/blob/10d66d93fa66b1a53dc3fffe9799a72c30127645/apps/sim/lib/workflows/api/route-policies.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8910/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8910/files#diff-6747c051da408a50ebee8a0707d2f889c3f82a3e0de1149e6cbbb7b27744a59e
https://github.com/simstudioai/sim/pull/8910/files#diff-6747c051da408a50ebee8a0707d2f889c3f82a3e0de1149e6cbbb7b27744a59e
Please reload this pagehttps://github.com/simstudioai/sim/pull/8910/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.