René's URL Explorer Experiment


Title: perf(knowledge): lock the knowledge base row FOR NO KEY UPDATE on document writes by waleedlatif1 · Pull Request #8909 · simstudioai/sim · GitHub

Open Graph Title: perf(knowledge): lock the knowledge base row FOR NO KEY UPDATE on document writes by waleedlatif1 · Pull Request #8909 · simstudioai/sim

X Title: perf(knowledge): lock the knowledge base row FOR NO KEY UPDATE on document writes by waleedlatif1 · Pull Request #8909 · simstudioai/sim

Description: Summary Document uploads, document hard deletes, connector creation, and knowledge base restore locked the parent knowledge_base row FOR UPDATE. Every embedding insert takes FOR KEY SHARE on that row through its foreign key for the whole indexing transaction, and FOR UPDATE conflicts with it, so these writes queued behind any indexing pass in the same knowledge base (and a hard delete could deadlock against an indexing pass on one of its own documents). Switch those sites to FOR NO KEY UPDATE. It still conflicts with itself, FOR SHARE (connector sync), FOR UPDATE (KB move, tag mutations) and any UPDATE/DELETE of the row, so every serialization these locks provided is kept; only the foreign-key KEY SHARE conflict goes away. KB move and tag mutations keep FOR UPDATE (they do need to exclude child inserts). Matches soft delete and connector cleanup, which already use FOR NO KEY UPDATE. Type of Change Performance improvement Testing Verified every lock site, the work done under each lock, and every other locker/writer of the row; nothing under these locks writes knowledge_base.id (the only key column) or enforces a count-based limit New integration case: single and bulk uploads, then a hard delete, each must commit while another transaction holds FOR KEY SHARE on the KB row (as an in-flight embedding insert does); with FOR UPDATE they wait on it and the case times out biome on changed files; CI runs type-check, audits and the integration suite Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Document uploads, document hard deletes, connector creation, and knowledge base restore locked the parent knowledge_base row FOR UPDATE. Every embedding insert takes FOR KEY SHARE on that ...

X Description: Summary Document uploads, document hard deletes, connector creation, and knowledge base restore locked the parent knowledge_base row FOR UPDATE. Every embedding insert takes FOR KEY SHARE on that ...

Opengraph URL: https://github.com/simstudioai/sim/pull/8909

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a10f8190-fa90-e9cd-5cb1-45dbfc7e5f6d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDBCC:14B945:CB604D:117F5B8:6AFB5A9B
html-safe-nonced313a0f2657b41a015758018ed0c11bb884ac5c09700bff50d37b645d36dfb92
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQkNDOjE0Qjk0NTpDQjYwNEQ6MTE3RjVCODo2QUZCNUE5QiIsInZpc2l0b3JfaWQiOiI0NTQ2NzAwMDA4MjMyODAyOTcxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace2a111cc5317299b5533ac031f64e0ae424fe397c9e293665f0a18e3e945e8e3
hovercard-subject-tagpull_request:4815007224
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8909/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Document uploads, document hard deletes, connector creation, and knowledge base restore locked the parent knowledge_base row FOR UPDATE. Every embedding insert takes FOR KEY SHARE on that ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8909/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8909%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8909%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8909/files
Reloadhttps://github.com/simstudioai/sim/pull/8909/files
Reloadhttps://github.com/simstudioai/sim/pull/8909/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
perf/kb-lockhttps://github.com/simstudioai/sim/tree/perf/kb-lock
Conversation 2 https://github.com/simstudioai/sim/pull/8909
Commits 2 https://github.com/simstudioai/sim/pull/8909/commits
Checks 46 https://github.com/simstudioai/sim/pull/8909/checks
Files changed https://github.com/simstudioai/sim/pull/8909/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8909/files
perf(knowledge): lock the knowledge base row FOR NO KEY UPDATE on document writes https://github.com/simstudioai/sim/pull/8909/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/8909/files
53b6499 perf(knowledge): lock the knowledge base row FOR NO KEY UPDATE on doc… waleedlatif1 Oct 10, 2026 https://github.com/simstudioai/sim/pull/8909/commits/53b6499a43a6518c7689aef0ab17139b2317e221
09adc67 test(knowledge): uploads and hard deletes commit while an embedding h… waleedlatif1 Oct 11, 2026 https://github.com/simstudioai/sim/pull/8909/commits/09adc679b937ba1c1a40b42b4a988633906599bc
Clear filters https://github.com/simstudioai/sim/pull/8909/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8909/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8909/files
workspace-import.integration.ts https://github.com/simstudioai/sim/pull/8909/files#diff-6626fe83052081e047e24ccd365f285742d404840817ce046e48172293d8d02e
service.ts https://github.com/simstudioai/sim/pull/8909/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
connectors.ts https://github.com/simstudioai/sim/pull/8909/files#diff-50cb99189b1dc87df12d9b4f50a563206952b53de947873de00ad9f30ef59a25
service.ts https://github.com/simstudioai/sim/pull/8909/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
apps/sim/lib/knowledge/__integration__/workspace-import.integration.tshttps://github.com/simstudioai/sim/pull/8909/files#diff-6626fe83052081e047e24ccd365f285742d404840817ce046e48172293d8d02e
View file https://github.com/simstudioai/sim/blob/09adc679b937ba1c1a40b42b4a988633906599bc/apps/sim/lib/knowledge/__integration__/workspace-import.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8909/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8909/files#diff-6626fe83052081e047e24ccd365f285742d404840817ce046e48172293d8d02e
https://github.com/simstudioai/sim/pull/8909/files#diff-6626fe83052081e047e24ccd365f285742d404840817ce046e48172293d8d02e
https://github.com/simstudioai/sim/pull/8909/files#diff-6626fe83052081e047e24ccd365f285742d404840817ce046e48172293d8d02e
https://github.com/simstudioai/sim/pull/8909/files#diff-6626fe83052081e047e24ccd365f285742d404840817ce046e48172293d8d02e
https://github.com/simstudioai/sim/pull/8909/files#diff-6626fe83052081e047e24ccd365f285742d404840817ce046e48172293d8d02e
https://github.com/simstudioai/sim/pull/8909/files#diff-6626fe83052081e047e24ccd365f285742d404840817ce046e48172293d8d02e
https://github.com/simstudioai/sim/pull/8909/files#diff-6626fe83052081e047e24ccd365f285742d404840817ce046e48172293d8d02e
https://github.com/simstudioai/sim/pull/8909/files#diff-6626fe83052081e047e24ccd365f285742d404840817ce046e48172293d8d02e
apps/sim/lib/knowledge/documents/service.tshttps://github.com/simstudioai/sim/pull/8909/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
View file https://github.com/simstudioai/sim/blob/09adc679b937ba1c1a40b42b4a988633906599bc/apps/sim/lib/knowledge/documents/service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8909/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8909/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/8909/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/8909/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/8909/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/8909/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/8909/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/8909/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
apps/sim/lib/knowledge/orchestration/connectors.tshttps://github.com/simstudioai/sim/pull/8909/files#diff-50cb99189b1dc87df12d9b4f50a563206952b53de947873de00ad9f30ef59a25
View file https://github.com/simstudioai/sim/blob/09adc679b937ba1c1a40b42b4a988633906599bc/apps/sim/lib/knowledge/orchestration/connectors.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8909/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8909/files#diff-50cb99189b1dc87df12d9b4f50a563206952b53de947873de00ad9f30ef59a25
https://github.com/simstudioai/sim/pull/8909/files#diff-50cb99189b1dc87df12d9b4f50a563206952b53de947873de00ad9f30ef59a25
apps/sim/lib/knowledge/service.tshttps://github.com/simstudioai/sim/pull/8909/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
View file https://github.com/simstudioai/sim/blob/09adc679b937ba1c1a40b42b4a988633906599bc/apps/sim/lib/knowledge/service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8909/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8909/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/8909/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
Please reload this pagehttps://github.com/simstudioai/sim/pull/8909/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.