René's URL Explorer Experiment


Title: fix(resume): require write access to resume a paused run on the legacy route by waleedlatif1 · Pull Request #8896 · simstudioai/sim · GitHub

Open Graph Title: fix(resume): require write access to resume a paused run on the legacy route by waleedlatif1 · Pull Request #8896 · simstudioai/sim

X Title: fix(resume): require write access to resume a paused run on the legacy route by waleedlatif1 · Pull Request #8896 · simstudioai/sim

Description: Summary Legacy POST /api/resume/[workflowId]/[executionId]/[contextId] authorized through validateWorkflowAccess, which only checks workspace read, so a read-only member or their API key could answer a human-in-the-loop pause and continue the run with their own input The route now authenticates with internalWorkflowSessionOrApiKeyAuth and runs resumeWorkflowRun, the same workflows.runs.resume operation (write role) the v2 resume route uses, which also brings the run-to-workflow scope check and cross-tenant concealment resumeWorkflowRun takes the calling surface (legacy | v2) so the legacy route keeps streaming and job-id polling, and forwards the request signal/headers a streamed resume needs Inlined the single-consumer resume-handler.ts presenter into the route, keeping its legacy-only "failed sync run → 400 { error }" answer; the GET detail handler stays read Response contract changes on the legacy route: an unexpected server fault (malformed snapshot, run buffer unavailable, DB error) now returns a generic 500 instead of a 400 echoing the raw message; typed admission failures keep their 4xx. OAuth and delegated principals are now treated as API callers (previously only API keys) Type of Change Bug fix Testing Regression tests: a read-role member gets 403 from the legacy POST over session and personal-API-key auth, and nothing is enqueued; they go red when resumeRun is lowered to read The legacy failed-sync-run 400 test goes red when the ported branch is removed [contextId]/route.test.ts, resume/poll/route.test.ts, run-control.test.ts, v2 resume/route.test.ts (53/53) bun run lint; generators in sync; remaining audits, type-check, and the full suite run in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) 🤖 Generated with Claude Code

Open Graph Description: Summary Legacy POST /api/resume/[workflowId]/[executionId]/[contextId] authorized through validateWorkflowAccess, which only checks workspace read, so a read-only member or their API key could ans...

X Description: Summary Legacy POST /api/resume/[workflowId]/[executionId]/[contextId] authorized through validateWorkflowAccess, which only checks workspace read, so a read-only member or their API key could ans...

Opengraph URL: https://github.com/simstudioai/sim/pull/8896

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f9a73448-a2c5-df3d-3d22-762f97e90ddb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDA8A:394173:BDC0CA:10455B1:6AFB53B8
html-safe-nonce4c16cea1aa03b5c23753c57706b72229d62ff200b7de557c0375739233cf069d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQThBOjM5NDE3MzpCREMwQ0E6MTA0NTVCMTo2QUZCNTNCOCIsInZpc2l0b3JfaWQiOiI4NDUzODkzNDExNjU5NTM1Mjg5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac295a7591d49af0c6b29d700709cc9c0cc10173983cb7bb7869b3e5e36276afba
hovercard-subject-tagpull_request:4814057669
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8896/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Legacy POST /api/resume/[workflowId]/[executionId]/[contextId] authorized through validateWorkflowAccess, which only checks workspace read, so a read-only member or their API key could ans...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8896/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8896%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8896%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8896/files
Reloadhttps://github.com/simstudioai/sim/pull/8896/files
Reloadhttps://github.com/simstudioai/sim/pull/8896/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/resume-post-write-authzhttps://github.com/simstudioai/sim/tree/fix/resume-post-write-authz
Conversation 20 https://github.com/simstudioai/sim/pull/8896
Commits 9 https://github.com/simstudioai/sim/pull/8896/commits
Checks 50 https://github.com/simstudioai/sim/pull/8896/checks
Files changed https://github.com/simstudioai/sim/pull/8896/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8896/files
fix(resume): require write access to resume a paused run on the legacy route https://github.com/simstudioai/sim/pull/8896/files#top
Show all changes 9 commits https://github.com/simstudioai/sim/pull/8896/files
e6f8799 fix(resume): require write access to resume a paused run on the legac… waleedlatif1 Oct 10, 2026 https://github.com/simstudioai/sim/pull/8896/commits/e6f87993bb4f34e32120648eb1b1b44b4c5451e8
a53667e fix(resume): let unexpected resume failures reach the route handler a… waleedlatif1 Oct 10, 2026 https://github.com/simstudioai/sim/pull/8896/commits/a53667e9fd7d67f37e638bd7b5b2d810a2f78876
ddca8ea Merge remote-tracking branch 'origin/staging' into fix/resume-post-wr… waleedlatif1 Oct 15, 2026 https://github.com/simstudioai/sim/pull/8896/commits/ddca8eae631122cab0d5051a69d9de2cd8493186
c7e6864 refactor(resume): fold the legacy route's auth catch into one handler… waleedlatif1 Oct 15, 2026 https://github.com/simstudioai/sim/pull/8896/commits/c7e68646736b185316f36a9414e9047678b6e0ed
5949b2b docs(resume): note the v2 job-id dedupe on the executor's pollingSurf… waleedlatif1 Oct 15, 2026 https://github.com/simstudioai/sim/pull/8896/commits/5949b2b8abf07c622856dd6747588abb9cad0966
94fe01e Merge remote-tracking branch 'origin/staging' into fix/resume-post-wr… waleedlatif1 Oct 15, 2026 https://github.com/simstudioai/sim/pull/8896/commits/94fe01e085566fc9c532311d0134675871976c90
224476a fix(resume): withhold unsafe resume failure messages on the legacy route waleedlatif1 Oct 15, 2026 https://github.com/simstudioai/sim/pull/8896/commits/224476adef8105096f9ad694eef6eaf81ce16d28
03b429c Merge remote-tracking branch 'origin/staging' into fix/resume-post-wr… waleedlatif1 Oct 17, 2026 https://github.com/simstudioai/sim/pull/8896/commits/03b429c9c0e0584838a4f3d7987d781db5803bc5
2356a28 test(resume): name the v2 dispatch test after what it asserts waleedlatif1 Oct 17, 2026 https://github.com/simstudioai/sim/pull/8896/commits/2356a28682b0b6bd0223c4ad54f2167022f05eee
Clear filters https://github.com/simstudioai/sim/pull/8896/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8896/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8896/files
route.test.ts https://github.com/simstudioai/sim/pull/8896/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
route.ts https://github.com/simstudioai/sim/pull/8896/files#diff-f0099906729eb6afd2000b6dced811259d2d33f9603467865a6f175dcc06e685
resume-handler.ts https://github.com/simstudioai/sim/pull/8896/files#diff-2747afa46cc2b328243ac3608c407f2d915facd5400ecd3a1b2f7af8875906a0
route.test.ts https://github.com/simstudioai/sim/pull/8896/files#diff-b281a2d5d86a631525fac0dd758d37c1457b2a2907de0c488241d30164271a6f
route.ts https://github.com/simstudioai/sim/pull/8896/files#diff-7e6d50fd88ff452c4637e5419f46aecc8fc451f858d0e7748d0029cf88bce2b2
resume-run.ts https://github.com/simstudioai/sim/pull/8896/files#diff-80851bd52682d01e03cf47cde75ecfaf52bd1446063eecab97eb5b4cf493ac08
run-control.test.ts https://github.com/simstudioai/sim/pull/8896/files#diff-a149f5f7be39742efe7809b4d40330b4b5bce9f64da8b724415e0a3d657c6aa2
resume-execution.ts https://github.com/simstudioai/sim/pull/8896/files#diff-304d5a83871c2e18b2f6994cb1cf3f6832238938ebf88dcfa4273e9d43e38082
apps/sim/app/api/resume/[workflowId]/[executionId]/[contextId]/route.test.tshttps://github.com/simstudioai/sim/pull/8896/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
View file https://github.com/simstudioai/sim/blob/2356a28682b0b6bd0223c4ad54f2167022f05eee/apps/sim/app/api/resume/%5BworkflowId%5D/%5BexecutionId%5D/%5BcontextId%5D/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8896/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8896/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
https://github.com/simstudioai/sim/pull/8896/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
https://github.com/simstudioai/sim/pull/8896/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
https://github.com/simstudioai/sim/pull/8896/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
https://github.com/simstudioai/sim/pull/8896/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
https://github.com/simstudioai/sim/pull/8896/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
https://github.com/simstudioai/sim/pull/8896/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
https://github.com/simstudioai/sim/pull/8896/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
https://github.com/simstudioai/sim/pull/8896/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
https://github.com/simstudioai/sim/pull/8896/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
https://github.com/simstudioai/sim/pull/8896/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
https://github.com/simstudioai/sim/pull/8896/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
https://github.com/simstudioai/sim/pull/8896/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
https://github.com/simstudioai/sim/pull/8896/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
https://github.com/simstudioai/sim/pull/8896/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
https://github.com/simstudioai/sim/pull/8896/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
https://github.com/simstudioai/sim/pull/8896/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
https://github.com/simstudioai/sim/pull/8896/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
https://github.com/simstudioai/sim/pull/8896/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
https://github.com/simstudioai/sim/pull/8896/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
https://github.com/simstudioai/sim/pull/8896/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
https://github.com/simstudioai/sim/pull/8896/files#diff-e14fc86f19ccf313c565ffd7d1b3f7e844716ef396cf3b5d17c3a64d2e804873
Please reload this pagehttps://github.com/simstudioai/sim/pull/8896/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8896/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.