René's URL Explorer Experiment


Title: fix(file-parsers): cap untrusted number formats and make time-format check linear by waleedlatif1 · Pull Request #8893 · simstudioai/sim · GitHub

Open Graph Title: fix(file-parsers): cap untrusted number formats and make time-format check linear by waleedlatif1 · Pull Request #8893 · simstudioai/sim

X Title: fix(file-parsers): cap untrusted number formats and make time-format check linear by waleedlatif1 · Pull Request #8893 · simstudioai/sim

Description: Summary isTimeOnlyFormat sliced the format and ran an unanchored /[:\s]+$/ once per m run, so classifying a date cell's number format was quadratic in the format's length. The format comes verbatim from the workbook's styles.xml (cell.z), so one spreadsheet could make each date cell cost hundreds of ms of synchronous CPU across the parse/preview window (server ingestion and the Files viewer tab) Replaced the per-match slicing with isMinutesRun, a linear walk outward from each m run that skips :/whitespace — same classification as before normalizeSheetDisplayText now treats a cell.z longer than 255 characters (Excel's own custom-format limit) as unformatted, which bounds every scan of the format, including dateTokensOf's bracket strip and the elapsed-token check Type of Change Bug fix Testing isTimeOnlyFormat on a 50k-char format: 645 ms → <1 ms; normalizeSheetDisplayText over 20 such cells: 12.7 s → <1 ms New regression test (307-char format ignored, 247-char format still honored) fails with the cap reverted vitest run lib/file-parsers — 29 files, 298 tests passing; biome clean Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) 🤖 Generated with Claude Code

Open Graph Description: Summary isTimeOnlyFormat sliced the format and ran an unanchored /[:\s]+$/ once per m run, so classifying a date cell's number format was quadratic in the format's length. The format comes...

X Description: Summary isTimeOnlyFormat sliced the format and ran an unanchored /[:\s]+$/ once per m run, so classifying a date cell&#39;s number format was quadratic in the format&#39;s length. The form...

Opengraph URL: https://github.com/simstudioai/sim/pull/8893

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:48844c86-136c-148a-3579-8cf7ecaf562d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD788:3B3600:B5FF09:FA0A79:6AFB5284
html-safe-nonce09eb2129bd52001f68ebbfd5367d31e7dacd0b66310706c10d0f6e4082f809cb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzg4OjNCMzYwMDpCNUZGMDk6RkEwQTc5OjZBRkI1Mjg0IiwidmlzaXRvcl9pZCI6IjE2NzYyNTc1NDYyMjc4OTY5NjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac70d0b434f37dd8fd2e474ecb94b2abf2416d768d9d35dc11360cfed333eee5ae
hovercard-subject-tagpull_request:4813957713
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8893/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary isTimeOnlyFormat sliced the format and ran an unanchored /[:\s]+$/ once per m run, so classifying a date cell's number format was quadratic in the format's length. The format comes...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8893/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8893%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8893%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8893/files
Reloadhttps://github.com/simstudioai/sim/pull/8893/files
Reloadhttps://github.com/simstudioai/sim/pull/8893/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/xlsx-time-format-quadratichttps://github.com/simstudioai/sim/tree/fix/xlsx-time-format-quadratic
Conversation 14 https://github.com/simstudioai/sim/pull/8893
Commits 3 https://github.com/simstudioai/sim/pull/8893/commits
Checks 47 https://github.com/simstudioai/sim/pull/8893/checks
Files changed https://github.com/simstudioai/sim/pull/8893/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8893/files
fix(file-parsers): cap untrusted number formats and make time-format check linear https://github.com/simstudioai/sim/pull/8893/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/8893/files
d7d44df fix(file-parsers): cap untrusted number formats and make time-format … waleedlatif1 Oct 10, 2026 https://github.com/simstudioai/sim/pull/8893/commits/d7d44df867a86fa5d9d0bd19a07873f4b16e0f5a
6a73deb fix(file-parsers): keep the elapsed-format check on the uncapped format waleedlatif1 Oct 10, 2026 https://github.com/simstudioai/sim/pull/8893/commits/6a73debf7a1874cc8e0720c6cddbb5a54b9570b0
9c39903 fix(file-parsers): leave dates with over-long formats untouched inste… waleedlatif1 Oct 10, 2026 https://github.com/simstudioai/sim/pull/8893/commits/9c3990325a7118e0d8e35ed7b7f6118496d1a251
Clear filters https://github.com/simstudioai/sim/pull/8893/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8893/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8893/files
sheet-display-text.test.ts https://github.com/simstudioai/sim/pull/8893/files#diff-a67bf5ca03ab36eadaf107790fe2efeffcd2113b4d08f7246846d856f490f064
sheet-display-text.ts https://github.com/simstudioai/sim/pull/8893/files#diff-6904a07a590f65b7cb0363bc1f3b64307c20a7a195fbb6b2d043353c5b71f82d
apps/sim/lib/file-parsers/sheet-display-text.test.tshttps://github.com/simstudioai/sim/pull/8893/files#diff-a67bf5ca03ab36eadaf107790fe2efeffcd2113b4d08f7246846d856f490f064
View file https://github.com/simstudioai/sim/blob/9c3990325a7118e0d8e35ed7b7f6118496d1a251/apps/sim/lib/file-parsers/sheet-display-text.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8893/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8893/files#diff-a67bf5ca03ab36eadaf107790fe2efeffcd2113b4d08f7246846d856f490f064
apps/sim/lib/file-parsers/sheet-display-text.tshttps://github.com/simstudioai/sim/pull/8893/files#diff-6904a07a590f65b7cb0363bc1f3b64307c20a7a195fbb6b2d043353c5b71f82d
View file https://github.com/simstudioai/sim/blob/9c3990325a7118e0d8e35ed7b7f6118496d1a251/apps/sim/lib/file-parsers/sheet-display-text.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8893/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8893/files#diff-6904a07a590f65b7cb0363bc1f3b64307c20a7a195fbb6b2d043353c5b71f82d
https://github.com/simstudioai/sim/pull/8893/files#diff-6904a07a590f65b7cb0363bc1f3b64307c20a7a195fbb6b2d043353c5b71f82d
https://github.com/simstudioai/sim/pull/8893/files#diff-6904a07a590f65b7cb0363bc1f3b64307c20a7a195fbb6b2d043353c5b71f82d
https://github.com/simstudioai/sim/pull/8893/files#diff-6904a07a590f65b7cb0363bc1f3b64307c20a7a195fbb6b2d043353c5b71f82d
https://github.com/simstudioai/sim/pull/8893/files#diff-6904a07a590f65b7cb0363bc1f3b64307c20a7a195fbb6b2d043353c5b71f82d
https://github.com/simstudioai/sim/pull/8893/files#diff-6904a07a590f65b7cb0363bc1f3b64307c20a7a195fbb6b2d043353c5b71f82d
https://github.com/simstudioai/sim/pull/8893/files#diff-6904a07a590f65b7cb0363bc1f3b64307c20a7a195fbb6b2d043353c5b71f82d
Please reload this pagehttps://github.com/simstudioai/sim/pull/8893/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.