René's URL Explorer Experiment


Title: fix(files): refuse Chat current-file reads no provenance observer records by waleedlatif1 · Pull Request #8864 · simstudioai/sim · GitHub

Open Graph Title: fix(files): refuse Chat current-file reads no provenance observer records by waleedlatif1 · Pull Request #8864 · simstudioai/sim

X Title: fix(files): refuse Chat current-file reads no provenance observer records by waleedlatif1 · Pull Request #8864 · simstudioai/sim

Description: Summary #8843 refused a Chat version-text read that had no delivery observer recording the snapshot's secret provenance, "whatever transport composed the call". The current-file text read and download, which handle the same bytes, still relied on Chat's file-read transport to install the observer. Not reachable today, because Chat always composes that transport, but it is the class #8843 set out to close readWorkspaceFileText and downloadWorkspaceFileStream now apply the same application-layer guard before loading any bytes. The v2 file error policy already maps the refusal to 503 SERVICE_UNAVAILABLE The agent CLI's transport stack moves into createAgentCliTransport (lib/mothership/agent-cli/transport.ts), which executeBoundAgentCliRequest uses unchanged. The integration harness now runs on that exact composition instead of a hand-assembled subset The guard keys on the Copilot service rather than on any delegated principal (requireCopilotWorkspaceFileDeliveryObserver). Current-file reads also admit the workflow executor. Its reads feed blocks rather than Chat's model and nothing observes them, so a delegation-wide check would break every workflow file read. Version reads admit only Copilot, so their behavior is unchanged Type of Change Bug fix Testing copilot-file-versions.integration.ts (real Postgres, local storage, Chat's in-process transports) gains 4 cases: a Chat text read without the observer answers 503 and returns no secret. On staging it answered 200 with the raw secret a Chat download without the observer is refused before streaming. On staging it streamed a workflow-executor download still streams the bytes a Chat download through the real transport answers 200 with the secret redacted a sim files read through the real CLI and composed transport returns the text with the secret redacted 15/15 pass. Every existing Chat case in the file now also runs on the production composition sandbox-resource-transport.test.ts: the workbench proxy dispatches a file read under a delivery observer that the Copilot guard admits, and records its provenance lib/workspace-files, app/api/v2/files, lib/mothership unit suites; full gate: bun run lint, type-check, check:audits, docs-manifest:check, block-registry check, root bun run test Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary #8843 refused a Chat version-text read that had no delivery observer recording the snapshot's secret provenance, "whatever transport composed the call". The current-file text...

X Description: Summary #8843 refused a Chat version-text read that had no delivery observer recording the snapshot's secret provenance, "whatever transport composed the call". The curre...

Opengraph URL: https://github.com/simstudioai/sim/pull/8864

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:019035f7-8eb2-7277-4f25-76dcfb691b84
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8CD2:26BE6B:1568453:1D57C62:6AFB7A0D
html-safe-noncec6cd8303b0eb92119707b64a17b46b86a08d961870eaf404fa5e945f89058ff8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Q0QyOjI2QkU2QjoxNTY4NDUzOjFENTdDNjI6NkFGQjdBMEQiLCJ2aXNpdG9yX2lkIjoiNTM3OTA0MDU4ODMxNTk4MjM0OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac642028f863972bad1beee78efb5c0035ffb9cd5ae243f9c9f67242c403c3cd93
hovercard-subject-tagpull_request:4806813115
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8864/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary #8843 refused a Chat version-text read that had no delivery observer recording the snapshot's secret provenance, "whatever transport composed the call". The current-file text...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8864/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8864%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8864%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8864/files
Reloadhttps://github.com/simstudioai/sim/pull/8864/files
Reloadhttps://github.com/simstudioai/sim/pull/8864/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests202 (202)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/file-provenancehttps://github.com/simstudioai/sim/tree/fix/file-provenance
Conversation 14 https://github.com/simstudioai/sim/pull/8864
Commits 3 https://github.com/simstudioai/sim/pull/8864/commits
Checks 47 https://github.com/simstudioai/sim/pull/8864/checks
Files changed https://github.com/simstudioai/sim/pull/8864/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8864/files
fix(files): refuse Chat current-file reads no provenance observer records https://github.com/simstudioai/sim/pull/8864/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/8864/files
58132a3 fix(files): refuse Chat current-file reads no provenance observer rec… waleedlatif1 Oct 9, 2026 https://github.com/simstudioai/sim/pull/8864/commits/58132a3ae88de38db8037a25472121b84de97e38
b26d9b1 test(files): run Chat file reads through the production CLI transport… waleedlatif1 Oct 10, 2026 https://github.com/simstudioai/sim/pull/8864/commits/b26d9b1446aeedd51685694f034e9288af972599
89527b6 test(sandbox): assert the observed file read is admitted, not the rec… waleedlatif1 Oct 10, 2026 https://github.com/simstudioai/sim/pull/8864/commits/89527b60e894e8b94a72e8f354ee3fee6f4fe6c6
Clear filters https://github.com/simstudioai/sim/pull/8864/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8864/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8864/files
index.ts https://github.com/simstudioai/sim/pull/8864/files#diff-47b01f359bdc1851c02b08d41af3e3215aabe3de12b61bba9c2e8ec103a8d308
transport.ts https://github.com/simstudioai/sim/pull/8864/files#diff-c3b9960b693e0a560ee100e9630904cab3e60a27f17a46a25ad720a5239e8e3d
sandbox-resource-transport.test.ts https://github.com/simstudioai/sim/pull/8864/files#diff-7c532b52f412620a32c9b0d16a7d3381da2f952f866072ea2d42d81421e70f8a
copilot-file-versions.integration.ts https://github.com/simstudioai/sim/pull/8864/files#diff-192f54b5313876ab03243b3d80fab15281c3484e712e11c2e770e3ee0d4656f5
download-workspace-file.ts https://github.com/simstudioai/sim/pull/8864/files#diff-6f2441601aac3bdfc13ceb847faa4f9d558f33b56b8390a6a130f6b8650a12a1
file-delivery-observer.ts https://github.com/simstudioai/sim/pull/8864/files#diff-a96ceb38e11d68f943ccf1cbbabde87767a7fbcd0f6a1b72059cbc704234c20a
file-versions.ts https://github.com/simstudioai/sim/pull/8864/files#diff-860d5d55abd8503974107012d58b44862cdd0527212f52dee4a59a49b83941be
read-workspace-file-text.ts https://github.com/simstudioai/sim/pull/8864/files#diff-a5b5e4419228e72a99445bf57332a6aae0f19026cf3563a227e5fe4f922a51c3
apps/sim/lib/mothership/agent-cli/index.tshttps://github.com/simstudioai/sim/pull/8864/files#diff-47b01f359bdc1851c02b08d41af3e3215aabe3de12b61bba9c2e8ec103a8d308
View file https://github.com/simstudioai/sim/blob/89527b60e894e8b94a72e8f354ee3fee6f4fe6c6/apps/sim/lib/mothership/agent-cli/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8864/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8864/files#diff-47b01f359bdc1851c02b08d41af3e3215aabe3de12b61bba9c2e8ec103a8d308
https://github.com/simstudioai/sim/pull/8864/files#diff-47b01f359bdc1851c02b08d41af3e3215aabe3de12b61bba9c2e8ec103a8d308
https://github.com/simstudioai/sim/pull/8864/files#diff-47b01f359bdc1851c02b08d41af3e3215aabe3de12b61bba9c2e8ec103a8d308
https://github.com/simstudioai/sim/pull/8864/files#diff-47b01f359bdc1851c02b08d41af3e3215aabe3de12b61bba9c2e8ec103a8d308
apps/sim/lib/mothership/agent-cli/transport.tshttps://github.com/simstudioai/sim/pull/8864/files#diff-c3b9960b693e0a560ee100e9630904cab3e60a27f17a46a25ad720a5239e8e3d
View file https://github.com/simstudioai/sim/blob/89527b60e894e8b94a72e8f354ee3fee6f4fe6c6/apps/sim/lib/mothership/agent-cli/transport.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8864/{{ revealButtonHref }}
apps/sim/lib/mothership/tools/sandbox-resource-transport.test.tshttps://github.com/simstudioai/sim/pull/8864/files#diff-7c532b52f412620a32c9b0d16a7d3381da2f952f866072ea2d42d81421e70f8a
View file https://github.com/simstudioai/sim/blob/89527b60e894e8b94a72e8f354ee3fee6f4fe6c6/apps/sim/lib/mothership/tools/sandbox-resource-transport.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8864/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8864/files#diff-7c532b52f412620a32c9b0d16a7d3381da2f952f866072ea2d42d81421e70f8a
https://github.com/simstudioai/sim/pull/8864/files#diff-7c532b52f412620a32c9b0d16a7d3381da2f952f866072ea2d42d81421e70f8a
https://github.com/simstudioai/sim/pull/8864/files#diff-7c532b52f412620a32c9b0d16a7d3381da2f952f866072ea2d42d81421e70f8a
https://github.com/simstudioai/sim/pull/8864/files#diff-7c532b52f412620a32c9b0d16a7d3381da2f952f866072ea2d42d81421e70f8a
apps/sim/lib/workspace-files/__integration__/copilot-file-versions.integration.tshttps://github.com/simstudioai/sim/pull/8864/files#diff-192f54b5313876ab03243b3d80fab15281c3484e712e11c2e770e3ee0d4656f5
View file https://github.com/simstudioai/sim/blob/89527b60e894e8b94a72e8f354ee3fee6f4fe6c6/apps/sim/lib/workspace-files/__integration__/copilot-file-versions.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8864/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8864/files#diff-192f54b5313876ab03243b3d80fab15281c3484e712e11c2e770e3ee0d4656f5
https://github.com/simstudioai/sim/pull/8864/files#diff-192f54b5313876ab03243b3d80fab15281c3484e712e11c2e770e3ee0d4656f5
https://github.com/simstudioai/sim/pull/8864/files#diff-192f54b5313876ab03243b3d80fab15281c3484e712e11c2e770e3ee0d4656f5
https://github.com/simstudioai/sim/pull/8864/files#diff-192f54b5313876ab03243b3d80fab15281c3484e712e11c2e770e3ee0d4656f5
https://github.com/simstudioai/sim/pull/8864/files#diff-192f54b5313876ab03243b3d80fab15281c3484e712e11c2e770e3ee0d4656f5
https://github.com/simstudioai/sim/pull/8864/files#diff-192f54b5313876ab03243b3d80fab15281c3484e712e11c2e770e3ee0d4656f5
apps/sim/lib/workspace-files/application/download-workspace-file.tshttps://github.com/simstudioai/sim/pull/8864/files#diff-6f2441601aac3bdfc13ceb847faa4f9d558f33b56b8390a6a130f6b8650a12a1
View file https://github.com/simstudioai/sim/blob/89527b60e894e8b94a72e8f354ee3fee6f4fe6c6/apps/sim/lib/workspace-files/application/download-workspace-file.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8864/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8864/files#diff-6f2441601aac3bdfc13ceb847faa4f9d558f33b56b8390a6a130f6b8650a12a1
https://github.com/simstudioai/sim/pull/8864/files#diff-6f2441601aac3bdfc13ceb847faa4f9d558f33b56b8390a6a130f6b8650a12a1
https://github.com/simstudioai/sim/pull/8864/files#diff-6f2441601aac3bdfc13ceb847faa4f9d558f33b56b8390a6a130f6b8650a12a1
https://github.com/simstudioai/sim/pull/8864/files#diff-6f2441601aac3bdfc13ceb847faa4f9d558f33b56b8390a6a130f6b8650a12a1
Please reload this pagehttps://github.com/simstudioai/sim/pull/8864/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8864/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.