René's URL Explorer Experiment


Title: fix(deploy): return deployed-version lint as its own field, opt-in and time-bounded by waleedlatif1 · Pull Request #8863 · simstudioai/sim · GitHub

Open Graph Title: fix(deploy): return deployed-version lint as its own field, opt-in and time-bounded by waleedlatif1 · Pull Request #8863 · simstudioai/sim

X Title: fix(deploy): return deployed-version lint as its own field, opt-in and time-bounded by waleedlatif1 · Pull Request #8863 · simstudioai/sim

Description: Summary Deploy lint (#8803) was appended to warnings, which every surface treats as side-effect warnings. The workspace UI toasts warnings after an active deploy, so any UI deploy with a lint finding showed a "Workflow deployed" toast whose body was the whole lint report, including advisory findings that depend on who runs the workflow deployWorkflow now returns the report as a typed lint field and leaves warnings to side effects. Linting is opt-in (lintDeployedVersion): only POST /api/v2/workflows/{id}/deploy, the surface #8803 targeted (API, CLI, Chat), asks for it. The UI route and the Deployments block tool no longer pay for a lint they never present, and the UI toast is back to side-effect warnings only The lint runs under a 5s budget (withinDeadline). Its reference lookups read credentials, tools and table schemas after the deploy has already committed, so a slow lookup no longer holds the response. A lint that fails or runs out of time returns lint: null and never fails the deploy v2 DeployResult gains lint: WorkflowLintReport | null. This is additive and reuses the same schema and presenter as the graph writes. DeploymentState.warnings now describes side-effect warnings and says lint never appears there. OpenAPI, the CLI API, MCP operations and the CLI docs are regenerated Type of Change Bug fix Testing workflow-deployments.test.ts covers four cases: lint returned as lint and never as a warning; no lint unless the surface asks; a lint failure returns null; a lint that never settles is abandoned at its budget. The new app/api/v2/workflows/[workflowId]/deploy/route.test.ts checks that the v2 response carries lint apart from side-effect warnings. All of them failed on staging. The budget case hung until the test timeout Full gate: bun run lint, type-check, check:audits, docs-manifest:check, block-registry check, root bun run test Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Deploy lint (#8803) was appended to warnings, which every surface treats as side-effect warnings. The workspace UI toasts warnings after an active deploy, so any UI deploy with a lint find...

X Description: Summary Deploy lint (#8803) was appended to warnings, which every surface treats as side-effect warnings. The workspace UI toasts warnings after an active deploy, so any UI deploy with a lint find...

Opengraph URL: https://github.com/simstudioai/sim/pull/8863

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:22c2326d-22a6-ebd9-b565-e6b34cd7e93c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8704:8CC91:3F56BF:565D15:6AFB570D
html-safe-nonced17994a21d12e4b0b5e8bf4ce174968d2a27ec257a4a8db1c4e73e4a9a7ad8d4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NzA0OjhDQzkxOjNGNTZCRjo1NjVEMTU6NkFGQjU3MEQiLCJ2aXNpdG9yX2lkIjoiMzI2NjY4NjY0MTc2NjA5NDYwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccbfa19cbe5505a13e6e0a8587152a7c434b420526beaed3a57fabca61aa67405
hovercard-subject-tagpull_request:4806759207
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8863/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Deploy lint (#8803) was appended to warnings, which every surface treats as side-effect warnings. The workspace UI toasts warnings after an active deploy, so any UI deploy with a lint find...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8863/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8863%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8863%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8863/files
Reloadhttps://github.com/simstudioai/sim/pull/8863/files
Reloadhttps://github.com/simstudioai/sim/pull/8863/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/deploy-linthttps://github.com/simstudioai/sim/tree/fix/deploy-lint
Conversation 8 https://github.com/simstudioai/sim/pull/8863
Commits 2 https://github.com/simstudioai/sim/pull/8863/commits
Checks 47 https://github.com/simstudioai/sim/pull/8863/checks
Files changed https://github.com/simstudioai/sim/pull/8863/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8863/files
fix(deploy): return deployed-version lint as its own field, opt-in and time-bounded https://github.com/simstudioai/sim/pull/8863/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/8863/files
3b49719 fix(deploy): return deployed-version lint as its own field, opt-in an… waleedlatif1 Oct 9, 2026 https://github.com/simstudioai/sim/pull/8863/commits/3b497196f485fae26464f76042343a55ddfe7eee
e665139 test(deploy): pin that an unrequested lint is never awaited, by behavior waleedlatif1 Oct 10, 2026 https://github.com/simstudioai/sim/pull/8863/commits/e6651390675d8c755f027242dccd7a02ea606a9e
Clear filters https://github.com/simstudioai/sim/pull/8863/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8863/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8863/files
openapi-v2-workflows.json https://github.com/simstudioai/sim/pull/8863/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
workflow-lint.ts https://github.com/simstudioai/sim/pull/8863/files#diff-89bd6b7d329a3af2b9a4ed7b636babe7d97d6f7077ad4dcb50c1e46c3a3a1d23
route.test.ts https://github.com/simstudioai/sim/pull/8863/files#diff-6224bce0b842fc8c22f0cf11f92a743aafd7304e469d96e94aa886f221969a2a
route.ts https://github.com/simstudioai/sim/pull/8863/files#diff-b0df64449009a7da80a0339f3456af2c789a199cbfc99fdcf9e96b452f25ccf8
workflows.ts https://github.com/simstudioai/sim/pull/8863/files#diff-8a92f40b0f57e6ef31cfc1af32cf15d24dcb56fdc7159594695a8db4f9761c91
workflows.ts https://github.com/simstudioai/sim/pull/8863/files#diff-7c1b6e587b506ea981d107bc7496349fd5020fd823e34f9c13d70f6845829728
v2-operations.ts https://github.com/simstudioai/sim/pull/8863/files#diff-a32a173b553c777ebd3d9ecabb9cbc5fe7705ac6fa3761dbceaeb5458fc449b7
deployments.ts https://github.com/simstudioai/sim/pull/8863/files#diff-fc93eb2ca2b799c8ed182bf7b1f7ab532b153f8546d00850311d878d3471a5ab
workflow-deployments.test.ts https://github.com/simstudioai/sim/pull/8863/files#diff-fbf581f6f9e261506d130ce4041f07cd9ef55ee972430ed1ec09baf426996743
v2-api.ts https://github.com/simstudioai/sim/pull/8863/files#diff-e856e756b18965607efb943e85bad153871936ce3ee5180ec2e8073a28dd1dd7
apps/docs/openapi-v2-workflows.jsonhttps://github.com/simstudioai/sim/pull/8863/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
View file https://github.com/simstudioai/sim/blob/e6651390675d8c755f027242dccd7a02ea606a9e/apps/docs/openapi-v2-workflows.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8863/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8863/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
https://github.com/simstudioai/sim/pull/8863/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
https://github.com/simstudioai/sim/pull/8863/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
https://github.com/simstudioai/sim/pull/8863/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
https://github.com/simstudioai/sim/pull/8863/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
https://github.com/simstudioai/sim/pull/8863/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
https://github.com/simstudioai/sim/pull/8863/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
https://github.com/simstudioai/sim/pull/8863/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
https://github.com/simstudioai/sim/pull/8863/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
https://github.com/simstudioai/sim/pull/8863/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
https://github.com/simstudioai/sim/pull/8863/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
https://github.com/simstudioai/sim/pull/8863/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
https://github.com/simstudioai/sim/pull/8863/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
https://github.com/simstudioai/sim/pull/8863/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
https://github.com/simstudioai/sim/pull/8863/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
https://github.com/simstudioai/sim/pull/8863/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
https://github.com/simstudioai/sim/pull/8863/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
https://github.com/simstudioai/sim/pull/8863/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
https://github.com/simstudioai/sim/pull/8863/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
apps/sim/app/api/v2/lib/workflow-lint.tshttps://github.com/simstudioai/sim/pull/8863/files#diff-89bd6b7d329a3af2b9a4ed7b636babe7d97d6f7077ad4dcb50c1e46c3a3a1d23
View file https://github.com/simstudioai/sim/blob/e6651390675d8c755f027242dccd7a02ea606a9e/apps/sim/app/api/v2/lib/workflow-lint.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8863/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8863/files#diff-89bd6b7d329a3af2b9a4ed7b636babe7d97d6f7077ad4dcb50c1e46c3a3a1d23
https://github.com/simstudioai/sim/pull/8863/files#diff-89bd6b7d329a3af2b9a4ed7b636babe7d97d6f7077ad4dcb50c1e46c3a3a1d23
apps/sim/app/api/v2/workflows/[workflowId]/deploy/route.test.tshttps://github.com/simstudioai/sim/pull/8863/files#diff-6224bce0b842fc8c22f0cf11f92a743aafd7304e469d96e94aa886f221969a2a
View file https://github.com/simstudioai/sim/blob/e6651390675d8c755f027242dccd7a02ea606a9e/apps/sim/app/api/v2/workflows/%5BworkflowId%5D/deploy/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8863/{{ revealButtonHref }}
apps/sim/app/api/v2/workflows/[workflowId]/deploy/route.tshttps://github.com/simstudioai/sim/pull/8863/files#diff-b0df64449009a7da80a0339f3456af2c789a199cbfc99fdcf9e96b452f25ccf8
View file https://github.com/simstudioai/sim/blob/e6651390675d8c755f027242dccd7a02ea606a9e/apps/sim/app/api/v2/workflows/%5BworkflowId%5D/deploy/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8863/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8863/files#diff-b0df64449009a7da80a0339f3456af2c789a199cbfc99fdcf9e96b452f25ccf8
https://github.com/simstudioai/sim/pull/8863/files#diff-b0df64449009a7da80a0339f3456af2c789a199cbfc99fdcf9e96b452f25ccf8
https://github.com/simstudioai/sim/pull/8863/files#diff-b0df64449009a7da80a0339f3456af2c789a199cbfc99fdcf9e96b452f25ccf8
https://github.com/simstudioai/sim/pull/8863/files#diff-b0df64449009a7da80a0339f3456af2c789a199cbfc99fdcf9e96b452f25ccf8
apps/sim/lib/api/contracts/v2/openapi/workflows.tshttps://github.com/simstudioai/sim/pull/8863/files#diff-8a92f40b0f57e6ef31cfc1af32cf15d24dcb56fdc7159594695a8db4f9761c91
View file https://github.com/simstudioai/sim/blob/e6651390675d8c755f027242dccd7a02ea606a9e/apps/sim/lib/api/contracts/v2/openapi/workflows.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8863/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8863/files#diff-8a92f40b0f57e6ef31cfc1af32cf15d24dcb56fdc7159594695a8db4f9761c91
https://github.com/simstudioai/sim/pull/8863/files#diff-8a92f40b0f57e6ef31cfc1af32cf15d24dcb56fdc7159594695a8db4f9761c91
https://github.com/simstudioai/sim/pull/8863/files#diff-8a92f40b0f57e6ef31cfc1af32cf15d24dcb56fdc7159594695a8db4f9761c91
https://github.com/simstudioai/sim/pull/8863/files#diff-8a92f40b0f57e6ef31cfc1af32cf15d24dcb56fdc7159594695a8db4f9761c91
Please reload this pagehttps://github.com/simstudioai/sim/pull/8863/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8863/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.