René's URL Explorer Experiment


Title: fix(files): refuse delegated version reads no provenance observer records by waleedlatif1 · Pull Request #8843 · simstudioai/sim · GitHub

Open Graph Title: fix(files): refuse delegated version reads no provenance observer records by waleedlatif1 · Pull Request #8843 · simstudioai/sim

X Title: fix(files): refuse delegated version reads no provenance observer records by waleedlatif1 · Pull Request #8843 · simstudioai/sim

Description: Summary A version text read redacted secrets only when the caller's transport had installed a delivery observer. Chat's transports install one today, but the guarantee depended on how they are composed. readWorkspaceFileVersionText now refuses a delegated caller with no observer before loading any bytes, and the v2 file error policy maps that refusal to 503 SERVICE_UNAVAILABLE. Direct callers are unchanged The version-history policy comment overstated the download rule. Download stays direct-only, but it is not a hard boundary for a writer: reverting to a version and downloading the current file reaches the same bytes, with provenance tracked at each step. Delete remains a real boundary, because a revert never purges history Integration coverage for chat version access that was previously only probed by hand: workspace pinning holds without the invocation scope (the delegated principal's own check) the files.use capability is enforced a version with unknown secret provenance is withheld a secret stays redacted after Chat reverts to the version holding it Type of Change Bug fix Testing lib/workspace-files/__integration__/copilot-file-versions.integration.ts (real Postgres, local storage, Chat's in-process transports), 5 new cases, 10/10 pass: a delegated version read through the in-process route with no file-read layer answers 503 and returns no secret. It fails with the new guard removed (200 with the raw secret) a chat pinned to another of the user's workspaces gets 404 on list and revert without the invocation scope, whether the request asserts the file's workspace or the chat's a member whose permission group hides Files is refused with PERMISSION_GROUP_CAPABILITY_BLOCKED a version with unknown provenance answers 503 even with a registry after Chat reverts to a secret-bearing version, a current-file read shows only [REDACTED_SECRET], and 503 without a registry Existing file-versions.integration.ts (28) and copilot-permission-config.integration.ts pass; lib/workspace-files, app/api/v2/files, lib/api/server/routes unit suites pass bun run lint, bun run type-check, bun run check:audits, root bun run test (one load timeout in lib/mothership/agent-cli/services.test.ts, which passes on its own) Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary A version text read redacted secrets only when the caller's transport had installed a delivery observer. Chat's transports install one today, but the guarantee depended on how they...

X Description: Summary A version text read redacted secrets only when the caller's transport had installed a delivery observer. Chat's transports install one today, but the guarantee depended on ...

Opengraph URL: https://github.com/simstudioai/sim/pull/8843

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6c0d3796-00f6-7dc9-43d4-644706f7e692
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id998A:1E90AB:28C56:387AF:6AFB6491
html-safe-nonce56a7bec45cf53e03eb2bd5857c56bcd63f14fec4950a327929bbe25263c0c173
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OThBOjFFOTBBQjoyOEM1NjozODdBRjo2QUZCNjQ5MSIsInZpc2l0b3JfaWQiOiIxMjkwMjYxMTgxNzA0NjYwMTEzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5dfa75384a148d6d2c40a027bdced21a8cc4844a598616c3c481b4c13f78d2b6
hovercard-subject-tagpull_request:4797324055
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8843/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary A version text read redacted secrets only when the caller's transport had installed a delivery observer. Chat's transports install one today, but the guarantee depended on how they...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8843/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8843%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8843%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8843/files
Reloadhttps://github.com/simstudioai/sim/pull/8843/files
Reloadhttps://github.com/simstudioai/sim/pull/8843/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/chat-delegation-hardeninghttps://github.com/simstudioai/sim/tree/fix/chat-delegation-hardening
Conversation 2 https://github.com/simstudioai/sim/pull/8843
Commits 1 https://github.com/simstudioai/sim/pull/8843/commits
Checks 46 https://github.com/simstudioai/sim/pull/8843/checks
Files changed https://github.com/simstudioai/sim/pull/8843/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8843/files
fix(files): refuse delegated version reads no provenance observer records https://github.com/simstudioai/sim/pull/8843/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/8843/files
1556d78 fix(files): refuse delegated version reads no provenance observer rec… waleedlatif1 Oct 9, 2026 https://github.com/simstudioai/sim/pull/8843/commits/1556d78d1079cce0670521473ab85c911c81d3f4
Clear filters https://github.com/simstudioai/sim/pull/8843/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8843/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8843/files
copilot-file-versions.integration.ts https://github.com/simstudioai/sim/pull/8843/files#diff-192f54b5313876ab03243b3d80fab15281c3484e712e11c2e770e3ee0d4656f5
route-policies.ts https://github.com/simstudioai/sim/pull/8843/files#diff-b770b6b9c49ec8170bd0414024408a8de75cbb8442185f6b72179aff26e741e2
file-delivery-observer.ts https://github.com/simstudioai/sim/pull/8843/files#diff-a96ceb38e11d68f943ccf1cbbabde87767a7fbcd0f6a1b72059cbc704234c20a
file-versions.ts https://github.com/simstudioai/sim/pull/8843/files#diff-860d5d55abd8503974107012d58b44862cdd0527212f52dee4a59a49b83941be
operations.ts https://github.com/simstudioai/sim/pull/8843/files#diff-ee398303387f3b37518430fab0f0c7167b5ab63ca2ebf290699c33f78ce899b3
apps/sim/lib/workspace-files/__integration__/copilot-file-versions.integration.tshttps://github.com/simstudioai/sim/pull/8843/files#diff-192f54b5313876ab03243b3d80fab15281c3484e712e11c2e770e3ee0d4656f5
View file https://github.com/simstudioai/sim/blob/1556d78d1079cce0670521473ab85c911c81d3f4/apps/sim/lib/workspace-files/__integration__/copilot-file-versions.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8843/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8843/files#diff-192f54b5313876ab03243b3d80fab15281c3484e712e11c2e770e3ee0d4656f5
https://github.com/simstudioai/sim/pull/8843/files#diff-192f54b5313876ab03243b3d80fab15281c3484e712e11c2e770e3ee0d4656f5
https://github.com/simstudioai/sim/pull/8843/files#diff-192f54b5313876ab03243b3d80fab15281c3484e712e11c2e770e3ee0d4656f5
https://github.com/simstudioai/sim/pull/8843/files#diff-192f54b5313876ab03243b3d80fab15281c3484e712e11c2e770e3ee0d4656f5
https://github.com/simstudioai/sim/pull/8843/files#diff-192f54b5313876ab03243b3d80fab15281c3484e712e11c2e770e3ee0d4656f5
https://github.com/simstudioai/sim/pull/8843/files#diff-192f54b5313876ab03243b3d80fab15281c3484e712e11c2e770e3ee0d4656f5
https://github.com/simstudioai/sim/pull/8843/files#diff-192f54b5313876ab03243b3d80fab15281c3484e712e11c2e770e3ee0d4656f5
https://github.com/simstudioai/sim/pull/8843/files#diff-192f54b5313876ab03243b3d80fab15281c3484e712e11c2e770e3ee0d4656f5
apps/sim/lib/workspace-files/api/route-policies.tshttps://github.com/simstudioai/sim/pull/8843/files#diff-b770b6b9c49ec8170bd0414024408a8de75cbb8442185f6b72179aff26e741e2
View file https://github.com/simstudioai/sim/blob/1556d78d1079cce0670521473ab85c911c81d3f4/apps/sim/lib/workspace-files/api/route-policies.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8843/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8843/files#diff-b770b6b9c49ec8170bd0414024408a8de75cbb8442185f6b72179aff26e741e2
https://github.com/simstudioai/sim/pull/8843/files#diff-b770b6b9c49ec8170bd0414024408a8de75cbb8442185f6b72179aff26e741e2
https://github.com/simstudioai/sim/pull/8843/files#diff-b770b6b9c49ec8170bd0414024408a8de75cbb8442185f6b72179aff26e741e2
apps/sim/lib/workspace-files/application/file-delivery-observer.tshttps://github.com/simstudioai/sim/pull/8843/files#diff-a96ceb38e11d68f943ccf1cbbabde87767a7fbcd0f6a1b72059cbc704234c20a
View file https://github.com/simstudioai/sim/blob/1556d78d1079cce0670521473ab85c911c81d3f4/apps/sim/lib/workspace-files/application/file-delivery-observer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8843/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8843/files#diff-a96ceb38e11d68f943ccf1cbbabde87767a7fbcd0f6a1b72059cbc704234c20a
apps/sim/lib/workspace-files/application/file-versions.tshttps://github.com/simstudioai/sim/pull/8843/files#diff-860d5d55abd8503974107012d58b44862cdd0527212f52dee4a59a49b83941be
View file https://github.com/simstudioai/sim/blob/1556d78d1079cce0670521473ab85c911c81d3f4/apps/sim/lib/workspace-files/application/file-versions.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8843/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8843/files#diff-860d5d55abd8503974107012d58b44862cdd0527212f52dee4a59a49b83941be
https://github.com/simstudioai/sim/pull/8843/files#diff-860d5d55abd8503974107012d58b44862cdd0527212f52dee4a59a49b83941be
https://github.com/simstudioai/sim/pull/8843/files#diff-860d5d55abd8503974107012d58b44862cdd0527212f52dee4a59a49b83941be
https://github.com/simstudioai/sim/pull/8843/files#diff-860d5d55abd8503974107012d58b44862cdd0527212f52dee4a59a49b83941be
apps/sim/lib/workspace-files/application/operations.tshttps://github.com/simstudioai/sim/pull/8843/files#diff-ee398303387f3b37518430fab0f0c7167b5ab63ca2ebf290699c33f78ce899b3
View file https://github.com/simstudioai/sim/blob/1556d78d1079cce0670521473ab85c911c81d3f4/apps/sim/lib/workspace-files/application/operations.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8843/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8843/files#diff-ee398303387f3b37518430fab0f0c7167b5ab63ca2ebf290699c33f78ce899b3
https://github.com/simstudioai/sim/pull/8843/files#diff-ee398303387f3b37518430fab0f0c7167b5ab63ca2ebf290699c33f78ce899b3
Please reload this pagehttps://github.com/simstudioai/sim/pull/8843/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.