René's URL Explorer Experiment


Title: fix(workflows): lint unquoted string references in JSON fields and surface lint on deploy by waleedlatif1 · Pull Request #8803 · simstudioai/sim · GitHub

Open Graph Title: fix(workflows): lint unquoted string references in JSON fields and surface lint on deploy by waleedlatif1 · Pull Request #8803 · simstudioai/sim

X Title: fix(workflows): lint unquoted string references in JSON fields and surface lint on deploy by waleedlatif1 · Pull Request #8803 · simstudioai/sim

Description: Summary Lint now flags a block reference written unquoted in a JSON editor field (Table row data, API body, …) when the referenced output is declared string. Outside Function code references are substituted as raw text, so {"id": } becomes invalid JSON and the block failed only at run time, while the edit result's lint, workflows lint, and deploy all reported clean. Numbers, booleans, objects and undeclared types are not flagged. The finding reuses unresolvedReferences (kind: 'block-output', reason unquoted-json-string: …), so it appears in the lint field of every graph write and in workflows lint with no wire-shape change. Tokens come from the runtime's own reference scanner; only tokens outside JSON string literals (escapes handled) are considered. POST /api/v2/workflows/{id}/deploy lints the exact version it just made live and, if anything is found, appends one entry to the existing warnings array. Deploy never refuses or fails on lint: findings stay advisory, and a lint failure is logged and ignored. unresolvedReferences description updated (OpenAPI regenerated); the lint summary header for block-output findings reads "will not work as written". Type of Change Bug fix Testing New json-literal-refs.test.ts (unquoted string refs flagged; quoted, escaped-quote, JSON-typed, unknown-type, non-JSON-field and non-string values not flagged), a lint-report wiring test, and deploy use-case tests (warning added as the deploying user, clean graph adds nothing, lint failure never fails the deploy). Each failed before the fix; escape handling and the deploy try/catch were each reverted and watched go red. bunx vitest run lib/workflows lib/mothership/agent-cli/engines app/api/v2/workflows (182 files, 2757 tests), bun run lint, bun run type-check, bun run check:audits, bun run docs-manifest:check. Sim CLI command inventory is byte-identical to staging (no CLI contract change). Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Lint now flags a block reference written unquoted in a JSON editor field (Table row data, API body, …) when the referenced output is declared string. Outside Function code references are s...

X Description: Summary Lint now flags a block reference written unquoted in a JSON editor field (Table row data, API body, …) when the referenced output is declared string. Outside Function code references are s...

Opengraph URL: https://github.com/simstudioai/sim/pull/8803

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:23cad840-2734-1618-ac37-4ad09dd7f311
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD2D6:3ED756:4B9785:69D80A:6AFB5CC5
html-safe-nonced637e6bbe215d055cd9db7efbb18cd2d58690aa2fce29544a3ce61f6a75566b4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkQ2OjNFRDc1Njo0Qjk3ODU6NjlEODBBOjZBRkI1Q0M1IiwidmlzaXRvcl9pZCI6IjM2ODQyOTY3ODMwODY0NDM3MTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacae38e9dab49375c82df381a81e406ff2b13dda8aad5e55fb1ce8bc39cd40da70
hovercard-subject-tagpull_request:4789295497
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8803/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Lint now flags a block reference written unquoted in a JSON editor field (Table row data, API body, …) when the referenced output is declared string. Outside Function code references are s...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8803/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8803%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8803%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8803/files
Reloadhttps://github.com/simstudioai/sim/pull/8803/files
Reloadhttps://github.com/simstudioai/sim/pull/8803/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/agent-deploy-validationhttps://github.com/simstudioai/sim/tree/fix/agent-deploy-validation
Conversation 20 https://github.com/simstudioai/sim/pull/8803
Commits 3 https://github.com/simstudioai/sim/pull/8803/commits
Checks 46 https://github.com/simstudioai/sim/pull/8803/checks
Files changed https://github.com/simstudioai/sim/pull/8803/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8803/files
fix(workflows): lint unquoted string references in JSON fields and surface lint on deploy https://github.com/simstudioai/sim/pull/8803/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/8803/files
0e06cd9 fix(workflows): lint unquoted string references in JSON fields and su… waleedlatif1 Oct 8, 2026 https://github.com/simstudioai/sim/pull/8803/commits/0e06cd98763e241c306c122c5f9c557b659b913b
5f67bf1 fix(workflows): lint only the JSON fields the operation sends, and li… waleedlatif1 Oct 8, 2026 https://github.com/simstudioai/sim/pull/8803/commits/5f67bf1c742e0bf35bacb0d8ae3fe7664e2646e6
fd2ab61 fix(workflows): check JSON editors sent under a canonical param waleedlatif1 Oct 8, 2026 https://github.com/simstudioai/sim/pull/8803/commits/fd2ab618f4a2bc1dc0bc734889baa6d2c8b91380
Clear filters https://github.com/simstudioai/sim/pull/8803/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8803/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8803/files
openapi-v2-workflows.json https://github.com/simstudioai/sim/pull/8803/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
workflows.ts https://github.com/simstudioai/sim/pull/8803/files#diff-7c1b6e587b506ea981d107bc7496349fd5020fd823e34f9c13d70f6845829728
apply-workflow-operations.test.ts https://github.com/simstudioai/sim/pull/8803/files#diff-c9eb1870c4d990c58d4978fc22c3f7581a0bffc42a2fce2ffcff4d5f64ca46a3
deployments.ts https://github.com/simstudioai/sim/pull/8803/files#diff-fc93eb2ca2b799c8ed182bf7b1f7ab532b153f8546d00850311d878d3471a5ab
workflow-deployments.test.ts https://github.com/simstudioai/sim/pull/8803/files#diff-fbf581f6f9e261506d130ce4041f07cd9ef55ee972430ed1ec09baf426996743
json-literal-refs.test.ts https://github.com/simstudioai/sim/pull/8803/files#diff-7d98c02a0ed6405cb68f8e8c72b2670a14fed1971185ac4641635b48001b7827
lint-report.test.ts https://github.com/simstudioai/sim/pull/8803/files#diff-d307a8cd749e07314701a1fddc54418bcd01d0f93cdb6e88d662568dc8cc94c5
lint-report.ts https://github.com/simstudioai/sim/pull/8803/files#diff-a5d7c695f7977f06ead3fd185cf35f62dd97cbfa8baa0535b26bee349988dab8
lint.ts https://github.com/simstudioai/sim/pull/8803/files#diff-a76ac58fcebbbf0dfc7828f8ccbfdeb7c39ed49d21dca6ab2cf9174d24465bdd
apps/docs/openapi-v2-workflows.jsonhttps://github.com/simstudioai/sim/pull/8803/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
View file https://github.com/simstudioai/sim/blob/fd2ab618f4a2bc1dc0bc734889baa6d2c8b91380/apps/docs/openapi-v2-workflows.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8803/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8803/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
https://github.com/simstudioai/sim/pull/8803/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
apps/sim/lib/api/contracts/v2/workflows.tshttps://github.com/simstudioai/sim/pull/8803/files#diff-7c1b6e587b506ea981d107bc7496349fd5020fd823e34f9c13d70f6845829728
View file https://github.com/simstudioai/sim/blob/fd2ab618f4a2bc1dc0bc734889baa6d2c8b91380/apps/sim/lib/api/contracts/v2/workflows.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8803/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8803/files#diff-7c1b6e587b506ea981d107bc7496349fd5020fd823e34f9c13d70f6845829728
https://github.com/simstudioai/sim/pull/8803/files#diff-7c1b6e587b506ea981d107bc7496349fd5020fd823e34f9c13d70f6845829728
apps/sim/lib/workflows/application/apply-workflow-operations.test.tshttps://github.com/simstudioai/sim/pull/8803/files#diff-c9eb1870c4d990c58d4978fc22c3f7581a0bffc42a2fce2ffcff4d5f64ca46a3
View file https://github.com/simstudioai/sim/blob/fd2ab618f4a2bc1dc0bc734889baa6d2c8b91380/apps/sim/lib/workflows/application/apply-workflow-operations.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8803/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8803/files#diff-c9eb1870c4d990c58d4978fc22c3f7581a0bffc42a2fce2ffcff4d5f64ca46a3
https://github.com/simstudioai/sim/pull/8803/files#diff-c9eb1870c4d990c58d4978fc22c3f7581a0bffc42a2fce2ffcff4d5f64ca46a3
apps/sim/lib/workflows/application/deployments.tshttps://github.com/simstudioai/sim/pull/8803/files#diff-fc93eb2ca2b799c8ed182bf7b1f7ab532b153f8546d00850311d878d3471a5ab
View file https://github.com/simstudioai/sim/blob/fd2ab618f4a2bc1dc0bc734889baa6d2c8b91380/apps/sim/lib/workflows/application/deployments.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8803/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8803/files#diff-fc93eb2ca2b799c8ed182bf7b1f7ab532b153f8546d00850311d878d3471a5ab
https://github.com/simstudioai/sim/pull/8803/files#diff-fc93eb2ca2b799c8ed182bf7b1f7ab532b153f8546d00850311d878d3471a5ab
https://github.com/simstudioai/sim/pull/8803/files#diff-fc93eb2ca2b799c8ed182bf7b1f7ab532b153f8546d00850311d878d3471a5ab
https://github.com/simstudioai/sim/pull/8803/files#diff-fc93eb2ca2b799c8ed182bf7b1f7ab532b153f8546d00850311d878d3471a5ab
Please reload this pagehttps://github.com/simstudioai/sim/pull/8803/files
https://github.com/simstudioai/sim/pull/8803/files#diff-fc93eb2ca2b799c8ed182bf7b1f7ab532b153f8546d00850311d878d3471a5ab
apps/sim/lib/workflows/application/workflow-deployments.test.tshttps://github.com/simstudioai/sim/pull/8803/files#diff-fbf581f6f9e261506d130ce4041f07cd9ef55ee972430ed1ec09baf426996743
View file https://github.com/simstudioai/sim/blob/fd2ab618f4a2bc1dc0bc734889baa6d2c8b91380/apps/sim/lib/workflows/application/workflow-deployments.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8803/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8803/files#diff-fbf581f6f9e261506d130ce4041f07cd9ef55ee972430ed1ec09baf426996743
https://github.com/simstudioai/sim/pull/8803/files#diff-fbf581f6f9e261506d130ce4041f07cd9ef55ee972430ed1ec09baf426996743
https://github.com/simstudioai/sim/pull/8803/files#diff-fbf581f6f9e261506d130ce4041f07cd9ef55ee972430ed1ec09baf426996743
https://github.com/simstudioai/sim/pull/8803/files#diff-fbf581f6f9e261506d130ce4041f07cd9ef55ee972430ed1ec09baf426996743
https://github.com/simstudioai/sim/pull/8803/files#diff-fbf581f6f9e261506d130ce4041f07cd9ef55ee972430ed1ec09baf426996743
https://github.com/simstudioai/sim/pull/8803/files#diff-fbf581f6f9e261506d130ce4041f07cd9ef55ee972430ed1ec09baf426996743
https://github.com/simstudioai/sim/pull/8803/files#diff-fbf581f6f9e261506d130ce4041f07cd9ef55ee972430ed1ec09baf426996743
https://github.com/simstudioai/sim/pull/8803/files#diff-fbf581f6f9e261506d130ce4041f07cd9ef55ee972430ed1ec09baf426996743
https://github.com/simstudioai/sim/pull/8803/files#diff-fbf581f6f9e261506d130ce4041f07cd9ef55ee972430ed1ec09baf426996743
Please reload this pagehttps://github.com/simstudioai/sim/pull/8803/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8803/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.