René's URL Explorer Experiment


Title: fix(code-placeholders): reject arithmetic comparisons and heredoc operands by waleedlatif1 · Pull Request #8760 · simstudioai/sim · GitHub

Open Graph Title: fix(code-placeholders): reject arithmetic comparisons and heredoc operands by waleedlatif1 · Pull Request #8760 · simstudioai/sim

X Title: fix(code-placeholders): reject arithmetic comparisons and heredoc operands by waleedlatif1 · Pull Request #8760 · simstudioai/sim

Description: Summary Reject supplied shell placeholders in arithmetic comparisons ([[ ... -eq/-ne/-lt/-le/-gt/-ge ... ]]), including nested substitutions. Carry arithmetic context from heredoc operators into their bodies, including quoted heredocs lowered to private input files. Preserve ordinary strings, regexes, [ ... ] tests, and string comparisons. Brackets and dollar signs remain valid data. Type of Change Bug fix Scope This is a lexical guard for explicit arithmetic delimiters and comparisons. It does not infer variable types or trace later evaluation through let, integer-attributed variables, name-taking builtins, or dynamically selected commands. Scripts must validate data before those evaluations. A global value blacklist cannot make those paths safe without breaking ordinary string inputs. Supplied placeholders in the guarded positions are rejected even when their current value is numeric. Testing Compiler-to-Bash execution suite: 72 checks on Bash 3.2 and 5.2, using environment bindings, real private input files, and a command-execution sentinel. The suite fails on the staging baseline. Disabling comparison detection or heredoc inheritance independently fails the corresponding cases. CI runs the execution suite and uploads its JSON report on failure. Focused compiler and CLI-service suites: 173 passed, 3 skipped. Lint, all 58 audits, type-checking across 26 workspaces, docs manifest, block registry, and workflow lint passed. Additional comparison probe: 512 source variants, no accepted variant executed the sentinel. Full local verification passed with two workers and unchanged timeouts: 366 script tests plus all workspace suites, including 35,447 app tests passed and 25 skipped. All 25 applicable CI checks passed; Greptile reviewed the current head at 5/5 and all 61 review threads are resolved. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Reject supplied shell placeholders in arithmetic comparisons ([[ ... -eq/-ne/-lt/-le/-gt/-ge ... ]]), including nested substitutions. Carry arithmetic context from heredoc operators into t...

X Description: Summary Reject supplied shell placeholders in arithmetic comparisons ([[ ... -eq/-ne/-lt/-le/-gt/-ge ... ]]), including nested substitutions. Carry arithmetic context from heredoc operators into t...

Opengraph URL: https://github.com/simstudioai/sim/pull/8760

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:bfa092ed-9bd0-dea4-4a46-5562e318b1a5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8566:D16D6:D26700:1217A55:6AFB5D5C
html-safe-noncead1fdaa7e66445be3726751cdaade0e9191add4f48e98aab1eca798bdc1e765e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NTY2OkQxNkQ2OkQyNjcwMDoxMjE3QTU1OjZBRkI1RDVDIiwidmlzaXRvcl9pZCI6Ijg2NDU0MTA2ODkxOTc0OTc2OTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9ac8142922d98bb6fe175600525a71372493de3aba49c1808ce06f5e09b96e46
hovercard-subject-tagpull_request:4777835480
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8760/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Reject supplied shell placeholders in arithmetic comparisons ([[ ... -eq/-ne/-lt/-le/-gt/-ge ... ]]), including nested substitutions. Carry arithmetic context from heredoc operators into t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8760/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8760%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8760%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8760/files
Reloadhttps://github.com/simstudioai/sim/pull/8760/files
Reloadhttps://github.com/simstudioai/sim/pull/8760/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/code-placeholders-arithmetic-contextshttps://github.com/simstudioai/sim/tree/fix/code-placeholders-arithmetic-contexts
Conversation 193 https://github.com/simstudioai/sim/pull/8760
Commits 7 https://github.com/simstudioai/sim/pull/8760/commits
Checks 48 https://github.com/simstudioai/sim/pull/8760/checks
Files changed https://github.com/simstudioai/sim/pull/8760/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8760/files
fix(code-placeholders): reject arithmetic comparisons and heredoc operands https://github.com/simstudioai/sim/pull/8760/files#top
Show all changes 7 commits https://github.com/simstudioai/sim/pull/8760/files
0dbe7db fix(code-placeholders): harden shell placeholder interpolation in ari… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8760/commits/0dbe7db27e35c3916b37b54dbbe5adbca9a2dd75
f6c87ba fix(code-placeholders): keep integer attributes across re-declaration… waleedlatif1 Oct 8, 2026 https://github.com/simstudioai/sim/pull/8760/commits/f6c87bafc3012c1eb68893f577fb2e6bfef74ea9
268cf41 fix(code-placeholders): end assignment-value scope at the word, carry… waleedlatif1 Oct 8, 2026 https://github.com/simstudioai/sim/pull/8760/commits/268cf41b39111164b9059d66e2bb707f3f12417e
dc283dc fix(code-placeholders): treat a declaration as pending inside its own… waleedlatif1 Oct 8, 2026 https://github.com/simstudioai/sim/pull/8760/commits/dc283dc47355c06c6fb77ec92f8635916079e1f4
d16e645 fix(code-placeholders): narrow arithmetic guards and preserve literal… waleedlatif1 Oct 8, 2026 https://github.com/simstudioai/sim/pull/8760/commits/d16e6458e1786083f7e21af90b6bb234ea953258
f4573b3 fix(code-placeholders): skip continued newlines before comparison ope… waleedlatif1 Oct 8, 2026 https://github.com/simstudioai/sim/pull/8760/commits/f4573b33fa92f3c2735b624e06bc589018d4037e
3d99351 fix(code-placeholders): preserve command scope across process substit… waleedlatif1 Oct 8, 2026 https://github.com/simstudioai/sim/pull/8760/commits/3d993519fbe4266f527486a3a00e69c9c0374ac7
Clear filters https://github.com/simstudioai/sim/pull/8760/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8760/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8760/files
checks.yml https://github.com/simstudioai/sim/pull/8760/files#diff-3ea54af4839eb75404d71b28252bead7e7ec8f676b1f815e1cde02629a75c165
shared.ts https://github.com/simstudioai/sim/pull/8760/files#diff-6661b621fa81d867fdd1fd3d652f3d11bd8790b4fb45cb29e2a07e434109c5d3
shell.ts https://github.com/simstudioai/sim/pull/8760/files#diff-69d4ae387611651fe49aafbb8208d088e22fb8ced81c1160eb3193e57f36a1ca
test-shell-placeholders-e2e.ts https://github.com/simstudioai/sim/pull/8760/files#diff-44f66af87369b0d60f77537e39c0350f1cf75a1ffe5bfaec85934b3aedcdd078
.github/workflows/checks.ymlhttps://github.com/simstudioai/sim/pull/8760/files#diff-3ea54af4839eb75404d71b28252bead7e7ec8f676b1f815e1cde02629a75c165
View file https://github.com/simstudioai/sim/blob/3d993519fbe4266f527486a3a00e69c9c0374ac7/.github/workflows/checks.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8760/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8760/files#diff-3ea54af4839eb75404d71b28252bead7e7ec8f676b1f815e1cde02629a75c165
https://github.com/simstudioai/sim/pull/8760/files#diff-3ea54af4839eb75404d71b28252bead7e7ec8f676b1f815e1cde02629a75c165
apps/sim/lib/execution/code-placeholders/shared.tshttps://github.com/simstudioai/sim/pull/8760/files#diff-6661b621fa81d867fdd1fd3d652f3d11bd8790b4fb45cb29e2a07e434109c5d3
View file https://github.com/simstudioai/sim/blob/3d993519fbe4266f527486a3a00e69c9c0374ac7/apps/sim/lib/execution/code-placeholders/shared.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8760/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8760/files#diff-6661b621fa81d867fdd1fd3d652f3d11bd8790b4fb45cb29e2a07e434109c5d3
https://github.com/simstudioai/sim/pull/8760/files#diff-6661b621fa81d867fdd1fd3d652f3d11bd8790b4fb45cb29e2a07e434109c5d3
Please reload this pagehttps://github.com/simstudioai/sim/pull/8760/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8760/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.