René's URL Explorer Experiment


Title: fix(mothership): cancel desktop tools a signed-out turn starts late, guard the shown-once license key by waleedlatif1 · Pull Request #8757 · simstudioai/sim · GitHub

Open Graph Title: fix(mothership): cancel desktop tools a signed-out turn starts late, guard the shown-once license key by waleedlatif1 · Pull Request #8757 · simstudioai/sim

X Title: fix(mothership): cancel desktop tools a signed-out turn starts late, guard the shown-once license key by waleedlatif1 · Pull Request #8757 · simstudioai/sim

Description: Summary Desktop tool leases are bound to the session the chat surface mounted in (desktopToolSession(), held once per useChat mount). Sign-out (stopAllDesktopTools) aborts that session and starts a new one. A send still pending at sign-out, or a reconnect of an old stream, delivers its tool events to a surface mounted before the stop, so each of them gets an already-aborted lease instead of a fresh controller. Signing out leaves or reloads every chat surface, so surfaces mounted after sign-in run normally, with no reset hook needed. No per-stream tombstone after a single turn's Stop: a withdrawn first send retries with the same message id (= stream id), so a tombstone would pre-abort the retry's tools. Stop already cancels that turn's stream reader. Mothership admin Licenses tab: the shown-once generated license key counts as unsaved, so switching tabs or environments asks first. Confirming the discard drops the key. The new-chat effort contract (optional effort in the chat response) and the effort pick's lifetime across the first-send composer swap already landed in #8754, with regression tests. Type of Change Bug fix Testing desktop-tool-lifetimes.test.ts: leases from a surface mounted before sign-out, including on a stream it reads later, are aborted with the sign-out reason (fails with the session guard reverted), and a surface mounted after sign-out gets live leases. stores/index.test.ts was updated to the new interface. mothership.test.tsx (new): after generating a key, leaving is refused until confirmed, and confirming drops the key. Both tests fail on the pre-fix code. bun run lint, bun run type-check, bun run check:audits, docs-manifest:check, block registry check, and the home/settings/stores vitest suites. Root bun run test passes except two CPU-heavy tests that time out under local load (archive.test.ts, remark-plain-text.test.ts); this PR doesn't touch them. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Desktop tool leases are bound to the session the chat surface mounted in (desktopToolSession(), held once per useChat mount). Sign-out (stopAllDesktopTools) aborts that session and starts ...

X Description: Summary Desktop tool leases are bound to the session the chat surface mounted in (desktopToolSession(), held once per useChat mount). Sign-out (stopAllDesktopTools) aborts that session and starts ...

Opengraph URL: https://github.com/simstudioai/sim/pull/8757

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5382bcb3-4cba-c170-a38a-e5b0faa2cd9d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD52E:243AE6:A88B29:EF11A0:6AFB572C
html-safe-nonceb466833926d0d16f274b2e76122ae5b71685a25fd71b2a87251fd60b410adbe7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTJFOjI0M0FFNjpBODhCMjk6RUYxMUEwOjZBRkI1NzJDIiwidmlzaXRvcl9pZCI6IjE2NzE5NTAyNDgwODA3OTEzNDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4a8c7159c0dd392ed136630310b78f65084c972d79fc6e283d7cc24d818a911e
hovercard-subject-tagpull_request:4777746704
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8757/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Desktop tool leases are bound to the session the chat surface mounted in (desktopToolSession(), held once per useChat mount). Sign-out (stopAllDesktopTools) aborts that session and starts ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8757/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8757%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8757%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8757/files
Reloadhttps://github.com/simstudioai/sim/pull/8757/files
Reloadhttps://github.com/simstudioai/sim/pull/8757/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/mothership-chat-effort-and-guardshttps://github.com/simstudioai/sim/tree/fix/mothership-chat-effort-and-guards
Conversation 19 https://github.com/simstudioai/sim/pull/8757
Commits 4 https://github.com/simstudioai/sim/pull/8757/commits
Checks 47 https://github.com/simstudioai/sim/pull/8757/checks
Files changed https://github.com/simstudioai/sim/pull/8757/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8757/files
fix(mothership): cancel desktop tools a signed-out turn starts late, guard the shown-once license key https://github.com/simstudioai/sim/pull/8757/files#top
Show all changes 4 commits https://github.com/simstudioai/sim/pull/8757/files
3752577 fix(mothership): cancel desktop tools a signed-out turn starts late, … waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8757/commits/3752577233288cccae806eaec506db7ec0a1b567
eb7723b fix(mothership): bind desktop tools to the session the chat surface m… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8757/commits/eb7723bdf36303460941010a4fa1135fa5f870dd
30296e4 test(mothership): assert the license key guard through tab and enviro… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8757/commits/30296e41b6874feb40c8d91b11721748ddc57523
5ac72c9 test(mothership): mock Chip for the license-key guard tests on top of… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8757/commits/5ac72c90786b834c01d2df8945f0037c4775c4d8
Clear filters https://github.com/simstudioai/sim/pull/8757/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8757/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8757/files
desktop-tool-lifetimes.test.ts https://github.com/simstudioai/sim/pull/8757/files#diff-ec382a9f2a2b37712b62d56d680bba9d315f67fe5274fb3d6430fb944267d1d2
desktop-tool-lifetimes.ts https://github.com/simstudioai/sim/pull/8757/files#diff-3574167671568f8f933fb8431cf1570cedb11cb8e345a2e2bfef5f91039057c3
use-chat.ts https://github.com/simstudioai/sim/pull/8757/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
mothership.test.tsx https://github.com/simstudioai/sim/pull/8757/files#diff-ab2ff24b5525f73bf84594e9f8736c3647269f1df6c0878ede4635cbe767751f
index.test.ts https://github.com/simstudioai/sim/pull/8757/files#diff-7a351a851383262b13386aae19ea6e7245277bf1f4e9a60cdec17dbfc4201ae4
apps/sim/app/workspace/[workspaceId]/home/hooks/desktop-tool-lifetimes.test.tshttps://github.com/simstudioai/sim/pull/8757/files#diff-ec382a9f2a2b37712b62d56d680bba9d315f67fe5274fb3d6430fb944267d1d2
View file https://github.com/simstudioai/sim/blob/5ac72c90786b834c01d2df8945f0037c4775c4d8/apps/sim/app/workspace/%5BworkspaceId%5D/home/hooks/desktop-tool-lifetimes.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8757/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8757/files#diff-ec382a9f2a2b37712b62d56d680bba9d315f67fe5274fb3d6430fb944267d1d2
https://github.com/simstudioai/sim/pull/8757/files#diff-ec382a9f2a2b37712b62d56d680bba9d315f67fe5274fb3d6430fb944267d1d2
https://github.com/simstudioai/sim/pull/8757/files#diff-ec382a9f2a2b37712b62d56d680bba9d315f67fe5274fb3d6430fb944267d1d2
https://github.com/simstudioai/sim/pull/8757/files#diff-ec382a9f2a2b37712b62d56d680bba9d315f67fe5274fb3d6430fb944267d1d2
apps/sim/app/workspace/[workspaceId]/home/hooks/desktop-tool-lifetimes.tshttps://github.com/simstudioai/sim/pull/8757/files#diff-3574167671568f8f933fb8431cf1570cedb11cb8e345a2e2bfef5f91039057c3
View file https://github.com/simstudioai/sim/blob/5ac72c90786b834c01d2df8945f0037c4775c4d8/apps/sim/app/workspace/%5BworkspaceId%5D/home/hooks/desktop-tool-lifetimes.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8757/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8757/files#diff-3574167671568f8f933fb8431cf1570cedb11cb8e345a2e2bfef5f91039057c3
https://github.com/simstudioai/sim/pull/8757/files#diff-3574167671568f8f933fb8431cf1570cedb11cb8e345a2e2bfef5f91039057c3
https://github.com/simstudioai/sim/pull/8757/files#diff-3574167671568f8f933fb8431cf1570cedb11cb8e345a2e2bfef5f91039057c3
https://github.com/simstudioai/sim/pull/8757/files#diff-3574167671568f8f933fb8431cf1570cedb11cb8e345a2e2bfef5f91039057c3
apps/sim/app/workspace/[workspaceId]/home/hooks/use-chat.tshttps://github.com/simstudioai/sim/pull/8757/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
View file https://github.com/simstudioai/sim/blob/5ac72c90786b834c01d2df8945f0037c4775c4d8/apps/sim/app/workspace/%5BworkspaceId%5D/home/hooks/use-chat.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8757/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8757/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8757/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8757/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8757/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8757/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8757/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8757/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8757/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8757/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8757/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8757/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8757/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8757/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8757/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
Please reload this pagehttps://github.com/simstudioai/sim/pull/8757/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8757/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.