René's URL Explorer Experiment


Title: fix(mothership): close a pre-aborted SSE stream, keep the new-chat effort across a failed first send by waleedlatif1 · Pull Request #8754 · simstudioai/sim · GitHub

Open Graph Title: fix(mothership): close a pre-aborted SSE stream, keep the new-chat effort across a failed first send by waleedlatif1 · Pull Request #8754 · simstudioai/sim

X Title: fix(mothership): close a pre-aborted SSE stream, keep the new-chat effort across a failed first send by waleedlatif1 · Pull Request #8754 · simstudioai/sim

Description: Summary Three findings from the #8748 release review. A pre-aborted SSE request no longer subscribes. createSSEStream adds its abort listener inside start(), and that listener never fires for a signal that's already aborted. A client that left while the route was still authorizing got a stream that subscribed anyway and held its handler, timers and a revalidate query every 30 s until rotation (~16.5 min). start() now closes at once with aborted before taking any subscription. Covers all three callers: the desktop inbox stream, mothership events and createWorkspaceSSE. The new-chat effort survives a failed first send. ModelSelector cleared the pick on unmount whenever it had no chat id. A first send swaps the empty-state composer for the chat view, so the pick was wiped mid-send: the chat view showed the default while pending, and once rollbackOptimisticSend restored the pick, the swapped-back composer's unmount wiped it again. The pick belongs to the chatless surface, not one composer, so useChat now owns its lifetime: it drops when the surface unmounts, switches chats, or adopts a chat (adoptResolvedChatId, so a first send stopped before admission doesn't carry it into the next new chat). Admission still moves it onto the new chat via adoptNewChatEffort first. The rollbackOptimisticSend restore is gone: nothing clears the pick while a send is pending, and it overwrote a pick made in the chat view during the send. Covers every useChat surface: Home, organization home and the workflow copilot panel. effort is optional on the chat response. It was required, so during a deploy's traffic shift a new client hitting an old server failed contract validation and the chat didn't load. parseChatHistory already maps a missing value to null; MothershipChatHistory is unchanged. Type of Change Bug fix Testing Each new test fails on staging: never subscribes when the request aborted before the stream started (sse-endpoint.test.ts): expected false to be true, the body never finishes. keeps the new-chat effort across the composer swap of a first send that fails (use-chat.dom.test.tsx, renders the real ModelSelector in a Home-shaped swap): expected 'High' to be 'Low' while pending, and with that line removed, expected null to be 'low' after the failure. keeps a new-chat effort picked while the first send is pending when that send fails: expected 'Low' to be 'Medium' with the rollback restore. starts the next new chat at the default after a first send stopped before admission: expected 'Low' to be 'High' without the adoption clear. drops an unsent new-chat effort when the surface leaves the page / opens another chat pins the remaining abandonment paths on the new layer. loads a chat from a server that predates the effort field (mothership-chats.test.ts): Response failed contract validation — chat.effort. apps/sim typecheck, biome, check:api-validation, check:api-contract-routes, check:openapi, check:comment-hygiene, check:test-patterns and the home, hooks/queries, contracts and sse-endpoint suites (1031 tests) pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Three findings from the #8748 release review. A pre-aborted SSE request no longer subscribes. createSSEStream adds its abort listener inside start(), and that listener never fires for a si...

X Description: Summary Three findings from the #8748 release review. A pre-aborted SSE request no longer subscribes. createSSEStream adds its abort listener inside start(), and that listener never fires for a si...

Opengraph URL: https://github.com/simstudioai/sim/pull/8754

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:709fa2bc-8d1f-baea-9181-acfeb42c202e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD1BA:F138D:E29915:1362FC9:6AFB5D65
html-safe-nonceb8ace29f56ef8161cbdece13bc11307b9ed2169b33e102c3653e097897d43214
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMUJBOkYxMzhEOkUyOTkxNToxMzYyRkM5OjZBRkI1RDY1IiwidmlzaXRvcl9pZCI6Ijg2NTg0ODAyNDQ2MTQ0NTQ2MzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac97d6fde7acb8fac95109858e46ec5fb96ac20d683dd21306e8dde8b2e1fde8bb
hovercard-subject-tagpull_request:4776605164
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8754/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Three findings from the #8748 release review. A pre-aborted SSE request no longer subscribes. createSSEStream adds its abort listener inside start(), and that listener never fires for a si...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8754/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8754%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8754%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8754/files
Reloadhttps://github.com/simstudioai/sim/pull/8754/files
Reloadhttps://github.com/simstudioai/sim/pull/8754/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/sim-review-findingshttps://github.com/simstudioai/sim/tree/fix/sim-review-findings
Conversation 5 https://github.com/simstudioai/sim/pull/8754
Commits 2 https://github.com/simstudioai/sim/pull/8754/commits
Checks 35 https://github.com/simstudioai/sim/pull/8754/checks
Files changed https://github.com/simstudioai/sim/pull/8754/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8754/files
fix(mothership): close a pre-aborted SSE stream, keep the new-chat effort across a failed first send https://github.com/simstudioai/sim/pull/8754/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/8754/files
3c266bf fix(mothership): close a pre-aborted SSE stream, keep the new-chat ef… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8754/commits/3c266bf5b278ee85f3d958eabceb7a62c3c8f1ac
9eb580b fix(mothership): drop the new-chat effort when the surface adopts a chat waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8754/commits/9eb580bd6b77fc5fb22ca246a8f3b3f3ff42f6b5
Clear filters https://github.com/simstudioai/sim/pull/8754/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8754/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8754/files
model-selector.tsx https://github.com/simstudioai/sim/pull/8754/files#diff-5a757ddbae59660a55408f377bbb677b658adbbcff43675423dd03f39d5ffdd4
use-chat.dom.test.tsx https://github.com/simstudioai/sim/pull/8754/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
use-chat.ts https://github.com/simstudioai/sim/pull/8754/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
mothership-chats.test.ts https://github.com/simstudioai/sim/pull/8754/files#diff-d98e509113958ce4f2b40df87695287e3b70124eb675fd7f2a6180dbde0b10ea
mothership-chats.ts https://github.com/simstudioai/sim/pull/8754/files#diff-960eb86dfce0edf82ee9d3ba690f1644349c37467f238ae8be028ece995bc21b
sse-endpoint.test.ts https://github.com/simstudioai/sim/pull/8754/files#diff-fe4bc27f0a5836f89b1ee7e1ab0e1180c4c53f170b14768b494c3d83e482e7a0
sse-endpoint.ts https://github.com/simstudioai/sim/pull/8754/files#diff-383257e7bcffe26ad3a94d114fdb49ceed8019920242632adf23ea0b72687978
store.ts https://github.com/simstudioai/sim/pull/8754/files#diff-08089d9f00e9355828629c2237ef32b4a0f6def9914fde7ac99d982bcdd387c6
.../sim/app/workspace/[workspaceId]/home/components/user-input/components/model-selector.tsxhttps://github.com/simstudioai/sim/pull/8754/files#diff-5a757ddbae59660a55408f377bbb677b658adbbcff43675423dd03f39d5ffdd4
View file https://github.com/simstudioai/sim/blob/9eb580bd6b77fc5fb22ca246a8f3b3f3ff42f6b5/apps/sim/app/workspace/%5BworkspaceId%5D/home/components/user-input/components/model-selector.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8754/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8754/files#diff-5a757ddbae59660a55408f377bbb677b658adbbcff43675423dd03f39d5ffdd4
https://github.com/simstudioai/sim/pull/8754/files#diff-5a757ddbae59660a55408f377bbb677b658adbbcff43675423dd03f39d5ffdd4
https://github.com/simstudioai/sim/pull/8754/files#diff-5a757ddbae59660a55408f377bbb677b658adbbcff43675423dd03f39d5ffdd4
apps/sim/app/workspace/[workspaceId]/home/hooks/use-chat.dom.test.tsxhttps://github.com/simstudioai/sim/pull/8754/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
View file https://github.com/simstudioai/sim/blob/9eb580bd6b77fc5fb22ca246a8f3b3f3ff42f6b5/apps/sim/app/workspace/%5BworkspaceId%5D/home/hooks/use-chat.dom.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8754/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8754/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
https://github.com/simstudioai/sim/pull/8754/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
https://github.com/simstudioai/sim/pull/8754/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
https://github.com/simstudioai/sim/pull/8754/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
https://github.com/simstudioai/sim/pull/8754/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
https://github.com/simstudioai/sim/pull/8754/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
apps/sim/app/workspace/[workspaceId]/home/hooks/use-chat.tshttps://github.com/simstudioai/sim/pull/8754/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
View file https://github.com/simstudioai/sim/blob/9eb580bd6b77fc5fb22ca246a8f3b3f3ff42f6b5/apps/sim/app/workspace/%5BworkspaceId%5D/home/hooks/use-chat.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8754/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8754/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8754/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8754/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8754/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8754/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8754/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
apps/sim/hooks/queries/mothership-chats.test.tshttps://github.com/simstudioai/sim/pull/8754/files#diff-d98e509113958ce4f2b40df87695287e3b70124eb675fd7f2a6180dbde0b10ea
View file https://github.com/simstudioai/sim/blob/9eb580bd6b77fc5fb22ca246a8f3b3f3ff42f6b5/apps/sim/hooks/queries/mothership-chats.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8754/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8754/files#diff-d98e509113958ce4f2b40df87695287e3b70124eb675fd7f2a6180dbde0b10ea
https://github.com/simstudioai/sim/pull/8754/files#diff-d98e509113958ce4f2b40df87695287e3b70124eb675fd7f2a6180dbde0b10ea
https://github.com/simstudioai/sim/pull/8754/files#diff-d98e509113958ce4f2b40df87695287e3b70124eb675fd7f2a6180dbde0b10ea
https://github.com/simstudioai/sim/pull/8754/files#diff-d98e509113958ce4f2b40df87695287e3b70124eb675fd7f2a6180dbde0b10ea
https://github.com/simstudioai/sim/pull/8754/files#diff-d98e509113958ce4f2b40df87695287e3b70124eb675fd7f2a6180dbde0b10ea
apps/sim/lib/api/contracts/mothership-chats.tshttps://github.com/simstudioai/sim/pull/8754/files#diff-960eb86dfce0edf82ee9d3ba690f1644349c37467f238ae8be028ece995bc21b
View file https://github.com/simstudioai/sim/blob/9eb580bd6b77fc5fb22ca246a8f3b3f3ff42f6b5/apps/sim/lib/api/contracts/mothership-chats.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8754/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8754/files#diff-960eb86dfce0edf82ee9d3ba690f1644349c37467f238ae8be028ece995bc21b
https://github.com/simstudioai/sim/pull/8754/files#diff-960eb86dfce0edf82ee9d3ba690f1644349c37467f238ae8be028ece995bc21b
apps/sim/lib/events/sse-endpoint.test.tshttps://github.com/simstudioai/sim/pull/8754/files#diff-fe4bc27f0a5836f89b1ee7e1ab0e1180c4c53f170b14768b494c3d83e482e7a0
View file https://github.com/simstudioai/sim/blob/9eb580bd6b77fc5fb22ca246a8f3b3f3ff42f6b5/apps/sim/lib/events/sse-endpoint.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8754/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8754/files#diff-fe4bc27f0a5836f89b1ee7e1ab0e1180c4c53f170b14768b494c3d83e482e7a0
https://github.com/simstudioai/sim/pull/8754/files#diff-fe4bc27f0a5836f89b1ee7e1ab0e1180c4c53f170b14768b494c3d83e482e7a0
apps/sim/lib/events/sse-endpoint.tshttps://github.com/simstudioai/sim/pull/8754/files#diff-383257e7bcffe26ad3a94d114fdb49ceed8019920242632adf23ea0b72687978
View file https://github.com/simstudioai/sim/blob/9eb580bd6b77fc5fb22ca246a8f3b3f3ff42f6b5/apps/sim/lib/events/sse-endpoint.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8754/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8754/files#diff-383257e7bcffe26ad3a94d114fdb49ceed8019920242632adf23ea0b72687978
https://github.com/simstudioai/sim/pull/8754/files#diff-383257e7bcffe26ad3a94d114fdb49ceed8019920242632adf23ea0b72687978
apps/sim/stores/mothership-effort/store.tshttps://github.com/simstudioai/sim/pull/8754/files#diff-08089d9f00e9355828629c2237ef32b4a0f6def9914fde7ac99d982bcdd387c6
View file https://github.com/simstudioai/sim/blob/9eb580bd6b77fc5fb22ca246a8f3b3f3ff42f6b5/apps/sim/stores/mothership-effort/store.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8754/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8754/files#diff-08089d9f00e9355828629c2237ef32b4a0f6def9914fde7ac99d982bcdd387c6
https://github.com/simstudioai/sim/pull/8754/files#diff-08089d9f00e9355828629c2237ef32b4a0f6def9914fde7ac99d982bcdd387c6
Please reload this pagehttps://github.com/simstudioai/sim/pull/8754/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.