René's URL Explorer Experiment


Title: fix(desktop): stop a run the model never got the result of by waleedlatif1 · Pull Request #8749 · simstudioai/sim · GitHub

Open Graph Title: fix(desktop): stop a run the model never got the result of by waleedlatif1 · Pull Request #8749 · simstudioai/sim

X Title: fix(desktop): stop a run the model never got the result of by waleedlatif1 · Pull Request #8749 · simstudioai/sim

Description: Summary A terminal run can hand back a command that is still going. If Sim settles the call before the result reaches it (the user pressed Stop while the result was being sent, or a send kept failing), the model never learns about that command. Nothing then stops it until sign-out, quit, or the next launch. The per-call cancel can't cover this: once run returns, the call is no longer in flight, so cancelTool has nothing to stop. The executor now reports when Sim is done with a call without taking its real result (onResultNotDelivered). That covers a result Sim settled first, one it refused, and a stand-in result. It is the counterpart of onResultDelivered. The terminal registry then stops what that call's run left going: a plain shell's command, through its process group as Stop does, or the tmux run, through its recorded tag. This is the same rule the launch sweep already applies to a previous process's runs. It also covers a recovered run whose result is sent as "outcome unknown" after a restart: the model never gets its pane, so it is now stopped instead of lasting until the next launch. Type of Change Bug fix Testing New tests: Executor: a result Sim settled while a failed send waited to retry, and a refused result, both report as not reaching the model. Terminal service: stops a plain shell command handed back as still going, and leaves other calls' commands alone. Registry: stops only that call's tmux run, this process's or a previous one's. Extended the existing superseded and stand-in executor tests to assert the new callback. All 6 new or extended tests fail with the source change reverted. Desktop: typecheck clean, biome clean, 1053/1053 tests. Comment hygiene and desktop bridge/IPC audits pass. Why the existing tests missed it: they only asserted when a result did reach the model, and no test covered a command handed back as still going whose result was superseded. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary A terminal run can hand back a command that is still going. If Sim settles the call before the result reaches it (the user pressed Stop while the result was being sent, or a send kept fail...

X Description: Summary A terminal run can hand back a command that is still going. If Sim settles the call before the result reaches it (the user pressed Stop while the result was being sent, or a send kept fail...

Opengraph URL: https://github.com/simstudioai/sim/pull/8749

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:09360925-216d-c9bd-aa97-1b6312e54cbc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBF72:1BB96C:14D42FF:1C70D3A:6AFB75C8
html-safe-nonce747d0851fc14d4235e3b7eea04f8ffc716f80985b07df6415f98ae7951b08563
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjcyOjFCQjk2QzoxNEQ0MkZGOjFDNzBEM0E6NkFGQjc1QzgiLCJ2aXNpdG9yX2lkIjoiNDE3ODcyMDY0MDY3NDI2NDUyMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfc8acaa92b58afffaecd6e3e36a0e8c325411414815ffe97ec8b671ecdd03696
hovercard-subject-tagpull_request:4776265528
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8749/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary A terminal run can hand back a command that is still going. If Sim settles the call before the result reaches it (the user pressed Stop while the result was being sent, or a send kept fail...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8749/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8749%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8749%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8749/files
Reloadhttps://github.com/simstudioai/sim/pull/8749/files
Reloadhttps://github.com/simstudioai/sim/pull/8749/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests201 (201)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/desktop-stop-undelivered-runhttps://github.com/simstudioai/sim/tree/fix/desktop-stop-undelivered-run
Conversation 19 https://github.com/simstudioai/sim/pull/8749
Commits 4 https://github.com/simstudioai/sim/pull/8749/commits
Checks 37 https://github.com/simstudioai/sim/pull/8749/checks
Files changed https://github.com/simstudioai/sim/pull/8749/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8749/files
fix(desktop): stop a run the model never got the result of https://github.com/simstudioai/sim/pull/8749/files#top
Show all changes 4 commits https://github.com/simstudioai/sim/pull/8749/files
9025afb fix(desktop): stop a run the model never got the result of waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8749/commits/9025afbdb7459b9cd3c25d1c22f8bf3ac1db3d2f
5861b1d fix(desktop): never stop a run the model may hold waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8749/commits/5861b1dfac6bbfd11747752e40665530caf4a576
ab40352 fix(desktop): only a recovered result leaves a duplicate open waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8749/commits/ab40352f958f5672971aba1ee0556b63a0e12b27
8246e2a fix(desktop): keep a recovered result's mark while it is parked waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8749/commits/8246e2a573a50bee273c948ef926b5c56f540d36
Clear filters https://github.com/simstudioai/sim/pull/8749/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8749/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8749/files
executor.test.ts https://github.com/simstudioai/sim/pull/8749/files#diff-1d814ab1e49d94d9e6bfcfb97e062a92af6b9ea401ec82adcd5b9b12db0b6648
executor.ts https://github.com/simstudioai/sim/pull/8749/files#diff-3dfd3e1443ae11d37fee36e5f5bb3ad895438d3c5b5d2e8f23f8f46f2d423ed2
service.ts https://github.com/simstudioai/sim/pull/8749/files#diff-b1278501073652f766c12e4b75a1cc24571a04e46e4c4539bb52a80ed6df5f4d
index.ts https://github.com/simstudioai/sim/pull/8749/files#diff-5bf7db7b15749c034541a4a70a0cacf9816b4e214fd11cb5735c5ddb7ca4b1d8
index.ts https://github.com/simstudioai/sim/pull/8749/files#diff-74076d8d25116ad5bb8b4f51915e92169cac28f67682613e6b181a2c845e1412
registry-run-ledger.test.ts https://github.com/simstudioai/sim/pull/8749/files#diff-bf73f7bfa09ef47da9c1e8259fe4f80afa5109efc404d5ab50a824800aeb7730
registry.ts https://github.com/simstudioai/sim/pull/8749/files#diff-d30cc33e9e00dd9009a54bd75a24dbf056890b72571f5101186e11fd9291f199
service.test.ts https://github.com/simstudioai/sim/pull/8749/files#diff-ccf1a39e658c6d2cc7398268ef30d8d5da1a8ac78f2c13fdc808e54926c575cb
apps/desktop/src/main/desktop-executor/executor.test.tshttps://github.com/simstudioai/sim/pull/8749/files#diff-1d814ab1e49d94d9e6bfcfb97e062a92af6b9ea401ec82adcd5b9b12db0b6648
View file https://github.com/simstudioai/sim/blob/8246e2a573a50bee273c948ef926b5c56f540d36/apps/desktop/src/main/desktop-executor/executor.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8749/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8749/files#diff-1d814ab1e49d94d9e6bfcfb97e062a92af6b9ea401ec82adcd5b9b12db0b6648
https://github.com/simstudioai/sim/pull/8749/files#diff-1d814ab1e49d94d9e6bfcfb97e062a92af6b9ea401ec82adcd5b9b12db0b6648
https://github.com/simstudioai/sim/pull/8749/files#diff-1d814ab1e49d94d9e6bfcfb97e062a92af6b9ea401ec82adcd5b9b12db0b6648
https://github.com/simstudioai/sim/pull/8749/files#diff-1d814ab1e49d94d9e6bfcfb97e062a92af6b9ea401ec82adcd5b9b12db0b6648
https://github.com/simstudioai/sim/pull/8749/files#diff-1d814ab1e49d94d9e6bfcfb97e062a92af6b9ea401ec82adcd5b9b12db0b6648
https://github.com/simstudioai/sim/pull/8749/files#diff-1d814ab1e49d94d9e6bfcfb97e062a92af6b9ea401ec82adcd5b9b12db0b6648
https://github.com/simstudioai/sim/pull/8749/files#diff-1d814ab1e49d94d9e6bfcfb97e062a92af6b9ea401ec82adcd5b9b12db0b6648
https://github.com/simstudioai/sim/pull/8749/files#diff-1d814ab1e49d94d9e6bfcfb97e062a92af6b9ea401ec82adcd5b9b12db0b6648
apps/desktop/src/main/desktop-executor/executor.tshttps://github.com/simstudioai/sim/pull/8749/files#diff-3dfd3e1443ae11d37fee36e5f5bb3ad895438d3c5b5d2e8f23f8f46f2d423ed2
View file https://github.com/simstudioai/sim/blob/8246e2a573a50bee273c948ef926b5c56f540d36/apps/desktop/src/main/desktop-executor/executor.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8749/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8749/files#diff-3dfd3e1443ae11d37fee36e5f5bb3ad895438d3c5b5d2e8f23f8f46f2d423ed2
https://github.com/simstudioai/sim/pull/8749/files#diff-3dfd3e1443ae11d37fee36e5f5bb3ad895438d3c5b5d2e8f23f8f46f2d423ed2
https://github.com/simstudioai/sim/pull/8749/files#diff-3dfd3e1443ae11d37fee36e5f5bb3ad895438d3c5b5d2e8f23f8f46f2d423ed2
https://github.com/simstudioai/sim/pull/8749/files#diff-3dfd3e1443ae11d37fee36e5f5bb3ad895438d3c5b5d2e8f23f8f46f2d423ed2
https://github.com/simstudioai/sim/pull/8749/files#diff-3dfd3e1443ae11d37fee36e5f5bb3ad895438d3c5b5d2e8f23f8f46f2d423ed2
https://github.com/simstudioai/sim/pull/8749/files#diff-3dfd3e1443ae11d37fee36e5f5bb3ad895438d3c5b5d2e8f23f8f46f2d423ed2
https://github.com/simstudioai/sim/pull/8749/files#diff-3dfd3e1443ae11d37fee36e5f5bb3ad895438d3c5b5d2e8f23f8f46f2d423ed2
https://github.com/simstudioai/sim/pull/8749/files#diff-3dfd3e1443ae11d37fee36e5f5bb3ad895438d3c5b5d2e8f23f8f46f2d423ed2
https://github.com/simstudioai/sim/pull/8749/files#diff-3dfd3e1443ae11d37fee36e5f5bb3ad895438d3c5b5d2e8f23f8f46f2d423ed2
https://github.com/simstudioai/sim/pull/8749/files#diff-3dfd3e1443ae11d37fee36e5f5bb3ad895438d3c5b5d2e8f23f8f46f2d423ed2
https://github.com/simstudioai/sim/pull/8749/files#diff-3dfd3e1443ae11d37fee36e5f5bb3ad895438d3c5b5d2e8f23f8f46f2d423ed2
apps/desktop/src/main/desktop-executor/service.tshttps://github.com/simstudioai/sim/pull/8749/files#diff-b1278501073652f766c12e4b75a1cc24571a04e46e4c4539bb52a80ed6df5f4d
View file https://github.com/simstudioai/sim/blob/8246e2a573a50bee273c948ef926b5c56f540d36/apps/desktop/src/main/desktop-executor/service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8749/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8749/files#diff-b1278501073652f766c12e4b75a1cc24571a04e46e4c4539bb52a80ed6df5f4d
https://github.com/simstudioai/sim/pull/8749/files#diff-b1278501073652f766c12e4b75a1cc24571a04e46e4c4539bb52a80ed6df5f4d
https://github.com/simstudioai/sim/pull/8749/files#diff-b1278501073652f766c12e4b75a1cc24571a04e46e4c4539bb52a80ed6df5f4d
https://github.com/simstudioai/sim/pull/8749/files#diff-b1278501073652f766c12e4b75a1cc24571a04e46e4c4539bb52a80ed6df5f4d
apps/desktop/src/main/index.tshttps://github.com/simstudioai/sim/pull/8749/files#diff-5bf7db7b15749c034541a4a70a0cacf9816b4e214fd11cb5735c5ddb7ca4b1d8
View file https://github.com/simstudioai/sim/blob/8246e2a573a50bee273c948ef926b5c56f540d36/apps/desktop/src/main/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8749/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8749/files#diff-5bf7db7b15749c034541a4a70a0cacf9816b4e214fd11cb5735c5ddb7ca4b1d8
https://github.com/simstudioai/sim/pull/8749/files#diff-5bf7db7b15749c034541a4a70a0cacf9816b4e214fd11cb5735c5ddb7ca4b1d8
apps/desktop/src/main/terminal/index.tshttps://github.com/simstudioai/sim/pull/8749/files#diff-74076d8d25116ad5bb8b4f51915e92169cac28f67682613e6b181a2c845e1412
View file https://github.com/simstudioai/sim/blob/8246e2a573a50bee273c948ef926b5c56f540d36/apps/desktop/src/main/terminal/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8749/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8749/files#diff-74076d8d25116ad5bb8b4f51915e92169cac28f67682613e6b181a2c845e1412
https://github.com/simstudioai/sim/pull/8749/files#diff-74076d8d25116ad5bb8b4f51915e92169cac28f67682613e6b181a2c845e1412
apps/desktop/src/main/terminal/registry-run-ledger.test.tshttps://github.com/simstudioai/sim/pull/8749/files#diff-bf73f7bfa09ef47da9c1e8259fe4f80afa5109efc404d5ab50a824800aeb7730
View file https://github.com/simstudioai/sim/blob/8246e2a573a50bee273c948ef926b5c56f540d36/apps/desktop/src/main/terminal/registry-run-ledger.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8749/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8749/files#diff-bf73f7bfa09ef47da9c1e8259fe4f80afa5109efc404d5ab50a824800aeb7730
https://github.com/simstudioai/sim/pull/8749/files#diff-bf73f7bfa09ef47da9c1e8259fe4f80afa5109efc404d5ab50a824800aeb7730
apps/desktop/src/main/terminal/registry.tshttps://github.com/simstudioai/sim/pull/8749/files#diff-d30cc33e9e00dd9009a54bd75a24dbf056890b72571f5101186e11fd9291f199
View file https://github.com/simstudioai/sim/blob/8246e2a573a50bee273c948ef926b5c56f540d36/apps/desktop/src/main/terminal/registry.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8749/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8749/files#diff-d30cc33e9e00dd9009a54bd75a24dbf056890b72571f5101186e11fd9291f199
https://github.com/simstudioai/sim/pull/8749/files#diff-d30cc33e9e00dd9009a54bd75a24dbf056890b72571f5101186e11fd9291f199
Please reload this pagehttps://github.com/simstudioai/sim/pull/8749/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8749/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.