René's URL Explorer Experiment


Title: fix(executor): honor stop-after over pending pauses and carry it on resume by sudoKrishna · Pull Request #8745 · simstudioai/sim · GitHub

Open Graph Title: fix(executor): honor stop-after over pending pauses and carry it on resume by sudoKrishna · Pull Request #8745 · simstudioai/sim

X Title: fix(executor): honor stop-after over pending pauses and carry it on resume by sudoKrishna · Pull Request #8745 · simstudioai/sim

Description: Problem Two pre-existing bugs in stopAfterBlockId (the --stop-after / "run until block" feature), from #8661: Stop-after vs a pending pause. If the stop block completes while another branch is paused at a human-in-the-loop block, the run returns paused. Nothing downstream runs, before or after resume. Resume drops the stop target. If the stop block is itself a pausing block, resuming continues past it. Fix 1. Stop-after wins over a pending pause. The engine records that the stop target was reached; at the end of the run it clears any pending pause points and returns a completed run, so no unusable resume is persisted. Downstream of the stop target still does not run, as intended. 2. A pausing stop target is rejected upfront. stopAfterBlockId that targets a human-in-the-loop or wait block cannot be honored — the run pauses there and the resume path prunes the paused block's outgoing edges, so the target would be lost. execution-core now rejects it with a clear message instead of starting a run whose stop target resume cannot keep. New helper isPausingStopTarget in executor/utils/stop-after.ts. 3. The stop target is carried across pause/resume. stopAfterBlockId is persisted in the pause snapshot and passed back into the resumed run, so a run that pauses on a different branch still ends after its original stop target. Tests executor/execution/engine.test.ts — stop-after completes instead of pausing when another branch pauses; status is not paused and no pause points survive. executor/execution/snapshot-serializer.test.ts — the stop target is written into the pause snapshot. executor/utils/stop-after.test.ts — human-in-the-loop v1/v2 and wait targets are rejected; normal blocks and unknown ids are allowed. Existing coverage: 336 tests in executor/execution + the HITL manager pass unchanged. Closes #8661

Open Graph Description: Problem Two pre-existing bugs in stopAfterBlockId (the --stop-after / "run until block" feature), from #8661: Stop-after vs a pending pause. If the stop block completes while another bra...

X Description: Problem Two pre-existing bugs in stopAfterBlockId (the --stop-after / "run until block" feature), from #8661: Stop-after vs a pending pause. If the stop block completes while ano...

Opengraph URL: https://github.com/simstudioai/sim/pull/8745

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d56829ae-1947-c34f-bdf4-a87a83e572c7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE094:1B8129:D8EA53:129C0D0:6AFB5C76
html-safe-nonce6cda417af36108325b6dbd0de276f4a24f0986302ca88649e847304996f95e87
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDk0OjFCODEyOTpEOEVBNTM6MTI5QzBEMDo2QUZCNUM3NiIsInZpc2l0b3JfaWQiOiIzOTU2NDM2NDAzNTY2MTA3NzY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac166cd8d1abf797621231799a48bc2c6019fce3a1d421dc6b0e14a212a5d5a96f
hovercard-subject-tagpull_request:4772906892
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8745/files
twitter:imagehttps://avatars.githubusercontent.com/u/207152683?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/207152683?s=400&v=4
og:image:altProblem Two pre-existing bugs in stopAfterBlockId (the --stop-after / "run until block" feature), from #8661: Stop-after vs a pending pause. If the stop block completes while another bra...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8745/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8745%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8745%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8745/files
Reloadhttps://github.com/simstudioai/sim/pull/8745/files
Reloadhttps://github.com/simstudioai/sim/pull/8745/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
sudoKrishnahttps://github.com/sudoKrishna
simstudioai:staginghttps://github.com/simstudioai/sim/tree/staging
sudoKrishna:fix/stop-after-pausing-stophttps://github.com/sudoKrishna/sim/tree/fix/stop-after-pausing-stop
Conversation 4 https://github.com/simstudioai/sim/pull/8745
Commits 1 https://github.com/simstudioai/sim/pull/8745/commits
Checks 2 https://github.com/simstudioai/sim/pull/8745/checks
Files changed https://github.com/simstudioai/sim/pull/8745/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8745/files
fix(executor): honor stop-after over pending pauses and carry it on resume https://github.com/simstudioai/sim/pull/8745/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/8745/files
20e14bf fix(executor): honor stop-after over pending pauses and carry it on r… sudoKrishna Oct 7, 2026 https://github.com/simstudioai/sim/pull/8745/commits/20e14bfd57be2df64382049cfddec6baccf1c35b
Clear filters https://github.com/simstudioai/sim/pull/8745/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8745/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8745/files
engine.test.ts https://github.com/simstudioai/sim/pull/8745/files#diff-8a7dc7d2027ef09942b6480f995b1175f4f22ecbd015133850cb9f2dbc3df51e
engine.ts https://github.com/simstudioai/sim/pull/8745/files#diff-8fc33da0f336e4f8e9c4cef6bdcb2297ffb3bc693d739245b28cde225130de22
snapshot-serializer.test.ts https://github.com/simstudioai/sim/pull/8745/files#diff-cca2c61442682126a042f9f4c1960194d8d280b290a15d3418be3ab5d8a9e4c0
snapshot-serializer.ts https://github.com/simstudioai/sim/pull/8745/files#diff-286b94d0dccf44786a3521cfa8c89356d4c9527067384c199248493c4d6a9a9b
types.ts https://github.com/simstudioai/sim/pull/8745/files#diff-13fa0f819e17231a9e7f2853107d2f340fd9f18b0e86b8bdb411237ad0563669
stop-after.test.ts https://github.com/simstudioai/sim/pull/8745/files#diff-e05689649f07c5060818072f4197375d832c7bfb726c421499ad18f10a09625e
stop-after.ts https://github.com/simstudioai/sim/pull/8745/files#diff-98ebc2b60bdcc6b025ca58d6ae77d8fc74002bdbbe418e35db66a0f0640b145d
execution-core.ts https://github.com/simstudioai/sim/pull/8745/files#diff-2a32d546272efa06e3cbe2ccce1cf4e69c74ff37fe98253bcb2742ffed5bae4b
human-in-the-loop-manager.ts https://github.com/simstudioai/sim/pull/8745/files#diff-bb1129b15dc9783d16371ddc2f8992d36e41c60787a458e77e1c59a7e721d292
apps/sim/executor/execution/engine.test.tshttps://github.com/simstudioai/sim/pull/8745/files#diff-8a7dc7d2027ef09942b6480f995b1175f4f22ecbd015133850cb9f2dbc3df51e
View file https://github.com/sudoKrishna/sim/blob/20e14bfd57be2df64382049cfddec6baccf1c35b/apps/sim/executor/execution/engine.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8745/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8745/files#diff-8a7dc7d2027ef09942b6480f995b1175f4f22ecbd015133850cb9f2dbc3df51e
https://github.com/simstudioai/sim/pull/8745/files#diff-8a7dc7d2027ef09942b6480f995b1175f4f22ecbd015133850cb9f2dbc3df51e
apps/sim/executor/execution/engine.tshttps://github.com/simstudioai/sim/pull/8745/files#diff-8fc33da0f336e4f8e9c4cef6bdcb2297ffb3bc693d739245b28cde225130de22
View file https://github.com/sudoKrishna/sim/blob/20e14bfd57be2df64382049cfddec6baccf1c35b/apps/sim/executor/execution/engine.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8745/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8745/files#diff-8fc33da0f336e4f8e9c4cef6bdcb2297ffb3bc693d739245b28cde225130de22
https://github.com/simstudioai/sim/pull/8745/files#diff-8fc33da0f336e4f8e9c4cef6bdcb2297ffb3bc693d739245b28cde225130de22
https://github.com/simstudioai/sim/pull/8745/files#diff-8fc33da0f336e4f8e9c4cef6bdcb2297ffb3bc693d739245b28cde225130de22
https://github.com/simstudioai/sim/pull/8745/files#diff-8fc33da0f336e4f8e9c4cef6bdcb2297ffb3bc693d739245b28cde225130de22
https://github.com/simstudioai/sim/pull/8745/files#diff-8fc33da0f336e4f8e9c4cef6bdcb2297ffb3bc693d739245b28cde225130de22
https://github.com/simstudioai/sim/pull/8745/files#diff-8fc33da0f336e4f8e9c4cef6bdcb2297ffb3bc693d739245b28cde225130de22
apps/sim/executor/execution/snapshot-serializer.test.tshttps://github.com/simstudioai/sim/pull/8745/files#diff-cca2c61442682126a042f9f4c1960194d8d280b290a15d3418be3ab5d8a9e4c0
View file https://github.com/sudoKrishna/sim/blob/20e14bfd57be2df64382049cfddec6baccf1c35b/apps/sim/executor/execution/snapshot-serializer.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8745/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8745/files#diff-cca2c61442682126a042f9f4c1960194d8d280b290a15d3418be3ab5d8a9e4c0
https://github.com/simstudioai/sim/pull/8745/files#diff-cca2c61442682126a042f9f4c1960194d8d280b290a15d3418be3ab5d8a9e4c0
apps/sim/executor/execution/snapshot-serializer.tshttps://github.com/simstudioai/sim/pull/8745/files#diff-286b94d0dccf44786a3521cfa8c89356d4c9527067384c199248493c4d6a9a9b
View file https://github.com/sudoKrishna/sim/blob/20e14bfd57be2df64382049cfddec6baccf1c35b/apps/sim/executor/execution/snapshot-serializer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8745/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8745/files#diff-286b94d0dccf44786a3521cfa8c89356d4c9527067384c199248493c4d6a9a9b
https://github.com/simstudioai/sim/pull/8745/files#diff-286b94d0dccf44786a3521cfa8c89356d4c9527067384c199248493c4d6a9a9b
apps/sim/executor/execution/types.tshttps://github.com/simstudioai/sim/pull/8745/files#diff-13fa0f819e17231a9e7f2853107d2f340fd9f18b0e86b8bdb411237ad0563669
View file https://github.com/sudoKrishna/sim/blob/20e14bfd57be2df64382049cfddec6baccf1c35b/apps/sim/executor/execution/types.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8745/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8745/files#diff-13fa0f819e17231a9e7f2853107d2f340fd9f18b0e86b8bdb411237ad0563669
https://github.com/simstudioai/sim/pull/8745/files#diff-13fa0f819e17231a9e7f2853107d2f340fd9f18b0e86b8bdb411237ad0563669
apps/sim/executor/utils/stop-after.test.tshttps://github.com/simstudioai/sim/pull/8745/files#diff-e05689649f07c5060818072f4197375d832c7bfb726c421499ad18f10a09625e
View file https://github.com/sudoKrishna/sim/blob/20e14bfd57be2df64382049cfddec6baccf1c35b/apps/sim/executor/utils/stop-after.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8745/{{ revealButtonHref }}
apps/sim/executor/utils/stop-after.tshttps://github.com/simstudioai/sim/pull/8745/files#diff-98ebc2b60bdcc6b025ca58d6ae77d8fc74002bdbbe418e35db66a0f0640b145d
View file https://github.com/sudoKrishna/sim/blob/20e14bfd57be2df64382049cfddec6baccf1c35b/apps/sim/executor/utils/stop-after.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8745/{{ revealButtonHref }}
greptile-appshttps://github.com/apps/greptile-apps
Oct 7, 2026https://github.com/simstudioai/sim/pull/8745/files#r4207150323
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/simstudioai/sim/pull/8745/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8745/files
apps/sim/lib/workflows/executor/execution-core.tshttps://github.com/simstudioai/sim/pull/8745/files#diff-2a32d546272efa06e3cbe2ccce1cf4e69c74ff37fe98253bcb2742ffed5bae4b
View file https://github.com/sudoKrishna/sim/blob/20e14bfd57be2df64382049cfddec6baccf1c35b/apps/sim/lib/workflows/executor/execution-core.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8745/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8745/files#diff-2a32d546272efa06e3cbe2ccce1cf4e69c74ff37fe98253bcb2742ffed5bae4b
https://github.com/simstudioai/sim/pull/8745/files#diff-2a32d546272efa06e3cbe2ccce1cf4e69c74ff37fe98253bcb2742ffed5bae4b
https://github.com/simstudioai/sim/pull/8745/files#diff-2a32d546272efa06e3cbe2ccce1cf4e69c74ff37fe98253bcb2742ffed5bae4b
https://github.com/simstudioai/sim/pull/8745/files#diff-2a32d546272efa06e3cbe2ccce1cf4e69c74ff37fe98253bcb2742ffed5bae4b
apps/sim/lib/workflows/executor/human-in-the-loop-manager.tshttps://github.com/simstudioai/sim/pull/8745/files#diff-bb1129b15dc9783d16371ddc2f8992d36e41c60787a458e77e1c59a7e721d292
View file https://github.com/sudoKrishna/sim/blob/20e14bfd57be2df64382049cfddec6baccf1c35b/apps/sim/lib/workflows/executor/human-in-the-loop-manager.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8745/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8745/files#diff-bb1129b15dc9783d16371ddc2f8992d36e41c60787a458e77e1c59a7e721d292
https://github.com/simstudioai/sim/pull/8745/files#diff-bb1129b15dc9783d16371ddc2f8992d36e41c60787a458e77e1c59a7e721d292
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.