René's URL Explorer Experiment


Title: fix(mothership): a pure resend verdict, and Send-now drops a message the server already has by waleedlatif1 · Pull Request #8744 · simstudioai/sim · GitHub

Open Graph Title: fix(mothership): a pure resend verdict, and Send-now drops a message the server already has by waleedlatif1 · Pull Request #8744 · simstudioai/sim

X Title: fix(mothership): a pure resend verdict, and Send-now drops a message the server already has by waleedlatif1 · Pull Request #8744 · simstudioai/sim

Description: Summary Fourth step of the chat send-queue consolidation (after #8743): a pure resend verdict, one discard helper, and Send-now honouring the verdict (G5). A pure resend verdict. resendVerdict(entry, history | null) in send-queue-policy.ts returns 'send' | 'wait' | 'drop': drop when the chat's history shows the reused id accepted (as a user message or as the running turn); wait when the history couldn't be read; otherwise send. needsResendCheck decides whether the history has to be read at all. The queue drain acts on the verdict (defer on wait, discard on drop), replacing the side-effecting boolean mustNotResend. acceptedMessageIds moved into the policy module. One discard helper. discardQueuedSend(chatKey, id) replaces the three copies of clear handoff state, clear claim, remove. G5: Send-now honours drop. Send-now skipped the history check, so a message the server had already accepted could be sent again by hand. Once the earlier attempt's claim had expired, that ran a second turn. It now checks first and drops such a message. A history it can't read doesn't hold back a send the user asked for, because the server deduplicates while the claim lasts. Tidy-ups from #8743's review: rehydrate rows for the production shape and for a queue already in the new shape; the offline-hold waits in the DOM tests check hold === 'online'; the one-lookup comment names where the one-hop migration invariant is enforced. Release note: rollback A build older than #8743 ignores hold and retry when it restores a saved queue. After a rollback, a tab that reloads could drain a held message right away instead of waiting for the user, the network, or its retry delay. Duplicates are still covered: such a message keeps admissionUnknown and its reused id, so it can't be edited into a second message and the server deduplicates it while the claim lasts. Type of Change Bug fix Improvement (refactor) Testing drops a Send-now whose id the server already accepted instead of resending it (DOM) fails on staging: one POST goes out. It passes here. resendVerdict unit tests: no check needed, drop (message or running turn), send, and wait. The own-id 409 test from #8727 now reaches its branch through a Send-now restored from its stored handoff. With G5, a message whose earlier attempt is the running turn is dropped before any POST. It still fails without the own-id check. does not stop the running turn for a Send-now removed while its history is read (DOM): after its history read, Send-now goes on only if the message is still this view's queued, unedited, undispatched message. Fails without that check. Rehydrate test: the production shape (retryRequired: false) and the new shape pass through as expected. The full gate and integration tests ran on the CI runner. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Fourth step of the chat send-queue consolidation (after #8743): a pure resend verdict, one discard helper, and Send-now honouring the verdict (G5). A pure resend verdict. resendVerdict(en...

X Description: Summary Fourth step of the chat send-queue consolidation (after #8743): a pure resend verdict, one discard helper, and Send-now honouring the verdict (G5). A pure resend verdict. resendVerdict(en...

Opengraph URL: https://github.com/simstudioai/sim/pull/8744

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b9162d77-9f71-5c71-3687-2966fac41b32
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB648:2550AC:9FB609:E10093:6AFB757D
html-safe-nonce7e114b333276be59362423ac2036e1394700ac275c9befcdc005f4629d5661f6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjQ4OjI1NTBBQzo5RkI2MDk6RTEwMDkzOjZBRkI3NTdEIiwidmlzaXRvcl9pZCI6IjI4NTIxODY3NDM5NjI4MjYxMDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9e9467b3ca7ca4a131a07939f4f653591e86c82472c37daa22acb424646c43bf
hovercard-subject-tagpull_request:4772531924
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8744/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Fourth step of the chat send-queue consolidation (after #8743): a pure resend verdict, one discard helper, and Send-now honouring the verdict (G5). A pure resend verdict. resendVerdict(en...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8744/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8744%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8744%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8744/files
Reloadhttps://github.com/simstudioai/sim/pull/8744/files
Reloadhttps://github.com/simstudioai/sim/pull/8744/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests201 (201)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
refactor/mothership-resend-verdicthttps://github.com/simstudioai/sim/tree/refactor/mothership-resend-verdict
Conversation 14 https://github.com/simstudioai/sim/pull/8744
Commits 4 https://github.com/simstudioai/sim/pull/8744/commits
Checks 34 https://github.com/simstudioai/sim/pull/8744/checks
Files changed https://github.com/simstudioai/sim/pull/8744/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8744/files
fix(mothership): a pure resend verdict, and Send-now drops a message the server already has https://github.com/simstudioai/sim/pull/8744/files#top
Show all changes 4 commits https://github.com/simstudioai/sim/pull/8744/files
8ea8621 refactor(mothership): a pure resend verdict, one discard helper, and … waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8744/commits/8ea86217bdb0c882b9c893619d42a79537a7243c
d9d3589 test(mothership): lock the queue upgrade path and tighten held waits waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8744/commits/d9d35894f67cf1d446e7ea393a4bba12737c72af
2c5608b fix(mothership): don't stop the running turn for a Send-now gone duri… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8744/commits/2c5608bac4dab76153cee0cce0dbd30824a0173f
cb91ded test(mothership): cover Send-now's re-checks after its history read waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8744/commits/cb91ded87e6a6b8bed27e73d08191969e9639bf2
Clear filters https://github.com/simstudioai/sim/pull/8744/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8744/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8744/files
send-queue-policy.test.ts https://github.com/simstudioai/sim/pull/8744/files#diff-1f19ad2c53ae8c15158a8227b71177ab95679586bb747052274012bf0dcf5a42
send-queue-policy.ts https://github.com/simstudioai/sim/pull/8744/files#diff-bbbad867578f4bbaf88ce57cf065fe3f0997db7169a77b70eba2056a09a0a029
use-chat.dom.test.tsx https://github.com/simstudioai/sim/pull/8744/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
use-chat.ts https://github.com/simstudioai/sim/pull/8744/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
store.dom.test.ts https://github.com/simstudioai/sim/pull/8744/files#diff-6b254137160c4dbb5b0b26e82a5e6b07a78bfcfe4255e2dbd88cd9ba952a2cb1
store.ts https://github.com/simstudioai/sim/pull/8744/files#diff-f9609bb09028d5fea616b8fbeca370d62c6a6d20f6dc460fed34a8a0594dce70
apps/sim/app/workspace/[workspaceId]/home/hooks/send-queue-policy.test.tshttps://github.com/simstudioai/sim/pull/8744/files#diff-1f19ad2c53ae8c15158a8227b71177ab95679586bb747052274012bf0dcf5a42
View file https://github.com/simstudioai/sim/blob/cb91ded87e6a6b8bed27e73d08191969e9639bf2/apps/sim/app/workspace/%5BworkspaceId%5D/home/hooks/send-queue-policy.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8744/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8744/files#diff-1f19ad2c53ae8c15158a8227b71177ab95679586bb747052274012bf0dcf5a42
https://github.com/simstudioai/sim/pull/8744/files#diff-1f19ad2c53ae8c15158a8227b71177ab95679586bb747052274012bf0dcf5a42
apps/sim/app/workspace/[workspaceId]/home/hooks/send-queue-policy.tshttps://github.com/simstudioai/sim/pull/8744/files#diff-bbbad867578f4bbaf88ce57cf065fe3f0997db7169a77b70eba2056a09a0a029
View file https://github.com/simstudioai/sim/blob/cb91ded87e6a6b8bed27e73d08191969e9639bf2/apps/sim/app/workspace/%5BworkspaceId%5D/home/hooks/send-queue-policy.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8744/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8744/files#diff-bbbad867578f4bbaf88ce57cf065fe3f0997db7169a77b70eba2056a09a0a029
https://github.com/simstudioai/sim/pull/8744/files#diff-bbbad867578f4bbaf88ce57cf065fe3f0997db7169a77b70eba2056a09a0a029
Please reload this pagehttps://github.com/simstudioai/sim/pull/8744/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8744/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.