Title: fix(mothership): a pure resend verdict, and Send-now drops a message the server already has by waleedlatif1 · Pull Request #8744 · simstudioai/sim · GitHub
Open Graph Title: fix(mothership): a pure resend verdict, and Send-now drops a message the server already has by waleedlatif1 · Pull Request #8744 · simstudioai/sim
X Title: fix(mothership): a pure resend verdict, and Send-now drops a message the server already has by waleedlatif1 · Pull Request #8744 · simstudioai/sim
Description: Summary Fourth step of the chat send-queue consolidation (after #8743): a pure resend verdict, one discard helper, and Send-now honouring the verdict (G5). A pure resend verdict. resendVerdict(entry, history | null) in send-queue-policy.ts returns 'send' | 'wait' | 'drop': drop when the chat's history shows the reused id accepted (as a user message or as the running turn); wait when the history couldn't be read; otherwise send. needsResendCheck decides whether the history has to be read at all. The queue drain acts on the verdict (defer on wait, discard on drop), replacing the side-effecting boolean mustNotResend. acceptedMessageIds moved into the policy module. One discard helper. discardQueuedSend(chatKey, id) replaces the three copies of clear handoff state, clear claim, remove. G5: Send-now honours drop. Send-now skipped the history check, so a message the server had already accepted could be sent again by hand. Once the earlier attempt's claim had expired, that ran a second turn. It now checks first and drops such a message. A history it can't read doesn't hold back a send the user asked for, because the server deduplicates while the claim lasts. Tidy-ups from #8743's review: rehydrate rows for the production shape and for a queue already in the new shape; the offline-hold waits in the DOM tests check hold === 'online'; the one-lookup comment names where the one-hop migration invariant is enforced. Release note: rollback A build older than #8743 ignores hold and retry when it restores a saved queue. After a rollback, a tab that reloads could drain a held message right away instead of waiting for the user, the network, or its retry delay. Duplicates are still covered: such a message keeps admissionUnknown and its reused id, so it can't be edited into a second message and the server deduplicates it while the claim lasts. Type of Change Bug fix Improvement (refactor) Testing drops a Send-now whose id the server already accepted instead of resending it (DOM) fails on staging: one POST goes out. It passes here. resendVerdict unit tests: no check needed, drop (message or running turn), send, and wait. The own-id 409 test from #8727 now reaches its branch through a Send-now restored from its stored handoff. With G5, a message whose earlier attempt is the running turn is dropped before any POST. It still fails without the own-id check. does not stop the running turn for a Send-now removed while its history is read (DOM): after its history read, Send-now goes on only if the message is still this view's queued, unedited, undispatched message. Fails without that check. Rehydrate test: the production shape (retryRequired: false) and the new shape pass through as expected. The full gate and integration tests ran on the CI runner. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Fourth step of the chat send-queue consolidation (after #8743): a pure resend verdict, one discard helper, and Send-now honouring the verdict (G5). A pure resend verdict. resendVerdict(en...
X Description: Summary Fourth step of the chat send-queue consolidation (after #8743): a pure resend verdict, one discard helper, and Send-now honouring the verdict (G5). A pure resend verdict. resendVerdict(en...
Opengraph URL: https://github.com/simstudioai/sim/pull/8744
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b9162d77-9f71-5c71-3687-2966fac41b32 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B648:2550AC:9FB609:E10093:6AFB757D |
| html-safe-nonce | 7e114b333276be59362423ac2036e1394700ac275c9befcdc005f4629d5661f6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjQ4OjI1NTBBQzo5RkI2MDk6RTEwMDkzOjZBRkI3NTdEIiwidmlzaXRvcl9pZCI6IjI4NTIxODY3NDM5NjI4MjYxMDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 9e9467b3ca7ca4a131a07939f4f653591e86c82472c37daa22acb424646c43bf |
| hovercard-subject-tag | pull_request:4772531924 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8744/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Fourth step of the chat send-queue consolidation (after #8743): a pure resend verdict, one discard helper, and Send-now honouring the verdict (G5). A pure resend verdict. resendVerdict(en... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2e8872b770cc4d5d0cc1f2026afab747a268e2ce |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width