René's URL Explorer Experiment


Title: test(desktop): pin the journal snapshot before recovery, keep start going when the journal cannot load, and run tmux in the canary E2E by waleedlatif1 · Pull Request #8739 · simstudioai/sim · GitHub

Open Graph Title: test(desktop): pin the journal snapshot before recovery, keep start going when the journal cannot load, and run tmux in the canary E2E by waleedlatif1 · Pull Request #8739 · simstudioai/sim

X Title: test(desktop): pin the journal snapshot before recovery, keep start going when the journal cannot load, and run tmux in the canary E2E by waleedlatif1 · Pull Request #8739 · simstudioai/sim

Description: Summary Review follow-ups from #8737 and #8733. The journal-snapshot test now fails when the snapshot is taken after recovery. Recovery hands its deliveries off without waiting for them, so the journal still held the result when recover() returned. A snapshot taken after recovery therefore stayed green. The test now makes recovery return only once Sim has the result and the journal no longer holds it. A journal load that throws no longer stops the executor from starting. The pending-results snapshot catches a rejected journal.load(), logs it, and counts the journal as holding none. Without that, start() would never reach recovery or the inbox. The electron@latest canary job now installs tmux. Before, its terminal-cancel tmux scenarios skipped silently. Not changed: forget dropping the call index entry: a ledger test already pins it. It has no other observable effect: after forget, the record file is gone, so a late advance finds nothing and does nothing. A plain-shell user command in the cookie test: sign-out closes every plain shell by design. A user's plain-shell command is checked against Stop, and the user's tmux pane against every path. Type of Change Test coverage Testing Desktop executor tests: 88/88. Red checks: each of these fails the service tests in 3 of 3 runs: moving the snapshot after recover(); removing the snapshot; removing the .catch. EC2 gate: green. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Review follow-ups from #8737 and #8733. The journal-snapshot test now fails when the snapshot is taken after recovery. Recovery hands its deliveries off without waiting for them, so the j...

X Description: Summary Review follow-ups from #8737 and #8733. The journal-snapshot test now fails when the snapshot is taken after recovery. Recovery hands its deliveries off without waiting for them, so the j...

Opengraph URL: https://github.com/simstudioai/sim/pull/8739

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:10531200-f96f-d9b4-a3ff-7ebbbc00b937
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id82E6:330459:BF36FB:10EB494:6AFB5DE6
html-safe-nonce85695d990ecbe068e8e559764cb951998964a2c40309e05ecf46ae66456c7f47
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MkU2OjMzMDQ1OTpCRjM2RkI6MTBFQjQ5NDo2QUZCNURFNiIsInZpc2l0b3JfaWQiOiI3NTI1MjQ2NDYyMDcwNTc4NjYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4bd11a8eb940a0dc6711949264762f39989aa03ebfde8327b1310da6ac5b0006
hovercard-subject-tagpull_request:4770703961
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8739/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Review follow-ups from #8737 and #8733. The journal-snapshot test now fails when the snapshot is taken after recovery. Recovery hands its deliveries off without waiting for them, so the j...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8739/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8739%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8739%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8739/files
Reloadhttps://github.com/simstudioai/sim/pull/8739/files
Reloadhttps://github.com/simstudioai/sim/pull/8739/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
test/desktop-ledger-review-nitshttps://github.com/simstudioai/sim/tree/test/desktop-ledger-review-nits
Conversation 14 https://github.com/simstudioai/sim/pull/8739
Commits 2 https://github.com/simstudioai/sim/pull/8739/commits
Checks 35 https://github.com/simstudioai/sim/pull/8739/checks
Files changed https://github.com/simstudioai/sim/pull/8739/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8739/files
test(desktop): pin the journal snapshot before recovery, keep start going when the journal cannot load, and run tmux in the canary E2E https://github.com/simstudioai/sim/pull/8739/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/8739/files
07f858f test(desktop): pin the journal snapshot before recovery, keep start g… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8739/commits/07f858f4e79c0afca0291a5362687d0daad7bb55
9cece15 test(desktop): wait for the journal to empty, not for recovery to be … waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8739/commits/9cece15ca4edd261ec993f8b26ea8cdf17a44e57
Clear filters https://github.com/simstudioai/sim/pull/8739/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8739/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8739/files
desktop-e2e.yml https://github.com/simstudioai/sim/pull/8739/files#diff-bd135c8b96862e814e25bebb306d5ab90bed442b5507f46d017faa072565515c
service.test.ts https://github.com/simstudioai/sim/pull/8739/files#diff-bb870d6cdaadc893c82c9b02921605ea6aee1db801f3434d850e1fd7cd2dbd94
service.ts https://github.com/simstudioai/sim/pull/8739/files#diff-b1278501073652f766c12e4b75a1cc24571a04e46e4c4539bb52a80ed6df5f4d
.github/workflows/desktop-e2e.ymlhttps://github.com/simstudioai/sim/pull/8739/files#diff-bd135c8b96862e814e25bebb306d5ab90bed442b5507f46d017faa072565515c
View file https://github.com/simstudioai/sim/blob/9cece15ca4edd261ec993f8b26ea8cdf17a44e57/.github/workflows/desktop-e2e.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8739/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8739/files#diff-bd135c8b96862e814e25bebb306d5ab90bed442b5507f46d017faa072565515c
https://github.com/simstudioai/sim/pull/8739/files#diff-bd135c8b96862e814e25bebb306d5ab90bed442b5507f46d017faa072565515c
apps/desktop/src/main/desktop-executor/service.test.tshttps://github.com/simstudioai/sim/pull/8739/files#diff-bb870d6cdaadc893c82c9b02921605ea6aee1db801f3434d850e1fd7cd2dbd94
View file https://github.com/simstudioai/sim/blob/9cece15ca4edd261ec993f8b26ea8cdf17a44e57/apps/desktop/src/main/desktop-executor/service.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8739/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8739/files#diff-bb870d6cdaadc893c82c9b02921605ea6aee1db801f3434d850e1fd7cd2dbd94
https://github.com/simstudioai/sim/pull/8739/files#diff-bb870d6cdaadc893c82c9b02921605ea6aee1db801f3434d850e1fd7cd2dbd94
https://github.com/simstudioai/sim/pull/8739/files#diff-bb870d6cdaadc893c82c9b02921605ea6aee1db801f3434d850e1fd7cd2dbd94
https://github.com/simstudioai/sim/pull/8739/files#diff-bb870d6cdaadc893c82c9b02921605ea6aee1db801f3434d850e1fd7cd2dbd94
apps/desktop/src/main/desktop-executor/service.tshttps://github.com/simstudioai/sim/pull/8739/files#diff-b1278501073652f766c12e4b75a1cc24571a04e46e4c4539bb52a80ed6df5f4d
View file https://github.com/simstudioai/sim/blob/9cece15ca4edd261ec993f8b26ea8cdf17a44e57/apps/desktop/src/main/desktop-executor/service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8739/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8739/files#diff-b1278501073652f766c12e4b75a1cc24571a04e46e4c4539bb52a80ed6df5f4d
Please reload this pagehttps://github.com/simstudioai/sim/pull/8739/files
https://github.com/simstudioai/sim/pull/8739/files#diff-b1278501073652f766c12e4b75a1cc24571a04e46e4c4539bb52a80ed6df5f4d
Please reload this pagehttps://github.com/simstudioai/sim/pull/8739/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.