René's URL Explorer Experiment


Title: test(desktop): stop the agent's terminal commands in the real app, with real shells and real tmux by waleedlatif1 · Pull Request #8733 · simstudioai/sim · GitHub

Open Graph Title: test(desktop): stop the agent's terminal commands in the real app, with real shells and real tmux by waleedlatif1 · Pull Request #8733 · simstudioai/sim

X Title: test(desktop): stop the agent's terminal commands in the real app, with real shells and real tmux by waleedlatif1 · Pull Request #8733 · simstudioai/sim

Description: Summary Terminal cancel ships without a feature flag, so this tests it in the real app, with real shells and a real tmux server. It asserts what is running and which panes exist, never which calls were made. Builds on #8705, #8720, #8722 and #8725, all on staging. Stop: ends an agent command in a plain shell, and a tagged tmux run, closing only its pane. The user's own command, and the pane the user split beside the agent's, keep running. Sign-out: through the web app's logout, and through the session cookie going away (another account signing in). Every agent command stops, and the user's tmux panes keep running. Switching Terminal off: the same. A tmux run whose chat was put away: sign-out stops it, though no live terminal holds it any more. Launch recovery: after an interrupted sign-out, the previous process's run is stopped; after a crash mid-wait (the call never got its result), it is stopped; a run handed back as running survives a quit and the relaunch, and its pane can still be read; a finished run is only forgotten; a pane that took a recorded id after a tmux restart is never touched. tmux without pane options: using real tmux 2.9a's refusal text, a run goes ahead untracked, and Stop and sign-out leave it alone. How it is built Agent and user commands ignore SIGHUP, SIGINT and SIGTERM, so only Sim's own stop (which escalates to SIGKILL) can end them, and a stray stop would show. Each launch gets its own tmux server (TMUX_TMPDIR). Every process name carries a per-run suffix, so concurrent runs on one machine never see each other's processes. The fixture Sim and its helpers move to e2e/executor-sim.ts, shared with the background executor suite. The macOS Desktop E2E job installs tmux, so the tmux scenarios run in CI. Without tmux they skip, with the reason given. Each scenario's status and duration go to TERMINAL_CANCEL_REPORT_PATH (test-results/terminal-cancel-report.json in CI, uploaded on failure). A failed scenario attaches its calls, its panes, the app's output and the process list. By design, sign-out and Terminal off close every shell. So a user's command in a plain-shell tab is checked against Stop, and a user's command in a tmux pane is checked against every path. Type of Change Test coverage Testing EC2 (Linux, real tmux 3.4): 12/12. Each of 14 guards, removed in turn, turns its scenario red: Stop (plain shell and tmux); user commands and panes left alone; the sign-out, cookie and Terminal-off paths; untracked runs; the launch and sign-out sweeps; the tag check on recorded runs; dropping finished records; keeping collectable runs; marking runs handed back. Cold runs: 120/120 across 10 fresh Playwright invocations on EC2, on this branch rebased onto staging. Mac (no tmux installed): the 4 plain-shell scenarios pass and the 8 tmux scenarios skip. The background executor suite after the fixture move: 11/11 on the Mac. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Terminal cancel ships without a feature flag, so this tests it in the real app, with real shells and a real tmux server. It asserts what is running and which panes exist, never which calls ...

X Description: Summary Terminal cancel ships without a feature flag, so this tests it in the real app, with real shells and a real tmux server. It asserts what is running and which panes exist, never which calls ...

Opengraph URL: https://github.com/simstudioai/sim/pull/8733

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3cf585bf-9687-213c-4a2d-d5a7a4c1970b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA220:305156:8A55CE:C2BBD7:6AFB6F39
html-safe-nonce203eda9aed7eec7952ebd4af73700f3579402aae8523300446ee5b25f32d8381
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjIwOjMwNTE1Njo4QTU1Q0U6QzJCQkQ3OjZBRkI2RjM5IiwidmlzaXRvcl9pZCI6IjY5MDc1MjY3ODA3NDgwMDEwODEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacec39c716e807b7a6b9eceeb5baa99b0623a71f1e03d268524ca983fee1fca610
hovercard-subject-tagpull_request:4769328323
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8733/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Terminal cancel ships without a feature flag, so this tests it in the real app, with real shells and a real tmux server. It asserts what is running and which panes exist, never which calls ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecca289ecd54650fcf3c0b037a58b97186dee2cc4406819d87fab93728fd83700
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release88808b1fae5ab8a526a73e7ce5542a10eb9d6971
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8733/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8733%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8733%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8733/files
Reloadhttps://github.com/simstudioai/sim/pull/8733/files
Reloadhttps://github.com/simstudioai/sim/pull/8733/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
test/desktop-terminal-cancel-e2ehttps://github.com/simstudioai/sim/tree/test/desktop-terminal-cancel-e2e
Conversation 23 https://github.com/simstudioai/sim/pull/8733
Commits 4 https://github.com/simstudioai/sim/pull/8733/commits
Checks 35 https://github.com/simstudioai/sim/pull/8733/checks
Files changed https://github.com/simstudioai/sim/pull/8733/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8733/files
test(desktop): stop the agent's terminal commands in the real app, with real shells and real tmux https://github.com/simstudioai/sim/pull/8733/files#top
Show all changes 4 commits https://github.com/simstudioai/sim/pull/8733/files
2007048 test(desktop): stop the agent's terminal commands in the real app, wi… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8733/commits/2007048b2845d98384cd8c2864e318a76f7a69bb
f8ce008 test(desktop): draw the run nonce from the shared random helpers, and… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8733/commits/f8ce0081608ced6173c156c7606ca23dec3d1110
aa1ee57 test(desktop): attach terminal-cancel diagnostics instead of printing… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8733/commits/aa1ee574dbb3f81b56214ee663a6adf63dbc3943
53aab9b test(desktop): add each terminal-cancel check to the report as it fin… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8733/commits/53aab9b7028a823123bd23906a6762e3ea38c3ec
Clear filters https://github.com/simstudioai/sim/pull/8733/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8733/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8733/files
desktop-e2e.yml https://github.com/simstudioai/sim/pull/8733/files#diff-bd135c8b96862e814e25bebb306d5ab90bed442b5507f46d017faa072565515c
background-executor.spec.ts https://github.com/simstudioai/sim/pull/8733/files#diff-4332bb9fbb86c853395301498b2e8eb627bbc7c6b68c498ae343555109ea5d3b
executor-sim.ts https://github.com/simstudioai/sim/pull/8733/files#diff-f7287895c9710d50863469cc1e21109b849709c77267141ec2e89e12be1b5504
terminal-cancel.spec.ts https://github.com/simstudioai/sim/pull/8733/files#diff-a2a1fd3f18f9f2769bcff835feaa12ebf35127e58110b606e8b0ddf3be662ce6
.github/workflows/desktop-e2e.ymlhttps://github.com/simstudioai/sim/pull/8733/files#diff-bd135c8b96862e814e25bebb306d5ab90bed442b5507f46d017faa072565515c
View file https://github.com/simstudioai/sim/blob/53aab9b7028a823123bd23906a6762e3ea38c3ec/.github/workflows/desktop-e2e.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8733/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8733/files#diff-bd135c8b96862e814e25bebb306d5ab90bed442b5507f46d017faa072565515c
https://github.com/simstudioai/sim/pull/8733/files#diff-bd135c8b96862e814e25bebb306d5ab90bed442b5507f46d017faa072565515c
Please reload this pagehttps://github.com/simstudioai/sim/pull/8733/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8733/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.