René's URL Explorer Experiment


Title: fix(desktop): leave a stopped native file tool's outcome to Stop by waleedlatif1 · Pull Request #8732 · simstudioai/sim · GitHub

Open Graph Title: fix(desktop): leave a stopped native file tool's outcome to Stop by waleedlatif1 · Pull Request #8732 · simstudioai/sim

X Title: fix(desktop): leave a stopped native file tool's outcome to Stop by waleedlatif1 · Pull Request #8732 · simstudioai/sim

Description: Summary A local read or import cancelled by Stop (or sign-out) reported its own error completion. That raced Stop's settlement, so a stopped import ended failed or cancelled depending on which committed first. Native file tools now report nothing once cancelled, the same as browser actions and granted-folder (VFS) reads. Stop's own record stands: cancelled, with the stopped-before-start or stopped-while-running message. Regression tests: an import stopped mid-upload, and a read stopped while the desktop was reading, report nothing. Why the existing tests didn't catch it: they covered success, partial failure and replay, but never a cancelled signal. The live-Sim Electron E2E in #8697 surfaced it. Type of Change Bug fix Testing New unit tests failed before the fix and pass after Lint, typecheck and the client tool tests pass Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary A local read or import cancelled by Stop (or sign-out) reported its own error completion. That raced Stop's settlement, so a stopped import ended failed or cancelled depending on which...

X Description: Summary A local read or import cancelled by Stop (or sign-out) reported its own error completion. That raced Stop's settlement, so a stopped import ended failed or cancelled depending on w...

Opengraph URL: https://github.com/simstudioai/sim/pull/8732

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c73a5c24-d532-e675-7cd4-69baa64bb248
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8B64:ECC72:29B16F:3B14DF:6AFB6F51
html-safe-nonce9ab81c58624664c6d6e2ecf04ee39273d576239921307ea05c1c136e769504f4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QjY0OkVDQzcyOjI5QjE2RjozQjE0REY6NkFGQjZGNTEiLCJ2aXNpdG9yX2lkIjoiMTEwNzE1ODAyODU2NzQwODQ2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc95b2df0aa8a0855a5ad15be5b13f010888560013a3bc81cbfc2a8169122597a
hovercard-subject-tagpull_request:4769328129
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8732/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary A local read or import cancelled by Stop (or sign-out) reported its own error completion. That raced Stop's settlement, so a stopped import ended failed or cancelled depending on which...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecca289ecd54650fcf3c0b037a58b97186dee2cc4406819d87fab93728fd83700
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release88808b1fae5ab8a526a73e7ce5542a10eb9d6971
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8732/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8732%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8732%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8732/files
Reloadhttps://github.com/simstudioai/sim/pull/8732/files
Reloadhttps://github.com/simstudioai/sim/pull/8732/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/desktop-native-files-stop-cancelledhttps://github.com/simstudioai/sim/tree/fix/desktop-native-files-stop-cancelled
Conversation 2 https://github.com/simstudioai/sim/pull/8732
Commits 1 https://github.com/simstudioai/sim/pull/8732/commits
Checks 32 https://github.com/simstudioai/sim/pull/8732/checks
Files changed https://github.com/simstudioai/sim/pull/8732/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8732/files
fix(desktop): leave a stopped native file tool's outcome to Stop https://github.com/simstudioai/sim/pull/8732/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/8732/files
a61178d fix(desktop): leave a stopped native file tool's outcome to Stop waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8732/commits/a61178dd59588c9aa2e1319ad8601f3cf7db393c
Clear filters https://github.com/simstudioai/sim/pull/8732/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8732/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8732/files
native-files.test.ts https://github.com/simstudioai/sim/pull/8732/files#diff-2122eae0d9c01987176e3492dccbb143ddc615ff8b78201cad4ce8a27ba00b21
native-files.ts https://github.com/simstudioai/sim/pull/8732/files#diff-01e57591e5a87b4b94881498021b7ba9cca56769e8cc0504a85643e19b0f22ca
apps/sim/lib/mothership/tools/client/native-files.test.tshttps://github.com/simstudioai/sim/pull/8732/files#diff-2122eae0d9c01987176e3492dccbb143ddc615ff8b78201cad4ce8a27ba00b21
View file https://github.com/simstudioai/sim/blob/a61178dd59588c9aa2e1319ad8601f3cf7db393c/apps/sim/lib/mothership/tools/client/native-files.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8732/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8732/files#diff-2122eae0d9c01987176e3492dccbb143ddc615ff8b78201cad4ce8a27ba00b21
apps/sim/lib/mothership/tools/client/native-files.tshttps://github.com/simstudioai/sim/pull/8732/files#diff-01e57591e5a87b4b94881498021b7ba9cca56769e8cc0504a85643e19b0f22ca
View file https://github.com/simstudioai/sim/blob/a61178dd59588c9aa2e1319ad8601f3cf7db393c/apps/sim/lib/mothership/tools/client/native-files.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8732/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8732/files#diff-01e57591e5a87b4b94881498021b7ba9cca56769e8cc0504a85643e19b0f22ca
https://github.com/simstudioai/sim/pull/8732/files#diff-01e57591e5a87b4b94881498021b7ba9cca56769e8cc0504a85643e19b0f22ca
https://github.com/simstudioai/sim/pull/8732/files#diff-01e57591e5a87b4b94881498021b7ba9cca56769e8cc0504a85643e19b0f22ca
Please reload this pagehttps://github.com/simstudioai/sim/pull/8732/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.