Title: test(mothership): stop the online case of the accepted-resend test passing without its history check by waleedlatif1 · Pull Request #8730 · simstudioai/sim · GitHub
Open Graph Title: test(mothership): stop the online case of the accepted-resend test passing without its history check by waleedlatif1 · Pull Request #8730 · simstudioai/sim
X Title: test(mothership): stop the online case of the accepted-resend test passing without its history check by waleedlatif1 · Pull Request #8730 · simstudioai/sim
Description: Summary The online case of "drops a resend the chat history shows was accepted" dispatched a synthetic online event even though the browser never went offline. That event makes React Query refetch the chat, and the refetch drops the queued entry on its own before the queue's history check runs, so the test passed with the check removed The event is now dispatched only in the offline case, so the online case depends on the queue's history check Correction to #8726's description: it said the new tests "fail when their part of the change is reverted", but this online case didn't. Both cases now fail when the history check is removed Type of Change Bug fix (test only) Testing Both cases pass, and both fail with the history check removed from the queue drain Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary The online case of "drops a resend the chat history shows was accepted" dispatched a synthetic online event even though the browser never went offline. That event makes React Que...
X Description: Summary The online case of "drops a resend the chat history shows was accepted" dispatched a synthetic online event even though the browser never went offline. That event makes R...
Opengraph URL: https://github.com/simstudioai/sim/pull/8730
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:4e241da9-f82e-70fd-2de8-2017e05a4163 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9438:71617:DF201:137E1E:6AFB75D9 |
| html-safe-nonce | 681fe508354e8b821e5a3d6deacba5b467dfb7683f0054ed815256efd3600281 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDM4OjcxNjE3OkRGMjAxOjEzN0UxRTo2QUZCNzVEOSIsInZpc2l0b3JfaWQiOiI3ODA5NTIzNTYxMzQ0NDk3MTEzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 27b8b7a60997d9da6609d5c47143cae0a18f7165df893b54748cf993a81c1b00 |
| hovercard-subject-tag | pull_request:4769250695 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8730/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary The online case of "drops a resend the chat history shows was accepted" dispatched a synthetic online event even though the browser never went offline. That event makes React Que... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2e8872b770cc4d5d0cc1f2026afab747a268e2ce |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width