Title: fix(mothership): claim under the chat lock in the Stop-versus-recovery settlement test by waleedlatif1 · Pull Request #8728 · simstudioai/sim · GitHub
Open Graph Title: fix(mothership): claim under the chat lock in the Stop-versus-recovery settlement test by waleedlatif1 · Pull Request #8728 · simstudioai/sim
X Title: fix(mothership): claim under the chat lock in the Stop-versus-recovery settlement test by waleedlatif1 · Pull Request #8728 · simstudioai/sim
Description: Summary orphaned-runs.integration.ts › "settles a stopped run exactly once when Stop races a recovering controller claiming it" failed intermittently with claimed !== stopped false. Settlement is still exactly-once; the failure came from the test, not the product. The test's "recovering controller" claimed the run without holding the chat lock. Real recovery (recover-stream) always locks the chat, proves its lease, then claims. settleStoppedRunWithoutController treats a run with no lock holder as unowned. So when the claim committed before Stop read the run, which happens on a loaded runner, Stop read the new token, found no lock holder and cancelled the run the test had just claimed. Both sides reported success. With the lock held, the same ordering leaves the run to its controller. The test's recovering controller now locks the chat, proves its lease, claims, and releases the lock when done, as recover-stream does. Both orderings are asserted deterministically before the concurrent loop: claim first, then Stop is refused; Stop first, then the claim is refused. The loop keeps its exactly-once assertion. Type of Change Bug fix Testing A probe on Linux reproduced the failure deterministically. A lockless claim followed by Stop gave claimed: true, stopped: true. The same ordering with the chat lock held gave claimed: true, stopped: false. A concurrent lockless loop (300 runs) settled exactly once every time on a quiet box, so the CI failure needs the claim to finish before Stop's first read. Ran the integration file 6 times with the old test and 6 times with the new one, each on 4 cores shared with 4 CPU hogs. All 12 runs passed: the race is rare, which is why the deterministic ordering is now asserted. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary orphaned-runs.integration.ts › "settles a stopped run exactly once when Stop races a recovering controller claiming it" failed intermittently with claimed !== stopped false. Sett...
X Description: Summary orphaned-runs.integration.ts › "settles a stopped run exactly once when Stop races a recovering controller claiming it" failed intermittently with claimed !== stopped fal...
Opengraph URL: https://github.com/simstudioai/sim/pull/8728
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:c5289670-8836-d388-4a4d-4a4f44d3eda4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D9F2:4466C:4B3E98:697CF4:6AFB5D61 |
| html-safe-nonce | 64a4742de8ecae2c0562caa2d5c27dcb7b61010887bcb51251be2f4a729c4562 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOUYyOjQ0NjZDOjRCM0U5ODo2OTdDRjQ6NkFGQjVENjEiLCJ2aXNpdG9yX2lkIjoiOTAzMTMxNjgyNTA0Nzc4NDgwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4f3b39c7609e6b7de524366cb88944332c2aeea6cf6667855111f126b4849b2d |
| hovercard-subject-tag | pull_request:4768620237 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8728/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary orphaned-runs.integration.ts › "settles a stopped run exactly once when Stop races a recovering controller claiming it" failed intermittently with claimed !== stopped false. Sett... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | ea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 59ef97164c52cf59bd10558ddec9c4f482763988 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width