René's URL Explorer Experiment


Title: fix(mothership): claim under the chat lock in the Stop-versus-recovery settlement test by waleedlatif1 · Pull Request #8728 · simstudioai/sim · GitHub

Open Graph Title: fix(mothership): claim under the chat lock in the Stop-versus-recovery settlement test by waleedlatif1 · Pull Request #8728 · simstudioai/sim

X Title: fix(mothership): claim under the chat lock in the Stop-versus-recovery settlement test by waleedlatif1 · Pull Request #8728 · simstudioai/sim

Description: Summary orphaned-runs.integration.ts › "settles a stopped run exactly once when Stop races a recovering controller claiming it" failed intermittently with claimed !== stopped false. Settlement is still exactly-once; the failure came from the test, not the product. The test's "recovering controller" claimed the run without holding the chat lock. Real recovery (recover-stream) always locks the chat, proves its lease, then claims. settleStoppedRunWithoutController treats a run with no lock holder as unowned. So when the claim committed before Stop read the run, which happens on a loaded runner, Stop read the new token, found no lock holder and cancelled the run the test had just claimed. Both sides reported success. With the lock held, the same ordering leaves the run to its controller. The test's recovering controller now locks the chat, proves its lease, claims, and releases the lock when done, as recover-stream does. Both orderings are asserted deterministically before the concurrent loop: claim first, then Stop is refused; Stop first, then the claim is refused. The loop keeps its exactly-once assertion. Type of Change Bug fix Testing A probe on Linux reproduced the failure deterministically. A lockless claim followed by Stop gave claimed: true, stopped: true. The same ordering with the chat lock held gave claimed: true, stopped: false. A concurrent lockless loop (300 runs) settled exactly once every time on a quiet box, so the CI failure needs the claim to finish before Stop's first read. Ran the integration file 6 times with the old test and 6 times with the new one, each on 4 cores shared with 4 CPU hogs. All 12 runs passed: the race is rare, which is why the deterministic ordering is now asserted. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary orphaned-runs.integration.ts › "settles a stopped run exactly once when Stop races a recovering controller claiming it" failed intermittently with claimed !== stopped false. Sett...

X Description: Summary orphaned-runs.integration.ts › "settles a stopped run exactly once when Stop races a recovering controller claiming it" failed intermittently with claimed !== stopped fal...

Opengraph URL: https://github.com/simstudioai/sim/pull/8728

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c5289670-8836-d388-4a4d-4a4f44d3eda4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD9F2:4466C:4B3E98:697CF4:6AFB5D61
html-safe-nonce64a4742de8ecae2c0562caa2d5c27dcb7b61010887bcb51251be2f4a729c4562
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOUYyOjQ0NjZDOjRCM0U5ODo2OTdDRjQ6NkFGQjVENjEiLCJ2aXNpdG9yX2lkIjoiOTAzMTMxNjgyNTA0Nzc4NDgwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4f3b39c7609e6b7de524366cb88944332c2aeea6cf6667855111f126b4849b2d
hovercard-subject-tagpull_request:4768620237
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8728/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary orphaned-runs.integration.ts › "settles a stopped run exactly once when Stop races a recovering controller claiming it" failed intermittently with claimed !== stopped false. Sett...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8728/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8728%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8728%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8728/files
Reloadhttps://github.com/simstudioai/sim/pull/8728/files
Reloadhttps://github.com/simstudioai/sim/pull/8728/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/orphaned-runs-stop-racehttps://github.com/simstudioai/sim/tree/fix/orphaned-runs-stop-race
Conversation 18 https://github.com/simstudioai/sim/pull/8728
Commits 3 https://github.com/simstudioai/sim/pull/8728/commits
Checks 32 https://github.com/simstudioai/sim/pull/8728/checks
Files changed https://github.com/simstudioai/sim/pull/8728/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8728/files
fix(mothership): claim under the chat lock in the Stop-versus-recovery settlement test https://github.com/simstudioai/sim/pull/8728/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/8728/files
2746145 fix(mothership): claim under the chat lock in the Stop-versus-recover… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8728/commits/2746145c7dff513d7147cbe3953c1ad5002cb165
6a1be75 fix(mothership): guard the recovering controller's lease instead of a… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8728/commits/6a1be75c4721e0beb740d101a619e524245f87fa
c6f2bac fix(mothership): guard the run's controller token in the recovery hel… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8728/commits/c6f2bac71806dde9f9011c3fc124df0b08ee54fd
Clear filters https://github.com/simstudioai/sim/pull/8728/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8728/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8728/files
orphaned-runs.integration.ts https://github.com/simstudioai/sim/pull/8728/files#diff-ec44c1c6e5915437ecd7e01af1911844cdd02ebc730abd5c8c8fb34498fdbb07
check-explicit-any.baseline.json https://github.com/simstudioai/sim/pull/8728/files#diff-780d04116ec981737479435cdb0364b49047711f2dfb93b671a9be50a1b0bb27
apps/sim/lib/mothership/async-runs/orphaned-runs.integration.tshttps://github.com/simstudioai/sim/pull/8728/files#diff-ec44c1c6e5915437ecd7e01af1911844cdd02ebc730abd5c8c8fb34498fdbb07
View file https://github.com/simstudioai/sim/blob/c6f2bac71806dde9f9011c3fc124df0b08ee54fd/apps/sim/lib/mothership/async-runs/orphaned-runs.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8728/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8728/files#diff-ec44c1c6e5915437ecd7e01af1911844cdd02ebc730abd5c8c8fb34498fdbb07
https://github.com/simstudioai/sim/pull/8728/files#diff-ec44c1c6e5915437ecd7e01af1911844cdd02ebc730abd5c8c8fb34498fdbb07
scripts/check-explicit-any.baseline.jsonhttps://github.com/simstudioai/sim/pull/8728/files#diff-780d04116ec981737479435cdb0364b49047711f2dfb93b671a9be50a1b0bb27
View file https://github.com/simstudioai/sim/blob/c6f2bac71806dde9f9011c3fc124df0b08ee54fd/scripts/check-explicit-any.baseline.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8728/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8728/files#diff-780d04116ec981737479435cdb0364b49047711f2dfb93b671a9be50a1b0bb27
https://github.com/simstudioai/sim/pull/8728/files#diff-780d04116ec981737479435cdb0364b49047711f2dfb93b671a9be50a1b0bb27
Please reload this pagehttps://github.com/simstudioai/sim/pull/8728/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.